[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-23 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-188131082 @dblotsky ouch. That's clearly a bug. It shouldn't do that. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-23 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-187914846 @alsorokin those other commands print only new messages continuously. The Windows script prints existing messages over and over again, which is a different beh

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-23 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-187893159 @dblotsky when I was writing this code, I made continuous logging the default behavior because the log script for Android platform is continuously printing th

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-22 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-187364348 @alsorokin that makes sense. Do you think flipping the behavior would be better? That is, to behave as if `--dump` was passed by default, and loop only if a fl

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-20 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-186592682 The purpose of this code is to remember initial state of the channels to return them back to this state after the script is completed. If we remove th

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-19 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-186449043 +1 to remove the lines. @alsorokin your thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-186445524 @alsorokin: is there a reason that the code under [this line][line] is even necessary? [line]: https://github.com/apache/cordova-windows/blob/master/t

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-186444637 @alsorokin yep, I ran those and now it works. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-19 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-186125182 @dblotsky as far as I remember, this script can run without administrator privileges, but you'll need to enable the needed channels first: `wevtutil s

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-18 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-186026434 1. Why does running the script manually print repeatedly? Is that a use case? 2. What is the 2-second delay for? It doesn't wait on Ctrl-C if the script wa

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-18 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-186026681 I just realized that a lot of my above comments apply to the logging script in general, not to this specific fix. This fix seems to work, so it LGTM. Only one

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-18 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-windows/pull/152 CB-10640: Windows logging is broken **Issue** In the current system, the logs which are collected in the events must be listed in the CI logs is broken. For example, if there is a sy

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-17 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/151#discussion_r53257649 --- Diff: template/cordova/lib/log.js --- @@ -151,23 +154,23 @@ function exitGracefully(exitCode) { } function startLogging(channel)

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-17 Thread sarangan12
Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-windows/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-17 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/151#discussion_r53250824 --- Diff: template/cordova/lib/log.js --- @@ -47,10 +47,10 @@ var appTracingInitialState = null, * and prints them to console */ m

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-17 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/151#discussion_r53248411 --- Diff: template/cordova/lib/log.js --- @@ -47,10 +47,10 @@ var appTracingInitialState = null, * and prints them to console */ mod

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/151#issuecomment-185453467 + @alsorokin to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-17 Thread sarangan12
Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/151#discussion_r53247772 --- Diff: template/cordova/lib/log.js --- @@ -47,10 +47,10 @@ var appTracingInitialState = null, * and prints them to console */ m

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-17 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/151#discussion_r53247225 --- Diff: template/cordova/lib/log.js --- @@ -47,10 +47,10 @@ var appTracingInitialState = null, * and prints them to console */ modu

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-17 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-windows/pull/151 CB-10640: Windows logging is broken CB-10640: Windows logging is broken @dblotsky @riknoll @rakatyal @nikhilkh Can you please review and merge this PR? You can merge this pull