[GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...

2016-04-08 Thread rakatyal
Github user rakatyal closed the pull request at: https://github.com/apache/cordova-windows/pull/165 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...

2016-04-08 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/165#issuecomment-207563072 Merged [here](https://github.com/apache/cordova-windows/commit/07f6158bc24eda28c2946f54b1e3626c7e124c92) --- If your project is set up for it, you can reply t

[GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...

2016-04-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/165#discussion_r59051696 --- Diff: template/cordova/lib/ConfigParser.js --- @@ -73,6 +73,15 @@ WindowsConfigParser.prototype.getWindowsTargetVersion = function() {

[GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...

2016-04-07 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-windows/pull/165#issuecomment-207058473 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...

2016-04-07 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-windows/pull/165 CB-11024: Add preference to set the min UAP target version in the JSP… …roj File The current preferences allow the user to set the target and min versions in the appxmanifest