[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-05-04 Thread codecov-io
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-windows/pull/172#issuecomment-216891242 ## [Current coverage][cc-pull] is **73.42%** > Merging [#172][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-05-04 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/172#discussion_r62049082 --- Diff: cordova-js-src/exec.js --- @@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy'); */ module.exports = function (succes

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-05-04 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/172#discussion_r62048444 --- Diff: cordova-js-src/exec.js --- @@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy'); */ module.exports = function (succes

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-04-29 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/172#issuecomment-215833144 Minor comments. Otherwise LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-04-29 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/172#discussion_r61621269 --- Diff: cordova-js-src/exec.js --- @@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy'); */ module.exports = function (succe

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-04-29 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/172#discussion_r61619913 --- Diff: cordova-js-src/exec.js --- @@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy'); */ module.exports = function (succe

[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...

2016-04-29 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/172 CB-11176 Fix windows-splashscreen compatibility with older plugin ver… …sions [Jira issue with details](https://issues.apache.org/jira/browse/CB-11176) You can merge this pull