Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-windows/pull/172#issuecomment-216891242
## [Current coverage][cc-pull] is **73.42%**
> Merging [#172][cc-pull] into [master][cc-base-branch] will not change
coverage
```diff
@@
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r62049082
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function (succes
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r62048444
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function (succes
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/172#issuecomment-215833144
Minor comments. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r61621269
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function (succe
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r61619913
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function (succe
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/172
CB-11176 Fix windows-splashscreen compatibility with older plugin verâ¦
â¦sions
[Jira issue with details](https://issues.apache.org/jira/browse/CB-11176)
You can merge this pull