[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/78 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-20 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/78#discussion_r30723083 --- Diff: template/CordovaApp.Windows10.jsproj --- @@ -86,12 +93,11 @@ - - + --- End diff

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-20 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/78#issuecomment-103932432 LGTM. I prefer the revised version which ends up with only a single solution file. Consider squashing the two commits before merging. --- If your project is se

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-20 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/78#discussion_r30716069 --- Diff: template/CordovaApp.Windows10.jsproj --- @@ -86,12 +93,11 @@ - - + --- End dif

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-19 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-windows/pull/78#issuecomment-103709357 Hmm you're right on seperation of concerns. Having a new solution file isn't really a good solution to this problem. I think I have a workaround that will work w

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-19 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/78#issuecomment-103682040 Does it make sense to continue to support `cordova platform add windows` in this case? or should we add `cordova platform add windows10` ? I for one pre

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-19 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-windows/pull/78#issuecomment-103681444 UAP and SharedProj dont play nice on VisualStudio13. My understanding is, in order to have backwards compat we need to split UAP from SharedProj. This provides a

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-19 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/78#issuecomment-103679656 Is this the 'new' way, or is this a temporary step on the road to 10? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-19 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-windows/pull/78 CB-9045 Create a new solution for Win10/Dev15 Currently in dev12 solution we're using shared project. The shared project has some logic that doesn't work with windows10 projects. (This is du