Github user biasmv commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-184110837
That's fantastic! Thanks for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-183633182
Tested and merged, @biasmv Marco - thx for the patch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-182766890
I'll test new version and merge later today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user biasmv commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-182249434
Hi,
just to follow up on this. I've changed the code to use relative paths. We
have been using this version for a while for testing our plugin and it
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-177957240
I've taken a look too, and I agree this seems the best approach. Changes
look good to me, except I agree with your comment @sgrebnov that we should use
a
Github user biasmv commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-178005303
Thanks for taking a look! I agree that it would be better to use relative
paths. At the moment, csproj files are also referenced using absolute paths, so
one
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-176733241
I've tried this approach and it seems to work very well. The only two
things I've noticed are:
1. Generated `Include` is absolute, this could be a problem
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-176740857
Here is my +1, but it will be great if someone else can take a look on this
change as well.
---
If your project is set up for it, you can reply to this email
Github user biasmv commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-175489700
Cool, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-175442601
Hi @biasmv - I'll take a look and respond today or tomorrow, thank you for
clarification
---
If your project is set up for it, you can reply to this email
Github user biasmv commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-174499126
@sgrebnov: I've verified that it's still possible to have files in non-root
folder locations. I've inserted the following into my project (which is
essentially
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-174453773
I like the idea, but I think we will miss `target` attribute support as
resource-file will be always copied to root (pls correct me if I'm wrong). In
some
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-174454890
@nikhilkh - looks like the doc describing `target` support on windows and
corresponding example exist in dev version only.We should make it released.
---
If
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-173989565
I don't completely understand why you are packaging '.dll' as a resource
file? Can you explain your scenario?
---
If your project is set up for it, you can
GitHub user biasmv opened a pull request:
https://github.com/apache/cordova-windows/pull/139
don't copy resource-files at plugin install
Instead, reference the file in the plugin directory. This allows to have
multiple
source files map to the same destination file inside the
16 matches
Mail list logo
