Code LGTM! I think it's a good idea to land on master and pursue tests
after-the-fact. More time on master means more real-world testing before it
being released.
On Wed, Feb 11, 2015 at 10:23 PM, Ian Clelland iclell...@chromium.org
wrote:
Not specifically, yet -- I have done manual testing on
Tests are definitely critical before we call for a vote :) I don't mind a
short time between landing the code and landing the tests.
On Thu, Feb 12, 2015 at 2:48 PM, Andrew Grieve agri...@chromium.org wrote:
Code LGTM! I think it's a good idea to land on master and pursue tests
I've been keeping the whitelist breakout on a branch for some time now, but
since this is something that we want to get into Cordova 4.0.0, it will
have to be merged in soon.
I've rebased it against master as of this afternoon, and pushed it into a
branch - unplug-whitelist-4.0.0 -- It passes all
Not specifically, yet -- I have done manual testing on it so far, and was
going to work with Andrew to put proper unit tests in before we cut 4.0.0.
On Wed, Feb 11, 2015 at 4:39 PM, Joe Bowser bows...@gmail.com wrote:
Are their JUnit tests to test the new unplugged whitelist?
On Wed Feb 11
