Re: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

2014-02-28 Thread Andrew Grieve
My sentiment is the same. This is a good improvement (current behaviour is to loop forever). If someone's so inclined, there's no reason we couldn't support circular deps. On Fri, Feb 28, 2014 at 10:43 AM, Jonathan Bond-Caron < jbo...@gdesolutions.com> wrote: > On Fri Feb 28 10:18 AM, Martin Bek

RE: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

2014-02-28 Thread Jonathan Bond-Caron
On Fri Feb 28 10:18 AM, Martin Bektchiev wrote: > My first idea was to allow the installation of such interdependent plugins, > but > then I saw that once added they cannot be uninstalled due to the cylce in the > graph. That's why I decided to stay consistent with uninstall and not allow > it. >

RE: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

2014-02-28 Thread Martin Bektchiev
ndent plugins? I suppose that you'd simply want to merge them into one. -Original Message- From: Jonathan Bond-Caron [mailto:jbo...@gdesolutions.com] Sent: Friday, February 28, 2014 16:01 To: dev@cordova.apache.org Subject: RE: CB-6028: Fix for infinte loop in plugman with plugins w

RE: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

2014-02-28 Thread Jonathan Bond-Caron
On Fri Feb 28 08:09 AM, Andrew Grieve wrote: > Thanks Martin! Looks good! I've merged it in :) > > Should just keep track of what's pending to be installed, why throw an exception?

Re: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

2014-02-28 Thread Andrew Grieve
Also - I've given you JIRA access so that you can assign issues to yourself :) On Fri, Feb 28, 2014 at 8:09 AM, Andrew Grieve wrote: > Thanks Martin! Looks good! I've merged it in :) > > > On Thu, Feb 27, 2014 at 2:38 AM, Martin Bektchiev < > martin.bektch...@telerik.com> wrote: > >> Hi guys, >

Re: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

2014-02-28 Thread Andrew Grieve
Thanks Martin! Looks good! I've merged it in :) On Thu, Feb 27, 2014 at 2:38 AM, Martin Bektchiev < martin.bektch...@telerik.com> wrote: > Hi guys, > > I have prepared a pull request for fixing the above-mentioned issue. Can > you please review it at https://github.com/apache/cordova-plugman/pul

CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

2014-02-26 Thread Martin Bektchiev
Hi guys, I have prepared a pull request for fixing the above-mentioned issue. Can you please review it at https://github.com/apache/cordova-plugman/pull/54? Thanks in advance! Martin