Re: Converting scripts to node

2013-07-13 Thread Brian LeRoux
I tend to agree. The problem is certainly not acute enough to matter until sometime after 3 has settled. On 2013-07-13 5:08 PM, "Anis KADRI" wrote: > I think I've voiced my opinion on this topic but I will state it again. I > (and I bet most people) do not like dependencies. You ask people to > d

Re: Converting scripts to node

2013-07-13 Thread Anis KADRI
I think I've voiced my opinion on this topic but I will state it again. I (and I bet most people) do not like dependencies. You ask people to download and install SDKs and that is already tedious enough. You now want them to download an additional thing to make life easier for Cordova Core Develope

Re: Converting scripts to node

2013-07-12 Thread Filip Maj
I have to agree with Lorin on this one. Windows scripts are getting ignored and not maintained, no surprise. Moving to node won't eliminate windows neglect but should mitigate the issue of unix fixes not making their way into windows scripts. Don't think it's super high priority to get done soon, t

Re: Converting scripts to node

2013-07-12 Thread Brian LeRoux
So, science experiment. That's cool. [1] [1] https://twitter.com/jonathanpenn/status/355696329172844549 On Fri, Jul 12, 2013 at 10:07 AM, Filip Maj wrote: > Main benefit here is abstracting away two scripts for *nix & > windows-compatible platforms like android and blackberry. BB already uses

Re: Converting scripts to node

2013-07-12 Thread Lorin Beer
The primary benefit I see in moving to node based scripts is quality: it's a lot easier to write and maintain complex scripts with good tests in js than it is in bash. Even with the reliance on exiting command line tools like adb. It also makes contributing to the scripting side far less intimidat

Re: Converting scripts to node

2013-07-12 Thread Filip Maj
Main benefit here is abstracting away two scripts for *nix & windows-compatible platforms like android and blackberry. BB already uses node for those anyways.. On 7/12/13 9:47 AM, "Brian LeRoux" wrote: >Most of the scripts themselves shell out to things like adb or >whatever so putting another l

Re: Converting scripts to node

2013-07-12 Thread Brian LeRoux
Most of the scripts themselves shell out to things like adb or whatever so putting another layer of scripting abstraction over top feels unnecessary (to me). I suppose the benefit is that on Android we'd have less code? Are there other benefits? On Thu, Jul 11, 2013 at 6:55 PM, Andrew Grieve w

Re: Converting scripts to node

2013-07-11 Thread Andrew Grieve
Cool! I don't think npm is a good idea for them since that will add another avenue for mistakes to be made. Shelling out to them seems fine. You can also just require() them if you're sure they aren't going to mess up you're apps state (e.g. change your CWD), but shelling out is certainly safer.

Re: Converting scripts to node

2013-07-11 Thread Filip Maj
Don't think for android specifically there has been any work on this On 7/11/13 2:55 PM, "Andrew Grieve" wrote: >We talked about unifying on node post 3.0 for our scripts (e.g. android >create script). > >Was wondering if anyone had started on this?

Re: Converting scripts to node

2013-07-11 Thread Benn Mapes
I have not started it but I was thinking about how this might be done. Would we have it as an external tooling package for each platform, published to npm? - this would allow other tools (CLI) to use the npm package as opposed to shelling out to the scripts. Other option would be to just have lo

Converting scripts to node

2013-07-11 Thread Andrew Grieve
We talked about unifying on node post 3.0 for our scripts (e.g. android create script). Was wondering if anyone had started on this?