RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

pdate https://github.com/apache/cordova-docs/pull/201/ Thx! Sergey -Original Message- From: Bryan Higgins [mailto:br...@bryanhiggins.net] Sent: Friday, April 4, 2014 7:48 AM To: dev@cordova.apache.org Subject: Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

gt; > > > > > Thx!! > > > Sergey > > > -----Original Message- > > > From: Bryan Higgins [mailto:br...@bryanhiggins.net] > > > Sent: Thursday, April 3, 2014 9:29 PM > > > To: dev@cordova.apache.org > > > Subject: Re: cordova launch

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

9313 > > > > Thx!! > > Sergey > > -Original Message- > > From: Bryan Higgins [mailto:br...@bryanhiggins.net] > > Sent: Thursday, April 3, 2014 9:29 PM > > To: dev@cordova.apache.org > > Subject: Re: cordova launcher ico

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

thub.com/AxelNennker/cordova-cli/pull/4 > [2] https://gist.github.com/sgrebnov/9949313 > > Thx!! > Sergey > -Original Message- > From: Bryan Higgins [mailto:br...@bryanhiggins.net] > Sent: Thursday, April 3, 2014 9:29 PM > To: dev@cordova.apache.org > Subject: Re

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

/cordova-cli/pull/4 [2] https://gist.github.com/sgrebnov/9949313 Thx!! Sergey -Original Message- From: Bryan Higgins [mailto:br...@bryanhiggins.net] Sent: Thursday, April 3, 2014 9:29 PM To: dev@cordova.apache.org Subject: Re: cordova launcher icon support https://github.com/apache

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

I've got a branch up for bb10 here: https://github.com/blackberry/cordova-cli/commit/a3da36cdc31ea4d090f5c63b2930160af474d3bc Right now it fails to build if icons exist for any other platform or an icon element exists within . On Thu, Apr 3, 2014 at 11:23 AM, Bryan Higgins wrote: > All I am say

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

All I am saying is that from an end user perspective it would be nice if we were consistent. If there are problems with the current platform tag, those should be filed as issues in JIRA and fixed. Or we can decide it was a mistake and go with platform attribute on preferences as well since it was r

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Which supports my "suspicion" that platform was introduced for preference elements but implemented in a way that developers can stick any child element into it. Which would not have any consequences if a developer would do it because ConfigParser.js does not honor the platform element. Platform in

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Bryan, support for the legacy cdv:platform and gap:platform was introduced by Sergey and I accepted that PR because I think that there are a bunch of config.xml s out there that use those attributes. The PR https://github.com/apache/cordova-cli/pull/126 does not introduce any new elements. It just

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Awesome, thanks Bryan! On Thu, Apr 3, 2014 at 6:42 AM, Bryan Higgins wrote: > I added this to edge when it came up on the list a few weeks ago. > > > https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;a=blobdiff;f=docs/en/edge/config_ref/index.md;h=9c32672403f1ceffce4278aa7e1fa6add706594

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

I added this to edge when it came up on the list a few weeks ago. https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;a=blobdiff;f=docs/en/edge/config_ref/index.md;h=9c32672403f1ceffce4278aa7e1fa6add7065946;hp=2df993147957cfe6f626f8a08e4a47889e4d;hb=7598207d0e4395905c009c056947a5a7c9930

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Feel pretty strongly that we shouldn't introduce gap: prefix. cdv: is bad enough :(. I'm sure PG Build will accept whatever syntax we come up with. It's true that isn't documented (that I know of), but it's consistent with plugin.xml and I think being able to put any elements in there makes it qu

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

On Thu Apr 3 09:20 AM, Bryan Higgins wrote: > My point is only that we should be consistent. If the platform element is > used for > preference, then why introduce an attribute which does the same thing for > icon? > > Also, I've seen platform=, cdv:platform= and gap:platform= within the pull >

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

My point is only that we should be consistent. If the platform element is used for preference, then why introduce an attribute which does the same thing for icon? Also, I've seen platform=, cdv:platform= and gap:platform= within the pull requests. On Thu, Apr 3, 2014 at 9:08 AM, Axel Nennker wr

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Hi Jonathan, considering how difficult is is to get this icon thing is I would like to postpone splash screen discussion after this is merged or rejected. On the other hand there were discussions on this list about splash screen support/changes not so long ago. I did not join those because even thi

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

;merges' where we replace app > resources > > > > using some special logic. But it could be useful if we share same > image > > > > between platforms or reference the same image for different needs > > inside > > > > single platform. > > &g

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

On Thu Apr 3 05:06 AM, Axel Nennker wrote: > It is a shame that CB-2606 is unresolved this long. We should have something > rolled out soon. > +1, thoughts on splashscreens or other images?

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

> [3] https://github.com/apache/cordova-cli/pull/145/files > > Thx! > Sergey > -Original Message----- > From: Axel Nennker [mailto:ignisvul...@gmail.com] > Sent: Thursday, April 3, 2014 1:06 PM > To: dev > Subject: Re: cordova launcher icon support > https://github.com/apache

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

gic. But it could be useful if we share same image > > > between platforms or reference the same image for different needs > inside > > > single platform. > > > > > > [1] > > > > > > http://docs.build.phonegap.com/en_US/3.3.0/configuring_icons_and_splas

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

image for different needs inside single platform. > > > > [1] > > > http://docs.build.phonegap.com/en_US/3.3.0/configuring_icons_and_splas > h.md.html#Icons%20and%20Splash%20Screens > > [2] > > > https://github.com/apache/cordova-cli/pull/126/files#diff-45a2a0f2

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

onfiguring_icons_and_splash.md.html#Icons%20and%20Splash%20Screens > > [2] > > > https://github.com/apache/cordova-cli/pull/126/files#diff-45a2a0f22289a5eb91348499a5053cd8R170 > > > > Thx! > > Sergey > > -Original Message- > > From: Axel Nennker [

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

3.4.0/config_ref_images.md.html#Icon > > s%20and%20Splash%20Screens > > > > Thx! > > Sergey > > -Original Message- > > From: Axel Nennker [mailto:ignisvul...@gmail.com] > > Sent: Saturday, February 22, 2014 1:44 AM > > To: dev > > Subject:

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

dev Subject: RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126 Please fork https://github.com/AxelNennker/cordova-cli and send a PR for wp. Thanks Axel Am 13.03.2014 13:18 schrieb "Sergey Grebnov (Akvelon)" < v-seg...@microsoft.com>: > Hi > 1.

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

li? > > http://cordova.apache.org/docs/en/3.4.0/config_ref_images.md.html#Icons%20and%20Splash%20Screens > > Thx! > Sergey > -Original Message- > From: Axel Nennker [mailto:ignisvul...@gmail.com] > Sent: Saturday, February 22, 2014 1:44 AM > To: dev > Subject: Re: cordova launch

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

AM To: dev Subject: Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126 there is a pull request that implements this gap: prefix and phonegap namespace stuff but this is Cordova and we have cdv: as prefix and another namespace: xmlns:cdv="http://cordova.apache.org

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

https://developer.apple.com/library/ios/documentation/userexperience/conceptual/MobileHIG/IconMatrix.html App icon (required for all apps) 120 x 120 120 x 120 152 x 152 76 x 76 Right? I updated my pull request to implement the no-namespace-magic for Android. https://gi

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

there is a pull request that implements this gap: prefix and phonegap namespace stuff but this is Cordova and we have cdv: as prefix and another namespace: xmlns:cdv="http://cordova.apache.org/ns/1.0"; Looks like config.json adapted by both projects is a way out. 2014-02-21 21:36 GMT+01:00 Don Co

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Icons are a drag. Explicit configuration sucks, but is the way to go. It would be nice if the Cordova solution was compatible with PhoneGap Build icons . On Fri, Feb 21, 2014 at 11:2

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

What is your favorite explicit configuration? Am 21.02.2014 16:49 schrieb "Brian LeRoux" : > As much as I'd like a single icon source I do not think it is the right > path. To do this right I think we need to audit all possible icons for each > platform and create a map to analyze what could be di

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

As much as I'd like a single icon source I do not think it is the right path. To do this right I think we need to audit all possible icons for each platform and create a map to analyze what could be distilled across platforms. Ideally we'd accept a vector format (SVG) and generate all these ridicu

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

True but... CB-2606 is open for ages and people don't seem to be able to agree on a format (see namespace discussion). e.g. Phonegap has a solution but uses another prefix/namespace. My latest suggestion in this threat is what I think is "a small step forward". Not perfect, sure. Different icons on

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

On Fri Feb 21 09:43 AM, Axel Nennker wrote: > > I would like to avoid to invent new elements or attributes. I think my plan > works > and would like to know what the group thinks about it. > The "icon problem" is you can have different icons of the same size for different platforms. The cordo

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

I think that 4.0 drops XML altogether for the project's config. We already had long discussions about prefixes and namespaces which gave me the impression that most people would like to drop the w3c widget standard and XML. I would like to avoid to invent new elements or attributes. I think my pla

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

On Fri Feb 21 09:14 AM, Jonathan Bond-Caron wrote: > On Thu Feb 20 04:07 AM, Axel Nennker wrote: > > How about this strategy: > > > > Would this work: > ref="icons" src="icon.jpg" width="96" height="96" /> ref="splashscreens" src="splash.jpg" width="1024" height="768" /> > > > > > > The

RE: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

On Thu Feb 20 04:07 AM, Axel Nennker wrote: > How about this strategy: > > project_dir/config.xml > - no new elements in config.xml like cdv:icon > - no new attributes in icon element in config.xml like cdv:platform or > gap:platform > - do not invent stuff we have to support for the rest of our l

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

How about this strategy: project_dir/config.xml - no new elements in config.xml like cdv:icon - no new attributes in icon element in config.xml like cdv:platform or gap:platform - do not invent stuff we have to support for the rest of our life. On all platforms: - if config.xml contains a withou

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

The topic is reaching politics status... I think it is worth some effort to keep phonegap and cordova aligned. What is "Adobe"'s position on W3C widget and xml vs json? -Axel Regarding which PR to accept: I want support for launcher icons and I do not care whether my PR is accepted or the other

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Part of what you are seeing is the phonegap namespace extensions that are added for build.phonegap.com and the online tools. [1] [2] [1] http://docs.build.phonegap.com/en_US/3.1.0/configuring_basics.md.html#The%20Basics [2] https://github.com/phonegap/phonegap-start/blob/master/www/config.xml @

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Just started a new thread to propose removing the namespace. Don't the we should use "gap:density", since that's pretty PhoneGap-y as opposed to Cordova-y. How about we have "size" and "density" attributes that are just synonyms? Off for the day. On Wed, Feb 12, 2014 at 4:57 PM, Axel Nennker

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Another pull request came in last week: https://github.com/apache/cordova-cli/pull/29 It adds icons & splashscreens to both iOS and Android, and even uses imagemagick to generate them if it's available. Still looking it over. On Wed, Feb 12, 2014 at 4:37 PM, Andrew Grieve wrote: > > > > On Tu

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Hm. I guess the id test is historical stuff. It is legal XML and the parser ignores it. Regarding the NS prefix: cdv vs gap I am quite sure I did not invent cdv myself. Regarding the w3c widget standard: I am OK with ditching it. Should there be a poll or how do you handle such things? All app te

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

On Tue, Feb 11, 2014 at 3:43 PM, Brian LeRoux wrote: > Given we are the only 'widget spec' impl in use today I'm ok with diverging > and not adding namespace confusion. Def want config to be explicit and not > have magical implicit mappings. > > > On Tue, Feb 11, 2014 at 12:24 PM, Axel Nennker >

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Given we are the only 'widget spec' impl in use today I'm ok with diverging and not adding namespace confusion. Def want config to be explicit and not have magical implicit mappings. On Tue, Feb 11, 2014 at 12:24 PM, Axel Nennker wrote: > - My implementation does not use "id". Don't know what th

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

- My implementation does not use "id". Don't know what this or might mean. - I do not want to discuss the sense of xml namespaces in this issue if we can avoid it. The current template config.xml defines two namespaces and for this issue's implementation I do not want to change that. So I would not

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

Would love to move this along. Would like to get buy-in from others first though. The proposal in this PR is to add tags like: My feedback: - What is "id" for? - Supporting "cdv:platform" is fine, but we should also support just "platform=". I'd be fine to drop xmlns="http://www.w

Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126

He Axel, thanks for spearheading this. Will have a look shortly. On Mon, Feb 10, 2014 at 9:07 AM, Axel Nennker wrote: > Andrew, > > any comments to the current implementation? > https://github.com/apache/cordova-cli/pull/126 > > Joe commented that the new class in config_parser.js named "icon"