Re: [Android] InAppBrowser UI changes and Resources

2014-01-14 Thread Joe Bowser
OK, So it looks like the consensus was src/platform? Also, are we doing that resource tag, or is it cool if I just leave this as using the source tag. I'm going to be merging this in the next two days. On Tue, Dec 3, 2013 at 6:01 PM, Brian LeRoux wrote: > src/platform seems simplest to me > On

Re: [Android] InAppBrowser UI changes and Resources

2013-12-03 Thread Brian LeRoux
src/platform seems simplest to me On Dec 4, 2013 7:09 AM, "Steven Gill" wrote: > I think it looks good! > > I noticed that you created a top level res folder in the plugin to store > your resources. This rises the question about where should resources live > within a plugin. > > Two options I see

Re: [Android] InAppBrowser UI changes and Resources

2013-12-03 Thread Shazron
Moving it out of src is no problem for iOS, if we need to be consistent for all the platforms. e.g. https://github.com/apache/cordova-plugin-media-capture/tree/master/src/ios/CDVCapture.bundle On Tue, Dec 3, 2013 at 11:42 AM, Steven Gill wrote: > I think it looks good! > > I noticed that you c

Re: [Android] InAppBrowser UI changes and Resources

2013-12-03 Thread Steven Gill
I think it looks good! I noticed that you created a top level res folder in the plugin to store your resources. This rises the question about where should resources live within a plugin. Two options I see are: 1) Create the res folder with platform folders within to store resources. (this is what

Re: [Android] InAppBrowser UI changes and Resources

2013-12-03 Thread Joe Bowser
Oh crap, here's my GitHub fork of what I did: https://github.com/infil00p/cordova-plugin-inappbrowser/tree/drawables On Tue, Dec 3, 2013 at 10:57 AM, Joe Bowser wrote: > Hey > > I just did some hacking on the InAppBrowser UI, and I've added the > ability to add drawables. I've used the Android