Re: [DISCUSS] Android & iOS release

2018-04-18 Thread Terence M. Bandoian
Is this related to the difference between targets in config.xml and plugin.xml? In config.xml, target attribute values are relative to the base platform directory. In plugin.xml, they are relative to app/src/main in the base platform directory. Would it be useful to document this? -Teren

Re: [DISCUSS] Android & iOS release

2018-04-18 Thread Joe Bowser
Looks good. I'll do a quick sanity check later today, but it should be fine. On Wed, Apr 18, 2018 at 5:26 AM, julio cesar sanchez wrote: > I've sent a PR for the Android Studio detection problem, it just makes > isAndroidStudioProject return true, removed the non Android Studio > tests/files (o

Re: [DISCUSS] Android & iOS release

2018-04-18 Thread julio cesar sanchez
I've sent a PR for the Android Studio detection problem, it just makes isAndroidStudioProject return true, removed the non Android Studio tests/files (or updated some to be Android Studio tests) https://github.com/apache/cordova-android/pull/437 That wont fix incompatible plugins, but at least wil

Re: [DISCUSS] Android & iOS release

2018-04-17 Thread Steven Gill
Joe or myself don't currently have the time to fix this problem and probably won't for the foreseeable future. Plugin maintainers can send PRs to cordova-android adding their mapping if they want or update their plugins. But I'd like to get this release out because of the bug fixes that have lande

Re: [DISCUSS] Android & iOS release

2018-04-17 Thread Joe Bowser
On Tue, Apr 17, 2018 at 2:54 PM, julio cesar sanchez wrote: > Yeah, but our plugins work because we have put some code to copy our files > to a new location instead of updating the paths in the plugins' plugin.xml. > This is handled for what our plugins need, but not for all the possible > cases,

Re: [DISCUSS] Android & iOS release

2018-04-17 Thread julio cesar sanchez
Yeah, but our plugins work because we have put some code to copy our files to a new location instead of updating the paths in the plugins' plugin.xml. This is handled for what our plugins need, but not for all the possible cases, so I don't think it's ok to make a patch to just make our plugins wor

Re: [DISCUSS] Android & iOS release

2018-04-17 Thread Joe Bowser
I disagree. We have our core plugins installing and uninstalling without issue currently, and we can't babysit everyone with their third party plugins. The community needs to come up with a plan on deprecating the old project structure and communicating that to the third party plugin maintainers.

Re: [DISCUSS] Android & iOS release

2018-04-17 Thread julio cesar sanchez
Before doing an Android release we should fix the problems with plugins installs, people is not updating because of it 2018-04-17 3:31 GMT+02:00 gandhi rajan : > Hi Steve, > > Can you please have a look at this PR - > https://github.com/apache/cordova-docs/pull/811 > > It's related to Cordova doc

Re: [DISCUSS] Android & iOS release

2018-04-16 Thread gandhi rajan
Hi Steve, Can you please have a look at this PR - https://github.com/apache/cordova-docs/pull/811 It's related to Cordova doc changes. On Tuesday, April 17, 2018, Steven Gill stevengil...@gmail.com> wrote: > Going to aim to do a release this week. Let me know if there are any PRs I > should loo