Re: [DISCUSS] Cordova-Android 7.1.1 patch release

2018-07-16 Thread Chris Brody
Thanks Jesse for the review and vote. I already raised CB-14205 () in response to Shazron's observation. Does it cover your observation or should I maybe raise another issue? On Mon, Jul 16, 2018 at 5:13 AM Jesse wrote: > > I voted +1 because I

Re: [DISCUSS] Cordova-Android 7.1.1 patch release

2018-07-16 Thread Jesse
I voted +1 because I don't think the issues I encountered will affect regular users. The CI is green, BUT it has errors, that it deems not enough to reject ... I think it should Here is the 'green' CI with apparent fatal errors in the log:

Re: [DISCUSS] Cordova-Android 7.1.1 patch release

2018-07-16 Thread Shazron
Need one more vote for Cordova-Android to wrap it up. On Thu, Jul 12, 2018 at 7:49 PM Chris Brody wrote: > > Thanks Shazron for reviewing. I just raised CB-14205 > to add hints and help > links to error messages. > > On Jul 12, 2018 1:57 AM,

Re: [DISCUSS] Cordova-Android 7.1.1 patch release

2018-07-12 Thread Chris Brody
Thanks Shazron for reviewing. I just raised CB-14205 to add hints and help links to error messages. On Jul 12, 2018 1:57 AM, "Shazron" wrote: I realize that and that's what I did -- the error message was not helpful because I thought it would

Re: [DISCUSS] Cordova-Android 7.1.1 patch release

2018-07-11 Thread Shazron
I realize that and that's what I did -- the error message was not helpful because I thought it would just detect the one in Android Studio (seems to be specific to Windows?). Another gotcha: I had to add $ANDROID_HOME/emulator to my PATH to run it in the emulator On Thu, Jul 12, 2018 at 1:50 PM

Re: [DISCUSS] Cordova-Android 7.1.1 patch release

2018-07-11 Thread Darryl Pogue
I believe on macOS you'll need to install gradle through something like Homebrew. On Wed, Jul 11, 2018 at 10:42 PM Shazron wrote: > > Sorry, Android newbie here. > > I have Android 3.1.3 installed on macOS, with cordova 8.0.0. > I did: > cordova platform add