Re: Consolidating platform specific code from different places in cordova-lib

2015-03-12 Thread Mark Koudritsky
/platforms/platforms' moved from just '../platforms' - but not a big > > deal in the least. > > > > -Original Message- > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > Mocny > > Sent: Wednesday, March 11,

Re: Consolidating platform specific code from different places in cordova-lib

2015-03-11 Thread Andrew Grieve
.@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Wednesday, March 11, 2015 7:29 AM > To: dev > Subject: Re: Consolidating platform specific code from different places in > cordova-lib > > Reviewed, left comments. Overall looks good, thanks Mark. &

RE: Consolidating platform specific code from different places in cordova-lib

2015-03-11 Thread Rob Paveza
11, 2015 7:29 AM To: dev Subject: Re: Consolidating platform specific code from different places in cordova-lib Reviewed, left comments. Overall looks good, thanks Mark. However, seems you left something uncommitted, since you literally cannot require('cordova-lib'); without an

Re: Consolidating platform specific code from different places in cordova-lib

2015-03-11 Thread Michal Mocny
Reviewed, left comments. Overall looks good, thanks Mark. However, seems you left something uncommitted, since you literally cannot require('cordova-lib'); without an exception thrown. Yet all the cordova-lib tests pass. What does it say about the quality of the tests ;) On Tue, Mar 10, 2015 a

Re: Consolidating platform specific code from different places in cordova-lib

2015-03-10 Thread Jesse
Had a quick look, looks great! @purplecabbage risingj.com On Tue, Mar 10, 2015 at 3:09 PM, Mark Koudritsky wrote: > I've created a pull request with changes across cordova-lib that should > make it much easier to consolidate the platform specific code in > cordova-lib to reduce duplication and