Re: js commit: [All] patch, in case console.warn is not defined

2013-07-10 Thread Andrew Grieve
Yeah, I see what you mean. On one hand, it's possible someone will write console.error() as well, but otoh, that particular one hasn't come up. It's weird too that we patch these in cordova.js instead of bootstrap. Bootstrap is what runs first. I might have a look at moving this, but not super imp

Re: js commit: [All] patch, in case console.warn is not defined

2013-07-09 Thread Jesse
Yeah, my mistake. I have removed the windows only debug output. The console object does not exist, but we create an empty console{log:function...} in this case. However, there are places within cordova.js that we console.warn, and unfortunately this happens before DOMContentLoaded, so it is too

Re: js commit: [All] patch, in case console.warn is not defined

2013-07-09 Thread Andrew Grieve
Hey Jesse, Not sure you meant to add in the window.external.Notify into the shared code. Windows specific? Also - why patch console.warn? We already have plugin-console, which ensures all console methods are available, instead of just warn ( https://git-wip-us.apache.org/repos/asf?p=cordova-plugi