gt; >
> > >> Yeah, kill it. gh-pulls are much easier to review I think.
> > >>
> > >> @purplecabbage
> > >> risingj.com
> > >>
> > >> On Wed, Jan 7, 2015 at 1:14 PM, Joe Bowser wrote:
> > >>
> > >> > What's re
gh-pulls are much easier to review I think.
> >>
> >> @purplecabbage
> >> risingj.com
> >>
> >> On Wed, Jan 7, 2015 at 1:14 PM, Joe Bowser wrote:
> >>
> >> > What's reviewboard?
> >> >
> >> > j/k, yeah kill it!
> >>
n Wed, Jan 7, 2015 at 1:14 PM, Joe Bowser wrote:
>>
>> > What's reviewboard?
>> >
>> > j/k, yeah kill it!
>> > On Wed Jan 07 2015 at 1:13:55 PM Andrew Grieve
>> > wrote:
>> >
>> > > Anyone still interested in using ReviewBoard? I
+1
On Wed, Jan 7, 2015 at 4:20 PM, Jesse wrote:
> Yeah, kill it. gh-pulls are much easier to review I think.
>
> @purplecabbage
> risingj.com
>
> On Wed, Jan 7, 2015 at 1:14 PM, Joe Bowser wrote:
>
> > What's reviewboard?
> >
> > j/k, yeah kill it!
Yeah, kill it. gh-pulls are much easier to review I think.
@purplecabbage
risingj.com
On Wed, Jan 7, 2015 at 1:14 PM, Joe Bowser wrote:
> What's reviewboard?
>
> j/k, yeah kill it!
> On Wed Jan 07 2015 at 1:13:55 PM Andrew Grieve
> wrote:
>
> > Anyone still inter
What's reviewboard?
j/k, yeah kill it!
On Wed Jan 07 2015 at 1:13:55 PM Andrew Grieve wrote:
> Anyone still interested in using ReviewBoard? I feel like we gave it a
> decent shot, but github pull requests are working better.
>
> If no one objects, I'm going to delete th
Anyone still interested in using ReviewBoard? I feel like we gave it a
decent shot, but github pull requests are working better.
If no one objects, I'm going to delete the .reviewboardrc files from the
repos and update
https://github.com/apache/cordova-coho/blob/master/docs/code-reviews.md
iew board by uploading a diff so you don't technically
> need the reviewboard.rc.
>
> Sent from my BlackBerry 10 smartphone.
> Original Message
> From: Carlos Santana
> Sent: Wednesday, October 16, 2013 2:41 AM
> To: dev@cordova.apache.org
> Reply To: dev@cordova.apache
t: Re: reviewboard .reviewboardrc and TRACKING_BRANCH = 'origin/dev' ?
Wiki has being updated
https://wiki.apache.org/cordova/CommitterWorkflow
list which repos can be use with post-review, and using github as
alternative for code review.
Oh and I manage to get Jesse's cell numb
ile
>> >
>> > 2. Should the plugins repos contain the file ".reviewboardrc" and it
>> should
>> > have a variable TRACKING_BRANCH = 'origin/dev'? since 'master' is not
>> being
>> > use for development.
>> >
> > 1. Should all repos contain a file ".reviewboardrc" ? Some repos are
> > missing this file
> >
> > 2. Should the plugins repos contain the file ".reviewboardrc" and it
> should
> > have a variable TRACKING_BRANCH = 'origin/dev'? since
quot;.reviewboardrc" and it should
> have a variable TRACKING_BRANCH = 'origin/dev'? since 'master' is not being
> use for development.
>
> 3. Is obligatory to only use reviewboard? or can committers use github to
> review code?
> 3a. As a personal prefere
velopment.
3. Is obligatory to only use reviewboard? or can committers use github to
review code?
3a. As a personal preference I like github better for reviews, search, and
share code reviews. Maybe because it's what I have used for some time as a
contributor and also on other open source projec
Cool, thanks for the info! I've registered.
On Thu, Jun 20, 2013 at 5:59 AM, Andrew Grieve wrote:
> Just got word that all of the repos except for the plugin ones are now
> valid targets at http://reviews.apache.org.
>
> 1. Everyone will have to make a reviewboard account
>
Just got word that all of the repos except for the plugin ones are now
valid targets at http://reviews.apache.org.
1. Everyone will have to make a reviewboard account
2. Make sure to add yourself to the cordova group (via the "My Account"
link)
3. There's a command-line tool for
15 matches
Mail list logo
