cordova@2.9.4 on npm now
On 7/11/13 8:16 PM, "Ian Clelland" wrote:
>Works perfectly now!
>
>Agreed about looking into the 'right way' to do this; there are likely
>still edge conditions that we just haven't encountered yet.
>
>This is working great for now, though.
>
>
>
>On Thu, Jul 11, 2013 at
BTW filed https://issues.apache.org/jira/browse/CB-4189 to keep track of
the improvement suggestion brought up in this thread.
On 7/11/13 8:16 PM, "Ian Clelland" wrote:
>Works perfectly now!
>
>Agreed about looking into the 'right way' to do this; there are likely
>still edge conditions that we
Excellent, I'll merge into master shortly and bump the version.
On 7/11/13 8:16 PM, "Ian Clelland" wrote:
>Works perfectly now!
>
>Agreed about looking into the 'right way' to do this; there are likely
>still edge conditions that we just haven't encountered yet.
>
>This is working great for now,
Works perfectly now!
Agreed about looking into the 'right way' to do this; there are likely
still edge conditions that we just haven't encountered yet.
This is working great for now, though.
On Thu, Jul 11, 2013 at 6:24 PM, Filip Maj wrote:
> Hey Ian,
>
> I've patched this, pushed as plugman
Hey Ian,
I've patched this, pushed as plugman@0.9.3, and updated the CB-4077 branch
of cordova-cli to use the new plugman.
Assuming it works out for you (I tested with the file plugin), I will
merge back into master and publish a new cli version.
On 7/11/13 12:51 PM, "Ian Clelland" wrote:
>It
Ian, agreed, the plugin-repo-delete code should not care if a dependency
is already removed.
I will patch that, but perhaps it is worth filing an issue to do this "the
proper way" down the road..
On 7/11/13 12:51 PM, "Ian Clelland" wrote:
>It fails differently for me now... I think it's because
It fails differently for me now... I think it's because of the second level
dependency of file-transfer on file.
On uninstall I can see all platform-level commands succeeding, and all
plugins are removed from both ios and android. Then uninstallPlugin starts
to delete the plugin dirs, deletes org.
Hey Ian,
I think I've got it working. The issue was that I was invoking
uninstallPlugin (which does plugin repo removal) when uninstallPlatform
would recurse into dependencies.
I've now tweaked the behavior: uninstallPlatform _NEVER_ invokes
uninstallPlugin, and uninstallPlugin now recursed when
Ahh yes.. Good catch. I am looking into it.
On 7/11/13 10:45 AM, "Ian Clelland" wrote:
>I'm getting an error on uninstall -- haven't tracked it down yet, but you
>might have some insight.
>
>My test sequence looks like this:
>
>cordova create cb4077test com.google.cb4077test
>cd cb4077test
>cord
I'm getting an error on uninstall -- haven't tracked it down yet, but you
might have some insight.
My test sequence looks like this:
cordova create cb4077test com.google.cb4077test
cd cb4077test
cordova platform add ios
cordova platform add android
cordova plugin install ../cordova-mobile-spec/de
Thank you Ian!
On 7/11/13 10:17 AM, "Ian Clelland" wrote:
>Taking a look now (Sorry I missed this thread yesterday). I'll have an
>update for you shortly.
>
>
>On Thu, Jul 11, 2013 at 1:04 PM, Filip Maj wrote:
>
>> FYI plugman 0.9.0 is pushed up to npm and the cli is waiting review by
>>Ian
>>
Taking a look now (Sorry I missed this thread yesterday). I'll have an
update for you shortly.
On Thu, Jul 11, 2013 at 1:04 PM, Filip Maj wrote:
> FYI plugman 0.9.0 is pushed up to npm and the cli is waiting review by Ian
> / Google folk. I've pushed up a branch CB-4077 to the cli that integrat
FYI plugman 0.9.0 is pushed up to npm and the cli is waiting review by Ian
/ Google folk. I've pushed up a branch CB-4077 to the cli that integrates
with the new plugman. Can you guys check that this branch works properly
for any of your flows?
I'll assume everything works out if I don't hear back
Hey Ian, I just tried cordova-cli with the new plugman, and dependency
plugins are removed for me when I uninstall the mobile-spec dependency
plugin.
Cordova-cli seems to check out, I ran through the "Working With Three"
steps with the new cli and it works good (minus the version checking,
which i
I've pushed plugman 0.9.0 to npm, and pushed a CB-4077 branch to the cli
repo on apache, which is just your pull req, Ian, plus a bump to plug
man's version in package.json.
Am running through the testing motions now.
On 7/10/13 7:34 AM, "Ian Clelland" wrote:
>The new plugman works for me, when
Ian, that was one of my commits into plugman, actually: to call
uninstallPlugin when iterating over dangling dependencies. I added a test
for it too. Perhaps that has something to do with integration into the CLI?
Anyways, I'll be taking a look at the cli work for CB-4077 and ideally ill
push upda
The new plugman works for me, when coupled with my CB-4077 branch of cli.
I noticed that the /plugins/ directories don't
get removed for dangling dependencies -- only the top-level plugin is
removed from there. However, the dependents are removed from all platforms,
so the uninstallation works cor
Sounds good, Fil -- I'll take a look at the updates, and run it through its
paces here. I'll let you know right away if I find anything unusual.
Ian
On Tue, Jul 9, 2013 at 5:31 PM, Filip Maj wrote:
> I've pushed up a CB-4077 branch of plugman up to the apache git repo. It
> is a few extra comm
I've pushed up a CB-4077 branch of plugman up to the apache git repo. It
is a few extra commits on top of yours, Ian, addressing some other issues
I noticed during testing.
It looks like it is safe to merge into master, but I would like Ian and
Google co. to once-over it before we merge into maste
Oh, don't be sad, Brian ;)
That's why I only pushed to my fork; looking for constructive review.
And now I know where the cli and plugman tests are, and they shall be made
better before anything is pushed to a real repo.
On Fri, Jul 5, 2013 at 2:23 PM, Brian LeRoux wrote:
> =(
>
> Should go
=(
Should go without saying but lets not commit stuff without first
ensuring the tests pass, eh.
On Fri, Jul 5, 2013 at 10:05 AM, Filip Maj wrote:
> Added comments to the issue thread. The tests no longer pass + we'll need
> new tests to cover your changes.
>
> On 7/4/13 8:21 PM, "Ian Clelland"
Added comments to the issue thread. The tests no longer pass + we'll need
new tests to cover your changes.
On 7/4/13 8:21 PM, "Ian Clelland" wrote:
>Thanks, Fil,
>
>Created CB-4077 to track this. I'll start working on separating those
>functions.
>
>Ian
>
>On Thu, Jul 4, 2013 at 7:08 PM, Filip M
Thanks, Fil,
Created CB-4077 to track this. I'll start working on separating those
functions.
Ian
On Thu, Jul 4, 2013 at 7:08 PM, Filip Maj wrote:
> File an issue over at issues.cordova.io, tag plugman, and we can go from
> there
>
> On 7/4/13 12:59 PM, "Ian Clelland" wrote:
>
> >This is the
File an issue over at issues.cordova.io, tag plugman, and we can go from
there
On 7/4/13 12:59 PM, "Ian Clelland" wrote:
>This is the first time I've tried to use the CLI tools with the new 3.0
>project structure, and I've discovered that I can't uninstall a plugin
>that
>only has dependencies (
*Shrugs* bug, probably.
On 7/4/13 12:59 PM, "Ian Clelland" wrote:
>This is the first time I've tried to use the CLI tools with the new 3.0
>project structure, and I've discovered that I can't uninstall a plugin
>that
>only has dependencies (no source files, either JS or native)
>
>Specifically,
This is the first time I've tried to use the CLI tools with the new 3.0
project structure, and I've discovered that I can't uninstall a plugin that
only has dependencies (no source files, either JS or native)
Specifically, I've built a mobilespec app, installing
the mobile-spec-dependencies plugin
26 matches
Mail list logo
