Re: Working versions of Cordova-Android and Cordova-Crosswalk-Engine

2014-07-16 Thread Andrew Grieve
We could also do the opposite - make cordova-android a submodule within the engine repos. A submodule is just a URL & a hash, so I don't think it would go against any policies. On Wed, Jul 16, 2014 at 1:20 PM, Michal Mocny wrote: > DEPS file? > > > On Wed, Jul 16, 2014 at 12:23 PM, Ian Clelland

Re: Working versions of Cordova-Android and Cordova-Crosswalk-Engine

2014-07-16 Thread Michal Mocny
DEPS file? On Wed, Jul 16, 2014 at 12:23 PM, Ian Clelland wrote: > Agreed with Joe here -- the engines, Crosswalk included, are third-party > code. It's just coincidence that Cordova PMC members happen to be > implementing them. > > What we need is a well-defined stable API. > > > On Wed, Jul 1

Re: Working versions of Cordova-Android and Cordova-Crosswalk-Engine

2014-07-16 Thread Ian Clelland
Agreed with Joe here -- the engines, Crosswalk included, are third-party code. It's just coincidence that Cordova PMC members happen to be implementing them. What we need is a well-defined stable API. On Wed, Jul 16, 2014 at 12:17 PM, Joe Bowser wrote: > And I mean licence compatibility. Cros

Re: Working versions of Cordova-Android and Cordova-Crosswalk-Engine

2014-07-16 Thread Joe Bowser
And I mean licence compatibility. Crosswalk-Cordova-Engine is technically not ASF code. On Wed, Jul 16, 2014 at 9:17 AM, Joe Bowser wrote: > No, I don't think adding crosswalk as an engine would be a good idea > due to compatibility. We should make a spec engine that's just a > clone of Android

Re: Working versions of Cordova-Android and Cordova-Crosswalk-Engine

2014-07-16 Thread Joe Bowser
No, I don't think adding crosswalk as an engine would be a good idea due to compatibility. We should make a spec engine that's just a clone of AndroidWebView specifically for testing and API functionality. I'll add that to the JIRA subtask. On Wed, Jul 16, 2014 at 9:15 AM, Andrew Grieve wrote:

Re: Working versions of Cordova-Android and Cordova-Crosswalk-Engine

2014-07-16 Thread Andrew Grieve
Thanks for compiling. Do you think git submodules would be worth using to track this? E.g. add the engine plugins as submodules to 4.0.x? On Wed, Jul 16, 2014 at 11:49 AM, Ian Clelland wrote: > Joe and I spent a bit of time last night working out compatible versions of > cordova-android and cor

Working versions of Cordova-Android and Cordova-Crosswalk-Engine

2014-07-16 Thread Ian Clelland
Joe and I spent a bit of time last night working out compatible versions of cordova-android and cordova-crosswalk-engine. (One of the pains of having separate repos for everything is when APIs change, it's a pain to find matching versions again) This is what we found (I went over the commits from