ent from my Windows Phone
>>>____________________
>>>From: Filip Maj<mailto:f...@adobe.com>
>>>Sent: ?2/?18/?2013 2:07 PM
>>>To: dev@cordova.apache.org<mailto:dev@cordova.apache.org>
>>>Subject: Re: cordova command cli and merges
t;
>>Sent from my Windows Phone
>>
>>From: Filip Maj<mailto:f...@adobe.com>
>>Sent: ?2/?18/?2013 2:07 PM
>>To: dev@cordova.apache.org<mailto:dev@cordova.apache.org>
>>Subject: Re: cordova command cli and merges concept pull
07 PM
>To: dev@cordova.apache.org<mailto:dev@cordova.apache.org>
>Subject: Re: cordova command cli and merges concept pull request
>
>Hey Michael,
>
>I've rebased/merged your changes with the latest master and did a bit of
>refactoring and tweaks to get the tests pa
No, will get the icla sorted this week. Happy to help.
Sent from my Windows Phone
From: Filip Maj<mailto:f...@adobe.com>
Sent: 2/18/2013 2:07 PM
To: dev@cordova.apache.org<mailto:dev@cordova.apache.org>
Subject: Re: cordova command cli and merges
Hey Michael,
I've rebased/merged your changes with the latest master and did a bit of
refactoring and tweaks to get the tests passing again.
I've pushed this up to the "merges" branch on apache:
https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=shortlog;h=refs
/heads/merges
Once we hav
Michael, have you signed an Apache CLA? I can't find it on the committer
index (http://people.apache.org/committer-index.html).
On 2/17/13 3:53 PM, "Michael Wolf" wrote:
>Hey All:
>
>Posted changes to include tests (making sure the method gets called in the
>build and then per parser making sure
Thanks Mike, I will take a look tomorrow and post back in this thread!
On 2/17/13 3:53 PM, "Michael Wolf" wrote:
>Hey All:
>
>Posted changes to include tests (making sure the method gets called in the
>build and then per parser making sure the copied files make their way into
>the build) and mad
Hey All:
Posted changes to include tests (making sure the method gets called in the
build and then per parser making sure the copied files make their way into
the build) and made a subtle change in where in the process merges were
being copied, per Filip's feedback.
Thanks, let me know if you hav
I'm working with Michael off this discussion thread to get the code up to
par.
Michael, feel free to update your pull request and ping this thread
whenever you get a chance to update it. Then we can all take a look.
On 2/12/13 10:15 PM, "Anis KADRI" wrote:
>I believe this is a valid request. I
I believe this is a valid request. I like the idea of having
platform-specific code only deployed to matching devices.
I looked at the pull request and it looks good but as Fil mentioned, it
needs some tests.
On Tue, Feb 12, 2013 at 11:07 AM, Brian LeRoux wrote:
> yes there is some issues w/ em
yes there is some issues w/ emulation in this approach but I think its
a better architectural pattern for a universal project. we can make
ripple w/ this style rather the other way around.
On Tue, Feb 12, 2013 at 6:48 PM, Michael Wolf wrote:
> Have looked at suggesting folks mock in-browser using
Have looked at suggesting folks mock in-browser using ripple... however
there are a few issues with that, firstly being simply doesn't work for
non webkit platforms (ie windows phone... yah the cli doesn't currently
support windows phone but no reason why it can't) ... Also while you can
mock to wo
On Tue, Feb 12, 2013 at 1:11 PM, Brian LeRoux wrote:
> Splash screens and making an app a type of super plugin are rad ideas
> for other pull requests. ;)
>
> Attached image of me when idea of making an app a plugin came up.
No you didn't ;)
> On Tue, Feb 12, 2013 at 5:58 PM, Michal Mocny wro
Yup I can add a test for this over the next couple days.
mw
On 2/12/13 12:59 PM, "Filip Maj" wrote:
>BTW, Michael love the pull req, but is there any chance you can add tests
>for it?
>
>On 2/11/13 8:28 PM, "Michael Wolf" wrote:
>
>>Hey all:
>>
>>I submitted a pull request for an enhancement o
Splash screens and making an app a type of super plugin are rad ideas
for other pull requests. ;)
Attached image of me when idea of making an app a plugin came up.
On Tue, Feb 12, 2013 at 5:58 PM, Michal Mocny wrote:
> Perhaps this is crazy, but: We already have all this awesome functionality
>
Perhaps this is crazy, but: We already have all this awesome functionality
for plugins -- would it be impossible to just implement an app as a plugin?
On Tue, Feb 12, 2013 at 12:59 PM, Filip Maj wrote:
> BTW, Michael love the pull req, but is there any chance you can add tests
> for it?
>
> On
BTW, Michael love the pull req, but is there any chance you can add tests
for it?
On 2/11/13 8:28 PM, "Michael Wolf" wrote:
>Hey all:
>
>I submitted a pull request for an enhancement of the addition of a merges
>folder/concept into the cli build process.
>
>https://github.com/apache/cordova-cli/
On the topic of splash screen images, we can use the same approach (I
think).
1. Define a location for the splash screen img in your config.xml.
2. Use the merges/overrides feature described here to change it on a
per-platform basis.
It gets tricky tho when a single platform needs multiple images
I definitely think the use-case of per-platform files is valid. We already
have this for plugin.xml I think, by putting tags within
.
Solving it through directory structure instead of through config.xml is
easier I think.
We should think about solving this for splash screens images as well.
On
Cool, thanks Michael. I will take a look when I get a chance. Curious what
the rest of the list thinks.
As for mocking in-browser, I recommend trying out Ripple - it has great
support for mocking out arbitrary cordova plugins.
On 2/12/13 6:10 AM, "Gorkem Ercan" wrote:
>I have been cooking up a
I have been cooking up a similar functionality for Cordova development
plugins for Eclipse IDE that I am building. I think the only real
difference with what I have is I have named the merges folder as
www_platform.
As my goal is to keep 100% compatible with cordova-cli I was planning to
provide a
Hey all:
I submitted a pull request for an enhancement of the addition of a merges
folder/concept into the cli build process.
https://github.com/apache/cordova-cli/pull/3
The concept of merges is pretty simple, to support a common core web base
across platforms, but allow for deploying platfor
22 matches
Mail list logo
