Re: [DISCUSS] Tools Release

2015-01-03 Thread Andrew Grieve
Sounds great Steve! I'll go through tools PRs once more right now. On Fri, Jan 2, 2015 at 2:20 PM, Steven Gill wrote: > Thinking about doing a tools release early next week. Let me know if you > have a PR that needs to be looked at before the release. > > -Steve >

Re: [DISCUSS] Tools Release

2015-01-03 Thread Josh Soref
I don't think I personally have anything I need in. I know I need to comment on a couple. I hope to do that on Monday... ‎ Sent from my BlackBerry 10 smartphone. smime.p7s Description: S/MIME cryptographic signature

[GitHub] cordova-lib pull request: indented scriptContent.

2015-01-03 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/127#issuecomment-68616124 Ah, okay. I think if you're doing this, then you need to manually delete the function(){} wrapper that cordova adds to the file, no? In which case you wouldn't want

[GitHub] cordova-lib pull request: Fix typo: writting -> writing

2015-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-8225: Add Unit Tests for platform.js/...

2015-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-8043 CB-6462 CB-6105 Refactor orienta...

2015-01-03 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/128#issuecomment-68617474 A few comments but love where this is going! I've merged in your first 3 commits since those are fine and I don't want to risk merge conflicts by leaving them pendin

[GitHub] cordova-cli pull request: added --list support

2015-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android pull request: --list support for android

2015-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-ios pull request: --list feature for iOS

2015-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: typo fix for CB-7872

2015-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] Tools Release

2015-01-03 Thread Josh Soref
OK. Now I'm -1 on releasing. Merging the --list patch was not fair to the other platforms. I'll have to spend Monday writing compatibility code for them.  smime.p7s Description: S/MIME cryptographic signature