[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

2016-01-23 Thread biasmv
Github user biasmv commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-174159467 Yeah, that was confusing to me as well. My plugin uses an unmanaged native dll that I'm referencing from C# code. As described in the links below, it's not possi

[GitHub] cordova-plugin-splashscreen pull request: make android support Aut...

2016-01-23 Thread njleonzhang
Github user njleonzhang commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/71#issuecomment-174160943 @daserge Yeah, I agree with you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-01-23 Thread Titoine
Github user Titoine commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-174197635 android@5.0.1 ? Can't upgrade to that version.. ![capture](https://cloud.githubusercontent.com/assets/3514286/12531249/c2881952-c1f5-11e5-885f-0da2075c

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-01-23 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-174198598 @Titoine 5.1.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-01-23 Thread Titoine
Github user Titoine commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-174198681 Sorry, mistake in my comment. But as you see on the screen I tried with 5.1.0 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-01-23 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-174199195 Ok looks like it wan't published to NPM yet, just to git https://www.npmjs.com/package/cordova-android https://github.com/apache/cordova-android/relea

Re: [DISCUSS] Cordova 6.0.0 Release!

2016-01-23 Thread Carlos Santana
+1 On Fri, Jan 22, 2016 at 3:24 PM Steven Gill wrote: > any objections or concerns? Some PRs or issues that need to get fixed > before I do this? > > I want to try to get the vote out either later today or Monday. > > -Steve >

[GitHub] cordova-plugin-media pull request: Fixing issues on Android 6.0

2016-01-23 Thread drbeermann
Github user drbeermann commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/77#issuecomment-174223790 This fixes the callbacks for me, but I'm still having issues with playing multiple media files at the same time on Marshmallow. I'll have to spend some

[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...

2016-01-23 Thread nraboy
Github user nraboy commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-174225250 I can confirm this issue as well. I've added my two cents to the Jira ticket, but it is causing major problems for my open source library

Re: [DISCUSS] Cordova 6.0.0 Release!

2016-01-23 Thread julio cesar sanchez
+1 2016-01-23 21:55 GMT+01:00 Carlos Santana : > +1 > > On Fri, Jan 22, 2016 at 3:24 PM Steven Gill > wrote: > > > any objections or concerns? Some PRs or issues that need to get fixed > > before I do this? > > > > I want to try to get the vote out either later today or Monday. > > > > -Steve >

[GitHub] cordova-lib pull request: CB-10423 Recursive error in plugin add (...

2016-01-23 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-lib/pull/364 CB-10423 Recursive error in plugin add ( windows ) repro steps ; in a plugin repo that has a demo project, you may want to do something like this to allow other developers to run the

Re: [DISCUSS] Cordova 6.0.0 Release!

2016-01-23 Thread Tommy-Carlos Williams
+1 > On 24 Jan 2016, at 10:05 AM, julio cesar sanchez > wrote: > > +1 > > 2016-01-23 21:55 GMT+01:00 Carlos Santana : > >> +1 >> >> On Fri, Jan 22, 2016 at 3:24 PM Steven Gill >> wrote: >> >>> any objections or concerns? Some PRs or issues that need to get fixed >>> before I do this? >>>

Re: [Vote] 5.1.0 Android Release

2016-01-23 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Alexander Sorokin Carlos Santana The vote has passed. On Fri, Jan 22, 2016 at 12:05 PM, Carlos Santana wrote: > +1 > > ran coho create-archive --tag 5.1.0 -r android --dest test-android/ > compare pacakge and only

[GitHub] cordova-lib pull request: New plugin version selection implementat...

2016-01-23 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/363#issuecomment-174261045 Hey @riknoll, Thanks for doing this! I'll review it after the cordova 6 release. --- If your project is set up for it, you can reply to this email and h

[GitHub] cordova-coho pull request: Added apache permanent tag step to plat...

2016-01-23 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/111 Added apache permanent tag step to platform release process You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho pat

[GitHub] cordova-coho pull request: Added apache permanent tag step to plat...

2016-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i