Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/72#issuecomment-189606016
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54331174
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir,
options) {
v
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/396#issuecomment-189612511
@bso-intel, thanks. This looks good apart from the logic duplication in
`plugman/install` and `plugman/fetch`. However, this looks like is out of the
scope
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/401
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/49#issuecomment-189613712
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/6#issuecomment-189613962
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/127#discussion_r54331337
--- Diff: .jscsrc ---
@@ -1,7 +1,7 @@
{
"disallowMixedSpacesAndTabs": true,
"disallowTrailingWhitespace"
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/127#discussion_r54331382
--- Diff: package.json ---
@@ -20,8 +20,8 @@
},
"scripts": {
"test": "npm run lint && npm run style",
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/127#issuecomment-189614910
LGTm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/32#issuecomment-189614969
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-console/pull/16#issuecomment-189614983
LGTm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/41#issuecomment-189615176
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/25#issuecomment-189615205
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/65#issuecomment-189615257
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/72#issuecomment-189615537
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
GitHub user tuvistavie opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/128
Allow to pass an ArrayBuffer to the upload function when working in the
browser.
Hi,
I have been working with this plugin to create an app compatible
with both
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/396#issuecomment-189672357
Yes, please merge this for me.
I don't have committer privilege, which I wish to get. :)
Thanks, Vladimir.
---
If your project is set up for it, you can r
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54334968
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir,
options) {
var spli
Github user dlogo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-189703384
@dallas sorry for answering late, I have checked the differences between
the PR and the base and I think that merge should be done if the PR is checked
by
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-ios/pull/199
CB-10673 fixed conflicting plugin install issue with overlapped tag
The problem is that copyNewFile is too strict for tag.
You will never know which two plugins will write the library to
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-android/pull/264
CB-10673 fixed conflicting plugin install issue with overlapped tag
The problem is that copyNewFile is too strict for tag.
You will never know which two plugins will write the library
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-windows/pull/154
CB-10673 CB-10673 fixed conflicting plugin install issue with overlapped
The problem is that copyNewFile is too strict for tag.
You will never know which two plugins will write the
22 matches
Mail list logo
