Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/39#issuecomment-214183578
@infil00p i've just added a small guide on how to run cordova Appium tests
here:
https://github.com/apache/cordova-medic/blob/master/APPIUM.md
Hello Raghav,
I am not sure why the browser should be an issue, since both windows and wp8
platform should use the very same IE under the hood, and on wp8 platform it is
working.
I could take this problem to stackoverflow, but I guess they'd tell me it's a
bug and I should take it to the devs.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60898584
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more co
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60899092
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more co
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/99#discussion_r60904512
--- Diff: medic/medic-appium.js ---
@@ -241,6 +241,44 @@ function parseElementtreeSync(filename) {
return new elementTree.ElementTree(e
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-medic/pull/99#issuecomment-214296252
LGTM apart from one minor comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user dpeacock opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/94
CB-11146 - iOS getDuration only available after play
Duration is now set on create.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user dpeacock opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/95
CB-11148 - BB10 Media getDuration does not work
Duration is now set properly by calling onStatus for MEDIA_DURATION.
Removed old getDuration native function as this was not being used
Github user adamscybot commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/172#issuecomment-214413840
Anything stopping this being merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
So should we include a en/ folder in all the docs? and move all our current
readme files out of the root?
Personally I am against JSDoc automation, but willing to accept whatever we
decide, but that is another conversation.
@purplecabbage
risingj.com
On Sat, Apr 23, 2016 at 11:24 PM, Dmitry Blo
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/157#discussion_r60946780
--- Diff: template/package.phone.appxmanifest ---
@@ -40,11 +40,9 @@
Description="CordovaApp"
Travis is running this:
- git clone https://github.com/apache/cordova-js --depth 10
- cd cordova-lib
- npm link ../cordova-js
- npm link ../cordova-common
- npm link ../cordova-serve
- npm install
- "(cd ../cordova-common && npm test)"
- "npm run ci"
There are a lot of different things that could
This is an issue where Visual Studio suddenly treats all js files like they
are ts files and need to be transpiled.
@purplecabbage
risingj.com
On Mon, Apr 25, 2016 at 9:48 AM, nikhilkh wrote:
> Github user nikhilkh commented on a diff in the pull request:
>
>
> https://github.com/apache/cordov
cordova-wp8 platform uses IE10, regardless of what is on the phone. This
is done internally via a compatibility layer in the sdk so that moving to a
more recent device / OS does not break existing apps.
Thank you for posting a sample, I will have a look at it and report back
soon.
@purplecabbage
Thanks @alsorokin!
Can you include instructions on how to run the tests also? Please, please.
@purplecabbage
risingj.com
On Mon, Apr 25, 2016 at 12:32 AM, alsorokin wrote:
> Github user alsorokin commented on the pull request:
>
>
> https://github.com/apache/cordova-plugin-device-motion/pull/3
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/172#issuecomment-214443578
http://www.mtu.edu/umc/services/web/cms/characters-avoid/
---
If your project is set up for it, you can reply to this email and have your
reply appea
They do not use the same IE version. Also it works on Windows Phone 10 as well.
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Monday, April 25, 2016 9:58 AM
To: dev@cordova.apache.org
Subject: Re: Windows Phone, platform "Windows" and icon fonts
cordova-wp8 platf
It's jasmine test that is failing [1]
Does this means that jasmine tests are not running in a continuously? Any
reason why are they not running in Travis?
I can't figure out what is the test trying to test:
it('should successfully add a plugin using relative path when running from
subdir inside o
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/172#issuecomment-214472352
Okay, that's a weird link.
Ultimately, there is nothing wrong with the pull request, I just wonder if
other platforms have the issue.
It would
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/272#issuecomment-214474968
OK, so do we have the second commit on this so we can accept this and close
this out? Is there another pull request dealing with the same thing? This
seems to
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revolunet commented on the pull request:
https://github.com/apache/cordova-android/pull/272#issuecomment-214480581
ping @jfrumar again please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user adamscybot commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/172#issuecomment-214481456
I've found iOS doesn't have this issue. The jira issue is here:
https://issues.apache.org/jira/browse/CB-10317
---
If your project is set up for it, yo
Adding charset to the data-url appears to have resolved the issue:
data:application/x-font-woff;charset=utf-8;base64,...
@purplecabbage
risingj.com
On Mon, Apr 25, 2016 at 10:16 AM, Raghav Katyal
wrote:
> They do not use the same IE version. Also it works on Windows Phone 10 as
> well.
>
> -
Github user jfrumar commented on the pull request:
https://github.com/apache/cordova-android/pull/272#issuecomment-214492727
It does seem to be working.
I just created a new project using cordova@5.3.1 and set the app name to
"Cordova & me", and it seems to be working. Our is
Github user revolunet commented on the pull request:
https://github.com/apache/cordova-android/pull/272#issuecomment-214493612
thanks for the feedback @jfrumar ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/179
CB-11142: Fix the NeedPermission code for the case when external mediâ¦
â¦a is not mounted in Android
You can merge this pull request into a Git repository by running:
$ git pul
Github user robertarnesson commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/72#issuecomment-214519638
yes plz
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/179#issuecomment-214520604
@riknoll, @jasongin : Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/179#discussion_r60988953
--- Diff: README.md ---
@@ -273,6 +273,15 @@ Listing asset directories is really slow on Android.
You can speed it up though,
adding `src/an
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/179#discussion_r60990249
--- Diff: README.md ---
@@ -273,6 +273,15 @@ Listing asset directories is really slow on Android.
You can speed it up though,
adding `src/an
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/179#discussion_r60991619
--- Diff: README.md ---
@@ -273,6 +273,15 @@ Listing asset directories is really slow on Android.
You can speed it up though,
adding `src/a
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/40#issuecomment-214527826
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60995226
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contribu
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60995427
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contribu
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/40#discussion_r60995346
--- Diff: README.md ---
@@ -210,4 +210,120 @@ When running in the Emulator, the `connection.status`
is always unknown, so this
Hey everyone,
Here is the CI status for last week.
Build Status (# of test failures):
5 - Android on Windows
0 - Android on OS X
13 - iOS
? - WP 8.1 (CI failing, see CB-11150)
? - Windows (CI failing, see CB-11150)
JIRAs that need attention:
- CB-11150: Windows Platform - Could not f
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/179#issuecomment-214543607
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user Mikejo5000 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/40#discussion_r60999738
--- Diff: README.md ---
@@ -210,4 +210,120 @@ When running in the Emulator, the `connection.status`
is always unknown, so this
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/40#discussion_r61010954
--- Diff: README.md ---
@@ -210,4 +210,120 @@ When running in the Emulator, the `connection.status`
is always unknown, so this
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-android/pull/299
CB-11153 Use Gradle 2.8 correctly for building Android projects
This improves gradle build performance by 1 second on my machine
@jasongin; @infil00p; @riknoll to help review
You
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-android/pull/299#issuecomment-214615174
## [Current coverage][cc-pull] is **100%**
> Merging [#299][cc-pull] into [master][cc-base-branch] will increase
coverage by **+63.87%**
```diff
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/585
Use XML entities in attributes
This makes the XML well formed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikhilkh/cordova-docs patch-
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-docs/pull/585#issuecomment-214635727
These were rendering properly in github's markdown, is this an issue with
our own document md->html conversion?
