Re: Nightly build #137 for cordova has failed

2016-09-06 Thread Shazron
See https://issues.apache.org/jira/browse/CB-11811 On Mon, Sep 5, 2016 at 7:53 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > Nightly build #137 for cordova has failed. > > Please check failure details on build details page at > https://builds.apache.org/job/cordova-nightly/137/

publish Cordova iOS 4.2.1 on cocoapods

2016-09-06 Thread julio cesar sanchez
We should publish Cordova iOs 4.2.1 on cocoapods, latest version there is 4.1.1. I have created an issue on phonegap repo as people has been asking there because of the tutorial https://github.com/phonegap/phonegap-webview-ios/issues/14

[GitHub] cordova-plugin-dialogs issue #69: Added options to customize keyboard for pr...

2016-09-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/69 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/69/commits/b9b1752bd7d156d89f89fefeaf85c749bef4e3ad

[GitHub] cordova-android issue #244: CB-10140 Use application id instead of package n...

2016-09-06 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/244 @fredgalvao The PR was closed, not the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios issue #250: CB-9762 (iOS) Add launch storyboard support

2016-09-06 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/250 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/250?src=pr) is 56.14% (diff: 58.94%) > Merging [#250](https://codecov.io/gh/apache/cordova-ios/pull/250?src=pr) into [

[GitHub] cordova-android pull request #328: Nougat update - Updates required for API ...

2016-09-06 Thread pbakondy
Github user pbakondy commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/328#discussion_r77677216 --- Diff: framework/src/org/apache/cordova/CoreAndroid.java --- @@ -357,4 +358,33 @@ public void sendResumeEvent(PluginResult resumeEvent) {

[GitHub] cordova-android pull request #328: Nougat update - Updates required for API ...

2016-09-06 Thread infil00p
Github user infil00p commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/328#discussion_r77679067 --- Diff: framework/src/org/apache/cordova/CoreAndroid.java --- @@ -357,4 +358,33 @@ public void sendResumeEvent(PluginResult resumeEvent) {

Re: [Discuss] Cordova-Android 6.0.x

2016-09-06 Thread Joe Bowser
Merging the nougat_update code today. Master will now be targeting API 24. On Fri, Sep 2, 2016 at 11:21 AM, Joe Bowser wrote: > Yeah, I already added android-24 to that line, and now the error is even > more explicit and it's telling me straight up to install it. I need > someone to install an

[GitHub] cordova-android pull request #328: Nougat update - Updates required for API ...

2016-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: [Discuss] Cordova-Android 6.0.x

2016-09-06 Thread julio cesar sanchez
Now we shouldn't forget to increase the minSdkVersion. I couldn't find an issue open for this. Which API level did we say that we will support? 16? El martes, 6 de septiembre de 2016, Joe Bowser escribió: > Merging the nougat_update code today. Master will now be targeting API 24. > > On Fri,

Re: [Discuss] Cordova-Android 6.0.x

2016-09-06 Thread Joe Bowser
On Tue, Sep 6, 2016 at 11:14 AM, julio cesar sanchez wrote: > Now we shouldn't forget to increase the minSdkVersion. I couldn't find an > issue open for this. Which API level did we say that we will support? 16? > > Yes, we said 16. I already did it when bumping up to API 24, but an issue would

[Discuss] Cordova-Android 6.0.x

2016-09-06 Thread julio cesar sanchez
Those 2 lines have minSdkVersion 14 https://github.com/apache/cordova-android/blob/master/ framework/AndroidManifest.xml#L22 https://github.com/apache/cordova-android/blob/master/test/AndroidManifest.xml#L48 Maybe I looked into the wrong place and that is not being used El martes, 6 de septiem

[GitHub] cordova-plugin-dialogs issue #69: Added options to customize keyboard for pr...

2016-09-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/69 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/69/commits/c669ff8d20b9783ae20ba0effa6b5eb92f3dc374

[GitHub] cordova-plugin-camera pull request #236: CB-11661: (ios) Add mandatory iOS 1...

2016-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/236 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera issue #236: CB-11661: (ios) Add mandatory iOS 10 priva...

2016-09-06 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/236 Everything was fine, just didn't have time to merge it yesterday. Merged now, thanks for the PR --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-plugin-camera issue #236: CB-11661: (ios) Add mandatory iOS 10 priva...

2016-09-06 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/236 Everything was fine, just didn't have time to merge it yesterday. Merged now, thanks for the PR --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-plugin-camera issue #236: CB-11661: (ios) Add mandatory iOS 10 priva...

2016-09-06 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/236 Everything was fine, just didn't have time to merge it yesterday. Merged now, thanks for the PR --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-plugin-camera issue #236: CB-11661: (ios) Add mandatory iOS 10 priva...

2016-09-06 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/236 Everything was fine, just didn't have time to merge it yesterday. Merged now, thanks for the PR --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-plugin-camera issue #236: CB-11661: (ios) Add mandatory iOS 10 priva...

2016-09-06 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/236 Everything was fine, just didn't have time to merge it yesterday. Merged now, thanks for the PR --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-plugin-camera issue #236: CB-11661: (ios) Add mandatory iOS 10 priva...

2016-09-06 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/236 Everything was fine, just didn't have time to merge it yesterday. Merged now, thanks for the PR --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-plugin-media pull request #116: CB-1187: (iOS) Fix unused recording ...

2016-09-06 Thread ghenry22
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/116 CB-1187: (iOS) Fix unused recording settings ### Platforms affected iOS ### What does this PR do? easy fix: audioSettings object wasn't being passed in when starting a

[GitHub] cordova-plugin-media issue #116: CB-1187: (iOS) Fix unused recording setting...

2016-09-06 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 I didn't add any automated tests as it wasn't relevant, this was just a really simple bug. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2016-09-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/116/commits/642aef774aa60a34b29d451f684ffc67bf732700)

Nightly build #138 for cordova has succeeded!

2016-09-06 Thread Apache Jenkins Server
Nightly build #138 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/138/consoleFull - Jenkins for Apache Cordova -

optimizing ios inappbrowser plugin's open and openInSystem method s

2016-09-06 Thread Li, Jonathan
Hi, Currently there are two issues in iOS inappbrowser’s open and openInSystem methods. First, in the inappbrowser open method, it sets the instance variable at below self.callbackId = command.callbackId; this causes the problem when opening a _system targe from an inappbrowser viewCon