[GitHub] cordova-plugin-file-transfer issue #165: CB-12107: (android) Trigger media s...

2016-11-11 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/165 Cordova CI Build has one or more failures. Link: http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/43/ 312 tests run, 26 skipped, 50 failed.

[GitHub] cordova-plugin-media issue #54: Handles the "playAudioWhenScreenIsLocked" si...

2016-11-11 Thread katzlbt
Github user katzlbt commented on the issue: https://github.com/apache/cordova-plugin-media/pull/54 @ghenry22 Current sources and README do not indicate any deprecation of **_playAudioWhenScreenIsLocked_** in iOS. Which tickets did you read?

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-11 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87596875 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-11 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87598394 --- Diff: spec/unit/ConfigChanges.spec.js --- @@ -161,3 +165,40 @@ describe('Capabilities within package.windows.appxmanifest', function() {

[GitHub] cordova-ios pull request #277: CB-11243: Fix target-device and deployment-ta...

2016-11-11 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-ios/pull/277 CB-11243: Fix target-device and deployment-target preferences ### Platforms affected iOS ### What does this PR do? Fixes target-device and deployment-target preferences.

[GitHub] cordova-plugin-file-transfer issue #165: CB-12107: (android) Trigger media s...

2016-11-11 Thread beatgrabe
Github user beatgrabe commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/165 @infil00p Seems like project is still broken… --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-statusbar pull request #71: iOS multitasking fix not yet comm...

2016-11-11 Thread mikeg-red5hift
Github user mikeg-red5hift closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-statusbar pull request #71: iOS multitasking fix not yet comm...

2016-11-11 Thread mikeg-red5hift
GitHub user mikeg-red5hift opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/71 iOS multitasking fix not yet committed to the source plug-in repo ### Platforms affected ### What does this PR do? ### What testing has

[GitHub] cordova-plugin-statusbar pull request #71: iOS multitasking fix not yet comm...

2016-11-11 Thread mikeg-red5hift
GitHub user mikeg-red5hift reopened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/71 iOS multitasking fix not yet committed to the source plug-in repo ### Platforms affected ### What does this PR do? ### What testing

[GitHub] cordova-plugin-statusbar pull request #71: iOS multitasking fix not yet comm...

2016-11-11 Thread mikeg-red5hift
Github user mikeg-red5hift closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

2016-11-11 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/277 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/277?src=pr) is 60.00% (diff: 100%) > Merging [#277](https://codecov.io/gh/apache/cordova-ios/pull/277?src=pr) into

[GitHub] cordova-plugin-media issue #54: Handles the "playAudioWhenScreenIsLocked" si...

2016-11-11 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-media/pull/54 Hey @romedius! Thanks for sending this in! I have a few questions I was hoping you could answer to speed up the review. So right now, media will keep

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

2016-11-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 Reviewing this to understand where the bug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

2016-11-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 CB-11648 will be obsolete and may not be needed with https://issues.apache.org/jira/browse/CB-12127 already implemented. Example use:

[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...

2016-11-11 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 The existing hide and the new browserHide do exactly the same, can you make the old hide just call browserHide instead of duplicating code. Can you try adding this

[GitHub] cordova-ios pull request #278: CB-11243 - Added failing tests

2016-11-11 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/278 CB-11243 - Added failing tests ### Platforms affected iOS ### What does this PR do? Added failing tests for `target-device` and `deployment-target` preferences on

[GitHub] cordova-windows issue #207: Move windows-specific logic from cordova-common

2016-11-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/207 > Do I get it right that it will require us to release cordova-common before platform release? @matrosov-nikita, I think the idea was to make it so updated cordova-windows

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

2016-11-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 Evaluated this. Turns out this is not the problem - see #278 failing test for this issue which looks like a failure in node-xcode updateBuildProperty. Note that the test project pbxproj already

[GitHub] cordova-ios issue #278: CB-11243 - Added failing tests

2016-11-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/278 I'm going to run some independent tests on node-xcode to verify that updateBuildProperty is working properly (it has unit-tests already) or whether it is our test pbxproj that is faulty, etc.

[GitHub] cordova-plugin-file-transfer issue #165: CB-12107: (android) Trigger media s...

2016-11-11 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/165 @beatgrabe And the tests that are failing are all related to this plugin. Until these pass, I'm not going to merge it in. --- If your project is set up for it, you can reply

Nightly build #224 for cordova has succeeded!

2016-11-11 Thread Apache Jenkins Server
Nightly build #224 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/224/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-ios issue #278: CB-11243 - Added failing tests

2016-11-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/278 It's not a failure in node-xcode. Therefore, the tests are incorrect somehow. Tested using: ``` #!/usr/bin/env node var xcode = require('xcode'), fs =