Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103362438
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
var parsedSpec =
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103362278
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -342,13 +322,6 @@ function copyPlugin(pinfo, plugins_dir, link) {
var dest =
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103360880
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -221,7 +221,7 @@ describe('install', function() {
});
});
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103361780
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -165,14 +165,7 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
Nightly build #267 for cordova has failed.
Please check failure details on build details page at
https://builds.apache.org/job/cordova-nightly/267/
You can also take a look at build console:
https://builds.apache.org/job/cordova-nightly/267/consoleFull
-
Jenkins for Apache Cordova
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user romedius commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/121
@stevengill Hi! I will merge the functionality this week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/362
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/362?src=pr=h1)
Report
> Merging
[#362](https://codecov.io/gh/apache/cordova-android/pull/362?src=pr=desc)
into
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/521
CB-12425 : Auto-create package.json if it doesn't exist yet (during prepare)
### Platforms affected
### What does this PR do?
Auto-creates package.json if it
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/107
can you rebase and squash the commits into one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/363
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/358
@kalliste Thanks for submitting the ICLA. Is it possible for you to add a
Unit Test to the new Unit Testing framework for this patch? People have been
complaining about this being a
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/228
CB-12499 UWP: Dependent external libraries specified as resource-fileâ¦
⦠not being referenced in Release mode
### Platforms affected
Windows
### What
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/107
Rebasing on top of the master should resolve test failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/107
Cordova CI Build has completed successfully.
**Commit** -
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/228
#
[Codecov](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr=h1)
Report
> Merging
[#228](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr=desc)
into
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/219
Related: CB-9176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user samuelt1 commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/80
there is actually serious uses to this now. Google drive pretty much fails
in all cases when dealing with anything, but images. The reason for this is
because the images can get sent
Github user benbotto commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/99
Seconding @moneytree-doug's statement that this is important for OAuth, or
any protocol that requires redirects back to the app.
@ljcljc's fork corrects the problem, and
Github user Lazza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103162781
--- Diff: src/android/StatusBar.java ---
@@ -142,6 +142,23 @@ public void run() {
return true;
}
+
Github user Lazza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103163815
--- Diff: src/android/StatusBar.java ---
@@ -164,4 +181,21 @@ private void setStatusBarBackgroundColor(final String
colorPref) {
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Lazza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103163253
--- Diff: src/android/StatusBar.java ---
@@ -142,6 +142,23 @@ public void run() {
return true;
}
+
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103343073
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -221,7 +221,7 @@ describe('install', function() {
});
});
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/364
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/522
CB-12016 : removes pluginId mapping
### Platforms affected
### What does this PR do?
Removes pluginId mapping
### What testing has been done on this
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/523
CB-11346
### Platforms affected
All, none, ...
### What does this PR do?
Removes multiple checks for 'known' platforms
### What testing has been done
28 matches
Mail list logo