[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/522#discussion_r103362438 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) { var parsedSpec =

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/522#discussion_r103362278 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -342,13 +322,6 @@ function copyPlugin(pinfo, plugins_dir, link) { var dest =

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/522#discussion_r103360880 --- Diff: cordova-lib/spec-plugman/install.spec.js --- @@ -221,7 +221,7 @@ describe('install', function() { }); });

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/522#discussion_r103361780 --- Diff: cordova-lib/src/plugman/uninstall.js --- @@ -165,14 +165,7 @@ module.exports.uninstallPlugin = function(id, plugins_dir, options) {

Nightly build #267 for cordova has failed

2017-02-27 Thread Apache Jenkins Server
Nightly build #267 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/267/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/267/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-dialogs pull request #14: add password and login/password inp...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-dialogs pull request #71: Secure prompt text fields for passw...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...

2017-02-27 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 @stevengill Hi! I will merge the functionality this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-android issue #362: CB-12453: Remove unnecessary double quotes from ...

2017-02-27 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/362 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/362?src=pr=h1) Report > Merging [#362](https://codecov.io/gh/apache/cordova-android/pull/362?src=pr=desc) into

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-02-27 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/521 CB-12425 : Auto-create package.json if it doesn't exist yet (during prepare) ### Platforms affected ### What does this PR do? Auto-creates package.json if it

[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...

2017-02-27 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 can you rebase and squash the commits into one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request #363: CB-12465: Rewrite of the Unit Tests

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/363 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android issue #358: CB-12424: (android) Fix encoding of multipart me...

2017-02-27 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/358 @kalliste Thanks for submitting the ICLA. Is it possible for you to add a Unit Test to the new Unit Testing framework for this patch? People have been complaining about this being a

[GitHub] cordova-windows pull request #228: CB-12499 UWP: Dependent external librarie...

2017-02-27 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/228 CB-12499 UWP: Dependent external libraries specified as resource-file… … not being referenced in Release mode ### Platforms affected Windows ### What

[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...

2017-02-27 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 Rebasing on top of the master should resolve test failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...

2017-02-27 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-windows issue #228: CB-12499 UWP: Dependent external libraries speci...

2017-02-27 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/228 # [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr=h1) Report > Merging [#228](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr=desc) into

[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support

2017-02-27 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/219 Related: CB-9176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-camera issue #80: feature CB-8777 Add option onlyGalleries

2017-02-27 Thread samuelt1
Github user samuelt1 commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/80 there is actually serious uses to this now. Google drive pretty much fails in all cases when dealing with anything, but images. The reason for this is because the images can get sent

[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...

2017-02-27 Thread benbotto
Github user benbotto commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 Seconding @moneytree-doug's statement that this is important for OAuth, or any protocol that requires redirects back to the app. @ljcljc's fork corrects the problem, and

[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...

2017-02-27 Thread Lazza
Github user Lazza commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103162781 --- Diff: src/android/StatusBar.java --- @@ -142,6 +142,23 @@ public void run() { return true; } +

[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...

2017-02-27 Thread Lazza
Github user Lazza commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103163815 --- Diff: src/android/StatusBar.java --- @@ -164,4 +181,21 @@ private void setStatusBarBackgroundColor(final String colorPref) {

[GitHub] cordova-plugin-camera pull request #255: CB-12501 (Android) Appium tests don...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/255 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...

2017-02-27 Thread Lazza
Github user Lazza commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103163253 --- Diff: src/android/StatusBar.java --- @@ -142,6 +142,23 @@ public void run() { return true; } +

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/522#discussion_r103343073 --- Diff: cordova-lib/spec-plugman/install.spec.js --- @@ -221,7 +221,7 @@ describe('install', function() { }); });

[GitHub] cordova-android pull request #364: CB-8348: (android) Updating version numbe...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-02-27 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/522 CB-12016 : removes pluginId mapping ### Platforms affected ### What does this PR do? Removes pluginId mapping ### What testing has been done on this

[GitHub] cordova-lib pull request #523: CB-11346

2017-02-27 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-lib/pull/523 CB-11346 ### Platforms affected All, none, ... ### What does this PR do? Removes multiple checks for 'known' platforms ### What testing has been done