[GitHub] cordova-lib issue #567: CB-12361: Added unit tests for prepare.js

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/567 Sent an update with changes based on feedback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-battery-status pull request #55: CB-12935 Run paramedic build...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/55 CB-12935 Run paramedic builds on Travis ### Platforms affected Android, iOS ### What does this PR do? https://issues.apache.org/jira/browse/CB-12935 Adds

[GitHub] cordova-plugin-battery-status pull request #55: CB-12935 Run paramedic build...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media pull request #143: CB-7684

GitHub user adriano-di-giovanni opened a pull request: https://github.com/apache/cordova-plugin-media/pull/143 CB-7684 ### Platforms affected iOS ### What does this PR do? This PR will add an `isPlayingOrRecording` method that's called before any try to

[GitHub] cordova-plugin-media issue #100: CB-7684: (iOS) Fix CDVSound killing all aud...

Github user adriano-di-giovanni commented on the issue: https://github.com/apache/cordova-plugin-media/pull/100 I've just submitted a #143 PR that solves the issue implementing an `CDVSound#isPlayingOrRecording` method. The method checks the status of player/recorder for every

[GitHub] cordova-plugin-camera pull request #272: CB-12935: (android, ios) Run parame...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/272 CB-12935: (android, ios) Run paramedic tests on Travis ### Platforms affected iOS, Android ### What does this PR do? https://issues.apache.org/jira/browse/CB-12935

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/567#discussion_r123500548 --- Diff: spec-cordova/prepare.spec.js --- @@ -63,103 +63,103 @@ describe('cordova/prepare', function () { spyOn(cordova_config,

[GitHub] cordova-plugin-screen-orientation pull request #17: Update package.json

GitHub user luckylooke opened a pull request: https://github.com/apache/cordova-plugin-screen-orientation/pull/17 Update package.json minor change The plugin uses IonicNativePlugin from ionic-native / core version (3.6.1), so plugin need to have this specified, for earlier

[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...

Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/561 Couple things in this one: 1. This will need a rebase with the latest. 2. I wonder if instead of putting more efforts into tweaking the fixtures and integration tests, we put more

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

Github user filmaj closed the pull request at: https://github.com/apache/cordova-lib/pull/566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Cordova-Android 7.0.0 Review request

Hey So, there's currently a two outstanding PRs that I want to throw into Cordova-Android 7.0.0: https://github.com/apache/cordova-android/pull/384 https://github.com/apache/cordova-android/pull/352 The thing is that I want some people to actually review these changes before I add them. I'm

[GitHub] cordova-android pull request #387: CB-12605 In Windows get Android studio pa...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/387 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib issue #563: CB-11713 and CB-11961

Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/563 @goya CI should be passing now, you'll need to rebase as a bunch of files moved around as part of the plugin command refactor and test speed improvements we landed. The

[GitHub] cordova-android issue #387: CB-12605 In Windows get Android studio path from...

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/387 LGTM, pulling in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/386 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request #563: CB-11713 and CB-11961

Github user goya closed the pull request at: https://github.com/apache/cordova-lib/pull/563 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib issue #567: CB-12361: Added unit tests for prepare.js

Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/567 @stevengill rebase away and give it all another go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Cordova-Android 7.0.0 Review request

BTW: I also want to pull this in: https://github.com/apache/cordova-android/pull/385/files On Thu, Jun 22, 2017 at 10:38 AM, Joe Bowser wrote: > Hey > > So, there's currently a two outstanding PRs that I want to throw into > Cordova-Android 7.0.0: > >

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/568 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=h1) Report > Merging [#568](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=desc) into

[GitHub] cordova-lib pull request #568: Reorganized unit test directory structure + u...

GitHub user filmaj opened a pull request: https://github.com/apache/cordova-lib/pull/568 Reorganized unit test directory structure + updated npm task names ### What does this PR do? This is a proof-of-concept pull request mainly introduction file organizational changes.

[GitHub] cordova-lib issue #567: CB-12361: Added unit tests for prepare.js

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/567 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/567?src=pr=h1) Report > Merging [#567](https://codecov.io/gh/apache/cordova-lib/pull/567?src=pr=desc) into

[GitHub] cordova-lib pull request #567: CB-12361: Added unit tests for prepare.js

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

cordova-lib proposal on test directory reorganization

Proposal up in PR form here: https://github.com/apache/cordova-lib/pull/568 tl;dr consolidating `spec-cordova/` and `spec-plugman` directories into one, setting up to for one-unit-test-spec.js per source-module.js file. Looking for eyes and feedback! If you have any, please drop comments in the

Nightly build #407 for cordova has failed

Nightly build #407 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/407/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/407/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-geolocation issue #37: Fix error from translation, params nam...

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/37 Sorry for not seeing this sooner, and thanks for contributing. We use Crowdin, a translation and localization management platform to collaborate amongst translators and

[GitHub] cordova-browser pull request #33: CB-11711 clean should destroy platforms/br...

GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-browser/pull/33 CB-11711 clean should destroy platforms/browser/www folder contents ### Platforms affected browser ### What does this PR do? removes www/ folder during clean

[GitHub] cordova-browser pull request #33: CB-11711 clean should destroy platforms/br...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the