Re: Cordova-Android 7.0: Upgrading Java Requirement to 7.0

+1 As per: https://developer.android.com/guide/platform/j8-jack.html We can keep the source and target versions set to 1.7 and still use the subset of new Java 8 features if uses compile using JDK 8. Perhaps the readme should be updated to require JDK 8? Simon Mac Donald

Re: Cordova-Android 7.0: Upgrading Java Requirement to 7.0

+1 El 29 jun. 2017 8:34 p. m., "Joe Bowser" escribió: > Hey > > I think we should accept this PR to attract newer developers. Sure, we > could adopt Java 8, but I think being stuck with Java 6 may be limiting > contributions. Does anyone have any thoughts on this? > >

[GitHub] cordova-android issue #362: CB-12453: Remove unnecessary double quotes from ...

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/362 @filmaj Can you look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Cordova-Android 7.0: Upgrading Java Requirement to 7.0

Hey I think we should accept this PR to attract newer developers. Sure, we could adopt Java 8, but I think being stuck with Java 6 may be limiting contributions. Does anyone have any thoughts on this? https://github.com/apache/cordova-android/pull/380

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124878443 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124878233 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124871034 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124881302 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124878766 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124879465 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124874233 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124880319 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124881373 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124879975 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124891852 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124893969 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124894106 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124863854 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124890998 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124873252 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124893454 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124892113 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124867315 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r124868182 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,459 @@ */ /* eslint-env jasmine */ +var path =

[GitHub] cordova-plugin-device pull request #65: CB-12935: (windows) Enable paramedic...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-screen-orientation issue #15: fix(plugin): add es6-promise-pl...

Github user zhaosg commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/15 Having the same problem > Installing "cordova-plugin-screen-orientation" for android > Failed to install 'cordova-plugin-screen-orientation': CordovaError:

[GitHub] cordova-mobile-spec pull request #145: CB-10718: Update instruction

GitHub user halton opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/145 CB-10718: Update instruction ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ###

[GitHub] cordova-plugin-screen-orientation pull request #19: Dummy commmit to trigger...

Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-screen-orientation/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Nightly build #414 for cordova has failed

Nightly build #414 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/414/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/414/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-coho issue #153: CB-12963: npm-link all dependencies

Github user halton commented on the issue: https://github.com/apache/cordova-coho/pull/153 @alsorokin would you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Cordova-Android 7.0: Upgrading Java Requirement to 7.0

+1 Sent from my phone. ___ Kerri > On Jun 29, 2017, at 13:34, Joe Bowser wrote: > > Hey > > I think we should accept this PR to attract newer developers. Sure, we > could adopt Java 8, but I think being stuck with Java 6 may be limiting >

[GitHub] cordova-android pull request #386: CB-12895 : added eslint and removed jshin...

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/386#discussion_r124902965 --- Diff: bin/templates/cordova/Api.js --- @@ -112,16 +110,13 @@ Api.createPlatform = function (destination, config, options, events) {

Re: Cordova-Android 7.0: Upgrading Java Requirement to 7.0

+1 @purplecabbage risingj.com On Thu, Jun 29, 2017 at 12:34 PM, Simon MacDonald wrote: > +1 > > As per: https://developer.android.com/guide/platform/j8-jack.html > > We can keep the source and target versions set to 1.7 and still use the > subset of new Java 8

[GitHub] cordova-android issue #385: CB-12835: add a Context getter in CordovaInterfa...

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/385 @filmaj Yeah, that definitely needs an update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/573 CB-12361 : updated addHelper tests ### Platforms affected ### What does this PR do? updated addHelper tests ### What testing has been done on this change?

[GitHub] cordova-lib pull request #570: CB-12361 : updated cordova-lib addHelper.spec...

Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho pull request #153: CB-12963: npm-link all dependencies

GitHub user halton opened a pull request: https://github.com/apache/cordova-coho/pull/153 CB-12963: npm-link all dependencies ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ###

[GitHub] cordova-android issue #298: CB-9465 replace Integer.parseInt with BigInteger...

Github user pa-de-solminihac commented on the issue: https://github.com/apache/cordova-android/pull/298 I am afraid this commit was useless (if not harmful), as [the documentation](https://developer.android.com/studio/publish/versioning.html#appversioning) states: > Warning: The

[GitHub] cordova-plugin-screen-orientation pull request #18: CB-12935: (ios, android)...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-screen-orientation/pull/18 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-device pull request #65: CB-12935: (windows) Enable paramedic...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-device/pull/65 CB-12935: (windows) Enable paramedic builds on AppVeyor ### Platforms affected Windows ### What does this PR do? https://issues.apache.org/jira/browse/CB-12935

[GitHub] cordova-plugin-screen-orientation pull request #19: Dummy commmit to trigger...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-screen-orientation/pull/19 Dummy commmit to trigger Travis CI run ### Platforms affected ### What does this PR do? ### What testing has been done on this

[GitHub] cordova-plugin-inappbrowser issue #205: CB-9148 - (android) Add support for ...

Github user sbhandary commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/205 Hello, I am still having the issue with the android. Is this issue fixed/ included in the cordova? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-inappbrowser issue #205: CB-9148 - (android) Add support for ...

Github user andersborgabiro commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/205 It's included in cordova-plugin-inappbrowser 1.7.0. Note though that it will not work on certain Android versions, notably 4.4.2, as described below. I don't know about

[GitHub] cordova-plugin-screen-orientation pull request #18: CB-12935: (ios, android)...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-screen-orientation/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes