[GitHub] cordova-ios pull request #327: CB-12895: replaced jshint with eslint

2017-07-13 Thread audreyso 
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-ios/pull/327

CB-12895: replaced jshint with eslint



### Platforms affected


### What does this PR do?
Replaced jshint with eslint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-ios CB-12895-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/327.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #327


commit f9b046e5fae2f83c7aa9bf20d80a1fcfd09d05f9
Author: Audrey So 
Date:   2017-06-15T17:56:59Z

CB-12895 : removed jshint and added eslint

commit b7b92263af52efd2bad27d5bdba63ee24244e76a
Author: Audrey So 
Date:   2017-06-15T18:02:03Z

CB-12895 : formatted using eslint rules

commit d2fae43e99f2f4da52d3aa13aee309c805964eea
Author: Audrey So 
Date:   2017-07-12T21:47:46Z

CB-12895 : updated indenting with eslint rules




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #375: CB-12657 android: fixed android 4.3 exit ...

2017-07-13 Thread Thomsen 
Github user Thomsen closed the pull request at:

https://github.com/apache/cordova-android/pull/375


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

2017-07-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/573


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #575: CB-13020: (plugman) install filters out nohoo...

2017-07-13 Thread wildabeast 
GitHub user wildabeast opened a pull request:

https://github.com/apache/cordova-lib/pull/575

CB-13020: (plugman) install filters out nohooks



### Platforms affected

n/a

### What does this PR do?

fixes CB-13020: plugman filters out nohooks opt

### What testing has been done on this change?

manual

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wildabeast/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #575


commit 6234355db76342b6fb3045b9a3b23e08f42a92bd
Author: Ryan Willoughby 
Date:   2017-07-13T19:10:04Z

CB-13020: (plugman) install filters out nohooks




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #327: CB-12895: replaced jshint with eslint

2017-07-13 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/327
  
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=h1) 
Report
> Merging 
[#327](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/26beb94e2d454917db0bb024ab75e8dd9759c028?src=pr=desc)
 will **increase** coverage by `0.14%`.
> The diff coverage is `52.39%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/327/graphs/tree.svg?height=150=650=pr=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #327  +/-   ##
==
+ Coverage   63.77%   63.91%   +0.14% 
==
  Files  14   14  
  Lines1623 1671  +48 
  Branches  277  277  
==
+ Hits 1035 1068  +33 
- Misses588  603  +15
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[...mplates/scripts/cordova/lib/copy-www-build-step.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NvcHktd3d3LWJ1aWxkLXN0ZXAuanM=)
 | `0% <0%> (ø)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/clean.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NsZWFuLmpz)
 | `0% <0%> (ø)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=)
 | `84.66% <100%> (+0.06%)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/PodsJson.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZHNKc29uLmpz)
 | `100% <100%> (ø)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3J1bi5qcw==)
 | `25.61% <17.8%> (+3.2%)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz)
 | `38.77% <19.78%> (+1.93%)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/versions.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ZlcnNpb25zLmpz)
 | `12.35% <27.58%> (+0.45%)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=)
 | `42.04% <36.11%> (+2.04%)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz)
 | `53.89% <42.85%> (ø)` | :arrow_up: |
| 
[bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=)
 | `76.85% <60.41%> (+1.2%)` | :arrow_up: |
| ... and [4 
more](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=footer). 
Last update 
[26beb94...80f4521](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-07-13 Thread audreyso 
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/574

CB-12838 : prevented sorting and alphabetizing platforms and plugins i…

…n pkgJson and config



### Platforms affected


### What does this PR do?

Prevents modifying/alphabetizing platforms and plugins in config

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12838

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/574.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #574


commit 083deef9ce70afe8455a36f49ddccf0b093558f8
Author: Audrey So 
Date:   2017-07-12T00:21:41Z

CB-12838 : prevented sorting and aphabetizing platforms and plugins in 
pkgjson and config




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #221: CB-12834: (android) Fix bug when ope...

2017-07-13 Thread alanhg 
Github user alanhg commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/221
  
Please publish the official version v1.7.2 as soon as possible.
I need to implement download file like pdf or doc .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #428 for cordova has failed

2017-07-13 Thread Apache Jenkins Server 
Nightly build #428 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/428/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/428/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-07-13 Thread Lazza 
Github user Lazza commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/125
  
Are there any news on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org