[GitHub] cordova-plugin-statusbar pull request #86: CB-13291: iOS 11 statusbar fixes

[BrainstemStudio]

Github user BrainstemStudio closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/86


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #86: CB-13291: iOS 11 statusbar fixes

[BrainstemStudio]

Github user BrainstemStudio commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/86
  
@mhartington Testing now, did not know about viewport-fit will let you know 
what my test reveal, if it is unnecessary will remove the property. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #86: CB-13291: iOS 11 statusbar fixes

[mhartington]

Github user mhartington commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/86
  
With `StatusBarCropsWebview`, does this override/breaks the expected 
behavior of `viewport-fit`? In my tested, most of the sizing/cropping settings 
can be fixed just by adding `viewport-fit=cover` to the viewport meta tag. 

If this setting does something similar, I'd think it would not be 
necessary. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #86: CB-13291: iOS 11 statusbar fixes

[BrainstemStudio]

GitHub user BrainstemStudio opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/86

CB-13291: iOS 11 statusbar fixes

1. Added new property "StatusBarCropsWebview" to allow iPhone X to display 
edge to edge using the "safeAreaInsets" top and bottom. By default this will be 
set as "true" and crop the webview below and above the safe areas

2. When "StatusBarCropsWebview" is set to false. The web view will extend 
to the correcr full screen on iPhone X. However, is the 
"StatusBarOverlaysWebView" is to false. This will only extend the web view at 
the bottom edge

3. If both StatusBarCropsWebview and “StatusBarOverlaysWebView” are set 
to false this will extend the screen top and bottom edge.

4. Added fix for iOS 11 gap problems. If “StatusBarOverlaysWebView” is 
set to false, this now fixes the 20px bottom gap.

5. Added fix for iOS 11 gap after status bar is set to hidden after 
showing. This now fixes the 20px bottom gap.

6. Added fix for iPad to force web view status bar to not run if app for 
iPhone but running on iPad. Requirement from apple.

See https://issues.apache.org/jira/browse/CB-13291 for full details



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BrainstemStudio/cordova-plugin-statusbar 
CB-13291

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #86


commit b2e83b26f12b68a5d504d2ba171d7fcb1e1d19a7
Author: BrainstemStudio 
Date:   2017-09-17T11:31:58Z

CB-13291: Fixes

1. Added new property "StatusBarCropsWebview" to allow iPhone X to display 
edge to edge using the "safeAreaInsets" top and bottom. By default this will be 
set as "true" and crop the webview below and above the safe areas

2. When "StatusBarCropsWebview" is set to false. The web view will extend 
to the correcr full screen on iPhone X. However, is the 
"StatusBarOverlaysWebView" is to false. This will only extend the web view at 
the bottom edge

3. If both StatusBarCropsWebview and “StatusBarOverlaysWebView” are set 
to false this will extend the screen top and bottom edge.

4. Added fix for iOS 11 gap problems. If “StatusBarOverlaysWebView” is 
set to false, this now fixes the 20px bottom gap.

5. Added fix for iOS 11 gap after status bar is set to hidden after 
showing. This now fixes the 20px bottom gap.

See https://issues.apache.org/jira/browse/CB-13291 for full details




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #86: CB-13291: iOS 11 statusbar fixes

[BrainstemStudio]

Github user BrainstemStudio commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/86
  
@mhartington You are correct. The viewport-fit=cover makes doe fix the 
problem without the need to add the new property. I am going to revise the 
issue and submit.

I see you have already submitted a fix for this which does work when using 
viewport-fit=cover. I think it would be best for me to remove my pull request 
and rather let yours make the change.

I would however like to suggest you add #if __IPHONE_OS_VERSION_MAX_ALLOWED 
>= 11
where you use iOS 11 safearea, so errors can be avoided in previous version 
of xcode.





---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #732: CB-13284: Slackin.js on docs fails to load d...

[devgeeks]

GitHub user devgeeks opened a pull request:

https://github.com/apache/cordova-docs/pull/732

CB-13284: Slackin.js on docs fails to load due to insecure response



### Platforms affected

Docs

### What does this PR do?

Changed location of slackin.js to https://slack-cordova-io.herokuapp.com
to match the TLS certificate


### What testing has been done on this change?

Manual testing


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/devgeeks/cordova-docs CB-13284

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #732


commit 4ca39eb1cbe3ec0926f522d59c9f256eb7f00947
Author: tommy-carlos williams 
Date:   2017-09-17T23:31:39Z

[CB-13284] Slack js on cordova-docs fails to load due to insecure response

Changed location of slackin.js to https://slack-cordova-io.herokuapp.com
to match the TLS certificate




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #239: Enabling Appcache for the android we...

[andreszs]

Github user andreszs commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/239
  
Is this the same cache that caches all images as they are requested by the 
app? (not the images from an eventual webview control, I mean every single 
image downloaded and shown dynamically)

The current app cache has **no limit** and grows until the internal device 
memory has been depleted, which is renders the entire device unusable. Putting 
a limit to such cache would be a great idea.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #731: CB-13283 Fetching of download counts fails o...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/731


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #53: CB-12726: Device Motion - SUN...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device-motion/pull/53


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #732: CB-13284: Slackin.js on docs fails to load d...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/732


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-plugin-device-motion/pull/57
  
Merged this in, Added `info` tag. 

@maverickmishra can you close this issue?


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation pull request #36: CB-12728: Device Orienta...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device-orientation/pull/36


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation pull request #39: CB-13076: Updated README

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device-orientation/pull/39


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #488 for cordova has failed

[Apache Jenkins Server]

Nightly build #488 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/488/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/488/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...

[stevengill]

Github user stevengill commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r139333464
  
--- Diff: README.md ---
@@ -27,6 +27,18 @@ description: Access accelerometer data.
 
 # cordova-plugin-device-motion
 
+# Deprecation Notice
+
+With the [W3C Device Motion and Orientation 
API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) now
+being supported on iOS, Android and Windows devices, this plugin is not 
needed any more. Migrating from this
+plugin to the [W3C Device Motion and Orientation 
API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/)
+is explained in this [PhoneGap blog 
post](https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed).
--- End diff --

The plugins release blog post will talk about the deprecation. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #728: CB-13025 Remove use of React in plugins.cord...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/728


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #730: CB-13277: (docs) Improve README

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/730


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org