[GitHub] cordova-plugin-globalization pull request: Fix typo

2015-01-28 Thread Aljullu
GitHub user Aljullu opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/34 Fix typo You can merge this pull request into a Git repository by running: $ git pull https://github.com/Aljullu/cordova-plugin-globalization patch-1 Alternatively you

[GitHub] cordova-medic pull request: [INFRA-8588] Fixing build script bugs,...

2015-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file-transfer pull request: CB-5059 Add a CookieMan...

2015-01-28 Thread crissi
Github user crissi commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/60#issuecomment-71813597 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-android pull request: CB-4914 Fix build whitespace issue

2015-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: add try ... catch for getting ...

2015-01-28 Thread vilic
GitHub user vilic opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/63 add try ... catch for getting image orientation There's bug in Windows Phone 8.1 causing Seek on a DssPhotoStream not working properly.

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-01-28 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71878798 `cordova serve` is potentially usable by `cordova-android` or `cordova-ios` or `cordova-blackberry`, so, no, please don't just fork it or hand wave and pray that

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-01-28 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71878896 Specifically, it in theory allows one to live(-ish) edit an application instead of constantly republishing it to the device. --- If your project is set up for it,

[GitHub] cordova-plugin-file-transfer pull request: CB-5059 Add a CookieMan...

2015-01-28 Thread dpogue
Github user dpogue commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/60#issuecomment-71879606 @agrieve Thanks, updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

RE: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Murat Sutunc
I’ve ran the mobile-spec tests on android 4.0.3 with 4.0.x and there are some failures. I’ve searched the jira for issues but wasn’t able to find any. Has anyone else ran into these issues before? org.apache.cordova.contacts.tests.tests Contacts (navigator.contacts) Round trip Contact tests

Re: [Proposal] Publishing plugins to NPM top level package.json for cordova projects

2015-01-28 Thread Michal Mocny
Thanks for putting this together Steve! Gives us something concrete to debate ;) On Tue, Jan 27, 2015 at 7:17 PM, Steven Gill stevengil...@gmail.com wrote: Hey All, In preparation of the upcoming hangout this Thursday, here is my proposal on publishing plugins to npm (Phase 1) and adding a

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-01-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/155#issuecomment-71907847 Very cool Tim! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Andrew Grieve
On Wed, Jan 28, 2015 at 1:44 PM, Joe Bowser bows...@gmail.com wrote: On Wed Jan 28 2015 at 10:38:07 AM Andrew Grieve agri...@chromium.org wrote: - Make CordovaActivity not implement CordovaInterface, but instead provide CordovaInterface via an inner class (to solidify that you can't

iOS 8.1.3

2015-01-28 Thread Edna Y Morales
Apple recently released a minor update (iOS 8.1.3). No issues were found on Cordova. FYI Thanks, Edna Morales

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Steven Gill
I can do the tools release. Let's chat about it tomorrow at hangout. On Jan 28, 2015 12:33 PM, Andrew Grieve agri...@chromium.org wrote: On Wed, Jan 28, 2015 at 1:44 PM, Joe Bowser bows...@gmail.com wrote: On Wed Jan 28 2015 at 10:38:07 AM Andrew Grieve agri...@chromium.org wrote: -

[GitHub] cordova-coho pull request: CB-8375 Improve windows support for for...

2015-01-28 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-coho/pull/62 CB-8375 Improve windows support for for-each This improvement makes coho for-each work on Windows without issues. You can merge this pull request into a Git repository by running: $ git

Re: So...can we merge 4.0.x into master yet?

2015-01-28 Thread Andrew Grieve
Merged 4.0.x in. On Mon, Jan 26, 2015 at 2:27 PM, Joe Bowser bows...@gmail.com wrote: Well, I think we NEED to support third-party WebViews as a first step. If I don't hear any objections, I'm going to merge 4.0.x into master tomorrow, and start a discuss thread for the 4.0.x release. I

[GitHub] cordova-android pull request: CB-5059 Add a CookieManager abstract...

2015-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: cordova-android 4.0 JUnit tests

2015-01-28 Thread Andrew Grieve
I'd prefer to go the other way, and change AndroidWebView to composition. It's more flexible and does a better job of splitting up groups of APIs. On Wed, Jan 28, 2015 at 12:49 AM, Hu, Ningxin ningxin...@intel.com wrote: Hi Joe, The tests don't work with Crosswalk because Crosswalk's main

Re: Build signed archives using CLI

2015-01-28 Thread Victor Sosa
Hi Andrew. AFAICT, no one has done any work on this area, but I'd like to add this topic to the hangout agenda, start discussing this. I think Subhag has a very good design in the google doc in this thread. We can start from there and try to make this happen for a future release. Thoughts before

Re: Cordova plugin namespace

2015-01-28 Thread Andrew Grieve
I don't think the URL ever existed. XML namespace URLs don't need to actually exist IIRC. They are just identifiers. On Tue, Jan 27, 2015 at 6:07 PM, John M. Wargo j...@johnwargo.com wrote: Looking at the plugin guide at http://cordova.apache.org/ docs/en/4.0.0/plugin_ref_spec.md.html the

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-28 Thread Andrew Grieve
--webview=crosswalk sounds good. All it will do is add the plugin On Tue, Jan 27, 2015 at 4:09 PM, Murat Sutunc mura...@microsoft.com wrote: What exactly would this flag do underneath? I suppose it will add the crosswalk plugin and run it's tests. Am I missing anything else? On Jan 27,

RE: cordova-android 4.0 JUnit tests

2015-01-28 Thread Hu, Ningxin
Hi Joe, I have never seen an example of Crosswalk using Android XML layouts, and as far as I'm currently aware, embedding Crosswalk is less straightforward than embedding AndroidWebView or MozillaWebView. Is this what you are looking for?

Re: cordova-android 4.0 JUnit tests

2015-01-28 Thread Joe Bowser
That's part of it. What's the setup code for that look like? On Wed Jan 28 2015 at 7:15:10 PM Hu, Ningxin ningxin...@intel.com wrote: Hi Joe, I have never seen an example of Crosswalk using Android XML layouts, and as far as I'm currently aware, embedding Crosswalk is less

Browserify what's left proposal

2015-01-28 Thread Steven Gill
Sorry for sending this out so late. We can review it together during the hangout tomorrow. https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing

RE: Build signed archives using CLI

2015-01-28 Thread Chuck Lantz
Dan Levine whom some of you met at PhoneGap day actually has been working on a PR based on Subhag's proposal for discussion - he is out sick which is why he didn't respond to this thread. I'll let him speak to it once he's back but the good news is there is someone working on something in this

Re: Build signed archives using CLI

2015-01-28 Thread Victor Sosa
Yay!! Great news! Chuck, by any chance, do you have a link to the sandbox, or design doc or something worth to look at it? If no, we can wait until Dan is back (hope he feels better soon) I'm happy to help if needed. 2015-01-28 10:05 GMT-06:00 Chuck Lantz cla...@microsoft.com: Dan Levine whom

[GitHub] cordova-plugin-file-transfer pull request: CB-5059 Add a CookieMan...

2015-01-28 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/60#discussion_r23698327 --- Diff: src/android/FileTransfer.java --- @@ -316,7 +316,7 @@ public void run() {

Re: So...can we merge 4.0.x into master yet?

2015-01-28 Thread Joe Bowser
Cool. I'll start the discuss thread. On Wed Jan 28 2015 at 7:05:17 AM Andrew Grieve agri...@chromium.org wrote: Merged 4.0.x in. On Mon, Jan 26, 2015 at 2:27 PM, Joe Bowser bows...@gmail.com wrote: Well, I think we NEED to support third-party WebViews as a first step. If I don't hear

[DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Joe Bowser
Hey So, it's finally here. I want to see us work more on Pluggable Webviews, and adding the API, but I think it's time that we released what we've been working on for almost a year to our users. I know that the API isn't exactly the most awesome we can make it, but it works, and I'd rather have

[GitHub] cordova-blackberry pull request: CB-6418 Remove copyright statemen...

2015-01-28 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/181 CB-6418 Remove copyright statements You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-blackberry cb_6418 Alternatively

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Josh Bavari
Joe and team, I work for Ionic and I've had some involvement with the Cordova project since last year. At Ionic, we've released a Crosswalk build using Cordova Android 4.0 so we can use the cordova crosswalk engine for the ionic platform. I've been working with Ian and Andrew on this to gather

[GitHub] cordova-blackberry pull request: CB-6418 Remove copyright statemen...

2015-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Build signed archives using CLI

2015-01-28 Thread Andrew Grieve
Sounds good, let's wait until Dan is back to discuss. The main point I'd like to cover is whether it'd be good to have layer of indirection between cordova and the platform-specific files that dictate signing info. E.g.: Instead of using ant.properties / gradle.properties / build.xcconfig, have:

Re: Build signed archives using CLI

2015-01-28 Thread Darryl Pogue
One issue we've run into on iOS is that the xcconfig specifies iPhone Developer by default, and for release builds that needs to be iPhone Distribution. We ended up using a before_compile JS hook to check if we're building with --release and modify the xcconfig:

RE: Build signed archives using CLI

2015-01-28 Thread Chuck Lantz
Yeah personally I am thinking that - particularly if we treat platforms as dependencies in package.json as proposed - we'll need some facility to set native build settings. We may be able to come up with some sort of abstraction for this part, but I'm kind of thinking we'll ultimately want a

Re: cordova-android 4.0 JUnit tests

2015-01-28 Thread Andrew Grieve
I think we're talking about the same thing. You can have an XWalkCordovaView within a layout, and then attach a XWalkCordovaWebView to it in code afterwards. What might be even better though, is if we made CordovaWebView extend View (probably AbsoluteLayout), and then you wouldn't have to change

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Joe Bowser
On Wed Jan 28 2015 at 10:38:07 AM Andrew Grieve agri...@chromium.org wrote: - Make CordovaActivity not implement CordovaInterface, but instead provide CordovaInterface via an inner class (to solidify that you can't cast the activity to CordovaInterface and expect that to work - some used to

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Joe Bowser
Reminder: failures with plugins are not blockers. I've run into that contact issue numerous times when testing with my personal device. I recommend making sure that your contacts are completely clean so that you don't get these weird results. The file failures have been happening for quite a

Re: cordova-android 4.0 JUnit tests

2015-01-28 Thread Andrew Grieve
You can still embed a view using composition. We are not providing any backwards compatibility right now, even with inheritance, because CordovaWebView is no longer a View (it's an interface, which requires an explicit cast to (View), or a call to .getView() to be considered as a View) On Wed,

Re: cordova-android 4.0 JUnit tests

2015-01-28 Thread Joe Bowser
What is your definition of embedding a view? I think we're talking about two different things. What I'm talking about is being able to embed AndroidWebView as an embedded view without having to change any code other than the name of the class. This means that you don't have to worry about the

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Andrew Grieve
Things i think we should still wait for: - Ian's been working on getting crosswalk 10 working and is hitting some FileTransfer crash issues. - Mobilespec really should be passing, let's investigate and fix plugins / tests if they are the issues. - Android's update script is not preserving

RE: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Murat Sutunc
Just give some data point, running mobile spec I'm getting: - 11 failures in 4.4.2 - 6 failures in 4.0.4 Ideally we should bring those numbers to 0 to ensure a stable release. -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, January 28, 2015 10:45 AM To:

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-01-28 Thread kirkshoop
Github user kirkshoop commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71892622 no prayer was involved. As I said, if there are good scenarios for `cordova serve` then it should continue to exist. You have explained that it should

Re: cordova-android 4.0 JUnit tests

2015-01-28 Thread Joe Bowser
On Wed Jan 28 2015 at 10:42:46 AM Andrew Grieve agri...@chromium.org wrote: I think we're talking about the same thing. You can have an XWalkCordovaView within a layout, and then attach a XWalkCordovaWebView to it in code afterwards. What might be even better though, is if we made

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Joe Bowser
I can't remember a single release that had zero failures in mobile-spec, so I don't know why we are so intent on doing this now. On Wed Jan 28 2015 at 10:50:54 AM Murat Sutunc mura...@microsoft.com wrote: Just give some data point, running mobile spec I'm getting: - 11 failures in 4.4.2 - 6

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-01-28 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/155 CB-8123 Plugin references can target specific windows platforms. Adds support for `target`, `versions` and `arch` attributes on `lib-file` and `framework` elements in the windows platform of

[GitHub] cordova-docs pull request: CB-8123 Plugin references can target sp...

2015-01-28 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-docs/pull/263 CB-8123 Plugin references can target specific windows platforms. Adds documentation for the new `target`, `versions` and `arch` attributes on `lib-file` and `framework` elements in the