[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...

2015-05-05 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82 CB-8951 Fixed crash related to headers parsing on wp8 This is a quick temporary fix for https://issues.apache.org/jira/browse/CB-8951 Without it, mobilespec app crashes.

[GitHub] cordova-android pull request: CB-8902: use immersive mode when ava...

2015-05-05 Thread pwnall
Github user pwnall commented on the pull request: https://github.com/apache/cordova-android/pull/175#issuecomment-99301712 I look forward to using this! :heart: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [GitHub] cordova-js pull request: CB-8674: Creates a 'cordova.env' object.....

2015-05-05 Thread Jesse
Looking. On May 5, 2015, at 6:12 PM, nikhilkh g...@git.apache.org wrote: Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-js/pull/108#issuecomment-99280031 LGTM. @purplecabbage - Thoughts? --- If your project is set up for it, you can

Re: Cordova 5.0.0 duplicate cordova check breaks Ripple

2015-05-05 Thread Jesse
This fix has been merged ( your way Tim ) Steve, can we do a minor bump of all platforms that included cordova-js 3.8.2 ? This will be a 3.9.2 cordova-js release I think, and appropriately enough has a ripple effect into platforms and tools. @purplecabbage risingj.com On Mon, May 4, 2015 at 7:30

[GitHub] cordova-js pull request: CB-8674: Creates a 'cordova.env' object.....

2015-05-05 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-js/pull/108#issuecomment-99280031 LGTM. @purplecabbage - Thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-js pull request: check the window.cordova object a little ...

2015-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/109 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: before you go! (Andrew Michal)

2015-05-05 Thread Michal Mocny
I wouldn't expect to be able to convert existing hardware beacons to this new format. However, you can literally create your own beacon by running a node script on a BT capable laptop: https://github.com/google/uribeacon/tree/master/beacons/nodejs -- Fun fact: Don Coleman contributed this, small

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

2015-05-05 Thread sinofool
Github user sinofool commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-99256131 There is a minor difference with pull request in cordova-ios. The original OverrideUserAgent will also ignore AppendUserAgent configuration.

[GitHub] cordova-windows pull request: CB-8946: Added the WindowsToastCapa...

2015-05-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/74#issuecomment-99278002 Okay, we can merge this. I will file an issue to fix plugman also. I would much rather if we could just go: ```config-file

[GitHub] cordova-windows pull request: CB-8486 Support for signing and buil...

2015-05-05 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-windows/pull/75 CB-8486 Support for signing and build.json for Windows Related JIRA item: https://issues.apache.org/jira/browse/CB-8483 Details of the design and scenario here:

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: Remove hardcoded reference to registry.n...

2015-05-05 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/211#issuecomment-99094530 Thanks Matt! JIRA for this: https://issues.apache.org/jira/browse/CB-8956 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-8757 - Resolve symlinks in order to a...

2015-05-05 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/212#discussion_r29671237 --- Diff: cordova-lib/src/plugman/plugman.js --- @@ -89,9 +90,12 @@ plugman.commands = { plugman.owner(cli_opts.argv.remain); },

Re: Also moving to a new team

2015-05-05 Thread Shazron
Awesome - Good luck Andrew! It's a good thing that we have Cordova people embedded in other groups within Google, so perhaps we can eventually reach our goal of not needing Cordova in Android... (Or at least make it easier) On Tuesday, May 5, 2015, Andrew Grieve agri...@chromium.org wrote: As

cordova-plugin-background-app

2015-05-05 Thread Andrew Grieve
Wanted to draw attention to a new plugin we've created for allowing Android apps to behave as a service on Android (without actually being a service!) https://github.com/MobileChromeApps/cordova-plugin-background-app We use it as part of our chrome.gcm, chrome.notifications, and chrome.alarms

Re: Also moving to a new team

2015-05-05 Thread Gorkem Ercan
Best of luck on your new project. -- Gorkem On 5 May 2015, at 11:15, Andrew Grieve wrote: As with Michal, you'll be seeing less of me around. My new full-time project will be on the Android port of Chrome. Just want to make it clear that us moving to new teams has nothing to do with a lack

[GitHub] cordova-lib pull request: CB-8757 - Resolve symlinks in order to a...

2015-05-05 Thread mbektchiev
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/212#issuecomment-99119782 @agrieve I moved the fixes to `install.js` and `uninstall.js`. Do you think it's OK now? --- If your project is set up for it, you can reply to this email and

Re: cordova-osx - mothball

2015-05-05 Thread Shazron
Great! This is encouraging. I'll help expedite this as much as I can for it to catch up, I'll look at any PRs and review and merge. On Tuesday, May 5, 2015, Ondrej Florian oflor...@adobe.com wrote: If there is any interest, I would volunteer to pick it up. The Cordova-osx has its uses (I use

Re: Would like to submit PR, unable to figure out JIRA

2015-05-05 Thread Andrew Grieve
Thanks Matt! Not sure what's going on with JIRA, but I created an issue for it: https://issues.apache.org/jira/browse/CB-8956 ICLA's are required only for big changes (though still a nice thing to have on file). I'll go ahead and merge. On Mon, May 4, 2015 at 6:50 PM, Matt Steele

[GitHub] cordova-lib pull request: Remove hardcoded reference to registry.n...

2015-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Also moving to a new team

2015-05-05 Thread Andrew Grieve
As with Michal, you'll be seeing less of me around. My new full-time project will be on the Android port of Chrome. Just want to make it clear that us moving to new teams has nothing to do with a lack of faith in the project, but rather is due to needing a change of scenery and exciting new

Re: cordova-osx - mothball

2015-05-05 Thread Ondrej Florian
If there is any interest, I would volunteer to pick it up. The Cordova-osx has its uses (I use it myself). One advantage over the Atom Electron is the plugins. Many non-UI iOS plugins will works with it out of the box. Another is that it's just another Cordova platform so you don't have to work

[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...

2015-05-05 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82#issuecomment-99157052 Please make a JIRA or some other task to track the proper fix so we don't forget to do it. --- If your project is set up for it, you can reply to

Re: Also moving to a new team

2015-05-05 Thread Jesse
Congrats Andrew! Best of luck in your new role, don't be a stranger. Cheers, Jesse @purplecabbage risingj.com On Tue, May 5, 2015 at 10:28 AM, Michael Brooks mich...@michaelbrooks.ca wrote: Congrats Andrew and best of luck on the new project! On Tue, May 5, 2015 at 9:35 AM, Nikhil

[GitHub] cordova-windows pull request: CB-8946: Added the WindowsToastCapa...

2015-05-05 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/74#issuecomment-99160167 The plugin is likely unable to do this directly except via hooks, because the `config-file` directive is an element-level change, but the modification is at an

[GitHub] cordova-lib pull request: CB-8757 - Resolve symlinks in order to a...

2015-05-05 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/212#discussion_r29683101 --- Diff: cordova-lib/src/plugman/plugman.js --- @@ -228,3 +228,4 @@ plugman.commands = { }; module.exports = plugman; + --- End

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99137602 Today. On May 5, 2015, at 9:17 AM, Nikhil Khandelwal notificati...@github.com wrote: @purplecabbage - When do you plan to merge

[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...

2015-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: cordova-plugin-background-app

2015-05-05 Thread Raymond Camden
Do you have an example appl? On Tue, May 5, 2015 at 10:20 AM, Andrew Grieve agri...@chromium.org wrote: Wanted to draw attention to a new plugin we've created for allowing Android apps to behave as a service on Android (without actually being a service!)

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-05 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99129350 @purplecabbage - When do you plan to merge this. There is another related issue now causing WP8 mobilespec tests to crash because this has not been fixed within the

[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...

2015-05-05 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99142847 Once apache/cordova-wp8#79 is included (and released) then we can include this one. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-05-05 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-99129950 We need this one to be fixed soon - Personally, I prefer @vladimir-kotikov incremental fix than a major version bump for WP8 platform with

RE: Also moving to a new team

2015-05-05 Thread Murat Sutunc
Best of luck on your new team Andrew! It's been a pleasure working with you. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, May 5, 2015 8:16 AM To: dev Subject: Also moving to a new team As with Michal, you'll be seeing

RE: Also moving to a new team

2015-05-05 Thread Nikhil Khandelwal
All the best, Andrew! Thanks for being so responsive and taking a look at so many of my PRs! Thanks, Nikhil -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Tuesday, May 5, 2015 9:26 AM To: dev@cordova.apache.org Subject: RE: Also moving to a new team Best

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-05 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99134840 apache/cordova-plugin-file-transfer#82 apache/cordova-plugin-file-transfer#82 is a quick fix that could have been included already. Looking through the

Re: Also moving to a new team

2015-05-05 Thread Michael Brooks
Congrats Andrew and best of luck on the new project! On Tue, May 5, 2015 at 9:35 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: All the best, Andrew! Thanks for being so responsive and taking a look at so many of my PRs! Thanks, Nikhil -Original Message- From: Murat Sutunc

[GitHub] cordova-windows pull request: CB-8946: Added the WindowsToastCapa...

2015-05-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/74#issuecomment-99159134 This should be done by the Local Notification plugin itself shouldn't it? -1 --- If your project is set up for it, you can reply to this email and have

Shorter URI for ci.ordova.io

2015-05-05 Thread Dmitry Blotsky
Hi Michael, We've added some goodies in Buildbot so our ci.cordova.io URI can be shorter. We can now have it point to http://ci.apache.org/waterfall?category=cordova. Whenever it is convenient for you, please feel free to make the change. Many thanks! Kindly, Dmitry

RE: Also moving to a new team

2015-05-05 Thread Ryan J. Salva
Thanks for all you've done for the project, Andrew and Michal. I'm sure we'll cross paths again sometime soon. In the meantime, I can't wait to see what you create with the Physical Web. It looks like a super-cool project. I only expect great things :-) rjs Ryan J. Salva  |  Principal Program

Re: Plugins release prep: Cherry-picking plugin updates

2015-05-05 Thread Steven Gill
Hey guys, I can help you out. The process is designed for all plugins but it is pretty easy to do it for just a few. I've done it many times. If changes are on master, they shouldn't be incomplete. Any known problem with release the master branch of those plugins? We could cherry-pick, but it

[GitHub] cordova-coho pull request: Add github URL for pull requests to `li...

2015-05-05 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-coho/pull/75 Add github URL for pull requests to `list-pulls` command You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-coho pull_url

Re: Also moving to a new team

2015-05-05 Thread Steven Gill
Andrew, it has been a pleasure to work with you these last few years! Good luck on your new team!! On Tue, May 5, 2015 at 11:11 AM, Ryan J. Salva rsa...@microsoft.com wrote: Thanks for all you've done for the project, Andrew and Michal. I'm sure we'll cross paths again sometime soon. In the

[GitHub] cordova-lib pull request: CB-8757 - Resolve symlinks in order to a...

2015-05-05 Thread mbektchiev
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/212#issuecomment-99200674 Done. I hadn't noticed the failing test, because it's failing only on Mac, but I hadn't run the tests on a Mac. :four_leaf_clover: --- If your project is set

Re: Plugins release prep: Cherry-picking plugin updates

2015-05-05 Thread Jesse
+ file-transfer so we can resolve CB-8951 @purplecabbage risingj.com On Tue, May 5, 2015 at 12:19 PM, Steven Gill stevengil...@gmail.com wrote: Hey guys, I can help you out. The process is designed for all plugins but it is pretty easy to do it for just a few. I've done it many times. If

[GitHub] cordova-ios pull request: [CB-8948] Clipboard fix for iOS safari c...

2015-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: Proposal: Expose check_reqs at the CLI level

2015-05-05 Thread Vladimir Kotikov (Akvelon)
Hey, guys. Leo and Josh's feedback is addressed and since there is no more issues, I'm going to merge these changes tomorrow. If there is still any notes/questions, please let me know. --- Best regards, Vladimir -Original Message- From: Vladimir Kotikov (Akvelon)

[GitHub] cordova-plugman pull request: CB-8757 - Resolve any symlinks in or...

2015-05-05 Thread mbektchiev
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-plugman/pull/83#issuecomment-99005935 You're right. I have opened a [new PR](https://github.com/apache/cordova-lib/pull/212) which should be better. --- If your project is set up for it, you can

[GitHub] cordova-plugman pull request: CB-8757 - Resolve any symlinks in or...

2015-05-05 Thread mbektchiev
Github user mbektchiev closed the pull request at: https://github.com/apache/cordova-plugman/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: [CB-8948] Clipboard fix for iOS safari c...

2015-05-05 Thread markharding
Github user markharding commented on the pull request: https://github.com/apache/cordova-ios/pull/139#issuecomment-98989257 Checkout http://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/. It's actually a safari bug but this patch does get around the issue. --- If your project

[GitHub] cordova-lib pull request: CB-8757 - Resolve symlinks in order to a...

2015-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: [CB-8785] add try/catch for evalJS:

2015-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: CB-3360 Set custom User-Agent

2015-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: cordova-lib change -- if you develop with the latest

2015-05-05 Thread Steven Gill
Thanks for the heads up! On Tue, May 5, 2015 at 1:26 PM, Shazron shaz...@gmail.com wrote: Intent to pull in: https://github.com/apache/cordova-lib/pull/209 If you use the local version in your environment, do an npm install again

[GitHub] cordova-windows pull request: CB-8946: Added the WindowsToastCapa...

2015-05-05 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-windows/pull/74 CB-8946: Added the WindowsToastCapable preference Added the WindowsToastCapable preference to indicate that the app can support toasts. This is to support the Local Notifications

RE: Also moving to a new team

2015-05-05 Thread Dmitry Blotsky
Congrats on the move! Wish you all the best on the new team. -Original Message- From: mikeywbro...@gmail.com [mailto:mikeywbro...@gmail.com] On Behalf Of Michael Brooks Sent: Tuesday, May 5, 2015 10:29 AM To: dev@cordova.apache.org Subject: Re: Also moving to a new team Congrats Andrew

RE: FYI - Moving to new team, seeing me less around here

2015-05-05 Thread Dmitry Blotsky
Congrats on the move! The Physical Web looks like a really exciting initiative. :D -Original Message- From: Andrey Kurdumov [mailto:kant2...@googlemail.com] Sent: Monday, May 4, 2015 7:40 PM To: dev@cordova.apache.org Subject: Re: FYI - Moving to new team, seeing me less around here

Plugins release prep: Cherry-picking plugin updates

2015-05-05 Thread Rob Paveza
Hi all - I started a [discuss] thread about plugin updates last week, effectively saying that we wanted to take four JIRA items which are causing problems for Windows 10: CB-8926, CB-8928, CB-8930, and CB-8943. Since Murat is a committer, he's actually trying to do the release. We're

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-05-05 Thread delijati
Github user delijati commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-99019365 Need this feature too. The old way in `onCreate` is not working anymore. ``` super.appView.getSettings().setUserAgentString(Your own agent string);

Re: [Vote] 3.7.0 FirefoxOS Release

2015-05-05 Thread Shazron
Has this vote failed? On Wed, Apr 1, 2015 at 11:50 AM, Steven Gill stevengil...@gmail.com wrote: Bump. I also noticed https://issues.apache.org/jira/browse/CB-4548 got resolved. Having cordova run support is great! Not sure of mozilla folk want me to add that into the release and do a revote.

Re: [Vote] 3.7.0 FirefoxOS Release

2015-05-05 Thread Steven Gill
Yup. This vote has failed. Once we get some more people interested in doing a release for this we can try again. On May 5, 2015 2:44 PM, Shazron shaz...@gmail.com wrote: Has this vote failed? On Wed, Apr 1, 2015 at 11:50 AM, Steven Gill stevengil...@gmail.com wrote: Bump. I also noticed

Re: before you go! (Andrew Michal)

2015-05-05 Thread Lisa Seacat DeLuca
I'd also like to clime in that I've been put on another project that still uses Cordova but I'm not part of our open source team anymore. So I've been following what has been going on with Cordova but haven't been as active as I'd like to be. Michal~ you gave me a good distraction reading up