[GitHub] cordova-lib pull request: CB-9225 Adds plugman support for the Win...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/251#issuecomment-114177934 Mefire - in response to your first question, yeah - `plugman` provides some tools to get started building your plugin - creates the initial structure and `plugin.xml`, and adds a basic bits when you add a platform. In response to your second question - the `windows` platform is the preferred way to build Windows mobile apps using Cordova. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Experimenting with API for cordova tooling
The PRs had been closed, because we've decided to revisit API to make it more solid, before it can be moved to master. The proposal has been moved to cordova-discuss repo, to be easier to review/comment. Link to proposal: https://github.com/cordova/cordova-discuss/pull/9 --- Best regards, Vladimir -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Thursday, 4 June, 2015 22:30 To: dev@cordova.apache.org Subject: RE: Experimenting with API for cordova tooling Hello again :) I wanted to bring your attention to this thread again. I've opened a new PR updated according to Mark's feedback and will be very grateful if someone can review this again before merging. There is also the implementation for Android platform which uses this new API provides own implementation for all PlatformAPI methods. Links to PRs: https://github.com/apache/cordova-lib/pull/235 https://github.com/apache/cordova-android/pull/179 --- Best regards, Vladimir -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Monday, May 25, 2015 7:31 PM To: dev@cordova.apache.org Subject: RE: Experimenting with API for cordova tooling Hey, guys. I would like to raise this thread again. I've done implementing a draft for Platform API interface, integrated directly into cordova-lib, that allows to use platform functionality as a node modules. The PRs for this is: Cordova-lib: https://github.com/apache/cordova-lib/pull/226 Cordova-windows (sample platform's implementation): https://github.com/apache/cordova-windows/pull/84 Here is brief details of implementation: There is PlatformApi (former PlatformProject) class -- acts as entry point for platform-related functionality. It exposes: a) methods that represent platform's actions, like 'build', 'run', etc. Base implementations of these methods acts as a wrappers around platform executable scripts, but each platform can provide its own implementation by defining Api.js module with same prototype methods, which will override methods of base implementation. Current draft contains wrappers for `build` and `requirements` commands. b) PlatformHandler instance, accessible via both `getPlatformHandler()` method and `parser` property (left for backward compatibility). The PlatformHandler class is intended to be a container for platform-specific implementations for `prepare` logic. The approach here is the same as with PlatformApi class - the platform can override default implementation (currently it's being taken from cordova\metadata\platform_parser.js file) with custom one through providing own PlatformApi.PlatformHandler class. c) PluginHandler instance - for plugin manipulation related functionality. Approach is the same as for PlatformHandler. Since this implementation provides a fallback alternatives for all new functionality, it will allow to us to seamlessly move all platform-related functionality to platforms. IMO this could be done in three steps: 1. Copy platform actions (build, run, etc. ) to platforms. (See windows PR for sample - https://github.com/MSOpenTech/cordova-windows/blob/unified_platform_api/template/cordova/Api.js ) 2. Copy `prepare`- and plugin-related logic to platforms, leave existing code for compatibility with old platforms. 3. Completely remove platform-related functionality from lib. This will break compatibility with old platforms, so we'll need to wait for some time before doing this. Would love to hear any feedback and thoughts on this. --- Best regards, Vladimir -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Saturday, 25 April, 2015 6:14 To: dev@cordova.apache.org Subject: Re: Experimenting with API for cordova tooling I like the idea of cordova-discuss, lets give it a try ) To read the md file formatted: https://github.com/kamrik/cordova-discuss/blob/master/proposals/PlatformProject.md To comment, look at the pull request https://github.com/cordova/cordova-discuss/pull/4 On Fri, Apr 24, 2015 at 10:16 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Should we move this docs to cordova-discuss instead -https://github.com/cordova/cordova-discuss ? On 4/24/15, 4:02 PM, Mark Koudritsky kam...@google.com wrote: I'm back from ApacheCon and vacation. Very glad to see some enthusiasm about this! My thoughts about the next steps turned out to be rather lengthy so here is a doc: https://docs.google.com/document/d/1jxQvygBtTeCYhxMtHLD9jgKTKZofMJdux1 UIzs dd5b0 The most important next steps are: - Take one platform and try combine the logic from cordova/metadata and plugman/platforms for it. This will help figure out some details. - Improve plugin (un)install logic in PlatformProject so that the CLI can be eventually implemented in terms of PlatformProject. Comments and discussion will be greatly appreciated!
Re: Cordova issue.
+ dev@ mailing list
There have been (fixed) bugs with the online bridge in the past. Are you
running a recent version of cordova-android?
https://issues.apache.org/jira/browse/CB-6761
https://issues.apache.org/jira/browse/CB-6746
As a quick fix, you can switch to use the PROMPT-based bridge.
On Sun, Jun 21, 2015 at 6:31 PM, David Hadas david.ha...@gmail.com wrote:
Hi agrieve,
While hunting what initialy appeared to be a file plugin bug on a an S3
Neo android 4.3 device, we had learned that OnlineEventsBridgeMode seem to
be broken on that device. We noticed that from a certain point in time,
the boolean *online* was always set to false during toggleNetworkRunnable
{ ...webView.setNetworkAvailable(*online*) } - hence *online* was no
longer toggled via notifyOfFlush - consequently there were no more
webView *online *events sent out to the JS. From that moment events from
JAVA to JS were delivered only when someone from the JS was
calling androidExec (cordova.js) and we were always missing the last set of
events as there were stuck down at the JAVA queue.
We realized that the OnlineEventsBridgeMode depends on the boolean
*online* always being maintained as an inverse of the WebView
online-state. Once it is reversed for any reason/bug, the system never
corrects itself.
Till now we were unable to track down the exact sequance leading to the
reversal event, but we do notice a sequance of two consecutive calls to
notifyOfFlush,
flipping *online* twice - thereafter *online* is left unchanged (stuck on
teh wrong value).
In fact we are somewhat uncomfirtable with the design choice of using
online toggling and blindly trying to keep the *online* variable as an
inverse of the WebView state. Our main conccern there is that this design
does not converge to a stable state and does not follow a KISS methodology
which may be painful in view of the asynchnous environment, dependency on
different WebView implementations etc, as a result implementation issues
and bugs such as the one we encuntered are more likely. We are wondering
about a simpler design choice of replacing:
webView.setNetworkAvailable(*online*);
with:
webView.setNetworkAvailable(*true*); // trigger an event
webView.setNetworkAvailable(*false*); // reset the webView to its
default state
thereafter removing redundent code such as the notifyOfFlush mechanism
which would no longer be needed, the JS event listener for offline etc.
This apperently solved the problem with that S3 NEO android 4.3 - but may
be a better strategy to follow alltogether.
If so, we might be able to take the challange and suggest a patch or
better so, work with an existing contributer to create one.
Please advise,
David Hadas
Re: [VOTE] Plugins Release June 17th, 2015
ONE MOREEE On Sun, Jun 21, 2015 at 11:30 PM, Vladimir Kotikov (Akvelon) v-vlk...@microsoft.com wrote: I vote +1: * Verified signatures and hashes * Verified tags * Verified that plugins can added correctly to blank app * Verified that blank app can be successfully ran and built * Ran smoke testing of mobilespec app * Verified Release Notes --- Best regards, Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Saturday, 20 June, 2015 1:41 To: dev@cordova.apache.org Subject: Re: [VOTE] Plugins Release June 17th, 2015 Bump! On Wed, Jun 17, 2015 at 6:06 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9192 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/ The packages were published from their corresponding git tags: cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66) cordova-plugin-camera: 1.2.0 (437cf3d93a) cordova-plugin-console: 1.0.1 (f055daec45) cordova-plugin-contacts: 1.1.0 (e47559b0d4) cordova-plugin-device: 1.0.1 (b3da8484ec) cordova-plugin-device-motion: 1.1.1 (28394c4607) cordova-plugin-device-orientation: 1.0.1 (427d49f612) cordova-plugin-dialogs: 1.1.1 (b698f3a7b5) cordova-plugin-file: 2.1.0 (6276d06d7a) cordova-plugin-file-transfer: 1.2.0 (b01ab78fec) cordova-plugin-geolocation: 1.0.1 (e529db6abd) cordova-plugin-globalization: 1.0.1 (cd9d52355a) cordova-plugin-inappbrowser: 1.0.1 (47e332fc92) cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab) cordova-plugin-media: 1.0.1 (b3056343fc) cordova-plugin-media-capture: 1.0.1 (9af90d8540) cordova-plugin-network-information: 1.0.1 (d8bdb0e953) cordova-plugin-splashscreen: 2.1.0 (4b1df233ae) cordova-plugin-statusbar: 1.0.1 (5e96b2a345) cordova-plugin-test-framework: 1.0.1 (0167a2f9ab) cordova-plugin-vibration: 1.2.0 (274003cb33) cordova-plugin-whitelist: 1.1.0 (521e62b0fd) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting .md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built and ran mobilespec on android and ios - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova plugin Errors
They seem like warnings, not errors, does the app work? 2015-06-22 11:24 GMT+02:00 SiShop ST sishop@gmail.com: Hi With latest version of cordova for iOS build there are errors in plugin cordova-plugin-statusbar and cordova-plugin-media-capture /Users/sishopsnt/Projekti/quicka/platforms/ios/QuickA/Plugins/cordova-plugin-statusbar/CDVStatusBar.m:182:40: warning: implicit conversion from enumeration type 'UIInterfaceOrientation' (aka 'enum UIInterfaceOrientation') to different enumeration type 'UIDeviceOrientation' (aka 'enum UIDeviceOrientation') [-Wenum-conversion] if (UIDeviceOrientationIsLandscape(orientation) (rect.size.width ... ~~ ^~~ /Users/sishopsnt/Projekti/quicka/platforms/ios/QuickA/Plugins/cordova-plugin-statusbar/CDVStatusBar.m:204:44: warning: implicit conversion from enumeration type 'UIInterfaceOrientation' (aka 'enum UIInterfaceOrientation') to different enumeration type 'UIDeviceOrientation' (aka 'enum UIDeviceOrientation') [-Wenum-conversion] ...(UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation... ~~ ^~~~ /Users/sishopsnt/Projekti/quicka/platforms/ios/QuickA/Plugins/cordova-plugin-statusbar/CDVStatusBar.m:373:52: warning: implicit conversion from enumeration type 'UIInterfaceOrientation' (aka 'enum UIInterfaceOrientation') to different enumeration type 'UIDeviceOrientation' (aka 'enum UIDeviceOrientation') [-Wenum-conversion] ...(UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation... ~~ ^~~~ 3 warnings generated. cordova-plugin-media-capture /Users/sishopsnt/Projekti/quicka/platforms/ios/QuickA/Plugins/cordova-plugin-media-capture/CDVCapture.m:819:60: warning: comparison of address of 'UIAccessibilityAnnouncementNotification' not equal to a null pointer is always true [-Wtautological-pointer-compare] ...= (UIAccessibilityAnnouncementNotification != NULL); ^~~ 1 warning generated.
Cordova plugin Errors
Hi With latest version of cordova for iOS build there are errors in plugin cordova-plugin-statusbar and cordova-plugin-media-capture /Users/sishopsnt/Projekti/quicka/platforms/ios/QuickA/Plugins/cordova-plugin-statusbar/CDVStatusBar.m:182:40: warning: implicit conversion from enumeration type 'UIInterfaceOrientation' (aka 'enum UIInterfaceOrientation') to different enumeration type 'UIDeviceOrientation' (aka 'enum UIDeviceOrientation') [-Wenum-conversion] if (UIDeviceOrientationIsLandscape(orientation) (rect.size.width ... ~~ ^~~ /Users/sishopsnt/Projekti/quicka/platforms/ios/QuickA/Plugins/cordova-plugin-statusbar/CDVStatusBar.m:204:44: warning: implicit conversion from enumeration type 'UIInterfaceOrientation' (aka 'enum UIInterfaceOrientation') to different enumeration type 'UIDeviceOrientation' (aka 'enum UIDeviceOrientation') [-Wenum-conversion] ...(UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation... ~~ ^~~~ /Users/sishopsnt/Projekti/quicka/platforms/ios/QuickA/Plugins/cordova-plugin-statusbar/CDVStatusBar.m:373:52: warning: implicit conversion from enumeration type 'UIInterfaceOrientation' (aka 'enum UIInterfaceOrientation') to different enumeration type 'UIDeviceOrientation' (aka 'enum UIDeviceOrientation') [-Wenum-conversion] ...(UIDeviceOrientationIsLandscape(self.viewController.interfaceOrientation... ~~ ^~~~ 3 warnings generated. cordova-plugin-media-capture /Users/sishopsnt/Projekti/quicka/platforms/ios/QuickA/Plugins/cordova-plugin-media-capture/CDVCapture.m:819:60: warning: comparison of address of 'UIAccessibilityAnnouncementNotification' not equal to a null pointer is always true [-Wtautological-pointer-compare] ...= (UIAccessibilityAnnouncementNotification != NULL); ^~~ 1 warning generated.
Re: [VOTE] Plugins Release June 17th, 2015
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Vladimir Kotikov Shazron Abdullah The vote has passed. I will publish to dist, npm and get the blog post up. On Mon, Jun 22, 2015 at 2:30 PM, Shazron shaz...@gmail.com wrote: +1 On Mon, Jun 22, 2015 at 2:28 PM, Steven Gill stevengil...@gmail.com wrote: ONE MOREEE On Sun, Jun 21, 2015 at 11:30 PM, Vladimir Kotikov (Akvelon) v-vlk...@microsoft.com wrote: I vote +1: * Verified signatures and hashes * Verified tags * Verified that plugins can added correctly to blank app * Verified that blank app can be successfully ran and built * Ran smoke testing of mobilespec app * Verified Release Notes --- Best regards, Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Saturday, 20 June, 2015 1:41 To: dev@cordova.apache.org Subject: Re: [VOTE] Plugins Release June 17th, 2015 Bump! On Wed, Jun 17, 2015 at 6:06 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9192 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/ The packages were published from their corresponding git tags: cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66) cordova-plugin-camera: 1.2.0 (437cf3d93a) cordova-plugin-console: 1.0.1 (f055daec45) cordova-plugin-contacts: 1.1.0 (e47559b0d4) cordova-plugin-device: 1.0.1 (b3da8484ec) cordova-plugin-device-motion: 1.1.1 (28394c4607) cordova-plugin-device-orientation: 1.0.1 (427d49f612) cordova-plugin-dialogs: 1.1.1 (b698f3a7b5) cordova-plugin-file: 2.1.0 (6276d06d7a) cordova-plugin-file-transfer: 1.2.0 (b01ab78fec) cordova-plugin-geolocation: 1.0.1 (e529db6abd) cordova-plugin-globalization: 1.0.1 (cd9d52355a) cordova-plugin-inappbrowser: 1.0.1 (47e332fc92) cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab) cordova-plugin-media: 1.0.1 (b3056343fc) cordova-plugin-media-capture: 1.0.1 (9af90d8540) cordova-plugin-network-information: 1.0.1 (d8bdb0e953) cordova-plugin-splashscreen: 2.1.0 (4b1df233ae) cordova-plugin-statusbar: 1.0.1 (5e96b2a345) cordova-plugin-test-framework: 1.0.1 (0167a2f9ab) cordova-plugin-vibration: 1.2.0 (274003cb33) cordova-plugin-whitelist: 1.1.0 (521e62b0fd) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting .md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built and ran mobilespec on android and ios - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: iframe history.back() issues in Cordova app (iOS)
This is the list for cordova developers, not for cordova-end developers. I wrote you a first comment on stackoverflow. Joerg Am 23.06.2015 um 00:49 schrieb Nomamoto, Satoshi s.nomam...@jp.fujitsu.com: Hi guys I am developing the application of Android and iOS by using Cordova. Page structure is as follows. Page A (w/o iframe) Page B (w/ iframe) Transitions Page A -- Page B (forward) Page A -- Page B (backward by history.back()) iframe displays external web page. When it goes back to Page A(w/o iframe) from Page B(w/ iframe), i have to call hisotory.back() twice. However, Android app build by same javascript source only has to call history.back() once. In addition, a similar problem does not occur when native WebVIew(UIWebView) of iOS is used. Is this a Cordova(iOS) spec or bug? Versions Cordova 4.2 (iOS Platform 3.8.0) iOS 8.3 Same question on StackOverflow http://stackoverflow.com/questions/30973368/iframe-history-back-issues-in-cordova-app-ios Best regards, Satoshi NOMAMOTO - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org Jörg Holz | +49-175-640 35 80 h...@hamburg.de NEU: doreport - die Reportingsoftware: http://www.doreport.de - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
iframe history.back() issues in Cordova app (iOS)
Hi guys I am developing the application of Android and iOS by using Cordova. Page structure is as follows. Page A (w/o iframe) Page B (w/ iframe) Transitions Page A -- Page B (forward) Page A -- Page B (backward by history.back()) iframe displays external web page. When it goes back to Page A(w/o iframe) from Page B(w/ iframe), i have to call hisotory.back() twice. However, Android app build by same javascript source only has to call history.back() once. In addition, a similar problem does not occur when native WebVIew(UIWebView) of iOS is used. Is this a Cordova(iOS) spec or bug? Versions Cordova 4.2 (iOS Platform 3.8.0) iOS 8.3 Same question on StackOverflow http://stackoverflow.com/questions/30973368/iframe-history-back-issues-in-cordova-app-ios Best regards, Satoshi NOMAMOTO - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] Plugins Release June 17th, 2015
I vote +1: * Verified signatures and hashes * Verified tags * Verified that plugins can added correctly to blank app * Verified that blank app can be successfully ran and built * Ran smoke testing of mobilespec app * Verified Release Notes --- Best regards, Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Saturday, 20 June, 2015 1:41 To: dev@cordova.apache.org Subject: Re: [VOTE] Plugins Release June 17th, 2015 Bump! On Wed, Jun 17, 2015 at 6:06 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9192 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/ The packages were published from their corresponding git tags: cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66) cordova-plugin-camera: 1.2.0 (437cf3d93a) cordova-plugin-console: 1.0.1 (f055daec45) cordova-plugin-contacts: 1.1.0 (e47559b0d4) cordova-plugin-device: 1.0.1 (b3da8484ec) cordova-plugin-device-motion: 1.1.1 (28394c4607) cordova-plugin-device-orientation: 1.0.1 (427d49f612) cordova-plugin-dialogs: 1.1.1 (b698f3a7b5) cordova-plugin-file: 2.1.0 (6276d06d7a) cordova-plugin-file-transfer: 1.2.0 (b01ab78fec) cordova-plugin-geolocation: 1.0.1 (e529db6abd) cordova-plugin-globalization: 1.0.1 (cd9d52355a) cordova-plugin-inappbrowser: 1.0.1 (47e332fc92) cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab) cordova-plugin-media: 1.0.1 (b3056343fc) cordova-plugin-media-capture: 1.0.1 (9af90d8540) cordova-plugin-network-information: 1.0.1 (d8bdb0e953) cordova-plugin-splashscreen: 2.1.0 (4b1df233ae) cordova-plugin-statusbar: 1.0.1 (5e96b2a345) cordova-plugin-test-framework: 1.0.1 (0167a2f9ab) cordova-plugin-vibration: 1.2.0 (274003cb33) cordova-plugin-whitelist: 1.1.0 (521e62b0fd) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting .md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built and ran mobilespec on android and ios - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32921216
--- Diff: src/android/CameraLauncher.java ---
@@ -173,6 +181,20 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM)) {
// LOCAL METHODS
//--
+private void processConfiguration(JSONArray args) throws JSONException
{
+if (args == null)
+throw new JSONException(no configuration object passed);
+this.mQuality = args.optInt(0, 80);
+// args 1 and 2 (destType, srcType) are skipped because they have
no field representation in this class
+this.targetWidth = args.optInt(3);
+this.targetHeight = args.optInt(4);
+this.encodingType = args.optInt(5, JPEG);
+this.mediaType = args.optInt(6, PICTURE);
+this.allowEdit = args.optBoolean(7);
+this.correctOrientation = args.optBoolean(8);
+this.saveToPhotoAlbum = args.optBoolean(9);
+}
--- End diff --
this might be a little to much, optInt already defaults to 0 and optBoolean
to false.
no need to explicitly define these defaults.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Implementation for Unified platform API
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32921498
--- Diff: src/android/CameraLauncher.java ---
@@ -163,7 +159,19 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM)) {
PluginResult r = new
PluginResult(PluginResult.Status.NO_RESULT);
r.setKeepCallback(true);
callbackContext.sendPluginResult(r);
-
+
+return true;
+} else if (action.equals(checkForSavedResult)) {
+if (savedRequestCode 0 || savedResultCode 0) {
+processConfiguration(args);
+imageUri = Uri.fromFile(createCaptureFile(encodingType));
+onActivityResult(savedRequestCode, savedResultCode,
savedIntent);
+savedRequestCode = 0;
+savedResultCode = 0;
+savedIntent = null;
+} else {
+callbackContext.success();
--- End diff --
one should only return an error when an error occurs.
@agrieve advised me to callback success with empty string so you can handle
the result in onSuccess javascript like so:
`if (result) {
//do something
}`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Implementation for Unified platform API
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/235#issuecomment-114060806 Closing this since the PlatformApi needs for more detailed design. The discussion is moved to cordova/cordova-discuss#9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: WP8: Avoid config `value...
GitHub user Deathspike opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/50 WP8: Avoid config `value` of a wrong element. If you have an element that shares the `name`, like feature name=SplashScreen, then the `value` attribute was read of that instead (since it can appear *before* the preference element). Thus, the config of `SplashScreen` preference was not settable at all. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Deathspike/cordova-plugin-splashscreen master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit ac23964ac6e5f7a77a62ed9923344857109e71fb Author: Roel van Uden r.h.g.v.u...@outlook.com Date: 2015-06-22T09:50:07Z WP8: Avoid config `value` of a wrong element. If you have an element that shares the `name`, like feature name=SplashScreen, then the `value` attribute was read of that instead (since it can appear *before* the preference element). Thus, the config of `SplashScreen` preference was not settable at all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user thehuijb commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-114052451 ## How a cordova camera application works on android This is basically how a cordova application works:  - User presses App-icon - Applications start - Mainactivity start - Java side of plugins included - WebView initialized - Html loads - javascript side of plugins loaded - onDeviceReady fired Now we have our application up and running. Itâs time to take a picture  - We call getPicture - The call goes to the CordovaBridge - CordovaBridge uses the PluginManager to pass it to the camera Plugin - Camera plugin launches a camera Activity Now that a camera Activity is running, our MainActivity is pushed to the background, onPause is fired. When the Camera Activity finished the MainActivity is called again via onActivityResult  the result is dispatched to the javascript succesFunction where our application can then do with it as planned. Thatâs what happens in a high memory availability scenario, a happy flow. Now what happens when there isnât enough memory left and the OS decides to kill our MainActivity?  - CameraActivity is finished and sends its result back to the activity that launched it. - Our MainActivity, is started. - Java side of plugins included - onActivityResult fires - plugin fails to send result back to the javascript because it is not there anymore - a completely new WebView is initialized - Html loads - javascript side of plugins loaded - onDeviceReady fired the precise order of event could differ on occasion but that doesnât matter because the entire webview has to be rebuilt and with it all the javascript therefor the callback can never be completed in this situation. You will always have to call a method in (or after) onDeviceReady to solve this problem. Serge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Malfunction OnlineEventsBridgeMode
Hi,
Apologies for any potential mishaps as this is a first communication with
the Cordova community.
We may be reporting or shedding light on a known issue.
While hunting a bug on an S3 Neo android 4.3 device, resulting in file API
not reporting success/failure during asynchronous calls, we had learned
that OnlineEventsBridgeMode (NativeToJsMessageQueue.java) seem to be
broken. We noticed that from a certain point in time, the Boolean *online* was
always set to false during:
toggleNetworkRunnable {
...
webView.setNetworkAvailable(*online*)
}
Consequently there were no more online/offline events triggered at the JS
and no more consequent polling of messages.
To be more precise, events from JAVA to JS were delivered only when someone
from the JS was calling androidExec (cordova.js) and never during
online/offline events.
As a result, we were always missing the last set of events as there were
stuck down at the JAVA queue resulting in application freeze.
(Once that started, the Boolean *online* was no longer being toggled via
notifyOfFlush resulting in a permanent failure resolved only when reloading
the software).
As far as we understand, WebView only deliverers online/offline events to JS
if the state of the Network changes i.e. if after a call to webView.
setNetworkAvailable(*false*) one would call webView.setNetworkAvailable(
*true*) and vice versa. This means that by design, Cordova seeks to
maintain the Boolean *online* to maintain the inverse state of the WebView
Network state. If/when the Boolean *online* looses track of the WebView
Network state, the system online/offline events are discontinued until
software reloading.
Till now we were unable to track down the exact sequence leading the Boolean
*online* to loose track of the WebView Network state in our system, but we
do notice a sequence of two consecutive calls to notifyOfFlush, flipping
the Boolean *online* twice - thereafter the Boolean *online* seem to have
lost track of the WebView Network state and online/offline events no longer
propagated to JS.
If our understanding is indeed correct. than, our main concern is that
this design does not converge to a stable state and that inview of the
asynchronous nature of the design and reliance on WebView specifics, a KISS
methodology which would not put the code at risk of coming into a complete
halt in view of a single mishap may be better. I.e. a design with a better
self healing property following mishaps.
We tried out a simple modification by replacing:
webView.setNetworkAvailable(*online*);
with:
webView.setNetworkAvailable(*true*); // trigger an event
webView.setNetworkAvailable(*false*); // reset the webView to its
default state
This had apparently solved the issues in our S3 Neo android 4.3 device
though more testing are needed.
If this approach is adopted, it requires cleaning up the code and removing
now redundant code such as the notifyOfFlush mechanism which would no
longer be needed, same for the JS event listener for offline events etc.
This we hope would result in overall simplification of code in this area
and better stability and endurance to mishaps. On the negative side, this
alternative design results in doubling the amount of times in which webView.
setNetworkAvailable() is toggled - forcing certain overhead. Yet, notice
that there is no longer a need for cordova.js to listen to offline events,
such that the added offline processing is now limited to the WebView
internal overhead which is likely to be slim.
Please advise,
Reg,
David Hadas
[GitHub] cordova-registry-web pull request: CB-9229 Add basic SEO and Googl...
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-registry-web/pull/21 CB-9229 Add basic SEO and Google analytics to plugin search You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-registry-web raghav/seo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-registry-web/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit 7d4419afb2e4dbda554969f20fcfafa99309f883 Author: Raghav Katyal rakat...@microsoft.com Date: 2015-06-22T18:08:33Z CB-9229 Add basic SEO and Google analytics to plugin search --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: Refactor code
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Plugins Release June 17th, 2015
+1 On Mon, Jun 22, 2015 at 2:28 PM, Steven Gill stevengil...@gmail.com wrote: ONE MOREEE On Sun, Jun 21, 2015 at 11:30 PM, Vladimir Kotikov (Akvelon) v-vlk...@microsoft.com wrote: I vote +1: * Verified signatures and hashes * Verified tags * Verified that plugins can added correctly to blank app * Verified that blank app can be successfully ran and built * Ran smoke testing of mobilespec app * Verified Release Notes --- Best regards, Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Saturday, 20 June, 2015 1:41 To: dev@cordova.apache.org Subject: Re: [VOTE] Plugins Release June 17th, 2015 Bump! On Wed, Jun 17, 2015 at 6:06 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9192 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/ The packages were published from their corresponding git tags: cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66) cordova-plugin-camera: 1.2.0 (437cf3d93a) cordova-plugin-console: 1.0.1 (f055daec45) cordova-plugin-contacts: 1.1.0 (e47559b0d4) cordova-plugin-device: 1.0.1 (b3da8484ec) cordova-plugin-device-motion: 1.1.1 (28394c4607) cordova-plugin-device-orientation: 1.0.1 (427d49f612) cordova-plugin-dialogs: 1.1.1 (b698f3a7b5) cordova-plugin-file: 2.1.0 (6276d06d7a) cordova-plugin-file-transfer: 1.2.0 (b01ab78fec) cordova-plugin-geolocation: 1.0.1 (e529db6abd) cordova-plugin-globalization: 1.0.1 (cd9d52355a) cordova-plugin-inappbrowser: 1.0.1 (47e332fc92) cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab) cordova-plugin-media: 1.0.1 (b3056343fc) cordova-plugin-media-capture: 1.0.1 (9af90d8540) cordova-plugin-network-information: 1.0.1 (d8bdb0e953) cordova-plugin-splashscreen: 2.1.0 (4b1df233ae) cordova-plugin-statusbar: 1.0.1 (5e96b2a345) cordova-plugin-test-framework: 1.0.1 (0167a2f9ab) cordova-plugin-vibration: 1.2.0 (274003cb33) cordova-plugin-whitelist: 1.1.0 (521e62b0fd) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting .md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built and ran mobilespec on android and ios - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
