[GitHub] cordova-plugin-file-transfer pull request: CB-6928 Wrong behaviour...

2015-11-09 Thread daserge
GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/112

CB-6928 Wrong behaviour transferring cacheable content

Adds support of 304 handling for iOS, Windows and adds a corresponding test.

[Jira issue](https://issues.apache.org/jira/browse/CB-6928) 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
CB-6928

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #112


commit e8fa2c3a67144133e060f97e6dd5964cef0116de
Author: daserge 
Date:   2015-11-09T13:25:03Z

CB-6928 Wrong behaviour transferring cacheable content

Adds support of 304 handling for iOS, Windows and adds a corresponding test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-09 Thread Maxime Alexandre
Thanks Connor for this script. It's "simpler" for iOS because you don't
need to modify Cordova source files, whereas for Android, i need to change
the gradle build file to integrate more instructions. I'll try your script
and get back to you.

--
Maxime


On Mon, Nov 9, 2015 at 12:55 PM, Connor Pearson  wrote:

> If you're interested, I created a proof of concept for iOS using deliver.
> https://github.com/cjpearson/cordova-package-upload
>
> It works as an after_build hook. If you add --upload to the build command,
> it will upload the ipa to the store.
>
> On Mon, Nov 9, 2015 at 5:09 AM, Maxime Alexandre <
> maxime.alexan...@wininup.com> wrote:
>
> > Hey! Thanks everyone for your answers. Just to be more precise, this
> upload
> > command could, at first, only upload the binaries and not creating the
> > whole process (meta, images, descriptions...) which is quite complex as
> we
> > all know. So it should first focus on uploading a new binary to an
> existing
> > projet. To sym up :
> >
> >- On Google Play, there is an official way to upload your APK through
> >their API (i successfully uploaded my APK file using
> >https://github.com/bluesliverx/gradle-android-publisher which use
> this
> >API.
> >- On Apple Store, the existing tools both use the iTMSTransporter
> >protocol (nomad/shenzhen, fastlane/deliver) in order to upload the
> > binary
> >to Apple. Not sure if we can call that "official" but it's quite safe
> to
> >use and looks like it's not going to change soon.
> >- Other stores i didn't look up yet
> >
> > We all agree it must be an official support method from the stores.
> Sounds
> > like an excellent idea to be able to plug extensions to the Cordova CLI
> via
> > NPM modules. I'll try to migrate my existing code as a plugin or hook to
> > Cordova CLI, add some docs then i'll PR.
> >
> > --
> > Maxime
> >
> >
> > On Sat, Nov 7, 2015 at 2:05 PM, Carlos Santana 
> > wrote:
> >
> > > Bless you Shaz :-)
> > >
> > > Yeah officially supporting unofficial methods not good idea. This is
> > > similar as old ios-sim or ios-deploy
> > >
> > > Before solving uploading, I would prefer to see improved docs and UX
> for
> > > packaging.
> > >
> > > For uploading this is something that lives in user land tools. With
> this
> > > said would love to accommodate in Cordova a way for this user land
> > features
> > > able to extend Cordova tooling.
> > >
> > > Today what we have are plugins and hooks, this is the approach today
> > being
> > > use for livereload plugin.
> > >
> > > At work we have being solving some problems in our CLI related to cli
> > > extensions/plugability.
> > > I think some of the solutions are applicable to Cordova cli. The basic
> > > idea is extending or adding CLI command or actions via extensions that
> > are
> > > packaged as npm modules, that anyone can add to a released CLI.
> > > Maybe this could be another way to make our tools pluggable in addition
> > of
> > > hooks.
> > >
> > > - Carlos
> > > @csantanapr
> > >
> > > > On Nov 6, 2015, at 10:25 PM, Connor Pearson 
> wrote:
> > > >
> > > > Would a hook or plugin work better then?
> > > >
> > > >> On Fri, Nov 6, 2015 at 8:42 PM, Shazron  wrote:
> > > >>
> > > >> The problem with using "unofficial" methods is, at least for some of
> > > >> our code contributors *cough IBM*, it won't fly with them, and IMO
> I'd
> > > >> rather not support unofficial methods as well in this project.
> > > >>
> > > >> e.g. http://stackoverflow.com/a/13232352 which appears to show a
> > > >> command line tool that allows upload, but guess what, they removed
> it
> > > >> in Xcode 7.1 
> > > >>
> > > >>> On Fri, Nov 6, 2015 at 4:58 PM, Connor Pearson 
> > > wrote:
> > > >>> There are some command line tools that support uploading an ipa (
> > > >>> https://github.com/nomad/shenzhen,
> > https://github.com/fastlane/deliver
> > > )
> > > >> so
> > > >>> it is possible. I don't think Apple officially supports this
> though,
> > so
> > > >> it
> > > >>> may be prone to breaking.
> > > >>>
> > >  On Fri, Nov 6, 2015 at 7:08 PM, Tommy Williams <
> to...@devgeeks.org>
> > > >>> wrote:
> > > >>>
> > >  I am with Jesse… I think it would be great, but wouldn’t hold my
> > > breath.
> > > 
> > >  Also agree documenting the process would be fantastic both as a
> > > reality
> > >  check and a resource for our users.
> > > 
> > >  The more we can provide after "Hello World", the better.
> > > 
> > >  - tommy
> > > 
> > > 
> > >  On 7 November 2015 at 09:54:41, Jesse (purplecabb...@gmail.com)
> > > wrote:
> > > 
> > >  Yes, I too see the value, but I think it's a bit of wishful
> > thinking.
> > > I
> > >  would love to be proven wrong though.
> > >  There are vast differences between the stores submission
> processes,
> > as
> > > >> well
> > >  as the meta that 

RE: Native vs. File URIs

2015-11-09 Thread Richard Knoll
Does that mean that FILE_URI should exclusively be returning URIs that follow 
the cdvfile:// scheme? Currently we never return those (at least, not in 
Android). Is there anything else that can be defined as cross device?

Thanks,
Richard

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Monday, November 9, 2015 11:45 AM
To: dev@cordova.apache.org
Subject: Re: Native vs. File URIs

FILE_URI is cross device, NATIVE_URL is device specific, and intended to be 
used when you need to know the REAL file path for something.


@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7ca343f6e3176f41d7d4a808d2e93e3956%7c72f988bf86f141af91ab2d7cd011db47%7c1=HJ0cDsXqCIWDzlpiv0DpZLzHMKAWAHGsn7cL%2bamJpXg%3d

On Mon, Nov 9, 2015 at 9:25 AM, Richard Knoll  wrote:

> Oh, so does it refer to the location rather than the type of URI? 
> That's fine with me, but if that is the case than we should still 
> probably be sure that whatever is returned from the call is of a consistent 
> type (i.e.
> always using content or always using file).
>
> Richard
>
> -Original Message-
> From: Shazron [mailto:shaz...@gmail.com]
> Sent: Friday, November 6, 2015 5:52 PM
> To: dev@cordova.apache.org
> Subject: Re: Native vs. File URIs
>
> I always thought a native URI was if the image was retrieved from the 
> ALAssetsLibrary (Photos Album).
>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdevel
> oper.apple.com%2flibrary%2fios%2fdocumentation%2fAssetsLibrary%2fRefer
> ence%2fALAssetsLibrary_Class%2f=01%7c01%7cRIKNOLL%40exchange.micr
> osoft.com%7c326ecc41750b4739501e08d2e7161af7%7c72f988bf86f141af91ab2d7
> cd011db47%7c1=k5JGWbePhlj4jmLCekW9tZiBlU11sE5cUv%2fr%2bqPMYkU%3d
> and the file URI was the image we dumped into tmp.
>
>
>
> On Fri, Nov 6, 2015 at 11:43 AM, Richard Knoll 
> wrote:
> > Hey all,
> >
> > I was wondering if anybody could clarify for me what the difference
> between FILE_URI and NATIVE_URI is in the camera plugin. Do we have a 
> clear definition of either? I assumed that FILE_URI would refer to an 
> actual path on the device (i.e. a URI using the "file" scheme) but the 
> docs for the camera plugin actually use a content URI as an example. 
> This seems counterintuitive, especially since the "content" scheme is 
> specific to Android. As it stands, FILE_URI and NATIVE_URI always 
> return the same thing in Android and can either give a content URI or 
> a file URI depending on the other camera options that are passed. I 
> think we need to be clear when returning URIs so that app developers 
> can tell what they have to do with it before they can use it in their 
> app. Also, it's worth noting that the FILE_URI and NATIVE_URI question 
> is complicated by the fact that on Android it is possible to pick 
> photos using apps like Google Photos which can choose files that have 
> no local path. I also would love some clarification as to where 
> "cdvfile" fits into all of this and the type of support it has across the 
> plugins. This is in regards to CB-9548, for those interested.
> >
> > Thanks,
> > Richard
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


[GitHub] cordova-docs pull request: Default value for required variables

2015-11-09 Thread stevengill
Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/415#issuecomment-155257121
  
Just confirming that plugman already handles the default attribute on 
preference tags before I merge this in. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-09 Thread Shazron
Filed https://issues.apache.org/jira/browse/CB-9972

On Mon, Nov 9, 2015 at 5:18 PM, Carlos Santana  wrote:
> Shaz,
>Got some feedback but so far nothing extreme to block your proposal.
>
> The only concerned was my comments around iOS8 and lower and it looks like 
> CSP is the level of security it will get and that's fine.
>
>  +1 to move forward
>
> - Carlos
> @csantanapr
>
>> On Nov 9, 2015, at 8:13 PM, Shazron  wrote:
>>
>> Any updates on your end Carlos? Anyone else have any concerns? I'm
>> preparing a PR for review soon.
>>
>>> On Wed, Nov 4, 2015 at 2:42 PM, Carlos Santana  wrote:
>>> currently evaluating with some other folks at work, will provide feedback
>>> soon.
>>>
>>> On Tue, Nov 3, 2015 at 11:07 PM Tommy-Carlos Williams 
>>> wrote:
>>>
 +1 to letting the OS handle it.

> On 4 Nov 2015, at 12:44, Jesse  wrote:
>
> I completely support the proposal!
>
>
> @purplecabbage
> risingj.com
>
>> On Tue, Nov 3, 2015 at 5:35 PM, Shazron  wrote:
>>
>> BUMP. This is important, and is causing a lot of pain for our users.
>> For example:
>>
 https://github.com/jessemonroy650/top-phonegap-mistakes/blob/master/the-whitelist-system.md
>>
>>
>>> On Mon, Nov 2, 2015 at 5:38 PM, Shazron  wrote:
>>> To view contents of the PR easily:
>>
 https://github.com/shazron/cordova-discuss/blob/da7af6606848a1b7d96f4d5ee5402360bf5fd53c/proposals/ios-whitelist-removal.md
>>>
 On Mon, Nov 2, 2015 at 5:36 PM, Shazron  wrote:
 PR sent: https://github.com/cordova/cordova-discuss/pull/27

> On Mon, Nov 2, 2015 at 5:21 PM, Shazron  wrote:
> Sorry everyone -- I'm structuring it as a PR and will revert my
> commits. Will be easier to comment that way
>
>> On Mon, Nov 2, 2015 at 5:05 PM, Shazron  wrote:
>>
 https://github.com/cordova/cordova-discuss/blob/master/proposals/ios-whitelist-removal.md
>>
>> Comment here or there, etc. I've included flowcharts...
>>
>> tldr; remove the whitelist in cordova-ios-4.x. we are not good at
>> security, let the OS handle it.
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

 -
 To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
 For additional commands, e-mail: dev-h...@cordova.apache.org


>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/409


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

2015-11-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-windows/pull/132

CB-9828 Implements PlatformApi contract for WIndows platform



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-9828

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #132


commit d5f75326c7df816f16aeb2d1db38aaa9624b5fd4
Author: Vladimir Kotikov 
Date:   2015-11-09T19:05:05Z

CB-9828 Implement and expose PlatformApi for Windows

commit f65f42dc3216f350e404ab5cde8d72c93a47d9a5
Author: Vladimir Kotikov 
Date:   2015-11-09T19:06:12Z

CB-9828 Upgrade and check-in node_modules




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-09 Thread Tommy Williams
Agree. The actual submission is such a small part over the overall pain. There 
are plenty of places we could make the day to day development better for all 
platforms before submission.


On 10 November 2015 at 06:43:42, Jesse (purplecabb...@gmail.com) wrote:

Ultimately this is optimizing 1% of the process of building an application, 
I would much rather see focus on the 99% that is developing and testing ... 

[GitHub] cordova-coho pull request: tools release: removed npm rc publish s...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/334


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request: tools release: removed npm rc publish s...

2015-11-09 Thread stevengill
GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-coho/pull/104

tools release: removed npm rc publish step



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-coho patch-41

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #104


commit 94760ec585b0fe7fc3b64d0bfd2d131cf35906e7
Author: Steve Gill 
Date:   2015-11-09T19:21:09Z

tools release: removed npm rc publish step




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Native vs. File URIs

2015-11-09 Thread Jesse
FILE_URI is cross device, NATIVE_URL is device specific, and intended to be
used when you need to know the REAL file path for something.


@purplecabbage
risingj.com

On Mon, Nov 9, 2015 at 9:25 AM, Richard Knoll  wrote:

> Oh, so does it refer to the location rather than the type of URI? That's
> fine with me, but if that is the case than we should still probably be sure
> that whatever is returned from the call is of a consistent type (i.e.
> always using content or always using file).
>
> Richard
>
> -Original Message-
> From: Shazron [mailto:shaz...@gmail.com]
> Sent: Friday, November 6, 2015 5:52 PM
> To: dev@cordova.apache.org
> Subject: Re: Native vs. File URIs
>
> I always thought a native URI was if the image was retrieved from the
> ALAssetsLibrary (Photos Album).
>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdeveloper.apple.com%2flibrary%2fios%2fdocumentation%2fAssetsLibrary%2fReference%2fALAssetsLibrary_Class%2f=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c326ecc41750b4739501e08d2e7161af7%7c72f988bf86f141af91ab2d7cd011db47%7c1=k5JGWbePhlj4jmLCekW9tZiBlU11sE5cUv%2fr%2bqPMYkU%3d
> and the file URI was the image we dumped into tmp.
>
>
>
> On Fri, Nov 6, 2015 at 11:43 AM, Richard Knoll 
> wrote:
> > Hey all,
> >
> > I was wondering if anybody could clarify for me what the difference
> between FILE_URI and NATIVE_URI is in the camera plugin. Do we have a clear
> definition of either? I assumed that FILE_URI would refer to an actual path
> on the device (i.e. a URI using the "file" scheme) but the docs for the
> camera plugin actually use a content URI as an example. This seems
> counterintuitive, especially since the "content" scheme is specific to
> Android. As it stands, FILE_URI and NATIVE_URI always return the same thing
> in Android and can either give a content URI or a file URI depending on the
> other camera options that are passed. I think we need to be clear when
> returning URIs so that app developers can tell what they have to do with it
> before they can use it in their app. Also, it's worth noting that the
> FILE_URI and NATIVE_URI question is complicated by the fact that on Android
> it is possible to pick photos using apps like Google Photos which can
> choose files that have no local path. I also would love some clarification
> as to where "cdvfile" fits into all of this and the type of support it has
> across the plugins. This is in regards to CB-9548, for those interested.
> >
> > Thanks,
> > Richard
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


[GitHub] cordova-lib pull request: path.parse only available on node 0.12+

2015-11-09 Thread apla
GitHub user apla opened a pull request:

https://github.com/apache/cordova-lib/pull/340

path.parse only available on node 0.12+



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apla/cordova-lib patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #340


commit 153abb92754ec01a551684e978e05099a06dad05
Author: ivan baktsheev 
Date:   2015-11-09T19:42:28Z

path.parse only available on node 0.12+




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Document and

2015-11-09 Thread sgrebnov
GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-docs/pull/416

Document  and .target-dir support on Windows

As per the following changes:
https://issues.apache.org/jira/browse/CB-9588
https://issues.apache.org/jira/browse/CB-8615

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-9588

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #416


commit 25b3ddd67af07d1d564a1ba426777e4f11a726ce
Author: sgrebnov 
Date:   2015-11-09T20:02:54Z

CB-9588 CB-8615 Documment  and .target-dir 
support on Windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-09 Thread Jesse
Again, not allowed by Apple, so I would rather not waste time with this.
+ The current implementation is probably not how we would want to extend
our tooling. Shoe-horning a cli plugin into the runtime plugin definition
is interesting, but fragile.

Ultimately this is optimizing 1% of the process of building an application,
I would much rather see focus on the 99% that is developing and testing ...

Additionally, having this functionality available on Android (the only
place it will work) and not on other platforms will just confuse users, I
would rather skip it all together.

Documenting the steps required to submit an app to each app store however,
is an awesome idea, and seemingly a requirement of this work anyway, so why
not just do that first?

Cheers,
  Jesse




@purplecabbage
risingj.com

On Mon, Nov 9, 2015 at 6:15 AM, Maxime Alexandre <
maxime.alexan...@wininup.com> wrote:

> Thanks Connor for this script. It's "simpler" for iOS because you don't
> need to modify Cordova source files, whereas for Android, i need to change
> the gradle build file to integrate more instructions. I'll try your script
> and get back to you.
>
> --
> Maxime
>
>
> On Mon, Nov 9, 2015 at 12:55 PM, Connor Pearson  wrote:
>
> > If you're interested, I created a proof of concept for iOS using deliver.
> > https://github.com/cjpearson/cordova-package-upload
> >
> > It works as an after_build hook. If you add --upload to the build
> command,
> > it will upload the ipa to the store.
> >
> > On Mon, Nov 9, 2015 at 5:09 AM, Maxime Alexandre <
> > maxime.alexan...@wininup.com> wrote:
> >
> > > Hey! Thanks everyone for your answers. Just to be more precise, this
> > upload
> > > command could, at first, only upload the binaries and not creating the
> > > whole process (meta, images, descriptions...) which is quite complex as
> > we
> > > all know. So it should first focus on uploading a new binary to an
> > existing
> > > projet. To sym up :
> > >
> > >- On Google Play, there is an official way to upload your APK
> through
> > >their API (i successfully uploaded my APK file using
> > >https://github.com/bluesliverx/gradle-android-publisher which use
> > this
> > >API.
> > >- On Apple Store, the existing tools both use the iTMSTransporter
> > >protocol (nomad/shenzhen, fastlane/deliver) in order to upload the
> > > binary
> > >to Apple. Not sure if we can call that "official" but it's quite
> safe
> > to
> > >use and looks like it's not going to change soon.
> > >- Other stores i didn't look up yet
> > >
> > > We all agree it must be an official support method from the stores.
> > Sounds
> > > like an excellent idea to be able to plug extensions to the Cordova CLI
> > via
> > > NPM modules. I'll try to migrate my existing code as a plugin or hook
> to
> > > Cordova CLI, add some docs then i'll PR.
> > >
> > > --
> > > Maxime
> > >
> > >
> > > On Sat, Nov 7, 2015 at 2:05 PM, Carlos Santana 
> > > wrote:
> > >
> > > > Bless you Shaz :-)
> > > >
> > > > Yeah officially supporting unofficial methods not good idea. This is
> > > > similar as old ios-sim or ios-deploy
> > > >
> > > > Before solving uploading, I would prefer to see improved docs and UX
> > for
> > > > packaging.
> > > >
> > > > For uploading this is something that lives in user land tools. With
> > this
> > > > said would love to accommodate in Cordova a way for this user land
> > > features
> > > > able to extend Cordova tooling.
> > > >
> > > > Today what we have are plugins and hooks, this is the approach today
> > > being
> > > > use for livereload plugin.
> > > >
> > > > At work we have being solving some problems in our CLI related to cli
> > > > extensions/plugability.
> > > > I think some of the solutions are applicable to Cordova cli. The
> basic
> > > > idea is extending or adding CLI command or actions via extensions
> that
> > > are
> > > > packaged as npm modules, that anyone can add to a released CLI.
> > > > Maybe this could be another way to make our tools pluggable in
> addition
> > > of
> > > > hooks.
> > > >
> > > > - Carlos
> > > > @csantanapr
> > > >
> > > > > On Nov 6, 2015, at 10:25 PM, Connor Pearson 
> > wrote:
> > > > >
> > > > > Would a hook or plugin work better then?
> > > > >
> > > > >> On Fri, Nov 6, 2015 at 8:42 PM, Shazron 
> wrote:
> > > > >>
> > > > >> The problem with using "unofficial" methods is, at least for some
> of
> > > > >> our code contributors *cough IBM*, it won't fly with them, and IMO
> > I'd
> > > > >> rather not support unofficial methods as well in this project.
> > > > >>
> > > > >> e.g. http://stackoverflow.com/a/13232352 which appears to show a
> > > > >> command line tool that allows upload, but guess what, they removed
> > it
> > > > >> in Xcode 7.1 
> > > > >>
> > > > >>> On Fri, Nov 6, 2015 at 4:58 PM, Connor Pearson  >
> > > > wrote:
> > > > >>> There are some command line tools 

[GitHub] cordova-docs pull request: Default value for required variables

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/415


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Default value for required variables

2015-11-09 Thread stevengill
Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/415#issuecomment-155320589
  
Awesome. Thanks for the commit!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Default value for required variables

2015-11-09 Thread mbektchiev
Github user mbektchiev commented on the pull request:

https://github.com/apache/cordova-docs/pull/415#issuecomment-155318013
  
Here's the JIRA issue which added this support: 
https://issues.apache.org/jira/browse/CB-9162


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...

2015-11-09 Thread mbektchiev
Github user mbektchiev commented on the pull request:

https://github.com/apache/cordova-lib/pull/289#issuecomment-155330596
  
Rebased on latest master and now tests pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

2015-11-09 Thread sgrebnov
Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-ios/pull/176#issuecomment-155028117
  
Re-based work on top of master and grouped all changes into two commits:
1. 6347263c80e4257506a77cece832c4c63c353145 contains implementation/changes
2. b4dd1e0bbd5bdbca3ef0bfd1561baedf38ccedaa just adds required node modules


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[ANNOUNCE] Cordova Android 5.0.0 Released!

2015-11-09 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/663835861079855104
Blog:
http://cordova.apache.org/announcements/2015/11/09/cordova-android-5.0.0.html

Thanks to everyone who helped with this!

-Steve


[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/119


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: CB-9883

2015-11-09 Thread purplecabbage
GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-ios/pull/179

CB-9883

Also remove the wk-webview bridge as the plugin itself simply clobbers 
cordova.exec now.
1 Bridge! You shall not pass!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-ios CB-9883

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #179


commit 21a71fe89ffe575d1b70ce51aa995ac23f17
Author: Jesse MacFadyen 
Date:   2015-11-07T01:53:29Z

Removed wk-webview exec and some linting

commit ccf936dc50977834e1744f383f8040c19e561ba9
Author: Jesse MacFadyen 
Date:   2015-11-07T02:01:37Z

rebuild cordova.js




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: CB-9883

2015-11-09 Thread purplecabbage
GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-ios/pull/180

CB-9883

Remove last remaining alternative bridge (wk-webview)
The wk-webview plugin is now clobbering cordova.exec to provide it's own 
implementation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-ios CB-9883

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #180


commit 21a71fe89ffe575d1b70ce51aa995ac23f17
Author: Jesse MacFadyen 
Date:   2015-11-07T01:53:29Z

Removed wk-webview exec and some linting

commit 3618162251e21f1ec6d7d83be403a984152a4c55
Author: Jesse MacFadyen 
Date:   2015-11-10T00:04:43Z

Update cordova.js




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: CB-9883

2015-11-09 Thread purplecabbage
Github user purplecabbage closed the pull request at:

https://github.com/apache/cordova-ios/pull/179


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-09 Thread Maxime Alexandre
Hey! Thanks everyone for your answers. Just to be more precise, this upload
command could, at first, only upload the binaries and not creating the
whole process (meta, images, descriptions...) which is quite complex as we
all know. So it should first focus on uploading a new binary to an existing
projet. To sym up :

   - On Google Play, there is an official way to upload your APK through
   their API (i successfully uploaded my APK file using
   https://github.com/bluesliverx/gradle-android-publisher which use this
   API.
   - On Apple Store, the existing tools both use the iTMSTransporter
   protocol (nomad/shenzhen, fastlane/deliver) in order to upload the binary
   to Apple. Not sure if we can call that "official" but it's quite safe to
   use and looks like it's not going to change soon.
   - Other stores i didn't look up yet

We all agree it must be an official support method from the stores. Sounds
like an excellent idea to be able to plug extensions to the Cordova CLI via
NPM modules. I'll try to migrate my existing code as a plugin or hook to
Cordova CLI, add some docs then i'll PR.

--
Maxime


On Sat, Nov 7, 2015 at 2:05 PM, Carlos Santana  wrote:

> Bless you Shaz :-)
>
> Yeah officially supporting unofficial methods not good idea. This is
> similar as old ios-sim or ios-deploy
>
> Before solving uploading, I would prefer to see improved docs and UX for
> packaging.
>
> For uploading this is something that lives in user land tools. With this
> said would love to accommodate in Cordova a way for this user land features
> able to extend Cordova tooling.
>
> Today what we have are plugins and hooks, this is the approach today being
> use for livereload plugin.
>
> At work we have being solving some problems in our CLI related to cli
> extensions/plugability.
> I think some of the solutions are applicable to Cordova cli. The basic
> idea is extending or adding CLI command or actions via extensions that are
> packaged as npm modules, that anyone can add to a released CLI.
> Maybe this could be another way to make our tools pluggable in addition of
> hooks.
>
> - Carlos
> @csantanapr
>
> > On Nov 6, 2015, at 10:25 PM, Connor Pearson  wrote:
> >
> > Would a hook or plugin work better then?
> >
> >> On Fri, Nov 6, 2015 at 8:42 PM, Shazron  wrote:
> >>
> >> The problem with using "unofficial" methods is, at least for some of
> >> our code contributors *cough IBM*, it won't fly with them, and IMO I'd
> >> rather not support unofficial methods as well in this project.
> >>
> >> e.g. http://stackoverflow.com/a/13232352 which appears to show a
> >> command line tool that allows upload, but guess what, they removed it
> >> in Xcode 7.1 
> >>
> >>> On Fri, Nov 6, 2015 at 4:58 PM, Connor Pearson 
> wrote:
> >>> There are some command line tools that support uploading an ipa (
> >>> https://github.com/nomad/shenzhen, https://github.com/fastlane/deliver
> )
> >> so
> >>> it is possible. I don't think Apple officially supports this though, so
> >> it
> >>> may be prone to breaking.
> >>>
>  On Fri, Nov 6, 2015 at 7:08 PM, Tommy Williams 
> >>> wrote:
> >>>
>  I am with Jesse… I think it would be great, but wouldn’t hold my
> breath.
> 
>  Also agree documenting the process would be fantastic both as a
> reality
>  check and a resource for our users.
> 
>  The more we can provide after "Hello World", the better.
> 
>  - tommy
> 
> 
>  On 7 November 2015 at 09:54:41, Jesse (purplecabb...@gmail.com)
> wrote:
> 
>  Yes, I too see the value, but I think it's a bit of wishful thinking.
> I
>  would love to be proven wrong though.
>  There are vast differences between the stores submission processes, as
> >> well
>  as the meta that they require. In the case of iOS, you would likely
> >> need to
>  scrape the website and live with the possibility that Apple could
> break
> >> it
>  at any time.
> 
>  I would like to see someone come up with a definitive list of the
> manual
>  steps to take to submit an app to all the stores before we even
> consider
>  automating the process.
>  Even as a document alone this would be a great help to our users.
> 
> 
> 
>  @purplecabbage
>  risingj.com
> 
>  On Fri, Nov 6, 2015 at 1:52 PM, Parashuram N 
>  wrote:
> 
> > I think this is a great idea. I understand that we already have a
> >> package
> > command and this could be a logical extension. However, will this be
> a
> > functionality that can be supported on multiple stores ? I am not
> >> sure if
> > this is legal on an iOS store.
> >
> >
> >
> >
> >> On 11/6/15, 2:41 AM, "M Alexandre"  wrote:
> >>
> >> Hello Cordova devs,
> >>
> >> Because Cordova CLI is a great tool for command line for almost
>  

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-09 Thread Connor Pearson
If you're interested, I created a proof of concept for iOS using deliver.
https://github.com/cjpearson/cordova-package-upload

It works as an after_build hook. If you add --upload to the build command,
it will upload the ipa to the store.

On Mon, Nov 9, 2015 at 5:09 AM, Maxime Alexandre <
maxime.alexan...@wininup.com> wrote:

> Hey! Thanks everyone for your answers. Just to be more precise, this upload
> command could, at first, only upload the binaries and not creating the
> whole process (meta, images, descriptions...) which is quite complex as we
> all know. So it should first focus on uploading a new binary to an existing
> projet. To sym up :
>
>- On Google Play, there is an official way to upload your APK through
>their API (i successfully uploaded my APK file using
>https://github.com/bluesliverx/gradle-android-publisher which use this
>API.
>- On Apple Store, the existing tools both use the iTMSTransporter
>protocol (nomad/shenzhen, fastlane/deliver) in order to upload the
> binary
>to Apple. Not sure if we can call that "official" but it's quite safe to
>use and looks like it's not going to change soon.
>- Other stores i didn't look up yet
>
> We all agree it must be an official support method from the stores. Sounds
> like an excellent idea to be able to plug extensions to the Cordova CLI via
> NPM modules. I'll try to migrate my existing code as a plugin or hook to
> Cordova CLI, add some docs then i'll PR.
>
> --
> Maxime
>
>
> On Sat, Nov 7, 2015 at 2:05 PM, Carlos Santana 
> wrote:
>
> > Bless you Shaz :-)
> >
> > Yeah officially supporting unofficial methods not good idea. This is
> > similar as old ios-sim or ios-deploy
> >
> > Before solving uploading, I would prefer to see improved docs and UX for
> > packaging.
> >
> > For uploading this is something that lives in user land tools. With this
> > said would love to accommodate in Cordova a way for this user land
> features
> > able to extend Cordova tooling.
> >
> > Today what we have are plugins and hooks, this is the approach today
> being
> > use for livereload plugin.
> >
> > At work we have being solving some problems in our CLI related to cli
> > extensions/plugability.
> > I think some of the solutions are applicable to Cordova cli. The basic
> > idea is extending or adding CLI command or actions via extensions that
> are
> > packaged as npm modules, that anyone can add to a released CLI.
> > Maybe this could be another way to make our tools pluggable in addition
> of
> > hooks.
> >
> > - Carlos
> > @csantanapr
> >
> > > On Nov 6, 2015, at 10:25 PM, Connor Pearson  wrote:
> > >
> > > Would a hook or plugin work better then?
> > >
> > >> On Fri, Nov 6, 2015 at 8:42 PM, Shazron  wrote:
> > >>
> > >> The problem with using "unofficial" methods is, at least for some of
> > >> our code contributors *cough IBM*, it won't fly with them, and IMO I'd
> > >> rather not support unofficial methods as well in this project.
> > >>
> > >> e.g. http://stackoverflow.com/a/13232352 which appears to show a
> > >> command line tool that allows upload, but guess what, they removed it
> > >> in Xcode 7.1 
> > >>
> > >>> On Fri, Nov 6, 2015 at 4:58 PM, Connor Pearson 
> > wrote:
> > >>> There are some command line tools that support uploading an ipa (
> > >>> https://github.com/nomad/shenzhen,
> https://github.com/fastlane/deliver
> > )
> > >> so
> > >>> it is possible. I don't think Apple officially supports this though,
> so
> > >> it
> > >>> may be prone to breaking.
> > >>>
> >  On Fri, Nov 6, 2015 at 7:08 PM, Tommy Williams 
> > >>> wrote:
> > >>>
> >  I am with Jesse… I think it would be great, but wouldn’t hold my
> > breath.
> > 
> >  Also agree documenting the process would be fantastic both as a
> > reality
> >  check and a resource for our users.
> > 
> >  The more we can provide after "Hello World", the better.
> > 
> >  - tommy
> > 
> > 
> >  On 7 November 2015 at 09:54:41, Jesse (purplecabb...@gmail.com)
> > wrote:
> > 
> >  Yes, I too see the value, but I think it's a bit of wishful
> thinking.
> > I
> >  would love to be proven wrong though.
> >  There are vast differences between the stores submission processes,
> as
> > >> well
> >  as the meta that they require. In the case of iOS, you would likely
> > >> need to
> >  scrape the website and live with the possibility that Apple could
> > break
> > >> it
> >  at any time.
> > 
> >  I would like to see someone come up with a definitive list of the
> > manual
> >  steps to take to submit an app to all the stores before we even
> > consider
> >  automating the process.
> >  Even as a document alone this would be a great help to our users.
> > 
> > 
> > 
> >  @purplecabbage
> >  risingj.com
> > 
> >  On Fri, Nov 6, 2015 at 1:52 PM, 

[GitHub] cordova-ios pull request: CB-9883

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/180


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-09 Thread Shazron
Any updates on your end Carlos? Anyone else have any concerns? I'm
preparing a PR for review soon.

On Wed, Nov 4, 2015 at 2:42 PM, Carlos Santana  wrote:
> currently evaluating with some other folks at work, will provide feedback
> soon.
>
> On Tue, Nov 3, 2015 at 11:07 PM Tommy-Carlos Williams 
> wrote:
>
>> +1 to letting the OS handle it.
>>
>> > On 4 Nov 2015, at 12:44, Jesse  wrote:
>> >
>> > I completely support the proposal!
>> >
>> >
>> > @purplecabbage
>> > risingj.com
>> >
>> >> On Tue, Nov 3, 2015 at 5:35 PM, Shazron  wrote:
>> >>
>> >> BUMP. This is important, and is causing a lot of pain for our users.
>> >> For example:
>> >>
>> https://github.com/jessemonroy650/top-phonegap-mistakes/blob/master/the-whitelist-system.md
>> >>
>> >>
>> >>> On Mon, Nov 2, 2015 at 5:38 PM, Shazron  wrote:
>> >>> To view contents of the PR easily:
>> >>
>> https://github.com/shazron/cordova-discuss/blob/da7af6606848a1b7d96f4d5ee5402360bf5fd53c/proposals/ios-whitelist-removal.md
>> >>>
>>  On Mon, Nov 2, 2015 at 5:36 PM, Shazron  wrote:
>>  PR sent: https://github.com/cordova/cordova-discuss/pull/27
>> 
>> > On Mon, Nov 2, 2015 at 5:21 PM, Shazron  wrote:
>> > Sorry everyone -- I'm structuring it as a PR and will revert my
>> > commits. Will be easier to comment that way
>> >
>> >> On Mon, Nov 2, 2015 at 5:05 PM, Shazron  wrote:
>> >>
>> https://github.com/cordova/cordova-discuss/blob/master/proposals/ios-whitelist-removal.md
>> >>
>> >> Comment here or there, etc. I've included flowcharts...
>> >>
>> >> tldr; remove the whitelist in cordova-ios-4.x. we are not good at
>> >> security, let the OS handle it.
>> >>
>> >> -
>> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> >> For additional commands, e-mail: dev-h...@cordova.apache.org
>> >>
>> >>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-09 Thread Carlos Santana
Shaz,
   Got some feedback but so far nothing extreme to block your proposal. 

The only concerned was my comments around iOS8 and lower and it looks like CSP 
is the level of security it will get and that's fine. 

 +1 to move forward 

- Carlos
@csantanapr

> On Nov 9, 2015, at 8:13 PM, Shazron  wrote:
> 
> Any updates on your end Carlos? Anyone else have any concerns? I'm
> preparing a PR for review soon.
> 
>> On Wed, Nov 4, 2015 at 2:42 PM, Carlos Santana  wrote:
>> currently evaluating with some other folks at work, will provide feedback
>> soon.
>> 
>> On Tue, Nov 3, 2015 at 11:07 PM Tommy-Carlos Williams 
>> wrote:
>> 
>>> +1 to letting the OS handle it.
>>> 
 On 4 Nov 2015, at 12:44, Jesse  wrote:
 
 I completely support the proposal!
 
 
 @purplecabbage
 risingj.com
 
> On Tue, Nov 3, 2015 at 5:35 PM, Shazron  wrote:
> 
> BUMP. This is important, and is causing a lot of pain for our users.
> For example:
> 
>>> https://github.com/jessemonroy650/top-phonegap-mistakes/blob/master/the-whitelist-system.md
> 
> 
>> On Mon, Nov 2, 2015 at 5:38 PM, Shazron  wrote:
>> To view contents of the PR easily:
> 
>>> https://github.com/shazron/cordova-discuss/blob/da7af6606848a1b7d96f4d5ee5402360bf5fd53c/proposals/ios-whitelist-removal.md
>> 
>>> On Mon, Nov 2, 2015 at 5:36 PM, Shazron  wrote:
>>> PR sent: https://github.com/cordova/cordova-discuss/pull/27
>>> 
 On Mon, Nov 2, 2015 at 5:21 PM, Shazron  wrote:
 Sorry everyone -- I'm structuring it as a PR and will revert my
 commits. Will be easier to comment that way
 
> On Mon, Nov 2, 2015 at 5:05 PM, Shazron  wrote:
> 
>>> https://github.com/cordova/cordova-discuss/blob/master/proposals/ios-whitelist-removal.md
> 
> Comment here or there, etc. I've included flowcharts...
> 
> tldr; remove the whitelist in cordova-ios-4.x. we are not good at
> security, let the OS handle it.
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 
> 
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>> 
>>> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Native vs. File URIs

2015-11-09 Thread Shazron
For the Camera plugin, FILE_URI is a file:// URI and existed even
before we created the file plugin's cdvfile:// cross-platform URI. We
didn't change it for backwards compat reasons.

On Mon, Nov 9, 2015 at 1:52 PM, Richard Knoll  wrote:
> Does that mean that FILE_URI should exclusively be returning URIs that follow 
> the cdvfile:// scheme? Currently we never return those (at least, not in 
> Android). Is there anything else that can be defined as cross device?
>
> Thanks,
> Richard
>
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Monday, November 9, 2015 11:45 AM
> To: dev@cordova.apache.org
> Subject: Re: Native vs. File URIs
>
> FILE_URI is cross device, NATIVE_URL is device specific, and intended to be 
> used when you need to know the REAL file path for something.
>
>
> @purplecabbage
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7ca343f6e3176f41d7d4a808d2e93e3956%7c72f988bf86f141af91ab2d7cd011db47%7c1=HJ0cDsXqCIWDzlpiv0DpZLzHMKAWAHGsn7cL%2bamJpXg%3d
>
> On Mon, Nov 9, 2015 at 9:25 AM, Richard Knoll  wrote:
>
>> Oh, so does it refer to the location rather than the type of URI?
>> That's fine with me, but if that is the case than we should still
>> probably be sure that whatever is returned from the call is of a consistent 
>> type (i.e.
>> always using content or always using file).
>>
>> Richard
>>
>> -Original Message-
>> From: Shazron [mailto:shaz...@gmail.com]
>> Sent: Friday, November 6, 2015 5:52 PM
>> To: dev@cordova.apache.org
>> Subject: Re: Native vs. File URIs
>>
>> I always thought a native URI was if the image was retrieved from the
>> ALAssetsLibrary (Photos Album).
>>
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdevel
>> oper.apple.com%2flibrary%2fios%2fdocumentation%2fAssetsLibrary%2fRefer
>> ence%2fALAssetsLibrary_Class%2f=01%7c01%7cRIKNOLL%40exchange.micr
>> osoft.com%7c326ecc41750b4739501e08d2e7161af7%7c72f988bf86f141af91ab2d7
>> cd011db47%7c1=k5JGWbePhlj4jmLCekW9tZiBlU11sE5cUv%2fr%2bqPMYkU%3d
>> and the file URI was the image we dumped into tmp.
>>
>>
>>
>> On Fri, Nov 6, 2015 at 11:43 AM, Richard Knoll 
>> wrote:
>> > Hey all,
>> >
>> > I was wondering if anybody could clarify for me what the difference
>> between FILE_URI and NATIVE_URI is in the camera plugin. Do we have a
>> clear definition of either? I assumed that FILE_URI would refer to an
>> actual path on the device (i.e. a URI using the "file" scheme) but the
>> docs for the camera plugin actually use a content URI as an example.
>> This seems counterintuitive, especially since the "content" scheme is
>> specific to Android. As it stands, FILE_URI and NATIVE_URI always
>> return the same thing in Android and can either give a content URI or
>> a file URI depending on the other camera options that are passed. I
>> think we need to be clear when returning URIs so that app developers
>> can tell what they have to do with it before they can use it in their
>> app. Also, it's worth noting that the FILE_URI and NATIVE_URI question
>> is complicated by the fact that on Android it is possible to pick
>> photos using apps like Google Photos which can choose files that have
>> no local path. I also would love some clarification as to where
>> "cdvfile" fits into all of this and the type of support it has across the 
>> plugins. This is in regards to CB-9548, for those interested.
>> >
>> > Thanks,
>> > Richard
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: CB-9883

2015-11-09 Thread shazron
Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/179#issuecomment-155253981
  
It's the Bridge of IFrame-Dûm! Good work Olórin of the Cabbages Purple


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org