[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

2015-12-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-161909928 @ngopal, please close the PR - the CLI has already been released (twice). Thanks! --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-file-transfer pull request: Fix/wp8 browser cookies

2015-12-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/90#issuecomment-161909635 @purplecabbage: Jesse, could you please take a look at this and #85 - do we need to accept `wp8` PRs taking into account the `wp8` platform

[GitHub] cordova-plugin-contacts pull request: Solved problem add Contact p...

2015-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept assets URIs ...

2015-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

2015-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/118 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request: Fix/wp8 browser cookies

2015-12-04 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/90#issuecomment-161917051 Plugins yes! Assiuming they don't require platform changes. Deprecation window is 6 months or more, and we haven't fully decided on

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

2015-12-04 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161938717 Another issue I found:

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

2015-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request: Fix/wp8 browser cookies

2015-12-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/90#issuecomment-161929619 @lvanengelen, here is the discussion link about wp8 deprecation: http://markmail.org/message/y2j62jbwrnlzzwrz --- If your project is set up for

Cordova implementation of windows desktop

2015-12-04 Thread Ajay Chebbi
Hi, I am looking for some historical background on the decision on the implementation stack for Windows (desktop) . Windows (desktop) is implemented in WinJS . Was there any reason / implementation hurdle in implementing it in C#/XAML (like Windows Phone 8). I'm increasingly seeing customers

[GitHub] cordova-app-hello-world pull request: CB-2528 Add window.onerror

2015-12-04 Thread BBosman
Github user BBosman closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-file-transfer pull request: Fix/wp8 browser cookies

2015-12-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/90#issuecomment-161930336 Also, regarding the `useBrowserHttp` parameter - would it even be better to place it into optional `options` parameter? That way the signature will

[GitHub] cordova-lib pull request: Adds copying of blackberry10 splashscree...

2015-12-04 Thread kdubuc
Github user kdubuc commented on the pull request: https://github.com/apache/cordova-lib/pull/342#issuecomment-161926911 You plan to merge it ? :suspect: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-file-transfer pull request: Fix/wp8 browser cookies

2015-12-04 Thread lvanengelen
Github user lvanengelen commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/90#issuecomment-161928602 @daserge @purplecabbage: what is this I hear about deprecation of the wp8 platform? I haven't been able to find any references to that on the

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

2015-12-04 Thread nleclerc
Github user nleclerc commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-161991229 Well, i'll gladly go with Miguel's solution. What should be the next step ? On Fri, 4 Dec 2015 at 16:06 Vladimir Kotikov

[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...

2015-12-04 Thread nleclerc
Github user nleclerc commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-161991834 Thanks for the answer. Actually i was a bit confused because i came over the PR from another commit, hence my question. This new commit

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

2015-12-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-161988854 After couple of tests this giving me a "no access to assets" error when cancelling a camera. @m-revetria solution looks more correct and robust.

Re: Cordova implementation of windows desktop

2015-12-04 Thread Ryan J. Salva
Ajay, Generally speaking, the aim of Cordova is to enable JavaScript developers to build cross-platform mobile applications. Since Windows is one of the few platforms to run JavaScript natively, it made sense to use the preferred language of the target audience. There are also performance

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

2015-12-04 Thread m-revetria
Github user m-revetria commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-161974581 I don't think this change completely fix the issue: we should check AVCaptureDevice auth status just when the picker source is the camera and check

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/10#issuecomment-161955467 @dblotsky, @stevengill could please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-04 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-labs/pull/10 CB-9840 Fallback file-transfer uploadResponse encoding to latin1 in c… …ase not encoded with UTF-8 on iOS Adds non-utf endpoints for the correspoding tests:

[GitHub] cordova-docs pull request: Adding Search Button

2015-12-04 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/435#issuecomment-161956019 @riknoll please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...

2015-12-04 Thread m-revetria
Github user m-revetria commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-161976293 Hi, Nicolas. The use case was show an alert message to the user indicating: - If he canceled the selection of an image that he must

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

2015-12-04 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-162031155 Hey @m-revetria, would you mind making a PR for that change? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-docs pull request: Adding Search Button

2015-12-04 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/435#issuecomment-162028933 @dblotsky That search icon is barely visible in the top right; I don't think people will notice it. Can we add a text input to make it easier to see and use? The

Re: [DISCUSS] CLI Templates

2015-12-04 Thread Michael Brooks
I'd love to see a pull request rather than a straight up merge, since the template discussion was more involved. Also, I'm really looking forward to seeing your work on this! On Thu, Dec 3, 2015 at 9:47 AM, Carlos Santana wrote: > I will be working later today with James

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-12-04 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-04 Thread Shazron
After working out some bridge improvements and fixing some Platform API bugs and testing, I believe it's ready. I'll start a [VOTE] thread soon. On Thu, Dec 3, 2015 at 5:19 PM, Carlos Santana wrote: > +1 let's move forward this items with WKWebview I don't see holding up

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-04 Thread Carlos Santana
+1 On Fri, Dec 4, 2015 at 3:07 PM Shazron wrote: > After working out some bridge improvements and fixing some Platform > API bugs and testing, I believe it's ready. I'll start a [VOTE] thread > soon. > > On Thu, Dec 3, 2015 at 5:19 PM, Carlos Santana >

Re: [DISCUSS] cordova-plugin-wkwebview release

2015-12-04 Thread Carlos Santana
+1 Could we open/report to WebKit and Apple Bugs, and add links these reports that are outside of our control? This way I think we feel better that we informed the issues to those that have the control to fix them. And the Cordova community sees that we did all we could for some, others we can

[GitHub] cordova-plugin-camera pull request: CB-9189 android: Implementing ...

2015-12-04 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/145 CB-9189 android: Implementing save/restore API to handle Activity destruction This fixes the long standing issue of the camera plugin crashing after receiving an Activity result

[GitHub] cordova-lib pull request: CB-9957 removed CPR fetching code

2015-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

2015-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/349 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

2015-12-04 Thread ngopal
Github user ngopal closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: Adds copying of blackberry10 splashscree...

2015-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/342 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho pull request: Removed r prefix from plugins release p...

2015-12-04 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/107 Removed r prefix from plugins release process You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-44

[DISCUSS] Dependency Hell

2015-12-04 Thread Dmitry Blotsky
Hey folks, I feel like we're in a bit of a dependency hell, and I feel that it's because there are two distinct worlds of Cordova that use the same version space: the run-time world, and the CLI-time world. For example a runtime change in Windows that bumps cordova-windows from 4.x to 5.x also

[VOTE] 4.0.0 iOS Release

2015-12-04 Thread Shazron
Please review and vote on this 4.0.0 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10147 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10147 The package

Re: [DISCUSS] cordova-plugin-wkwebview release

2015-12-04 Thread Shazron
Yeah we should file these, especially to WebKit and not Apple's Bug Reporter, for visibility. Since the iOS 4.0.0 VOTE thread is out, I'll start this one as well. On Fri, Dec 4, 2015 at 2:06 PM, Carlos Santana wrote: > +1 > Could we open/report to WebKit and Apple Bugs,

[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...

2015-12-04 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/289#issuecomment-162125224 Merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...

2015-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/289 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[DISCUSS] Cordova 6.0.0

2015-12-04 Thread Steven Gill
Hey everyone, I want to try and get cordova 6.0.0 vote out early next week (after ios vote). Plugin pinning, pinned cordova-android@5 and cordova-ios@4 and a few other fixes. I have a board going for it. https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=101=detail=CB-9858 If you

RE: [DISCUSS] CLI Templates

2015-12-04 Thread Dmitry Blotsky
Hey folks. Sorry I'm late to the party, but why is `--copy-from` not sufficient? Kindly, Dmitry -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Friday, December 4, 2015 10:09 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] CLI Templates Michael we will

[VOTE] cordova-plugin-wkwebview-engine 1.0.0 release

2015-12-04 Thread Shazron
Please review and vote on the release of this cordova-plugin-wkwebview release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10149 The plugins have been published to dist/dev:

Re: [DISCUSS] CLI Templates

2015-12-04 Thread Carlos Santana
Michael Links to PRs where available for a while on the proposal. https://github.com/apache/cordova-lib/pull/339 https://github.com/apache/cordova-cli/pull/226 On Fri, Dec 4, 2015 at 11:33 AM Michael Brooks wrote: > I'd love to see a pull request rather than a