[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-labs/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Shazron]

A regular `tar -cvzf` the missing folders are included, it's just `npm
pack` not liking my local repo for some reason.

On Tue, Dec 8, 2015 at 3:51 AM, Shazron  wrote:
> This is certainly bizarre.
>
> I've verified that my local repo copy of the cordova-ios 4.0.x branch
> does have those modules, then ran "npm pack" on the repo folder (which
> coho create-archive calls):
>
> 
> [cordova-ios (4.0.x)]$ npm pack --verbose
> npm info it worked if it ends with ok
> npm verb cli [ '/Users/shazron/.nvm/versions/node/v0.12.7/bin/node',
> npm verb cli   '/Users/shazron/.nvm/versions/node/v0.12.7/bin/npm',
> npm verb cli   'pack',
> npm verb cli   '--verbose' ]
> npm info using npm@2.11.3
> npm info using node@v0.12.7
> npm verb cache add spec .
> npm verb addLocalDirectory
> /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz not in flight;
> packing
> npm verb tar pack [ '/Users/shazron/.npm/cordova-ios/4.0.0/package.tgz',
> npm verb tar pack   '/Users/shazron/Documents/git/apache/cordova-ios' ]
> npm verb tarball /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
> npm verb folder /Users/shazron/Documents/git/apache/cordova-ios
> npm info prepublish cordova-ios@4.0.0
> npm verb addLocalTarball adding from inside cache
> /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
> npm verb afterAdd
> /Users/shazron/.npm/cordova-ios/4.0.0/package/package.json not in
> flight; writing
> npm verb afterAdd
> /Users/shazron/.npm/cordova-ios/4.0.0/package/package.json written
> cordova-ios-4.0.0.tgz
> npm verb exit [ 0, true ]
> npm info ok
> ---
>
> After expanding the .tgz I found that the modules mentioned are *not*
> there, but I don't know why.
>
> However, when I check out a fresh copy of cordova-ios and "npm pack"
> the 4.0.x branch there, the modules *are* there in the .tgz! Chalk
> this one up to the C-Files (cue X-Files theme).
>
>
>
> On Mon, Dec 7, 2015 at 6:05 PM, Carlos Santana  wrote:
>> Currently finding a discrepancy when recreating the archive
>>
>> The tgz dist/ [1] is missing 3 node modules, they are located in git [2]
>> Running the command coho create-archive --tag 4.0.0 -r ios --dest test-ios4/
>> I ran with npm@2.11.3 and npm@3.3.12 and was able to get all three in
>> expected location
>>
>> bin/node_modules/cordova-common/node_modules/glob
>> bin/node_modules/cordova-common/node_modules/q
>> bin/node_modules/ios-sim/node_modules/nopt
>>
>> [1]:
>> https://dist.apache.org/repos/dist/dev/cordova/CB-10147/cordova-ios-4.0.0.tgz
>> [2]: https://github.com/apache/cordova-ios/tree/4.0.0/bin/node_modules
>>
>>
>>
>>
>> On Mon, Dec 7, 2015 at 7:12 PM Carlos Santana  wrote:
>>
>>> Currently working on it...
>>>
>>> - Carlos
>>> @csantanapr
>>>
>>> > On Dec 7, 2015, at 6:50 PM, Steven Gill  wrote:
>>> >
>>> > both ios@4 and cordova-plugin-wkwebviewengine need 1 more vote. Someone
>>> > step up so Shaz can wrap up the vote threads and publish these!
>>> >
>>> >> On Fri, Dec 4, 2015 at 2:07 PM, Carlos Santana 
>>> wrote:
>>> >>
>>> >> +1
>>> >>
>>> >>> On Fri, Dec 4, 2015 at 3:07 PM Shazron  wrote:
>>> >>>
>>> >>> After working out some bridge improvements and fixing some Platform
>>> >>> API bugs and testing, I believe it's ready. I'll start a [VOTE] thread
>>> >>> soon.
>>> >>>
>>> >>> On Thu, Dec 3, 2015 at 5:19 PM, Carlos Santana 
>>> >>> wrote:
>>>  +1 let's move forward this items with WKWebview I don't see holding up
>>> >>> the
>>>  platform.
>>> 
>>>  Don't see any changes going on the platform, if any they will go into
>>> >> the
>>>  pluggable webview plugin or creating new plugin to handle.
>>> > On Wed, Dec 2, 2015 at 8:40 PM Shazron  wrote:
>>> >
>>> > Regarding Platform API, Vladimir Kotikov and Sergey Grebnov agree in
>>> > the PR comments that the changes can go in to cordova-ios-4.x:
>>> > https://github.com/apache/cordova-ios/pull/176
>>> >
>>> >> On Wed, Dec 2, 2015 at 5:38 PM, Shazron  wrote:
>>> >> Also, check footnote 3 above.
>>> >>
>>> >> Yes, WebKit defines window.openDatabase but it doesn't do anything.
>>> >> Not sure why their tests didn't catch this... (see footnote for the
>>> >> bug)
>>> >>
>>> >> With CSP off to rule things out:
>>> >> XHR to yourself of course works, but doesn't really make sense for
>>> >> real-world use. XHR to a sibling file, parent file, or any child
>>> >> file
>>> >> results in the error ""Cross origin requests are only supported for
>>> >> HTTP”.
>>> >>
>>> >> To illustrate:
>>> >>
>>> >>  |
>>> >> parent.xml
>>> >>  |
>>> >> www
>>> >>  | index.html (file currently loaded)
>>> >>  | sibling.xml
>>> >>  | child-folder
>>> >>  |   | child.xml
>>> >>
>>> >> index.html is the currently loaded file in the WebView. 

[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

[TimBarham]

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-windows/pull/132#issuecomment-162867249
  
Generally looks fine to me apart from some misplaced "Android" references I 
mention inline. Also, it concerns me that `ConsoleLogger` is duplicated across 
each platform - isn't this something that can live in `cordova-common`? Why 
aren't we using the same functionality as `cordova-cli`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Shazron]

This is certainly bizarre.

I've verified that my local repo copy of the cordova-ios 4.0.x branch
does have those modules, then ran "npm pack" on the repo folder (which
coho create-archive calls):


[cordova-ios (4.0.x)]$ npm pack --verbose
npm info it worked if it ends with ok
npm verb cli [ '/Users/shazron/.nvm/versions/node/v0.12.7/bin/node',
npm verb cli   '/Users/shazron/.nvm/versions/node/v0.12.7/bin/npm',
npm verb cli   'pack',
npm verb cli   '--verbose' ]
npm info using npm@2.11.3
npm info using node@v0.12.7
npm verb cache add spec .
npm verb addLocalDirectory
/Users/shazron/.npm/cordova-ios/4.0.0/package.tgz not in flight;
packing
npm verb tar pack [ '/Users/shazron/.npm/cordova-ios/4.0.0/package.tgz',
npm verb tar pack   '/Users/shazron/Documents/git/apache/cordova-ios' ]
npm verb tarball /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
npm verb folder /Users/shazron/Documents/git/apache/cordova-ios
npm info prepublish cordova-ios@4.0.0
npm verb addLocalTarball adding from inside cache
/Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
npm verb afterAdd
/Users/shazron/.npm/cordova-ios/4.0.0/package/package.json not in
flight; writing
npm verb afterAdd
/Users/shazron/.npm/cordova-ios/4.0.0/package/package.json written
cordova-ios-4.0.0.tgz
npm verb exit [ 0, true ]
npm info ok
---

After expanding the .tgz I found that the modules mentioned are *not*
there, but I don't know why.

However, when I check out a fresh copy of cordova-ios and "npm pack"
the 4.0.x branch there, the modules *are* there in the .tgz! Chalk
this one up to the C-Files (cue X-Files theme).



On Mon, Dec 7, 2015 at 6:05 PM, Carlos Santana  wrote:
> Currently finding a discrepancy when recreating the archive
>
> The tgz dist/ [1] is missing 3 node modules, they are located in git [2]
> Running the command coho create-archive --tag 4.0.0 -r ios --dest test-ios4/
> I ran with npm@2.11.3 and npm@3.3.12 and was able to get all three in
> expected location
>
> bin/node_modules/cordova-common/node_modules/glob
> bin/node_modules/cordova-common/node_modules/q
> bin/node_modules/ios-sim/node_modules/nopt
>
> [1]:
> https://dist.apache.org/repos/dist/dev/cordova/CB-10147/cordova-ios-4.0.0.tgz
> [2]: https://github.com/apache/cordova-ios/tree/4.0.0/bin/node_modules
>
>
>
>
> On Mon, Dec 7, 2015 at 7:12 PM Carlos Santana  wrote:
>
>> Currently working on it...
>>
>> - Carlos
>> @csantanapr
>>
>> > On Dec 7, 2015, at 6:50 PM, Steven Gill  wrote:
>> >
>> > both ios@4 and cordova-plugin-wkwebviewengine need 1 more vote. Someone
>> > step up so Shaz can wrap up the vote threads and publish these!
>> >
>> >> On Fri, Dec 4, 2015 at 2:07 PM, Carlos Santana 
>> wrote:
>> >>
>> >> +1
>> >>
>> >>> On Fri, Dec 4, 2015 at 3:07 PM Shazron  wrote:
>> >>>
>> >>> After working out some bridge improvements and fixing some Platform
>> >>> API bugs and testing, I believe it's ready. I'll start a [VOTE] thread
>> >>> soon.
>> >>>
>> >>> On Thu, Dec 3, 2015 at 5:19 PM, Carlos Santana 
>> >>> wrote:
>>  +1 let's move forward this items with WKWebview I don't see holding up
>> >>> the
>>  platform.
>> 
>>  Don't see any changes going on the platform, if any they will go into
>> >> the
>>  pluggable webview plugin or creating new plugin to handle.
>> > On Wed, Dec 2, 2015 at 8:40 PM Shazron  wrote:
>> >
>> > Regarding Platform API, Vladimir Kotikov and Sergey Grebnov agree in
>> > the PR comments that the changes can go in to cordova-ios-4.x:
>> > https://github.com/apache/cordova-ios/pull/176
>> >
>> >> On Wed, Dec 2, 2015 at 5:38 PM, Shazron  wrote:
>> >> Also, check footnote 3 above.
>> >>
>> >> Yes, WebKit defines window.openDatabase but it doesn't do anything.
>> >> Not sure why their tests didn't catch this... (see footnote for the
>> >> bug)
>> >>
>> >> With CSP off to rule things out:
>> >> XHR to yourself of course works, but doesn't really make sense for
>> >> real-world use. XHR to a sibling file, parent file, or any child
>> >> file
>> >> results in the error ""Cross origin requests are only supported for
>> >> HTTP”.
>> >>
>> >> To illustrate:
>> >>
>> >>  |
>> >> parent.xml
>> >>  |
>> >> www
>> >>  | index.html (file currently loaded)
>> >>  | sibling.xml
>> >>  | child-folder
>> >>  |   | child.xml
>> >>
>> >> index.html is the currently loaded file in the WebView. From it, you
>> >> can't load parent.xml, sibling.xml nor child.xml using XHR according
>> >> to my tests.
>> >>
>> >> Regarding *why* we have these storage tests, that is out of scope
>> >> for
>> >> this discussion, but I agree.
>> >>
>> >>
>> >> On Wed, Dec 2, 2015 at 6:37 AM, Carlos Santana <
>> >> 

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Carlos Santana]

Thanks for the update
Did you said you tried a new directory via clone

What about updating to latest npm@2.x ?
On Tue, Dec 8, 2015 at 7:16 AM Shazron  wrote:

> A regular `tar -cvzf` the missing folders are included, it's just `npm
> pack` not liking my local repo for some reason.
>
> On Tue, Dec 8, 2015 at 3:51 AM, Shazron  wrote:
> > This is certainly bizarre.
> >
> > I've verified that my local repo copy of the cordova-ios 4.0.x branch
> > does have those modules, then ran "npm pack" on the repo folder (which
> > coho create-archive calls):
> >
> > 
> > [cordova-ios (4.0.x)]$ npm pack --verbose
> > npm info it worked if it ends with ok
> > npm verb cli [ '/Users/shazron/.nvm/versions/node/v0.12.7/bin/node',
> > npm verb cli   '/Users/shazron/.nvm/versions/node/v0.12.7/bin/npm',
> > npm verb cli   'pack',
> > npm verb cli   '--verbose' ]
> > npm info using npm@2.11.3
> > npm info using node@v0.12.7
> > npm verb cache add spec .
> > npm verb addLocalDirectory
> > /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz not in flight;
> > packing
> > npm verb tar pack [ '/Users/shazron/.npm/cordova-ios/4.0.0/package.tgz',
> > npm verb tar pack   '/Users/shazron/Documents/git/apache/cordova-ios' ]
> > npm verb tarball /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
> > npm verb folder /Users/shazron/Documents/git/apache/cordova-ios
> > npm info prepublish cordova-ios@4.0.0
> > npm verb addLocalTarball adding from inside cache
> > /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
> > npm verb afterAdd
> > /Users/shazron/.npm/cordova-ios/4.0.0/package/package.json not in
> > flight; writing
> > npm verb afterAdd
> > /Users/shazron/.npm/cordova-ios/4.0.0/package/package.json written
> > cordova-ios-4.0.0.tgz
> > npm verb exit [ 0, true ]
> > npm info ok
> > ---
> >
> > After expanding the .tgz I found that the modules mentioned are *not*
> > there, but I don't know why.
> >
> > However, when I check out a fresh copy of cordova-ios and "npm pack"
> > the 4.0.x branch there, the modules *are* there in the .tgz! Chalk
> > this one up to the C-Files (cue X-Files theme).
> >
> >
> >
> > On Mon, Dec 7, 2015 at 6:05 PM, Carlos Santana 
> wrote:
> >> Currently finding a discrepancy when recreating the archive
> >>
> >> The tgz dist/ [1] is missing 3 node modules, they are located in git [2]
> >> Running the command coho create-archive --tag 4.0.0 -r ios --dest
> test-ios4/
> >> I ran with npm@2.11.3 and npm@3.3.12 and was able to get all three in
> >> expected location
> >>
> >> bin/node_modules/cordova-common/node_modules/glob
> >> bin/node_modules/cordova-common/node_modules/q
> >> bin/node_modules/ios-sim/node_modules/nopt
> >>
> >> [1]:
> >>
> https://dist.apache.org/repos/dist/dev/cordova/CB-10147/cordova-ios-4.0.0.tgz
> >> [2]: https://github.com/apache/cordova-ios/tree/4.0.0/bin/node_modules
> >>
> >>
> >>
> >>
> >> On Mon, Dec 7, 2015 at 7:12 PM Carlos Santana 
> wrote:
> >>
> >>> Currently working on it...
> >>>
> >>> - Carlos
> >>> @csantanapr
> >>>
> >>> > On Dec 7, 2015, at 6:50 PM, Steven Gill 
> wrote:
> >>> >
> >>> > both ios@4 and cordova-plugin-wkwebviewengine need 1 more vote.
> Someone
> >>> > step up so Shaz can wrap up the vote threads and publish these!
> >>> >
> >>> >> On Fri, Dec 4, 2015 at 2:07 PM, Carlos Santana <
> csantan...@gmail.com>
> >>> wrote:
> >>> >>
> >>> >> +1
> >>> >>
> >>> >>> On Fri, Dec 4, 2015 at 3:07 PM Shazron  wrote:
> >>> >>>
> >>> >>> After working out some bridge improvements and fixing some Platform
> >>> >>> API bugs and testing, I believe it's ready. I'll start a [VOTE]
> thread
> >>> >>> soon.
> >>> >>>
> >>> >>> On Thu, Dec 3, 2015 at 5:19 PM, Carlos Santana <
> csantan...@gmail.com>
> >>> >>> wrote:
> >>>  +1 let's move forward this items with WKWebview I don't see
> holding up
> >>> >>> the
> >>>  platform.
> >>> 
> >>>  Don't see any changes going on the platform, if any they will go
> into
> >>> >> the
> >>>  pluggable webview plugin or creating new plugin to handle.
> >>> > On Wed, Dec 2, 2015 at 8:40 PM Shazron 
> wrote:
> >>> >
> >>> > Regarding Platform API, Vladimir Kotikov and Sergey Grebnov
> agree in
> >>> > the PR comments that the changes can go in to cordova-ios-4.x:
> >>> > https://github.com/apache/cordova-ios/pull/176
> >>> >
> >>> >> On Wed, Dec 2, 2015 at 5:38 PM, Shazron 
> wrote:
> >>> >> Also, check footnote 3 above.
> >>> >>
> >>> >> Yes, WebKit defines window.openDatabase but it doesn't do
> anything.
> >>> >> Not sure why their tests didn't catch this... (see footnote for
> the
> >>> >> bug)
> >>> >>
> >>> >> With CSP off to rule things out:
> >>> >> XHR to yourself of course works, but doesn't really make sense
> for
> >>> >> real-world use. XHR to a sibling file, parent file, or any child
> >>> 

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Shazron]

Mystery solved.

cordova-ios has devDependencies in the root package.josn. This will
install a "node_modules" in the root, which npm pack will ignore and
git will as well (since it is in the .gitignore). However, even though
it is not packed, it will affect 'npm pack', as I will explain...

I hadn't run "npm install" in a while, and I had q, nopt, and glob in
there from a previous "bundledDependencies":
https://github.com/apache/cordova-ios/commit/a56cb22ee3f60f9c71abcf200aec1e96e324e343

So when I ran 'npm pack', this affected the packing of nested
node_modules because at the root those modules where there. I think.

If I ran a fresh "npm install" at the root, 'npm pack` seems fine (the
missing folders are there) but because of this weird behaviour I think
we should run `npm pack` without the root `node_modules`.

Any other explanation on what's going on, and what's the best way to
fix this? (npm install, then npm pack? or remove root node_modules?).
I'd rather find an "automated" way through coho rather than do this
manually just in case it happens again. Removing root node_modules
won't work in the generic case since cordova-android has
bundledDependencies.

I tried using .npmignore and it didn't work (at least for npm@2.11.3)

On Tue, Dec 8, 2015 at 4:10 AM, Shazron  wrote:
> A regular `tar -cvzf` the missing folders are included, it's just `npm
> pack` not liking my local repo for some reason.
>
> On Tue, Dec 8, 2015 at 3:51 AM, Shazron  wrote:
>> This is certainly bizarre.
>>
>> I've verified that my local repo copy of the cordova-ios 4.0.x branch
>> does have those modules, then ran "npm pack" on the repo folder (which
>> coho create-archive calls):
>>
>> 
>> [cordova-ios (4.0.x)]$ npm pack --verbose
>> npm info it worked if it ends with ok
>> npm verb cli [ '/Users/shazron/.nvm/versions/node/v0.12.7/bin/node',
>> npm verb cli   '/Users/shazron/.nvm/versions/node/v0.12.7/bin/npm',
>> npm verb cli   'pack',
>> npm verb cli   '--verbose' ]
>> npm info using npm@2.11.3
>> npm info using node@v0.12.7
>> npm verb cache add spec .
>> npm verb addLocalDirectory
>> /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz not in flight;
>> packing
>> npm verb tar pack [ '/Users/shazron/.npm/cordova-ios/4.0.0/package.tgz',
>> npm verb tar pack   '/Users/shazron/Documents/git/apache/cordova-ios' ]
>> npm verb tarball /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
>> npm verb folder /Users/shazron/Documents/git/apache/cordova-ios
>> npm info prepublish cordova-ios@4.0.0
>> npm verb addLocalTarball adding from inside cache
>> /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
>> npm verb afterAdd
>> /Users/shazron/.npm/cordova-ios/4.0.0/package/package.json not in
>> flight; writing
>> npm verb afterAdd
>> /Users/shazron/.npm/cordova-ios/4.0.0/package/package.json written
>> cordova-ios-4.0.0.tgz
>> npm verb exit [ 0, true ]
>> npm info ok
>> ---
>>
>> After expanding the .tgz I found that the modules mentioned are *not*
>> there, but I don't know why.
>>
>> However, when I check out a fresh copy of cordova-ios and "npm pack"
>> the 4.0.x branch there, the modules *are* there in the .tgz! Chalk
>> this one up to the C-Files (cue X-Files theme).
>>
>>
>>
>> On Mon, Dec 7, 2015 at 6:05 PM, Carlos Santana  wrote:
>>> Currently finding a discrepancy when recreating the archive
>>>
>>> The tgz dist/ [1] is missing 3 node modules, they are located in git [2]
>>> Running the command coho create-archive --tag 4.0.0 -r ios --dest test-ios4/
>>> I ran with npm@2.11.3 and npm@3.3.12 and was able to get all three in
>>> expected location
>>>
>>> bin/node_modules/cordova-common/node_modules/glob
>>> bin/node_modules/cordova-common/node_modules/q
>>> bin/node_modules/ios-sim/node_modules/nopt
>>>
>>> [1]:
>>> https://dist.apache.org/repos/dist/dev/cordova/CB-10147/cordova-ios-4.0.0.tgz
>>> [2]: https://github.com/apache/cordova-ios/tree/4.0.0/bin/node_modules
>>>
>>>
>>>
>>>
>>> On Mon, Dec 7, 2015 at 7:12 PM Carlos Santana  wrote:
>>>
 Currently working on it...

 - Carlos
 @csantanapr

 > On Dec 7, 2015, at 6:50 PM, Steven Gill  wrote:
 >
 > both ios@4 and cordova-plugin-wkwebviewengine need 1 more vote. Someone
 > step up so Shaz can wrap up the vote threads and publish these!
 >
 >> On Fri, Dec 4, 2015 at 2:07 PM, Carlos Santana 
 wrote:
 >>
 >> +1
 >>
 >>> On Fri, Dec 4, 2015 at 3:07 PM Shazron  wrote:
 >>>
 >>> After working out some bridge improvements and fixing some Platform
 >>> API bugs and testing, I believe it's ready. I'll start a [VOTE] thread
 >>> soon.
 >>>
 >>> On Thu, Dec 3, 2015 at 5:19 PM, Carlos Santana 
 >>> wrote:
  +1 let's move forward this items with WKWebview I don't see holding up
 >>> the
  platform.
 
  

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Shazron]

I removed the root node_modules in cordova-ios, and re-created the
archive. They are re-published at:
https://dist.apache.org/repos/dist/dev/cordova/CB-10147


On Tue, Dec 8, 2015 at 5:12 AM, Carlos Santana  wrote:
> Wow good find !
>
> I some times do a rm -r node_modules then npm install before running coho 
> create-archive, but not all the time. So I can see this happening
>
> I agree we should automate this in coho.
>
> The coho create-archive should clean node_modules for repo ios only, or also 
> do rm and then an npm install --production for each repo in the specific way 
> for each repo
>
> - Carlos
> @csantanapr
>
>> On Dec 8, 2015, at 7:55 AM, Shazron  wrote:
>>
>> Mystery solved.
>>
>> cordova-ios has devDependencies in the root package.josn. This will
>> install a "node_modules" in the root, which npm pack will ignore and
>> git will as well (since it is in the .gitignore). However, even though
>> it is not packed, it will affect 'npm pack', as I will explain...
>>
>> I hadn't run "npm install" in a while, and I had q, nopt, and glob in
>> there from a previous "bundledDependencies":
>> https://github.com/apache/cordova-ios/commit/a56cb22ee3f60f9c71abcf200aec1e96e324e343
>>
>> So when I ran 'npm pack', this affected the packing of nested
>> node_modules because at the root those modules where there. I think.
>>
>> If I ran a fresh "npm install" at the root, 'npm pack` seems fine (the
>> missing folders are there) but because of this weird behaviour I think
>> we should run `npm pack` without the root `node_modules`.
>>
>> Any other explanation on what's going on, and what's the best way to
>> fix this? (npm install, then npm pack? or remove root node_modules?).
>> I'd rather find an "automated" way through coho rather than do this
>> manually just in case it happens again. Removing root node_modules
>> won't work in the generic case since cordova-android has
>> bundledDependencies.
>>
>> I tried using .npmignore and it didn't work (at least for npm@2.11.3)
>>
>>> On Tue, Dec 8, 2015 at 4:10 AM, Shazron  wrote:
>>> A regular `tar -cvzf` the missing folders are included, it's just `npm
>>> pack` not liking my local repo for some reason.
>>>
 On Tue, Dec 8, 2015 at 3:51 AM, Shazron  wrote:
 This is certainly bizarre.

 I've verified that my local repo copy of the cordova-ios 4.0.x branch
 does have those modules, then ran "npm pack" on the repo folder (which
 coho create-archive calls):

 
 [cordova-ios (4.0.x)]$ npm pack --verbose
 npm info it worked if it ends with ok
 npm verb cli [ '/Users/shazron/.nvm/versions/node/v0.12.7/bin/node',
 npm verb cli   '/Users/shazron/.nvm/versions/node/v0.12.7/bin/npm',
 npm verb cli   'pack',
 npm verb cli   '--verbose' ]
 npm info using npm@2.11.3
 npm info using node@v0.12.7
 npm verb cache add spec .
 npm verb addLocalDirectory
 /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz not in flight;
 packing
 npm verb tar pack [ '/Users/shazron/.npm/cordova-ios/4.0.0/package.tgz',
 npm verb tar pack   '/Users/shazron/Documents/git/apache/cordova-ios' ]
 npm verb tarball /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
 npm verb folder /Users/shazron/Documents/git/apache/cordova-ios
 npm info prepublish cordova-ios@4.0.0
 npm verb addLocalTarball adding from inside cache
 /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
 npm verb afterAdd
 /Users/shazron/.npm/cordova-ios/4.0.0/package/package.json not in
 flight; writing
 npm verb afterAdd
 /Users/shazron/.npm/cordova-ios/4.0.0/package/package.json written
 cordova-ios-4.0.0.tgz
 npm verb exit [ 0, true ]
 npm info ok
 ---

 After expanding the .tgz I found that the modules mentioned are *not*
 there, but I don't know why.

 However, when I check out a fresh copy of cordova-ios and "npm pack"
 the 4.0.x branch there, the modules *are* there in the .tgz! Chalk
 this one up to the C-Files (cue X-Files theme).



> On Mon, Dec 7, 2015 at 6:05 PM, Carlos Santana  
> wrote:
> Currently finding a discrepancy when recreating the archive
>
> The tgz dist/ [1] is missing 3 node modules, they are located in git [2]
> Running the command coho create-archive --tag 4.0.0 -r ios --dest 
> test-ios4/
> I ran with npm@2.11.3 and npm@3.3.12 and was able to get all three in
> expected location
>
> bin/node_modules/cordova-common/node_modules/glob
> bin/node_modules/cordova-common/node_modules/q
> bin/node_modules/ios-sim/node_modules/nopt
>
> [1]:
> https://dist.apache.org/repos/dist/dev/cordova/CB-10147/cordova-ios-4.0.0.tgz
> [2]: https://github.com/apache/cordova-ios/tree/4.0.0/bin/node_modules
>
>
>
>
>> On Mon, Dec 7, 2015 at 7:12 PM Carlos Santana 

Re: [VOTE] 4.0.0 iOS Release

[Carlos Santana]

+1

Ran mobile-spec
Ran coho verify-archive
Ran coho create-archive and compare contents with dist tgz
Ran coho verify-tags
Created hello world app



On Mon, Dec 7, 2015 at 6:52 PM Steven Gill  wrote:

> +1
>
> * Ran mobile-spec. only file-transfer failed which was expected
> * Ran coho verify-archive
> * Ran coho audit-license-headers
>
> On Fri, Dec 4, 2015 at 5:33 PM, Shazron  wrote:
>
> > Please review and vote on this 4.0.0 iOS Release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-10147
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-10147
> >
> > The package was published from its corresponding git tag:
> > cordova-ios: 4.0.0 (9b042efdb7)
> >
> > Note that you can test it out via:
> >
> > cordova platform add
> > https://git-wip-us.apache.org/repos/asf/cordova-ios.git#4.0.0
> >
> > Upon a successful vote I will upload the archive to dist/, publish it
> > to npm, and post the blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ensured it passed mobile-spec (using my personal file-transfer
> > server) when repo was tagged (since cordova-vm.a.o is down)
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Carlos Santana]

Wow good find !

I some times do a rm -r node_modules then npm install before running coho 
create-archive, but not all the time. So I can see this happening 

I agree we should automate this in coho. 

The coho create-archive should clean node_modules for repo ios only, or also do 
rm and then an npm install --production for each repo in the specific way for 
each repo

- Carlos
@csantanapr

> On Dec 8, 2015, at 7:55 AM, Shazron  wrote:
> 
> Mystery solved.
> 
> cordova-ios has devDependencies in the root package.josn. This will
> install a "node_modules" in the root, which npm pack will ignore and
> git will as well (since it is in the .gitignore). However, even though
> it is not packed, it will affect 'npm pack', as I will explain...
> 
> I hadn't run "npm install" in a while, and I had q, nopt, and glob in
> there from a previous "bundledDependencies":
> https://github.com/apache/cordova-ios/commit/a56cb22ee3f60f9c71abcf200aec1e96e324e343
> 
> So when I ran 'npm pack', this affected the packing of nested
> node_modules because at the root those modules where there. I think.
> 
> If I ran a fresh "npm install" at the root, 'npm pack` seems fine (the
> missing folders are there) but because of this weird behaviour I think
> we should run `npm pack` without the root `node_modules`.
> 
> Any other explanation on what's going on, and what's the best way to
> fix this? (npm install, then npm pack? or remove root node_modules?).
> I'd rather find an "automated" way through coho rather than do this
> manually just in case it happens again. Removing root node_modules
> won't work in the generic case since cordova-android has
> bundledDependencies.
> 
> I tried using .npmignore and it didn't work (at least for npm@2.11.3)
> 
>> On Tue, Dec 8, 2015 at 4:10 AM, Shazron  wrote:
>> A regular `tar -cvzf` the missing folders are included, it's just `npm
>> pack` not liking my local repo for some reason.
>> 
>>> On Tue, Dec 8, 2015 at 3:51 AM, Shazron  wrote:
>>> This is certainly bizarre.
>>> 
>>> I've verified that my local repo copy of the cordova-ios 4.0.x branch
>>> does have those modules, then ran "npm pack" on the repo folder (which
>>> coho create-archive calls):
>>> 
>>> 
>>> [cordova-ios (4.0.x)]$ npm pack --verbose
>>> npm info it worked if it ends with ok
>>> npm verb cli [ '/Users/shazron/.nvm/versions/node/v0.12.7/bin/node',
>>> npm verb cli   '/Users/shazron/.nvm/versions/node/v0.12.7/bin/npm',
>>> npm verb cli   'pack',
>>> npm verb cli   '--verbose' ]
>>> npm info using npm@2.11.3
>>> npm info using node@v0.12.7
>>> npm verb cache add spec .
>>> npm verb addLocalDirectory
>>> /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz not in flight;
>>> packing
>>> npm verb tar pack [ '/Users/shazron/.npm/cordova-ios/4.0.0/package.tgz',
>>> npm verb tar pack   '/Users/shazron/Documents/git/apache/cordova-ios' ]
>>> npm verb tarball /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
>>> npm verb folder /Users/shazron/Documents/git/apache/cordova-ios
>>> npm info prepublish cordova-ios@4.0.0
>>> npm verb addLocalTarball adding from inside cache
>>> /Users/shazron/.npm/cordova-ios/4.0.0/package.tgz
>>> npm verb afterAdd
>>> /Users/shazron/.npm/cordova-ios/4.0.0/package/package.json not in
>>> flight; writing
>>> npm verb afterAdd
>>> /Users/shazron/.npm/cordova-ios/4.0.0/package/package.json written
>>> cordova-ios-4.0.0.tgz
>>> npm verb exit [ 0, true ]
>>> npm info ok
>>> ---
>>> 
>>> After expanding the .tgz I found that the modules mentioned are *not*
>>> there, but I don't know why.
>>> 
>>> However, when I check out a fresh copy of cordova-ios and "npm pack"
>>> the 4.0.x branch there, the modules *are* there in the .tgz! Chalk
>>> this one up to the C-Files (cue X-Files theme).
>>> 
>>> 
>>> 
 On Mon, Dec 7, 2015 at 6:05 PM, Carlos Santana  
 wrote:
 Currently finding a discrepancy when recreating the archive
 
 The tgz dist/ [1] is missing 3 node modules, they are located in git [2]
 Running the command coho create-archive --tag 4.0.0 -r ios --dest 
 test-ios4/
 I ran with npm@2.11.3 and npm@3.3.12 and was able to get all three in
 expected location
 
 bin/node_modules/cordova-common/node_modules/glob
 bin/node_modules/cordova-common/node_modules/q
 bin/node_modules/ios-sim/node_modules/nopt
 
 [1]:
 https://dist.apache.org/repos/dist/dev/cordova/CB-10147/cordova-ios-4.0.0.tgz
 [2]: https://github.com/apache/cordova-ios/tree/4.0.0/bin/node_modules
 
 
 
 
> On Mon, Dec 7, 2015 at 7:12 PM Carlos Santana  
> wrote:
> 
> Currently working on it...
> 
> - Carlos
> @csantanapr
> 
>> On Dec 7, 2015, at 6:50 PM, Steven Gill  wrote:
>> 
>> both ios@4 and cordova-plugin-wkwebviewengine need 1 more vote. Someone
>> step up so Shaz can wrap up the vote threads 

Re: [VOTE] 4.0.0 iOS Release

[Shazron]

The vote has now closed. The results are:

Positive Binding Votes: 3

Shazron Abdullah
Steve Gill
Carlos Santana

Negative Binding Votes: 0

The vote has passed. I will now publish to dist and npm.


On Tue, Dec 8, 2015 at 5:29 AM, Carlos Santana  wrote:
> +1
>
> Ran mobile-spec
> Ran coho verify-archive
> Ran coho create-archive and compare contents with dist tgz
> Ran coho verify-tags
> Created hello world app
>
>
>
> On Mon, Dec 7, 2015 at 6:52 PM Steven Gill  wrote:
>
>> +1
>>
>> * Ran mobile-spec. only file-transfer failed which was expected
>> * Ran coho verify-archive
>> * Ran coho audit-license-headers
>>
>> On Fri, Dec 4, 2015 at 5:33 PM, Shazron  wrote:
>>
>> > Please review and vote on this 4.0.0 iOS Release
>> > by replying to this email (and keep discussion on the DISCUSS thread)
>> >
>> > Release issue: https://issues.apache.org/jira/browse/CB-10147
>> >
>> > The archive has been published to dist/dev:
>> > https://dist.apache.org/repos/dist/dev/cordova/CB-10147
>> >
>> > The package was published from its corresponding git tag:
>> > cordova-ios: 4.0.0 (9b042efdb7)
>> >
>> > Note that you can test it out via:
>> >
>> > cordova platform add
>> > https://git-wip-us.apache.org/repos/asf/cordova-ios.git#4.0.0
>> >
>> > Upon a successful vote I will upload the archive to dist/, publish it
>> > to npm, and post the blog post.
>> >
>> > Voting guidelines:
>> >
>> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>> >
>> > Voting will go on for a minimum of 48 hours.
>> >
>> > I vote +1:
>> > * Ran coho audit-license-headers over the relevant repos
>> > * Ran coho check-license to ensure all dependencies and
>> > subdependencies have Apache-compatible licenses
>> > * Ensured it passed mobile-spec (using my personal file-transfer
>> > server) when repo was tagged (since cordova-vm.a.o is down)
>> >
>> > -
>> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> > For additional commands, e-mail: dev-h...@cordova.apache.org
>> >
>> >
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] cordova-plugin-wkwebview-engine 1.0.0 release

[Shazron]

The vote has now closed. The results are:

Positive Binding Votes: 3

Shazron Abdullah
Steve Gill
Carlos Santana

Negative Binding Votes: 0

The vote has passed. I will now publish to dist and npm.


On Mon, Dec 7, 2015 at 6:33 PM, Carlos Santana  wrote:
> +1
>
> - Created hello world app
> - coho verify-tag
> - coho verify-archive
> - coho create-archive and compare with dist
>
>
> On Mon, Dec 7, 2015 at 6:45 PM Steven Gill  wrote:
>
>> +1
>>
>> * Built a hello world app with it
>> * Ran coho verify-archive
>> * Ran audit-license-headers
>>
>> On Fri, Dec 4, 2015 at 6:11 PM, Shazron  wrote:
>>
>> > Please review and vote on the release of this cordova-plugin-wkwebview
>> > release
>> > by replying to this email (and keep discussion on the DISCUSS thread)
>> >
>> > Release issue: https://issues.apache.org/jira/browse/CB-10149
>> >
>> > The plugins have been published to dist/dev:
>> > https://dist.apache.org/repos/dist/dev/cordova/CB-10149/
>> >
>> > The packages were published from their corresponding git tags:
>> > cordova-plugin-wkwebview-engine: 1.0.0 (357acd1778)
>> >
>> > Upon a successful vote I will upload the archives to dist/, upload
>> > them to the Plugins Registry, and post the corresponding blog post.
>> >
>> > Voting guidelines:
>> >
>> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>> >
>> > Voting will go on for a minimum of 48 hours.
>> >
>> > -
>> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> > For additional commands, e-mail: dev-h...@cordova.apache.org
>> >
>> >
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[REVIEW] cordova-ios 4.0.0 blog post

[Shazron]

Please review and comment:
https://github.com/apache/cordova-docs/pull/436

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-docs/pull/436

Add cordova-ios-4.0.0 release blog post announcement



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-docs cordova-ios-4-release

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #436


commit b250c653656f0401b908f454f32136b42adf55e1
Author: Shazron Abdullah 
Date:   2015-12-08T01:43:09Z

Add cordova-ios-4.0.0 release blog post announcement




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[dpogue]

Github user dpogue commented on the pull request:

https://github.com/apache/cordova-docs/pull/436#issuecomment-162914587
  
Might be good to include a line like "This is a major release, and 
deprecated APIs have been removed. Some 3rd party plugins might require updates 
before they are compatible."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-docs/pull/436#issuecomment-162931682
  
@csantanapr good points, I'll add those in. Not sure about point 4 though, 
xcconfig stuff is build artifacts, and we don't have the `` tag 
yet for this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-docs/pull/436#issuecomment-162933618
  
@shazron ah ok, maybe I was thinking 

oh what about whitelist stuff?

Any other high level feature?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-docs/pull/436#issuecomment-162934725
  
@csantanapr whitelist stuff is already mentioned.

Deployment target change -- yes. Too many other changes to list in one blog 
post, that's why there is a "breaking changes" link that lists all.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-docs/pull/436#issuecomment-162934923
  
ok, I went over the wholes changes, that's it I didn't find anything else


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [REVIEW] plugins release blog post for cordova-plugin-wkwebview

[Carlos Santana]

LGTM

On Tue, Dec 8, 2015 at 11:01 AM Shazron  wrote:

> Please review and comment:
> https://github.com/apache/cordova-docs/pull/437
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-docs/pull/436#issuecomment-162928849
  
@dpogue  Good idea, will add that in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-docs/pull/436#issuecomment-162930851
  
What about mentioning other some high level features:

1. Support Asset Catalog
2. ios-sim (will use internal version, no need to npm i -g ios-sim)
3. ios-deploy (get the latest version)
4. can handle new fields in config.xml (I'm making this up? like xxconfig 
additions)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-docs/pull/436#issuecomment-162934402
  
What about AppDelegate changes/moving?

What about minimum Deployment Target to iOS 8.0? What does this means for 
humans :-), no ios 7?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-docs/pull/436#issuecomment-162935928
  
Ok all changes integrated, for those latecomers here is the link to view 
all PR changes: 
https://github.com/shazron/cordova-docs/blob/cordova-ios-4-release/www/_posts/2015-12-08-cordova-ios-4.0.0.md



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[REVIEW] plugins release blog post for cordova-plugin-wkwebview

[Shazron]

Please review and comment:
https://github.com/apache/cordova-docs/pull/437

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/436


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-docs/pull/436#issuecomment-162974919
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] CLI Templates

[Carlos Santana]

Hi Dmitry
1.  It was discuss in the mailing list, that use case #1 was not need it,
and to be replace by --template, user don't have to have config.xml and
other cordova specific files they will be created. So the reason to
deprecate --copy-from
2.  yes it's similar to a cp or git clone, but also a download of npm, it
will replace app name and id if they are passed in to create command if
template contains config.xml they will get replace, no night mare not that
many files to add if template purposely missing just config.xml and empty
folders for hooks, plugins, platform. template should have a www and any
other files outside www they want in their template like res/resource/
 (cordova uses res, ionic uses resources, etc..) .gitignore, .editorconfig,
pacakge.json, etc.. any other files they which their app to have that
template will get them started with.


On Mon, Dec 7, 2015 at 11:10 PM Dmitry Blotsky 
wrote:

> Thanks for the summary, Carlos! Sorry, I hadn’t read the whole thread when
> I sent my question. I read up after your email, and I have a better grasp
> on it now. My new questions are below.
>
> 1. What is the `cordova create` command then doing if it’s copying
> (potentially) the whole app it’s trying to create? The `--copy-from` flag
> creates fresh copies of Cordova-specific files and only copies the `www`
> folder, which is app-agnostic anyway.
> 2. Isn’t the new flag basically the same as an invocation of `cp` or `git
> clone`? And if we’re going into the realm of examining the template and
> “filling in” potentially missing files, isn’t that a logical nightmare
> since there are so many possible things that could be missing in an app?
>
> Kindly,
> Dmitry
>
> > On Dec 5, 2015, at 7:00 AM, Carlos Santana  wrote:
> >
> > The email thread has the details but in summary:
> > It doesn't handle npm and git as source
> > It doesn't copy everything
> > By adding npm and git having the flag copy-from it's confusing.
> >
> > On Fri, Dec 4, 2015 at 9:04 PM Dmitry Blotsky 
> > wrote:
> >
> >> Hey folks. Sorry I'm late to the party, but why is `--copy-from` not
> >> sufficient?
> >>
> >> Kindly,
> >> Dmitry
> >>
> >> -Original Message-
> >> From: Carlos Santana [mailto:csantan...@gmail.com]
> >> Sent: Friday, December 4, 2015 10:09 AM
> >> To: dev@cordova.apache.org
> >> Subject: Re: [DISCUSS] CLI Templates
> >>
> >> Michael we will love to hear your feedback, and we can improve on top of
> >> what's initially there.
> >>
> >>
> >> On Fri, Dec 4, 2015 at 1:04 PM Carlos Santana 
> >> wrote:
> >>
> >>> Michael
> >>> Links to PRs where available for a while on the proposal.
> >>>
> >>> https://github.com/apache/cordova-lib/pull/339
> >>> https://github.com/apache/cordova-cli/pull/226
> >>>
> >>>
> >>> On Fri, Dec 4, 2015 at 11:33 AM Michael Brooks
> >>> 
> >>> wrote:
> >>>
>  I'd love to see a pull request rather than a straight up merge, since
>  the template discussion was more involved. Also, I'm really looking
>  forward to seeing your work on this!
> 
>  On Thu, Dec 3, 2015 at 9:47 AM, Carlos Santana 
>  wrote:
> 
> > I will be working later today with James from my team on merging
> > initial implementation of --template. it will update a few repos
> > (cli, lib, doc)
> >
> > Anyone oppose?
> >
> >
> > On Fri, Nov 13, 2015 at 1:50 PM Carlos Santana
> > 
> > wrote:
> >
> >> alias, deprecate and later remove
> >>
> >> On Fri, Nov 13, 2015 at 1:49 PM Carlos Santana
> >> 
> >> wrote:
> >>
> >>> I agree, --template is the new --copy-from :-)
> >>>
> >>>
> >>> On Fri, Nov 13, 2015 at 1:48 PM Shazron  wrote:
> >>>
>  Well, we could deprecate --copy-from, and alias --template to it.
>  But
>  we shouldn't have both, it should just be one implementation.
> 
>  On Fri, Nov 13, 2015 at 10:45 AM, Carlos Santana <
>  csantan...@gmail.com
> >>
>  wrote:
> > In some way we we are enhancing --copy-from
> >
> > I'm OK to the copy blindly even plugins and platforms, I was
>  trying
> > to
> > avoid people creating templates when is not need it if they
>  already
>  have
> > platforms and plugins
> > But I'm OK if we want to allow it, but I would not documented
> > :-)
>  it
>  just
> > happens to work
> >
> > but I don't like the "--copy-from" name, I want to use
>  "--template"
>  that
> > takes path, giturl, and npm name
> >
> >
> > On Fri, Nov 13, 2015 at 1:41 PM Carlos Santana <
>  csantan...@gmail.com
> >>
>  wrote:
> >
> >> What dynamic nature you want ?

[GitHub] cordova-cli pull request: CB-8455 added --nohooks option

[bso-intel]

GitHub user bso-intel opened a pull request:

https://github.com/apache/cordova-cli/pull/230

CB-8455 added --nohooks option

implemented --nohooks option described in CB-8455

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bso-intel/cordova-cli CB-8455

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #230


commit 9e8fdd146bd6c2bd6df12eb96ad806a46df1bb7f
Author: Byoungro So 
Date:   2015-12-08T04:50:11Z

added --nohooks option




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

[bso-intel]

GitHub user bso-intel opened a pull request:

https://github.com/apache/cordova-lib/pull/353

CB-8455 added --nohooks option

implemented --nohooks noption as described in CB-8455

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bso-intel/cordova-lib CB-8455

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #353


commit d77c2d27bbf785f1c2471156f36693e5ce06b9dd
Author: Byoungro So 
Date:   2015-12-08T04:53:43Z

added --nohooks option

commit f8a430ccf5fc1db7f555dcbbd84651c3da7ca5f6
Author: Byoungro So 
Date:   2015-12-08T04:53:43Z

CB-8455 added --nohooks option

commit b4be9c724a70d819975f50b615da9a7203ad85e5
Author: Byoungro So 
Date:   2015-12-08T05:04:03Z

Merge branch 'CB-8455' of https://github.com/bso-intel/cordova-lib into 
CB-8455




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add plugins release blog post for cordo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/437


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Deprecate cordova-wp8

[Parashuram N]

I pinged the folks here on VS team to get an idea of number of people building 
for WP8. Looks like this is still a significant number (more than 10%) and 
almost 2000 unique users building for WP8 per month. Can we delay the 
deprecation for 3 more months to see if this number can go down ? 

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Wednesday, December 2, 2015 11:06 AM
To: dev@cordova.apache.org
Subject: [DISCUSS] Deprecate cordova-wp8

We've talked about it for awhile, but never moved on it. cordova-wp8 has been a 
work horse that seen us through tough times but the sun is setting.

cordova-windows has been a viable alternative for some time now, and allows 
developers to target newer device features from wp8.1 and wp10 as well.
Removing the responsibility of implementing changes in this now ancient code 
base will free many of us to focus on making the windows universal workflow 
better.

I would like to see this wrapped up by the end of the year, which for me is the 
end of next week.

Some suggestions of what needs to happen next :
- display warning message in cli when devs type `cordova platform add wp8` ( 
next cordova-lib/cli release )
- provide a plugin-dev migration guide outlining how to leverage existing C# 
code in a windows-universal application ( I will do this )
- update repos / documentation with polite wording to move on
- close a bunch of wp8 related issues in jira with "won't fix'
- put wp8 out to pasture

What are your thoughts?


Cheers,
  Jesse

@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7ctoddmosc%40microsoft.com%7c627f22cbc05040478d9808d2fb4bb85c%7c72f988bf86f141af91ab2d7cd011db47%7c1=baC3YZLF3cU%2fbC5ZYH7QvBtpyYtxBhJhkQd57sERCC0%3d

Re: [DISCUSS] CLI Templates

[Dmitry Blotsky]

1. The `--copy-from` flag is a valid use case, and it is definitely still used. 
If we do implement the `--template` flag, we should keep `--copy-from` as well.
2. Doing proper re-creation of files is harder than it seems: the template 
might have broken platforms that need regenerating, and that won’t get 
recreated because it already contains them. Also, replacing some XML properties 
(like the app ID) in an existing file sounds like a really bad idea and a huge 
source of confusion. I’d say that if a user has an app, then it’s already an 
app and they will never run `cordova create` on it. Overall, it seems to me 
like a very niche feature that is definitely convenient, but the gains in 
convenience are *very heavily* outweighed by the complexity of the feature.

Kindly,
Dmitry

> On Dec 8, 2015, at 10:47 AM, Carlos Santana  wrote:
> 
> Hi Dmitry
> 1.  It was discuss in the mailing list, that use case #1 was not need it,
> and to be replace by --template, user don't have to have config.xml and
> other cordova specific files they will be created. So the reason to
> deprecate --copy-from
> 2.  yes it's similar to a cp or git clone, but also a download of npm, it
> will replace app name and id if they are passed in to create command if
> template contains config.xml they will get replace, no night mare not that
> many files to add if template purposely missing just config.xml and empty
> folders for hooks, plugins, platform. template should have a www and any
> other files outside www they want in their template like res/resource/
> (cordova uses res, ionic uses resources, etc..) .gitignore, .editorconfig,
> pacakge.json, etc.. any other files they which their app to have that
> template will get them started with.
> 
> 
> On Mon, Dec 7, 2015 at 11:10 PM Dmitry Blotsky 
> wrote:
> 
>> Thanks for the summary, Carlos! Sorry, I hadn’t read the whole thread when
>> I sent my question. I read up after your email, and I have a better grasp
>> on it now. My new questions are below.
>> 
>> 1. What is the `cordova create` command then doing if it’s copying
>> (potentially) the whole app it’s trying to create? The `--copy-from` flag
>> creates fresh copies of Cordova-specific files and only copies the `www`
>> folder, which is app-agnostic anyway.
>> 2. Isn’t the new flag basically the same as an invocation of `cp` or `git
>> clone`? And if we’re going into the realm of examining the template and
>> “filling in” potentially missing files, isn’t that a logical nightmare
>> since there are so many possible things that could be missing in an app?
>> 
>> Kindly,
>> Dmitry
>> 
>>> On Dec 5, 2015, at 7:00 AM, Carlos Santana  wrote:
>>> 
>>> The email thread has the details but in summary:
>>> It doesn't handle npm and git as source
>>> It doesn't copy everything
>>> By adding npm and git having the flag copy-from it's confusing.
>>> 
>>> On Fri, Dec 4, 2015 at 9:04 PM Dmitry Blotsky 
>>> wrote:
>>> 
 Hey folks. Sorry I'm late to the party, but why is `--copy-from` not
 sufficient?
 
 Kindly,
 Dmitry
 
 -Original Message-
 From: Carlos Santana [mailto:csantan...@gmail.com]
 Sent: Friday, December 4, 2015 10:09 AM
 To: dev@cordova.apache.org
 Subject: Re: [DISCUSS] CLI Templates
 
 Michael we will love to hear your feedback, and we can improve on top of
 what's initially there.
 
 
 On Fri, Dec 4, 2015 at 1:04 PM Carlos Santana 
 wrote:
 
> Michael
> Links to PRs where available for a while on the proposal.
> 
> https://github.com/apache/cordova-lib/pull/339
> https://github.com/apache/cordova-cli/pull/226
> 
> 
> On Fri, Dec 4, 2015 at 11:33 AM Michael Brooks
> 
> wrote:
> 
>> I'd love to see a pull request rather than a straight up merge, since
>> the template discussion was more involved. Also, I'm really looking
>> forward to seeing your work on this!
>> 
>> On Thu, Dec 3, 2015 at 9:47 AM, Carlos Santana 
>> wrote:
>> 
>>> I will be working later today with James from my team on merging
>>> initial implementation of --template. it will update a few repos
>>> (cli, lib, doc)
>>> 
>>> Anyone oppose?
>>> 
>>> 
>>> On Fri, Nov 13, 2015 at 1:50 PM Carlos Santana
>>> 
>>> wrote:
>>> 
 alias, deprecate and later remove
 
 On Fri, Nov 13, 2015 at 1:49 PM Carlos Santana
 
 wrote:
 
> I agree, --template is the new --copy-from :-)
> 
> 
> On Fri, Nov 13, 2015 at 1:48 PM Shazron  wrote:
> 
>> Well, we could deprecate --copy-from, and alias --template to it.
>> But
>> we shouldn't have both, it should just 

Buildbot: buildslave cordova-osx-slave was lost

[buildbot]

The Buildbot working for 'ASF Buildbot'
has noticed that the buildslave named cordova-osx-slave went away

It last disconnected at Tue Dec  8 20:14:49 2015 (buildmaster-local time)

The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky 
'.

Sincerely,
 The Buildbot
 http://ci.apache.org/

http://ci.apache.org/buildslaves/cordova-osx-slave

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Buildbot: buildslave cordova-windows-slave was lost

[buildbot]

The Buildbot working for 'ASF Buildbot'
has noticed that the buildslave named cordova-windows-slave went away

It last disconnected at Tue Dec  8 20:31:48 2015 (buildmaster-local time)

The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky 
'.

Sincerely,
 The Buildbot
 http://ci.apache.org/

http://ci.apache.org/buildslaves/cordova-windows-slave

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Buildbot: buildslave cordova-windows-slave was lost

[Dmitry Blotsky]

Somebody kicked the switch by my desk and it knocked both machines off the 
network. Back now.

Kindly,
Dmitry

> On Dec 8, 2015, at 12:36 PM, build...@apache.org wrote:
> 
> The Buildbot working for 'ASF Buildbot'
> has noticed that the buildslave named cordova-windows-slave went away
> 
> It last disconnected at Tue Dec  8 20:31:48 2015 (buildmaster-local time)
> 
> The admin on record (as reported by BUILDSLAVE:info/admin)
> was 'Dmitry Blotsky 
> '.
> 
> Sincerely,
> The Buildbot
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fci.apache.org%2f=01%7c01%7cdblotsky%40microsoft.com%7c3b7adb970fa343aa709e08d3000f4d6f%7c72f988bf86f141af91ab2d7cd011db47%7c1=8ZQJ3qQ2cP7VHzX5D%2fvSwIm%2bUHrrdeuL4qx%2fk34QP%2fI%3d
> 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fci.apache.org%2fbuildslaves%2fcordova-windows-slave=01%7c01%7cdblotsky%40microsoft.com%7c3b7adb970fa343aa709e08d3000f4d6f%7c72f988bf86f141af91ab2d7cd011db47%7c1=gCCe1f2RplYK5gatF8yqqR%2bIL3xrDzLEy6hdAHz4S2Q%3d
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] CLI Templates

[Mefire O .]

We already have support for the --template flag in Cordova.

However, it currently only supports NPM packages and GIT URLs, no local folder.
The local folder scenario is currently being handled by --copy-from (only www 
and config.xml are copied)  and --link-to.

We also have a way of specifying default templates: throught the json file: 
cordova_project/.cordova/config.json.

I think we should:
   - deprecate --copy-from
   - update the current --template logic to support local folders in addition 
to NPM and GIT URLs
   - fallback to using the  'cordova-hello-world' template when a critical 
option/file/folder isn’t present in the supplied template (e.g: user did not 
specify app_id, app_name or supplied template has no www folder)
   - document .cordova/config.json (how it can be used to set default templates)
   - copy platforms/plugins folders when creating from a template


Thanks,
Omar Mefire  


-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Tuesday, December 8, 2015 10:48 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] CLI Templates

Hi Dmitry
1.  It was discuss in the mailing list, that use case #1 was not need it, and 
to be replace by --template, user don't have to have config.xml and other 
cordova specific files they will be created. So the reason to deprecate 
--copy-from 2.  yes it's similar to a cp or git clone, but also a download of 
npm, it will replace app name and id if they are passed in to create command if 
template contains config.xml they will get replace, no night mare not that many 
files to add if template purposely missing just config.xml and empty folders 
for hooks, plugins, platform. template should have a www and any other files 
outside www they want in their template like res/resource/  (cordova uses res, 
ionic uses resources, etc..) .gitignore, .editorconfig, pacakge.json, etc.. any 
other files they which their app to have that template will get them started 
with.


On Mon, Dec 7, 2015 at 11:10 PM Dmitry Blotsky 
wrote:

> Thanks for the summary, Carlos! Sorry, I hadn’t read the whole thread 
> when I sent my question. I read up after your email, and I have a 
> better grasp on it now. My new questions are below.
>
> 1. What is the `cordova create` command then doing if it’s copying
> (potentially) the whole app it’s trying to create? The `--copy-from` 
> flag creates fresh copies of Cordova-specific files and only copies 
> the `www` folder, which is app-agnostic anyway.
> 2. Isn’t the new flag basically the same as an invocation of `cp` or 
> `git clone`? And if we’re going into the realm of examining the 
> template and “filling in” potentially missing files, isn’t that a 
> logical nightmare since there are so many possible things that could be 
> missing in an app?
>
> Kindly,
> Dmitry
>
> > On Dec 5, 2015, at 7:00 AM, Carlos Santana  wrote:
> >
> > The email thread has the details but in summary:
> > It doesn't handle npm and git as source It doesn't copy everything 
> > By adding npm and git having the flag copy-from it's confusing.
> >
> > On Fri, Dec 4, 2015 at 9:04 PM Dmitry Blotsky 
> > 
> > wrote:
> >
> >> Hey folks. Sorry I'm late to the party, but why is `--copy-from` 
> >> not sufficient?
> >>
> >> Kindly,
> >> Dmitry
> >>
> >> -Original Message-
> >> From: Carlos Santana [mailto:csantan...@gmail.com]
> >> Sent: Friday, December 4, 2015 10:09 AM
> >> To: dev@cordova.apache.org
> >> Subject: Re: [DISCUSS] CLI Templates
> >>
> >> Michael we will love to hear your feedback, and we can improve on 
> >> top of what's initially there.
> >>
> >>
> >> On Fri, Dec 4, 2015 at 1:04 PM Carlos Santana 
> >> 
> >> wrote:
> >>
> >>> Michael
> >>> Links to PRs where available for a while on the proposal.
> >>>
> >>> https://github.com/apache/cordova-lib/pull/339
> >>> https://github.com/apache/cordova-cli/pull/226
> >>>
> >>>
> >>> On Fri, Dec 4, 2015 at 11:33 AM Michael Brooks 
> >>> 
> >>> wrote:
> >>>
>  I'd love to see a pull request rather than a straight up merge, 
>  since the template discussion was more involved. Also, I'm really 
>  looking forward to seeing your work on this!
> 
>  On Thu, Dec 3, 2015 at 9:47 AM, Carlos Santana 
>  
>  wrote:
> 
> > I will be working later today with James from my team on merging 
> > initial implementation of --template. it will update a few repos 
> > (cli, lib, doc)
> >
> > Anyone oppose?
> >
> >
> > On Fri, Nov 13, 2015 at 1:50 PM Carlos Santana 
> > 
> > wrote:
> >
> >> alias, deprecate and later remove
> >>
> >> On Fri, Nov 13, 2015 at 1:49 PM Carlos Santana 
> >> 
> >> wrote:
> >>
> >>> I agree, --template is the new --copy-from :-)
> >>>
> >>>
> >>> On Fri, Nov 13, 

RE: [DISCUSS] Deprecate cordova-wp8

[Parashuram N]

The Cordova Slack at http://cordova.slack.com/ would be a good place to start. 

-Original Message-
From: Sergio Nader [mailto:sergio.na...@brasilisdigital.com.br] 
Sent: Tuesday, December 8, 2015 3:41 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Deprecate cordova-wp8

Hello,

I have several questions about the diferences and uses of wp8, windows 
(universal).
I tried hard to find some objective readings about them, but could not found 
anything concise.
Where is the right place to ask for orientation?

Best regards,

Sergio

Sérgio Nader

Skype: 
https://na01.safelinks.protection.outlook.com/?url=sergio.nader.br=01%7c01%7cpanarasi%40microsoft.com%7c0a002f245dd04fb98e7e08d300299415%7c72f988bf86f141af91ab2d7cd011db47%7c1=u3mM56jO%2byqQI%2f216zKZNDa0LJv3BaN4n2EvzZ%2bvr6c%3d

Tel: 55 11 9 9101 4590



​https://na01.safelinks.protection.outlook.com/?url=www.brasilisdigital.com.br=01%7c01%7cpanarasi%40microsoft.com%7c0a002f245dd04fb98e7e08d300299415%7c72f988bf86f141af91ab2d7cd011db47%7c1=urBRhS2yfKIE1IbwQ3FRCedbtIm5RJIOG2hvp7PZRxc%3d

Tecnologia & Inovação​


On Tue, Dec 8, 2015 at 8:45 PM, Jesse  wrote:

> The deprecation window is a 'minimum' of 6 months.
> Waiting 3 months to maybe wait 6 more months seems less efficient than 
> deprecating now and deciding in 6 months time if we want to move on it.
> Deprecation is not the end, just the beginning of it.
>
> Also, we need to nudge people to move forwards, they are building on a 
> sdk that can only target wp 8.0 which was released 3 years ago.
> If we value this group and want to continue supporting the platform 
> then we should bite the bullet and update it to at least support 8.1 
> (Apr. 2014) but I think we are better off focusing on windows universal going 
> forward.
>
>
>
> @purplecabbage
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01
> %7c01%7cpanarasi%40microsoft.com%7c0a002f245dd04fb98e7e08d300299415%7c
> 72f988bf86f141af91ab2d7cd011db47%7c1=bqFj%2fQbrkwxV1oreM2vw59FIo
> %2bMCgXQzq1zJ8t4dSdE%3d
>
> On Tue, Dec 8, 2015 at 12:51 PM, Parashuram N 
> wrote:
>
> > I pinged the folks here on VS team to get an idea of number of 
> > people building for WP8. Looks like this is still a significant 
> > number (more
> than
> > 10%) and almost 2000 unique users building for WP8 per month. Can we
> delay
> > the deprecation for 3 more months to see if this number can go down ?
> >
> > -Original Message-
> > From: Jesse [mailto:purplecabb...@gmail.com]
> > Sent: Wednesday, December 2, 2015 11:06 AM
> > To: dev@cordova.apache.org
> > Subject: [DISCUSS] Deprecate cordova-wp8
> >
> > We've talked about it for awhile, but never moved on it. cordova-wp8 
> > has been a work horse that seen us through tough times but the sun 
> > is
> setting.
> >
> > cordova-windows has been a viable alternative for some time now, and 
> > allows developers to target newer device features from wp8.1 and 
> > wp10 as well.
> > Removing the responsibility of implementing changes in this now 
> > ancient code base will free many of us to focus on making the 
> > windows universal workflow better.
> >
> > I would like to see this wrapped up by the end of the year, which 
> > for me is the end of next week.
> >
> > Some suggestions of what needs to happen next :
> > - display warning message in cli when devs type `cordova platform 
> > add
> wp8`
> > ( next cordova-lib/cli release )
> > - provide a plugin-dev migration guide outlining how to leverage 
> > existing C# code in a windows-universal application ( I will do this 
> > )
> > - update repos / documentation with polite wording to move on
> > - close a bunch of wp8 related issues in jira with "won't fix'
> > - put wp8 out to pasture
> >
> > What are your thoughts?
> >
> >
> > Cheers,
> >   Jesse
> >
> > @purplecabbage
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01
> %7c01%7ctoddmosc%40microsoft.com%7c627f22cbc05040478d9808d2fb4bb85c%7c
> 72f988bf86f141af91ab2d7cd011db47%7c1=baC3YZLF3cU%2fbC5ZYH7QvBtpy
> YtxBhJhkQd57sERCC0%3d
> >
>

[GitHub] cordova-android pull request: Include native libraries from armeab...

[mbektchiev]

GitHub user mbektchiev opened a pull request:

https://github.com/apache/cordova-android/pull/243

Include native libraries from armeabi directory when producing armv7 apk

If a Cordova Android project contains `.so` files located in the 
`lib/armeabi` directory, they will not be included in the final apk when 
building for the `armv7` architecture with `cdvBuildMultipleApks` set to `true`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Icenium/cordova-android include-armeabi-dir

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #243


commit 6b71726091217dfe0de71563038ecc1faff57592
Author: Martin Bektchiev 
Date:   2015-12-09T07:30:37Z

Include native libraries from armeabi directory when producing armv7 apk




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-wp8

[julio cesar sanchez]

+1 to Jesse, deprecation doesn't mean they won't be able to use it.

Parashuram, can you get stats about the number of devices or percentaje of
devices that still use WP8? like windows store device access stats or
something like that

Sergio, you got an answer on cordova's slack general channel.
vladimir.kotikov 
10:56 AM 
@sergion : wp8 platform is for
building apps for wp8/wp8.1 devices only. It is a bit outdated, and there
are some rumors about deprecating. So i recommend you to use windows
platform which gives you an ability to target WinPhone 8.1 and 10 devices,
as well as Windows desktop.



2015-12-09 1:01 GMT+01:00 Sergio Nader 
:

> Thanks, but I tried a couple of times to ask about it (and other stuff) and
> got no answer.
> Weil, will not change the subject of this conversation. If anyone can help
> me or have any other suggestion, please email directly.
>
> Regards,
>
> Sérgio Nader
>
> Skype: sergio.nader.br
>
> Tel: 55 11 9 9101 4590
>
>
>
> ​www.brasilisdigital.com.br
>
> Tecnologia & Inovação​
>
>
> On Tue, Dec 8, 2015 at 9:52 PM, Parashuram N 
> wrote:
>
> > The Cordova Slack at http://cordova.slack.com/ would be a good place to
> > start.
> >
> > -Original Message-
> > From: Sergio Nader [mailto:sergio.na...@brasilisdigital.com.br]
> > Sent: Tuesday, December 8, 2015 3:41 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Deprecate cordova-wp8
> >
> > Hello,
> >
> > I have several questions about the diferences and uses of wp8, windows
> > (universal).
> > I tried hard to find some objective readings about them, but could not
> > found anything concise.
> > Where is the right place to ask for orientation?
> >
> > Best regards,
> >
> > Sergio
> >
> > Sérgio Nader
> >
> > Skype:
> >
> https://na01.safelinks.protection.outlook.com/?url=sergio.nader.br=01%7c01%7cpanarasi%40microsoft.com%7c0a002f245dd04fb98e7e08d300299415%7c72f988bf86f141af91ab2d7cd011db47%7c1=u3mM56jO%2byqQI%2f216zKZNDa0LJv3BaN4n2EvzZ%2bvr6c%3d
> >
> > Tel: 55 11 9 9101 4590
> >
> >
> >
> > ​
> >
> https://na01.safelinks.protection.outlook.com/?url=www.brasilisdigital.com.br=01%7c01%7cpanarasi%40microsoft.com%7c0a002f245dd04fb98e7e08d300299415%7c72f988bf86f141af91ab2d7cd011db47%7c1=urBRhS2yfKIE1IbwQ3FRCedbtIm5RJIOG2hvp7PZRxc%3d
> >
> > Tecnologia & Inovação​
> >
> >
> > On Tue, Dec 8, 2015 at 8:45 PM, Jesse  wrote:
> >
> > > The deprecation window is a 'minimum' of 6 months.
> > > Waiting 3 months to maybe wait 6 more months seems less efficient than
> > > deprecating now and deciding in 6 months time if we want to move on it.
> > > Deprecation is not the end, just the beginning of it.
> > >
> > > Also, we need to nudge people to move forwards, they are building on a
> > > sdk that can only target wp 8.0 which was released 3 years ago.
> > > If we value this group and want to continue supporting the platform
> > > then we should bite the bullet and update it to at least support 8.1
> > > (Apr. 2014) but I think we are better off focusing on windows universal
> > going forward.
> > >
> > >
> > >
> > > @purplecabbage
> > > https://na01.safelinks.protection.outlook.com/?url=risingj.com=01
> > > %7c01%7cpanarasi%40microsoft.com%7c0a002f245dd04fb98e7e08d300299415%7c
> > > 72f988bf86f141af91ab2d7cd011db47%7c1=bqFj%2fQbrkwxV1oreM2vw59FIo
> > > %2bMCgXQzq1zJ8t4dSdE%3d
> > >
> > > On Tue, Dec 8, 2015 at 12:51 PM, Parashuram N 
> > > wrote:
> > >
> > > > I pinged the folks here on VS team to get an idea of number of
> > > > people building for WP8. Looks like this is still a significant
> > > > number (more
> > > than
> > > > 10%) and almost 2000 unique users building for WP8 per month. Can we
> > > delay
> > > > the deprecation for 3 more months to see if this number can go down ?
> > > >
> > > > -Original Message-
> > > > From: Jesse [mailto:purplecabb...@gmail.com]
> > > > Sent: Wednesday, December 2, 2015 11:06 AM
> > > > To: dev@cordova.apache.org
> > > > Subject: [DISCUSS] Deprecate cordova-wp8
> > > >
> > > > We've talked about it for awhile, but never moved on it. cordova-wp8
> > > > has been a work horse that seen us through tough times but the sun
> > > > is
> > > setting.
> > > >
> > > > cordova-windows has been a viable alternative for some time now, and
> > > > allows developers to target newer device features from wp8.1 and
> > > > wp10 as well.
> > > > Removing the responsibility of implementing changes in this now
> > > > ancient code base will free many of us to focus on making the
> > > > windows universal workflow better.
> > > >
> > > > I would like to see this wrapped up by the end of the year, which
> > > > for me is the end of next week.
> > > >
> > > > Some suggestions of what needs to happen next :
> > > > - display warning 

[GitHub] cordova-lib pull request: CB-9311 Add support for 87x87 icon, fix ...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-lib/pull/354#issuecomment-163065696
  
It's possible all the work that has gone into cordova-lib for iOS has not 
been integrated into the Platform API for iOS: 
https://github.com/apache/cordova-ios/pull/182


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-wp8

[Sergio Nader]

Hello,

I have several questions about the diferences and uses of wp8, windows
(universal).
I tried hard to find some objective readings about them, but could not
found anything concise.
Where is the right place to ask for orientation?

Best regards,

Sergio

Sérgio Nader

Skype: sergio.nader.br

Tel: 55 11 9 9101 4590



​www.brasilisdigital.com.br

Tecnologia & Inovação​


On Tue, Dec 8, 2015 at 8:45 PM, Jesse  wrote:

> The deprecation window is a 'minimum' of 6 months.
> Waiting 3 months to maybe wait 6 more months seems less efficient than
> deprecating now and deciding in 6 months time if we want to move on it.
> Deprecation is not the end, just the beginning of it.
>
> Also, we need to nudge people to move forwards, they are building on a sdk
> that can only target wp 8.0 which was released 3 years ago.
> If we value this group and want to continue supporting the platform then we
> should bite the bullet and update it to at least support 8.1 (Apr. 2014)
> but I think we are better off focusing on windows universal going forward.
>
>
>
> @purplecabbage
> risingj.com
>
> On Tue, Dec 8, 2015 at 12:51 PM, Parashuram N 
> wrote:
>
> > I pinged the folks here on VS team to get an idea of number of people
> > building for WP8. Looks like this is still a significant number (more
> than
> > 10%) and almost 2000 unique users building for WP8 per month. Can we
> delay
> > the deprecation for 3 more months to see if this number can go down ?
> >
> > -Original Message-
> > From: Jesse [mailto:purplecabb...@gmail.com]
> > Sent: Wednesday, December 2, 2015 11:06 AM
> > To: dev@cordova.apache.org
> > Subject: [DISCUSS] Deprecate cordova-wp8
> >
> > We've talked about it for awhile, but never moved on it. cordova-wp8 has
> > been a work horse that seen us through tough times but the sun is
> setting.
> >
> > cordova-windows has been a viable alternative for some time now, and
> > allows developers to target newer device features from wp8.1 and wp10 as
> > well.
> > Removing the responsibility of implementing changes in this now ancient
> > code base will free many of us to focus on making the windows universal
> > workflow better.
> >
> > I would like to see this wrapped up by the end of the year, which for me
> > is the end of next week.
> >
> > Some suggestions of what needs to happen next :
> > - display warning message in cli when devs type `cordova platform add
> wp8`
> > ( next cordova-lib/cli release )
> > - provide a plugin-dev migration guide outlining how to leverage existing
> > C# code in a windows-universal application ( I will do this )
> > - update repos / documentation with polite wording to move on
> > - close a bunch of wp8 related issues in jira with "won't fix'
> > - put wp8 out to pasture
> >
> > What are your thoughts?
> >
> >
> > Cheers,
> >   Jesse
> >
> > @purplecabbage
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7ctoddmosc%40microsoft.com%7c627f22cbc05040478d9808d2fb4bb85c%7c72f988bf86f141af91ab2d7cd011db47%7c1=baC3YZLF3cU%2fbC5ZYH7QvBtpyYtxBhJhkQd57sERCC0%3d
> >
>

[GitHub] cordova-lib pull request: CB-9311 Add support for 87x87 icon, fix ...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-lib/pull/354#issuecomment-163065575
  
iOS parser code does not go into cordova-lib anymore. It goes in 
cordova-ios (Platform API)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-wp8

[Sergio Nader]

Thanks, but I tried a couple of times to ask about it (and other stuff) and
got no answer.
Weil, will not change the subject of this conversation. If anyone can help
me or have any other suggestion, please email directly.

Regards,

Sérgio Nader

Skype: sergio.nader.br

Tel: 55 11 9 9101 4590



​www.brasilisdigital.com.br

Tecnologia & Inovação​


On Tue, Dec 8, 2015 at 9:52 PM, Parashuram N  wrote:

> The Cordova Slack at http://cordova.slack.com/ would be a good place to
> start.
>
> -Original Message-
> From: Sergio Nader [mailto:sergio.na...@brasilisdigital.com.br]
> Sent: Tuesday, December 8, 2015 3:41 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Deprecate cordova-wp8
>
> Hello,
>
> I have several questions about the diferences and uses of wp8, windows
> (universal).
> I tried hard to find some objective readings about them, but could not
> found anything concise.
> Where is the right place to ask for orientation?
>
> Best regards,
>
> Sergio
>
> Sérgio Nader
>
> Skype:
> https://na01.safelinks.protection.outlook.com/?url=sergio.nader.br=01%7c01%7cpanarasi%40microsoft.com%7c0a002f245dd04fb98e7e08d300299415%7c72f988bf86f141af91ab2d7cd011db47%7c1=u3mM56jO%2byqQI%2f216zKZNDa0LJv3BaN4n2EvzZ%2bvr6c%3d
>
> Tel: 55 11 9 9101 4590
>
>
>
> ​
> https://na01.safelinks.protection.outlook.com/?url=www.brasilisdigital.com.br=01%7c01%7cpanarasi%40microsoft.com%7c0a002f245dd04fb98e7e08d300299415%7c72f988bf86f141af91ab2d7cd011db47%7c1=urBRhS2yfKIE1IbwQ3FRCedbtIm5RJIOG2hvp7PZRxc%3d
>
> Tecnologia & Inovação​
>
>
> On Tue, Dec 8, 2015 at 8:45 PM, Jesse  wrote:
>
> > The deprecation window is a 'minimum' of 6 months.
> > Waiting 3 months to maybe wait 6 more months seems less efficient than
> > deprecating now and deciding in 6 months time if we want to move on it.
> > Deprecation is not the end, just the beginning of it.
> >
> > Also, we need to nudge people to move forwards, they are building on a
> > sdk that can only target wp 8.0 which was released 3 years ago.
> > If we value this group and want to continue supporting the platform
> > then we should bite the bullet and update it to at least support 8.1
> > (Apr. 2014) but I think we are better off focusing on windows universal
> going forward.
> >
> >
> >
> > @purplecabbage
> > https://na01.safelinks.protection.outlook.com/?url=risingj.com=01
> > %7c01%7cpanarasi%40microsoft.com%7c0a002f245dd04fb98e7e08d300299415%7c
> > 72f988bf86f141af91ab2d7cd011db47%7c1=bqFj%2fQbrkwxV1oreM2vw59FIo
> > %2bMCgXQzq1zJ8t4dSdE%3d
> >
> > On Tue, Dec 8, 2015 at 12:51 PM, Parashuram N 
> > wrote:
> >
> > > I pinged the folks here on VS team to get an idea of number of
> > > people building for WP8. Looks like this is still a significant
> > > number (more
> > than
> > > 10%) and almost 2000 unique users building for WP8 per month. Can we
> > delay
> > > the deprecation for 3 more months to see if this number can go down ?
> > >
> > > -Original Message-
> > > From: Jesse [mailto:purplecabb...@gmail.com]
> > > Sent: Wednesday, December 2, 2015 11:06 AM
> > > To: dev@cordova.apache.org
> > > Subject: [DISCUSS] Deprecate cordova-wp8
> > >
> > > We've talked about it for awhile, but never moved on it. cordova-wp8
> > > has been a work horse that seen us through tough times but the sun
> > > is
> > setting.
> > >
> > > cordova-windows has been a viable alternative for some time now, and
> > > allows developers to target newer device features from wp8.1 and
> > > wp10 as well.
> > > Removing the responsibility of implementing changes in this now
> > > ancient code base will free many of us to focus on making the
> > > windows universal workflow better.
> > >
> > > I would like to see this wrapped up by the end of the year, which
> > > for me is the end of next week.
> > >
> > > Some suggestions of what needs to happen next :
> > > - display warning message in cli when devs type `cordova platform
> > > add
> > wp8`
> > > ( next cordova-lib/cli release )
> > > - provide a plugin-dev migration guide outlining how to leverage
> > > existing C# code in a windows-universal application ( I will do this
> > > )
> > > - update repos / documentation with polite wording to move on
> > > - close a bunch of wp8 related issues in jira with "won't fix'
> > > - put wp8 out to pasture
> > >
> > > What are your thoughts?
> > >
> > >
> > > Cheers,
> > >   Jesse
> > >
> > > @purplecabbage
> > >
> > >
> > https://na01.safelinks.protection.outlook.com/?url=risingj.com=01
> > %7c01%7ctoddmosc%40microsoft.com%7c627f22cbc05040478d9808d2fb4bb85c%7c
> > 72f988bf86f141af91ab2d7cd011db47%7c1=baC3YZLF3cU%2fbC5ZYH7QvBtpy
> > YtxBhJhkQd57sERCC0%3d
> > >
> >
>

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-lib/pull/353#issuecomment-163066579
  
This feature has much deeper and far reaching requirements, as the CI has 
pointed out.
The individual platforms are all keeping their own parsers, and because 
this affects the platform-api ALL platforms must be updated for this to work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-wp8

[Jesse]

The deprecation window is a 'minimum' of 6 months.
Waiting 3 months to maybe wait 6 more months seems less efficient than
deprecating now and deciding in 6 months time if we want to move on it.
Deprecation is not the end, just the beginning of it.

Also, we need to nudge people to move forwards, they are building on a sdk
that can only target wp 8.0 which was released 3 years ago.
If we value this group and want to continue supporting the platform then we
should bite the bullet and update it to at least support 8.1 (Apr. 2014)
but I think we are better off focusing on windows universal going forward.



@purplecabbage
risingj.com

On Tue, Dec 8, 2015 at 12:51 PM, Parashuram N 
wrote:

> I pinged the folks here on VS team to get an idea of number of people
> building for WP8. Looks like this is still a significant number (more than
> 10%) and almost 2000 unique users building for WP8 per month. Can we delay
> the deprecation for 3 more months to see if this number can go down ?
>
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Wednesday, December 2, 2015 11:06 AM
> To: dev@cordova.apache.org
> Subject: [DISCUSS] Deprecate cordova-wp8
>
> We've talked about it for awhile, but never moved on it. cordova-wp8 has
> been a work horse that seen us through tough times but the sun is setting.
>
> cordova-windows has been a viable alternative for some time now, and
> allows developers to target newer device features from wp8.1 and wp10 as
> well.
> Removing the responsibility of implementing changes in this now ancient
> code base will free many of us to focus on making the windows universal
> workflow better.
>
> I would like to see this wrapped up by the end of the year, which for me
> is the end of next week.
>
> Some suggestions of what needs to happen next :
> - display warning message in cli when devs type `cordova platform add wp8`
> ( next cordova-lib/cli release )
> - provide a plugin-dev migration guide outlining how to leverage existing
> C# code in a windows-universal application ( I will do this )
> - update repos / documentation with polite wording to move on
> - close a bunch of wp8 related issues in jira with "won't fix'
> - put wp8 out to pasture
>
> What are your thoughts?
>
>
> Cheers,
>   Jesse
>
> @purplecabbage
>
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7ctoddmosc%40microsoft.com%7c627f22cbc05040478d9808d2fb4bb85c%7c72f988bf86f141af91ab2d7cd011db47%7c1=baC3YZLF3cU%2fbC5ZYH7QvBtpyYtxBhJhkQd57sERCC0%3d
>

[GitHub] cordova-docs pull request: Add plugins release blog post for cordo...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-docs/pull/437#issuecomment-163067085
  
LGTM! :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[ANNOUNCE] Cordova ios@4.0.0 and cordova-plugin-wkwebview-engine plugin released!

[Steven Gill]

Blog:
http://cordova.apache.org/announcements/2015/12/08/cordova-ios-4.0.0.html
Tweet: https://twitter.com/apachecordova/status/674352882108391424

cordova-plugin-wkwebview-engine blog:
http://cordova.apache.org/news/2015/12/08/wkwebview-engine-plugin-release.html

Thanks to everyone who helped get this release out! And a special thanks to
Shazron for spending many months to make this release a reality!

[GitHub] cordova-lib pull request: CB-9311 Add support for 87x87 icon, fix ...

[tony--]

GitHub user tony-- opened a pull request:

https://github.com/apache/cordova-lib/pull/354

CB-9311 Add support for 87x87 icon, fix reference url



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tony--/cordova-lib CB-9311

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #354


commit 43771ef4118c11e47f45258f5c929cdc335d382d
Author: Tony Homer 
Date:   2015-12-08T22:54:27Z

CB-9311 Add support for 87x87 icon, fix reference url




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] CLI Templates

[Steven Gill]

The thread was proposed Nov 10th and PR was merged Dec 3rd. I think that is
ample time to give feedback. If people don't give feedback, apache way is
consider it as lazy consensus.

We do not vote on feature requests and I hope we never do as it is a
terrible practice. Good luck trying to get anything done.
The `--template` flag currently there is the one that was added as per this
discussion. I think in the future we should refrain from adding code before
a discussion completes, especially if there is contention. At the very
least, we should probably hold a vote.

I’m definitely not a fan of adding flags just for the purpose of very
specific convenience, but if I’m alone in that opinion then let’s do
whatever the majority decides.

Kindly,
Dmitry

> On Dec 8, 2015, at 2:34 PM, Mefire O.  wrote:
>
>
> We already have support for the --template flag in Cordova.
>
> However, it currently only supports NPM packages and GIT URLs, no local
folder.
> The local folder scenario is currently being handled by --copy-from (only
www and config.xml are copied)  and --link-to.
>
> We also have a way of specifying default templates: throught the json
file: cordova_project/.cordova/config.json.
>
> I think we should:
>   - deprecate --copy-from
>   - update the current --template logic to support local folders in
addition to NPM and GIT URLs
>   - fallback to using the  'cordova-hello-world' template when a critical
option/file/folder isn’t present in the supplied template (e.g: user did
not specify app_id, app_name or supplied template has no www folder)
>   - document .cordova/config.json (how it can be used to set default
templates)
>   - copy platforms/plugins folders when creating from a template
>
>
> Thanks,
> Omar Mefire
>
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Tuesday, December 8, 2015 10:48 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] CLI Templates
>
> Hi Dmitry
> 1.  It was discuss in the mailing list, that use case #1 was not need it,
and to be replace by --template, user don't have to have config.xml and
other cordova specific files they will be created. So the reason to
deprecate --copy-from 2.  yes it's similar to a cp or git clone, but also a
download of npm, it will replace app name and id if they are passed in to
create command if template contains config.xml they will get replace, no
night mare not that many files to add if template purposely missing just
config.xml and empty folders for hooks, plugins, platform. template should
have a www and any other files outside www they want in their template like
res/resource/  (cordova uses res, ionic uses resources, etc..) .gitignore,
.editorconfig, pacakge.json, etc.. any other files they which their app to
have that template will get them started with.
>
>
> On Mon, Dec 7, 2015 at 11:10 PM Dmitry Blotsky 
> wrote:
>
>> Thanks for the summary, Carlos! Sorry, I hadn’t read the whole thread
>> when I sent my question. I read up after your email, and I have a
>> better grasp on it now. My new questions are below.
>>
>> 1. What is the `cordova create` command then doing if it’s copying
>> (potentially) the whole app it’s trying to create? The `--copy-from`
>> flag creates fresh copies of Cordova-specific files and only copies
>> the `www` folder, which is app-agnostic anyway.
>> 2. Isn’t the new flag basically the same as an invocation of `cp` or
>> `git clone`? And if we’re going into the realm of examining the
>> template and “filling in” potentially missing files, isn’t that a
>> logical nightmare since there are so many possible things that could be
missing in an app?
>>
>> Kindly,
>> Dmitry
>>
>>> On Dec 5, 2015, at 7:00 AM, Carlos Santana  wrote:
>>>
>>> The email thread has the details but in summary:
>>> It doesn't handle npm and git as source It doesn't copy everything
>>> By adding npm and git having the flag copy-from it's confusing.
>>>
>>> On Fri, Dec 4, 2015 at 9:04 PM Dmitry Blotsky
>>> 
>>> wrote:
>>>
 Hey folks. Sorry I'm late to the party, but why is `--copy-from`
 not sufficient?

 Kindly,
 Dmitry

 -Original Message-
 From: Carlos Santana [mailto:csantan...@gmail.com]
 Sent: Friday, December 4, 2015 10:09 AM
 To: dev@cordova.apache.org
 Subject: Re: [DISCUSS] CLI Templates

 Michael we will love to hear your feedback, and we can improve on
 top of what's initially there.


 On Fri, Dec 4, 2015 at 1:04 PM Carlos Santana
 
 wrote:

> Michael
> Links to PRs where available for a while on the proposal.
>
> https://github.com/apache/cordova-lib/pull/339
> https://github.com/apache/cordova-cli/pull/226
>
>
> On Fri, Dec 4, 2015 at 11:33 AM Michael Brooks
> 
> wrote:
>
>> I'd love to see a pull request rather than 

[GitHub] cordova-plugin-file pull request: CB-10023 Fix "proxy not found er...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

[csantanapr]

Github user csantanapr commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/182#discussion_r47048171
  
--- Diff: bin/templates/scripts/cordova/lib/prepare.js ---
@@ -257,10 +257,11 @@ function handleBuildSettings(platformConfig, 
locations) {
 return Q();
 }
 
-function handleIcons(projectConfig, platformRoot) {
+function handleIcons(projectConfig, platformRoot, locations) {
 
 var icons = projectConfig.getIcons('ios');
-var appRoot = projectConfig.path;
+var appRoot = path.dirname(projectConfig.path);
+var originalName = path.basename(locations.xcodeCordovaProj);
--- End diff --

no need to create a new variable originalName or add 3rd parameter, use the 
value already provided here self.locations.xcodeCordovaProj




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding Search Button

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/435#issuecomment-163110477
  
@riknoll and I've again updated the PR. Please give it a look when you have 
a chance. In particular, on `md` screens the search field disappears, and the 
search button now sticks to the right of the field.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: Fixed installation instr...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/40#issuecomment-163135095
  
Ping @gtczap, could you please close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] CLI Templates

[Dmitry Blotsky]

The `--template` flag currently there is the one that was added as per this 
discussion. I think in the future we should refrain from adding code before a 
discussion completes, especially if there is contention. At the very least, we 
should probably hold a vote.

I’m definitely not a fan of adding flags just for the purpose of very specific 
convenience, but if I’m alone in that opinion then let’s do whatever the 
majority decides.

Kindly,
Dmitry

> On Dec 8, 2015, at 2:34 PM, Mefire O.  wrote:
> 
> 
> We already have support for the --template flag in Cordova.
> 
> However, it currently only supports NPM packages and GIT URLs, no local 
> folder.
> The local folder scenario is currently being handled by --copy-from (only www 
> and config.xml are copied)  and --link-to.
> 
> We also have a way of specifying default templates: throught the json file: 
> cordova_project/.cordova/config.json.
> 
> I think we should:
>   - deprecate --copy-from
>   - update the current --template logic to support local folders in addition 
> to NPM and GIT URLs
>   - fallback to using the  'cordova-hello-world' template when a critical 
> option/file/folder isn’t present in the supplied template (e.g: user did not 
> specify app_id, app_name or supplied template has no www folder)
>   - document .cordova/config.json (how it can be used to set default 
> templates)
>   - copy platforms/plugins folders when creating from a template
> 
> 
> Thanks,
> Omar Mefire  
> 
> 
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com] 
> Sent: Tuesday, December 8, 2015 10:48 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] CLI Templates
> 
> Hi Dmitry
> 1.  It was discuss in the mailing list, that use case #1 was not need it, and 
> to be replace by --template, user don't have to have config.xml and other 
> cordova specific files they will be created. So the reason to deprecate 
> --copy-from 2.  yes it's similar to a cp or git clone, but also a download of 
> npm, it will replace app name and id if they are passed in to create command 
> if template contains config.xml they will get replace, no night mare not that 
> many files to add if template purposely missing just config.xml and empty 
> folders for hooks, plugins, platform. template should have a www and any 
> other files outside www they want in their template like res/resource/  
> (cordova uses res, ionic uses resources, etc..) .gitignore, .editorconfig, 
> pacakge.json, etc.. any other files they which their app to have that 
> template will get them started with.
> 
> 
> On Mon, Dec 7, 2015 at 11:10 PM Dmitry Blotsky 
> wrote:
> 
>> Thanks for the summary, Carlos! Sorry, I hadn’t read the whole thread 
>> when I sent my question. I read up after your email, and I have a 
>> better grasp on it now. My new questions are below.
>> 
>> 1. What is the `cordova create` command then doing if it’s copying
>> (potentially) the whole app it’s trying to create? The `--copy-from` 
>> flag creates fresh copies of Cordova-specific files and only copies 
>> the `www` folder, which is app-agnostic anyway.
>> 2. Isn’t the new flag basically the same as an invocation of `cp` or 
>> `git clone`? And if we’re going into the realm of examining the 
>> template and “filling in” potentially missing files, isn’t that a 
>> logical nightmare since there are so many possible things that could be 
>> missing in an app?
>> 
>> Kindly,
>> Dmitry
>> 
>>> On Dec 5, 2015, at 7:00 AM, Carlos Santana  wrote:
>>> 
>>> The email thread has the details but in summary:
>>> It doesn't handle npm and git as source It doesn't copy everything 
>>> By adding npm and git having the flag copy-from it's confusing.
>>> 
>>> On Fri, Dec 4, 2015 at 9:04 PM Dmitry Blotsky 
>>> 
>>> wrote:
>>> 
 Hey folks. Sorry I'm late to the party, but why is `--copy-from` 
 not sufficient?
 
 Kindly,
 Dmitry
 
 -Original Message-
 From: Carlos Santana [mailto:csantan...@gmail.com]
 Sent: Friday, December 4, 2015 10:09 AM
 To: dev@cordova.apache.org
 Subject: Re: [DISCUSS] CLI Templates
 
 Michael we will love to hear your feedback, and we can improve on 
 top of what's initially there.
 
 
 On Fri, Dec 4, 2015 at 1:04 PM Carlos Santana 
 
 wrote:
 
> Michael
> Links to PRs where available for a while on the proposal.
> 
> https://github.com/apache/cordova-lib/pull/339
> https://github.com/apache/cordova-cli/pull/226
> 
> 
> On Fri, Dec 4, 2015 at 11:33 AM Michael Brooks 
> 
> wrote:
> 
>> I'd love to see a pull request rather than a straight up merge, 
>> since the template discussion was more involved. Also, I'm really 
>> looking forward to seeing your work on this!
>> 
>> On Thu, Dec 3, 2015 at 9:47 AM, 

[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-163120168
  
@emarashliev, looks like the issue has been fixed in #47 - could you please 
close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

[csantanapr]

Github user csantanapr commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/182#discussion_r47048069
  
--- Diff: bin/templates/scripts/cordova/lib/prepare.js ---
@@ -47,8 +47,8 @@ module.exports.prepare = function (cordovaProject) {
 return updateProject(self._config, self.locations);
 })
 .then(function () {
-handleIcons(cordovaProject.projectConfig, self.root);
-handleSplashScreens(cordovaProject.projectConfig, self.root);
+handleIcons(cordovaProject.projectConfig, self.root, 
self.locations);
--- End diff --

@eymorale 
instead of passing self.locations, pass the directory to use
handleIcons(cordovaProject.projectConfig, self.locations.xcodeCordovaProj);
handleSplashScreens(cordovaProject.projectConfig, 
self.locations.xcodeCordovaProj);

then no need to do basename or create new variable originalName



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9311 CB-10162 fixes app icon 87x87 an...

[csantanapr]

GitHub user csantanapr opened a pull request:

https://github.com/apache/cordova-ios/pull/183

CB-9311 CB-10162  fixes app icon 87x87 and copy errors



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/csantanapr/cordova-ios CB-9311

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #183


commit 83a3b6184230e90cf6e42254e9673e28ee218b69
Author: Carlos Santana 
Date:   2015-12-09T03:48:54Z

CB-9311 CB-10162  fixes app icon 87x87 and copy errors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: major bugs when user picture

[roysG]

GitHub user roysG opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/147

major bugs when user picture

I am sorry if this is not the right place for bug, but i can't find the 
issue category, and this is very major bugs and important to fix them.

I got from play store three different bugs that user got on their side when 
they used camera.

I will write the bugs and the devices:

1.
Device: LG Spirit LTE (c70) / android v5.0

Bug:
java.lang.RuntimeException: Unable to resume activity 
{com.pick.tags/com.pick.tags.MainActivity}: java.lang.RuntimeException: Failure 
delivering result ResultInfo{who=null, request=49, result=-1, data=Intent { 
dat=file:///storage/emulated/0/Android/data/com.pick.tags/cache/.Pic.jpg (has 
extras) }} to activity {com.pick.tags/com.pick.tags.MainActivity}: 
java.lang.NullPointerException: Attempt to invoke virtual method 'void 
org.apache.cordova.CallbackContext.error(java.lang.String)' on a null object 
reference
at 
android.app.ActivityThread.performResumeActivity(ActivityThread.java:2976)
at 
android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3007)
at 
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2373)
at android.app.ActivityThread.access$800(ActivityThread.java:149)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1284)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5299)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:908)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:703)
Caused by: java.lang.RuntimeException: Failure delivering result 
ResultInfo{who=null, request=49, result=-1, data=Intent { 
dat=file:///storage/emulated/0/Android/data/com.pick.tags/cache/.Pic.jpg (has 
extras) }} to activity {com.pick.tags/com.pick.tags.MainActivity}: 
java.lang.NullPointerException: Attempt to invoke virtual method 'void 
org.apache.cordova.CallbackContext.error(java.lang.String)' on a null object 
reference
at android.app.ActivityThread.deliverResults(ActivityThread.java:3581)
at 
android.app.ActivityThread.performResumeActivity(ActivityThread.java:2962)
... 11 more
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 
'void org.apache.cordova.CallbackContext.error(java.lang.String)' on a null 
object reference
at 
org.apache.cordova.camera.CameraLauncher.failPicture(CameraLauncher.java:1067)
at 
org.apache.cordova.camera.CameraLauncher.processPicture(CameraLauncher.java:1056)
at 
org.apache.cordova.camera.CameraLauncher.processResultFromGallery(CameraLauncher.java:594)
at 
org.apache.cordova.camera.CameraLauncher.onActivityResult(CameraLauncher.java:695)
at 
org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:120)
at 
org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:353)
at android.app.Activity.dispatchActivityResult(Activity.java:6222)
at android.app.ActivityThread.deliverResults(ActivityThread.java:3577)



2.
Device:
LG Spirit LTE (c70) / android v5.0
Bug:
java.lang.RuntimeException: Unable to resume activity 
{com.pick.tags/com.pick.tags.MainActivity}: java.lang.RuntimeException: Failure 
delivering result ResultInfo{who=null, request=49, result=-1, data=Intent { 
dat=content://media/external/images/media/4243 }} to activity 
{com.pick.tags/com.pick.tags.MainActivity}: java.lang.NullPointerException: 
Attempt to invoke virtual method 'void 
org.apache.cordova.CallbackContext.error(java.lang.String)' on a null object 
reference
at 
android.app.ActivityThread.performResumeActivity(ActivityThread.java:2976)
at 
android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3007)
at 
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2373)
at android.app.ActivityThread.access$800(ActivityThread.java:149)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1284)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5299)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:908)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:703)
Caused by: java.lang.RuntimeException: Failure delivering result 
ResultInfo{who=null, request=49, result=-1, 

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-labs/pull/10#discussion_r47014925
  
--- Diff: server.js ---
@@ -6,6 +6,11 @@ var formidable = require('formidable'),
 
 var DIRECT_UPLOAD_LIMIT = 32; // bytes
 
+// convert from UTF-8 to ISO-8859-1
+var LATIN1_SYMBOLS = '¥§©ÆÖÑøøø¼';
--- End diff --

Yeah, you're right. They're both equally difficult to maintain. I guess 
we'll just wait and see, and if it becomes a problem we can revisit it later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org