RE: Does Cordova have a problem making developers happy?

2016-03-18 Thread Ryan J. Salva
Keep in mind that the answers are limited to the technologies that Stack Overflow chooses to offer in their list of options. They have an "other" option with a text box, but people's answers are largely driven by the checkbox options. Ryan J. Salva  |  Principal PM Manager Visual Studio

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-18 Thread julio cesar sanchez
I like Jesse's proposal for #3 I think we should use a new command, I like cordova *downgrade* platform As I usually read most cordova questions on stackoverflow, most people is editing and tellign others to edit the .plist manually and doing some other manual changes. I always point them to use

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-18 Thread Carlos Santana
yep I agree Julio about adding more power to config.xml, that's basically what Mike's hook those allow tag in config.xml On Wed, Mar 16, 2016 at 10:23 AM julio cesar sanchez wrote: > I like Jesse's proposal > > for #3 I think we should use a new command, I like

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56562785 --- Diff: src/android/FileUtils.java --- @@ -347,18 +348,25 @@ else if (action.equals("write")) { threadhelper( new FileOp( ){

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579558 --- Diff: src/android/FileUtils.java --- @@ -444,17 +458,19 @@ else if (action.equals("getFile")) { threadhelper( new FileOp(

[GitHub] cordova-android pull request: CB-10894 Add supports-screens config...

2016-03-18 Thread akofman
GitHub user akofman opened a pull request: https://github.com/apache/cordova-android/pull/280 CB-10894 Add supports-screens config from the config.xml file You can merge this pull request into a Git repository by running: $ git pull https://github.com/akofman/cordova-android

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56701738 --- Diff: src/android/FileUtils.java --- @@ -433,28 +434,41 @@ public void run(JSONArray args) throws JSONException, IOException {

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-198148373 You can also refactor `needPermission` into `needWritePermission` and `needReadPermission`, and similarly you can add `getPermissionWriteFile`,

[GitHub] cordova-plugin-camera pull request: CB-10865 Run ios native tests ...

2016-03-18 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/195#discussion_r56371109 --- Diff: tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m --- @@ -304,24 +303,28 @@ - (void) testImageScaleNoCropForSize {

[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

2016-03-18 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/557#discussion_r56392768 --- Diff: www/docs/en/dev/guide/platforms/android/index.md --- @@ -299,6 +299,10 @@ To sign an app, you need the following parameters: These

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-18 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-197413662 I like #276 better, can you guys pop over, give it a look and comment on that? Thanks! --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-android pull request: CB-10837 Support platform-specific o...

2016-03-18 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/281 CB-10837 Support platform-specific orientation on Android This removes processing of "orientation" preference lets user to specify any platform-specific value for Android.

[GitHub] cordova-coho pull request: updated testing section in tools releas...

2016-03-18 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/114 updated testing section in tools release process You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-51

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-198047033 @riknoll , @dblotsky , @jasongin : Addressed feedback and added case for {create: true} flag. --- If your project is set up for it, you can reply to

[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/412 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android pull request: CB-10837 Support platform-specific o...

2016-03-18 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-android/pull/281#issuecomment-198428837 Ok, its better we leave the validation to gradle then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.

2016-03-18 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/562#issuecomment-198590861 This is just moving the docs over right? In that case LGTM (as far as I can review it)! Just make sure that #563 gets in before we publish --- If your project is

[GitHub] cordova-docs pull request: Removing prettify reference in index.js

2016-03-18 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/563#issuecomment-198592101 Whoop, good catch! LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: [DISCUSS] Tools Release

2016-03-18 Thread Mefire O .
PR issued: https://github.com/apache/cordova-lib/pull/413 Thanks, Omar Mefire On Mar 16, 2016, at 12:45 PM, Steven Gill > wrote: hmm, sounds like a reasonable solution. Right now we only reinstall plugins saved in config.xml (which prepare

[GitHub] cordova-plugin-camera pull request: Fix for CB-10050 : Plugin Came...

2016-03-18 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/183#issuecomment-197553388 I think this change is not necessary because the user could have edited the picture they picked from the PHOTOLIBRARY and want it saved (even though it

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

2016-03-18 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/51#discussion_r56393172 --- Diff: README.md --- @@ -175,6 +175,14 @@ code. ### Android Quirks - The `duration` parameter is not supported.

[GitHub] cordova-android pull request: Merge pull request #1 from apache/ma...

2016-03-18 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/275#issuecomment-197413270 I'm not sure what's going on here, can you please close this? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Does Cordova have a problem making developers happy?

2016-03-18 Thread Carlos Santana
I agree Joe It's easy to create a stackoverflow subscription that emails you once a day. I have one that covers "cordova" "worklight" "mobilefirst" I tried to answer what I can, but reading it daily which is not every day that I get something probably most every other day with a few. At least

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-18 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56722724 --- Diff: src/android/FileUtils.java --- @@ -433,28 +434,41 @@ public void run(JSONArray args) throws JSONException, IOException {

[GitHub] cordova-docs pull request: Removing prettify reference in index.js

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/563 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] cordova-ios release

2016-03-18 Thread Shazron
Another issue, the bundled ios-sim should be updated: https://issues.apache.org/jira/browse/CB-10912 On Thu, Mar 17, 2016 at 1:58 PM, Edna Y Morales wrote: > Ok sounds good > > Thanks, > *Edna Morales* > > [image: Inactive hide details for Carlos Santana ---03/17/2016

[GitHub] cordova-docs pull request: CB-10902 added tools release blog post

2016-03-18 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/561#discussion_r56729499 --- Diff: www/_posts/2016-03-21-tools-release.md --- @@ -0,0 +1,140 @@ +--- +layout: post +author: +name: Steve Gill +

[GitHub] cordova-docs pull request: CB-10679: Adding docs for new plugin ve...

2016-03-18 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/559#issuecomment-198562921 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10679: Adding docs for new plugin ve...

2016-03-18 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/559#discussion_r56729389 --- Diff: www/_posts/2016-03-16-new-plugin-fetching.md --- @@ -0,0 +1,46 @@ +--- +layout: post +author: +name: Richard Knoll

Re: [DISCUSS] Tools Release

2016-03-18 Thread Steven Gill
Please review tools release blog post: https://github.com/apache/cordova-docs/pull/561 Any other highlights I should include? -Steve On Thu, Mar 17, 2016 at 2:29 PM, Steven Gill wrote: > Tools release issue: https://issues.apache.org/jira/browse/CB-10902 > > > On Thu,

[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.

2016-03-18 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/562 Snapshotting dev to 6.x. @nikhilkh @rakatyal @riknoll please give this a glance when you have a moment. You can merge this pull request into a Git repository by running: $ git pull