Re: [Vote] 4.3.4 Ubuntu Release

2016-05-27 Thread Shazron
+1 - verified archive sigs, and git tag - created the platform on ubuntu 16.04 - built a project on ubuntu (couldn't test on device since I don't have an UbuntuTouch device) On Thu, May 26, 2016 at 9:42 AM, David Barth wrote: > Hey, > > Please review and vote on this

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-05-27 Thread Shazron
Umm yeah, my bad. Forgot that on a fresh Ubuntu system Git is not installed by default, so I had to install that. Installing Git makes the problem go away... On Fri, May 27, 2016 at 2:21 PM, Shazron wrote: > On a fresh Ubuntu 16.04 system, I: > 1. installed node 6.2.0 > 2.

[GitHub] cordova-docs pull request: CB-11157 Fixing anchor generation

2016-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-05-27 Thread Shazron
On a fresh Ubuntu 16.04 system, I: 1. installed node 6.2.0 2. installed cordova-6.2.0 3. Created a new project 4. Then `cordova platform add https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.4` I get an error: Error: Failed to fetch platform null@

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-05-27 Thread Shazron
Reviewing this today. On Tue, May 24, 2016 at 5:59 PM, Shazron wrote: > +1 go for it! > > On Thu, May 19, 2016 at 12:52 AM, David Barth > wrote: > >> Hey, >> >> Just a quick note to say I'm going to do another minor release of >> cordova-ubuntu to

RE: [DISCUSS] Cordova-windows release

2016-05-27 Thread Vladimir Kotikov (Akvelon)
Makes sense. I'll proceed w/ minor version update. The next version will be 4.4.0 - Best regards, Vladimir -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Friday, May 27, 2016 9:36 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Cordova-windows

RE: Proposal: Change Android Project Directory Structure to Android Studio style

2016-05-27 Thread Nikhil Khandelwal
As I see it, a change to the directory structure will break almost every Android plugin currently out there. There are atleast 20K references [1] on github where people use depend on the current directory structure for android: "res/xml/config.xml". Taking the example of a config.xml

RE: [DISCUSS] Cordova-windows release

2016-05-27 Thread Nikhil Khandelwal
I agree this qualifies for a minor version bump. I feel like these are the inner workings of the clean command and not a very explicit contract that we know anyone depends on. -Nikhil -Original Message- From: Jason Ginchereau [mailto:jason...@microsoft.com] Sent: Friday, May 27, 2016

[GitHub] cordova-plugin-file pull request: Update Cordova storage guide loc...

2016-05-27 Thread mbrookes
Github user mbrookes closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

RE: [DISCUSS] Cordova-windows release

2016-05-27 Thread Jason Ginchereau
How is that a breaking change? Note it doesn't affect a platform-centric workflow. I had expected only a minor version bump would be appropriate. -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Friday, May 27, 2016 2:21 AM To:

[GitHub] cordova-plugin-file pull request: CB-11305 Enable cdvfile: assets ...

2016-05-27 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/182#issuecomment-222173351 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: Master

2016-05-27 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/147#issuecomment-222163490 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file pull request: CB-11305 Enable cdvfile: assets ...

2016-05-27 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/182#issuecomment-222157371 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: Master

2016-05-27 Thread PaoloMessina
Github user PaoloMessina commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/147#issuecomment-222150059 I'm not able with travis, and how it work on test. Once installed the plugin work correctly, maybe can i fix something in thhis pull

[GitHub] cordova-plugin-file-transfer pull request: Master

2016-05-27 Thread PaoloMessina
GitHub user PaoloMessina opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/147 Master windows, android, ios new feature, download file in POST or GET and, if POST can passing data to server in json format. You can merge this pull request into a Git

[GitHub] cordova-lib pull request: CB-11274 Platform browser: wrong path fo...

2016-05-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/443#issuecomment-222141578 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera pull request: blackberry camera fixes

2016-05-27 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/187#issuecomment-222107592 Cordova CI Build has one or more failures. **Commit** -

[DISCUSS] Cordova-windows release

2016-05-27 Thread Vladimir Kotikov (Akvelon)
Hey, guys We're planning to do a major cordova-windows v.5.0.0 release. The major version bump is mostly required due to changed behavior of 'clean' command which now wipes 'www' contents as well as build artifacts which can be considered as a breaking change for some users. Here is the list

[GitHub] cordova-windows pull request: CB-11117: Optimize prepare for windo...

2016-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-11117: Optimize prepare for windo...

2016-05-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/174#issuecomment-222074009 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have