Nightly build #163 for cordova has failed

2016-09-29 Thread Apache Jenkins Server
Nightly build #163 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/163/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/163/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request #138: CB-9967

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/138


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[VOTE] create@1.0.1 & app-hello-world@3.11.0 release!

2016-09-29 Thread Steven Gill
Please review and vote on this release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-11904

Both packages have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11904/

The packages were published from their corresponding git tags:

cordova-app-hello-world: 3.11.0 (eb20135263)
cordova-create: 1.0.1 (a1c3ecda8b)

Upon a successful vote I will upload the archives to dist/, publish
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran npm test for cordova create
* Built hello world app


[GitHub] cordova-js pull request #138: CB-9967

2016-09-29 Thread audreyso
Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-js/pull/138#discussion_r81263858
  
--- Diff: tasks/lib/bundle.js ---
@@ -30,35 +30,44 @@ module.exports = function bundle(platform, debug, 
commitId, platformVersion, pla
 var scripts = collectFiles(path.join('src', 'scripts'));
 var platformDep;
 modules[''] = path.join('src', 'cordova.js');
-
+   
 //check to see if platform has cordova-js-src directory
 if(fs.existsSync(platformPath) && 
fs.existsSync(path.join(platformPath, 'cordova-js-src'))) {
+console.log(platformPath);
--- End diff --

fixed!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-app-hello-world pull request #17: CB-11938 updated csp to include co...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-app-hello-world/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-js pull request #138: CB-9967

2016-09-29 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-js/pull/138#discussion_r81262704
  
--- Diff: tasks/lib/bundle.js ---
@@ -30,35 +30,44 @@ module.exports = function bundle(platform, debug, 
commitId, platformVersion, pla
 var scripts = collectFiles(path.join('src', 'scripts'));
 var platformDep;
 modules[''] = path.join('src', 'cordova.js');
-
+   
 //check to see if platform has cordova-js-src directory
 if(fs.existsSync(platformPath) && 
fs.existsSync(path.join(platformPath, 'cordova-js-src'))) {
+console.log(platformPath);
--- End diff --

You probably meant to delete this console.log


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-app-hello-world pull request #17: CB-11938 updated csp to include co...

2016-09-29 Thread stevengill
GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-app-hello-world/pull/17

CB-11938 updated csp to include content: for img-src



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-app-hello-world master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-app-hello-world/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/257
  
I filed https://github.com/phonegap/ios-deploy/issues/258 to solve the 
symlink issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #140: CB-11642 Updated CDVAvailability.h in coho p...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/140


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #140: CB-11642 Updated CDVAvailability.h in coho p...

2016-09-29 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/140#discussion_r81260399
  
--- Diff: src/platform-release.js ---
@@ -111,7 +140,6 @@ function *updateJsSnapshot(repo, version) {
 } else if (repoutil.repoGroups.all.indexOf(repo) != -1) {
 print('*** DO NOT KNOW HOW TO UPDATE cordova.js FOR THIS REPO 
***');
 }
-}
--- End diff --

fixed!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread dpogue
Github user dpogue commented on the issue:

https://github.com/apache/cordova-ios/pull/257
  
Yeah, I was hoping to find a convenient way to override Ruby gem paths with 
environment variables or something, but for now it's probably worth just 
printing a warning for now.

I'm curious if the `--developmentTeam` is needed if you had multiple teams, 
but it's nice that for most people it will just work without issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #140: CB-11642 Updated CDVAvailability.h in coho p...

2016-09-29 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/140#discussion_r81259581
  
--- Diff: src/platform-release.js ---
@@ -111,7 +140,6 @@ function *updateJsSnapshot(repo, version) {
 } else if (repoutil.repoGroups.all.indexOf(repo) != -1) {
 print('*** DO NOT KNOW HOW TO UPDATE cordova.js FOR THIS REPO 
***');
 }
-}
--- End diff --

did this get accidentally deleted?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/257
  
@dpogue Just tested this. We need to add a warning if users are not using 
the system ruby, like the  pre-reqs check for xcodebuild (it wouldn't work like 
you said without the system ruby). I didn't even need to use the 
`--developmentTeam` flag for it to work. `cordova build --device` worked like 
it did before.

@chancezeus in `platforms\ios\device` there is already a symlink to the 
.app bundle. Unfortunately `ios-deploy` doesn't traverse the symlink for some 
reason, gives an error : `Can't access app path 
'/Users/shaz/Desktop/f/platforms/ios/build/device/my.app' : No such file or 
directory` . I'll have to make a patch release to ios-deploy for this, and 
update the minimum requirements to cordova-ios that has to go with this pull 
request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #140: CB-11642 Updated CDVAvailability.h in coho p...

2016-09-29 Thread audreyso
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-coho/pull/140

CB-11642 Updated CDVAvailability.h in coho prepare-release-branch

CB-11642 Updated CDVAvailability.h in coho prepare-release-branch. It 
affects iOS only.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-coho CB-11642

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #140


commit 729fc62973a5f37a88721baade6e637c490113b5
Author: juliascript 
Date:   2016-07-29T00:44:52Z

CB-11642 update CDVAvailability.h

commit 5f56d4a5ca75ea849c65a3cb54726c6a43e4d703
Author: juliascript 
Date:   2016-07-29T00:48:21Z

CB-11642 update CDVAvailability.h

commit 83c379cde28bc4678577ff89ee3015f85af53e7c
Author: juliascript 
Date:   2016-07-29T18:16:53Z

update npm test

commit e60c1d39324b943755348f74032680ffdccb4ace
Author: audreyso 
Date:   2016-09-29T23:26:48Z

CB-11642 updated CDVAvailability.h in coho




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-09-29 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/244
  
Merged into master: 
https://github.com/apache/cordova-ios/commit/c6587cffe7afded445500c2f30addfdf65290797
  -- you can close this PR. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] cordova-plugin-geolocation@2.4.0 Release

2016-09-29 Thread Jesse
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran coho verify-archive on the package
* Ran npm install && npm test



@purplecabbage
risingj.com

On Thu, Sep 29, 2016 at 2:40 PM, Shazron  wrote:

> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran coho verify-archive on the package
>
> On Mon, Sep 26, 2016 at 2:47 PM, Steven Gill 
> wrote:
>
> > Please review and vote on the release of this cordova-plugin-geolocation
> > release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-11904
> >
> > The plugin has been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11904/
> >
> > The package was published from its corresponding git tag:
> > cordova-plugin-geolocation: 2.4.0 (111c747823)
> >
> > Upon a successful vote I will upload the archives to dist/, upload
> > them to npm, and post the corresponding blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/
> release-voting.md
> > *NEW:*
> > How to vote on a plugins release at
> > https://github.com/apache/cordova-coho/blob/master/docs/
> > plugins-release-process.md#voting
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ensured continuous build was green when repos were tagged
> >
>


[GitHub] cordova-android issue #338: CB-11640: Fixing the checks so they check for Ja...

2016-09-29 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/338
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/338?src=pr) is 
35.15% (diff: 100%)
> Merging 
[#338](https://codecov.io/gh/apache/cordova-android/pull/338?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #338   diff @@
==
  Files12 12  
  Lines  1007   1007  
  Methods 198198  
  Messages  0  0  
  Branches168168  
==
  Hits354354  
  Misses  653653  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[30325e4...68e8100](https://codecov.io/gh/apache/cordova-android/compare/30325e4f32564cc8806bb1e100dbe4be8a0db449...68e81000635e1a2a7850c4e1545f2d2915ba6896?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-wkwebview-engine pull request #22: CB-11937 - Travis CI build...

2016-09-29 Thread shazron
GitHub user shazron opened a pull request:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/22

CB-11937 - Travis CI build failing



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-plugin-wkwebview-engine 
CB-11937

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22


commit 3437df6837ea121e4c842b62e426dde3266a998a
Author: Shazron Abdullah 
Date:   2016-09-29T22:11:30Z

CB-11937 - Travis CI build failing




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] cordova-plugin-geolocation@2.4.0 Release

2016-09-29 Thread Shazron
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran coho verify-archive on the package

On Mon, Sep 26, 2016 at 2:47 PM, Steven Gill  wrote:

> Please review and vote on the release of this cordova-plugin-geolocation
> release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-11904
>
> The plugin has been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11904/
>
> The package was published from its corresponding git tag:
> cordova-plugin-geolocation: 2.4.0 (111c747823)
>
> Upon a successful vote I will upload the archives to dist/, upload
> them to npm, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> *NEW:*
> How to vote on a plugins release at
> https://github.com/apache/cordova-coho/blob/master/docs/
> plugins-release-process.md#voting
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ensured continuous build was green when repos were tagged
>


[GitHub] cordova-android issue #338: CB-11640: Fixing the checks so they check for Ja...

2016-09-29 Thread infil00p
Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/338
  
Seriously, I can't even find info on Java 9 working with Android, and jenv 
is not letting me switch between Java 8 and Java 9, so it's definitely not 
ready for primetime. :/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #338: CB-11640: Fixing the checks so they check...

2016-09-29 Thread infil00p
GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-android/pull/338

CB-11640: Fixing the checks so they check for Java 1.8 and higher FINAL 
VERSIONS

Right now, we test for only final and not pre-release versions of the Java 
language.  Therefore, no Java 9 early candidates.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-android java_regex

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #338


commit f1b85a3f40ad928fd3bc6dd83cfcb1180725f2f5
Author: Joe Bowser 
Date:   2016-09-19T20:35:16Z

CB-11640: Changing requirements check to ask for Java 8

commit 27b3817294a48ebf157278fa9c4852b535eb33b6
Author: Joe Bowser 
Date:   2016-09-21T21:16:33Z

Tweaking the regex

commit 68e81000635e1a2a7850c4e1545f2d2915ba6896
Author: Joe Bowser 
Date:   2016-09-27T21:38:07Z

CB-11640: Fixing check_reqs.js so it actually works




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Develop a new plugin

2016-09-29 Thread Victor Sosa
Hi Deshan.

I'm not sure if there's something like a template or plugin starter, but
you can find your way going through the plugins documentation.
https://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html



On Thu, Sep 29, 2016 at 4:03 PM Deshan Kalupahana <
deshankalupah...@gmail.com> wrote:

> Hi,
>
> I have a idea to develop a Calander plugin for cordova to add events
> and reminders. How should i begin to do it?. Is there a template to
> get started or should I have to write it from scratch?
>
> thanks
>
> --
> Deshan Kalupahana,
> Undergraduate @ University of Peradeniya, Sri Lanka
> linkedin.com/in/deshankalupahana
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


Develop a new plugin

2016-09-29 Thread Deshan Kalupahana
Hi,

I have a idea to develop a Calander plugin for cordova to add events
and reminders. How should i begin to do it?. Is there a template to
get started or should I have to write it from scratch?

thanks

-- 
Deshan Kalupahana,
Undergraduate @ University of Peradeniya, Sri Lanka
linkedin.com/in/deshankalupahana

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request #645: Wrong header-file attribute. "target" should...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/645


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #494: Documentation for using cordova-lib with gulp

2016-09-29 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-lib/pull/494
  
Please close this PR and file an issue at issues.cordova.io -- why is this 
a pull request? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-geolocation issue #81: CB-11875 added android.hardware.locati...

2016-09-29 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/81
  
@mikepsinn pretty sure. 

Currently, the geolocation plugin already adds the `ACCESS_FINE_LOCATION` 
permission. So assuming we aren't removing that, we need to add the 
"android.hardware.location.gps" uses-feature. 

In this scenario, users have to remove the permission + uses feature to 
work with non-gps containing devices. If we decided to remove 
`ACCESS_FINE_LOCATION` permission and not add the uses-feature, then users 
would have to manually add those two (to their config.xml using config-file 
tag, or directly to their Android manifest). 

Seeing how we mainly target mobile devices which have GPS, it seems like it 
makes more sense to add than remove. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread ekrapfl
Github user ekrapfl commented on the issue:

https://github.com/apache/cordova-ios/pull/257
  
dpogue: I see.  I was only thinking of the case of trying to run a debug 
build on a device.  I that case, I think skipping the archiving step would 
potentially be fine.  However, if you were attempting to do a run --release 
--device, then it would need to do the archive step for proper signing.

shazron: That approach seems like it would work great as long as the .ipa 
is also kept in its original state as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/257
  
Re: unzipping the .ipa. node.js has built-in support through the zlib 
module: https://nodejs.org/docs/latest-v0.10.x/api/zlib.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request #260: CB-10078 fixed by refreshing cached userAgent...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/260


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

2016-09-29 Thread kerrishotts
Github user kerrishotts commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/114#discussion_r81187425
  
--- Diff: README.md ---
@@ -51,6 +51,206 @@ Report issues with this plugin on the [Apache Cordova 
issue tracker][Apache Cord
 
 __Note__: Extended splashscreen does not require the plugin on Windows (as 
opposed to Android and iOS) in case you don't use the plugin API, i.e. 
programmatic hide/show.
 
+### iOS-specific information
+
+There are two mechanisms for displaying a launch screen on iOS:
+
+1. Legacy launch images: images are sized exactly for the device's screen 
size. Does not support the iPad Pro 12.9's native resolution or 
split-screen/slide-over multitasking.
+
+2. Launch storyboard images: Images are sized based on scale, idiom, and 
size classes. Supports all devices, and can be used with 
split-screen/slide-over multitasking.
+
+Apple is moving away from legacy launch images. There is no official 
support for providing a native-resolution launch image for the iPad pro 12.9 or 
for providing launch images that work with split-screen multitasking or 
slide-over. If your app doesn't need to support these contexts, then you can 
continue to use legacy launch images for as long as you like. 
--- End diff --

fixed; thanks for catching it! :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

2016-09-29 Thread kerrishotts
Github user kerrishotts commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/114#discussion_r81187431
  
--- Diff: README.md ---
@@ -51,6 +51,206 @@ Report issues with this plugin on the [Apache Cordova 
issue tracker][Apache Cord
 
 __Note__: Extended splashscreen does not require the plugin on Windows (as 
opposed to Android and iOS) in case you don't use the plugin API, i.e. 
programmatic hide/show.
 
+### iOS-specific information
+
+There are two mechanisms for displaying a launch screen on iOS:
+
+1. Legacy launch images: images are sized exactly for the device's screen 
size. Does not support the iPad Pro 12.9's native resolution or 
split-screen/slide-over multitasking.
+
+2. Launch storyboard images: Images are sized based on scale, idiom, and 
size classes. Supports all devices, and can be used with 
split-screen/slide-over multitasking.
+
+Apple is moving away from legacy launch images. There is no official 
support for providing a native-resolution launch image for the iPad pro 12.9 or 
for providing launch images that work with split-screen multitasking or 
slide-over. If your app doesn't need to support these contexts, then you can 
continue to use legacy launch images for as long as you like. 
+
+The preferred method of providing launch images is to use a launch 
storyboard. For native app developers, the ideal launch storyboard is an 
unpopulated version of the app's user interface at launch. For non-native app 
developers who don't wish to learn interface builder, however, this plugin 
simulates the legacy launch image method as much as is feasible.
--- End diff --

fixed; thanks for catching it! :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread dpogue
Github user dpogue commented on the issue:

https://github.com/apache/cordova-ios/pull/257
  
The only reasons to go through the archive step is to ensure that the build 
is signed with the right certificates. Building and deploying the .app directly 
would be signed with a development certificate instead of a distribution one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [Discuss] Cordova-Android 6.0.x

2016-09-29 Thread Joe Bowser
OK, so it's been a while.  I think we're ready for a release of this soon.
I just have to fix up check_reqs so it works, and then we can move forward
with the Cordova-Android 6.0.0 release.

Should we start the vote thread on Monday?

On Tue, Sep 13, 2016 at 11:24 AM, Joe Bowser  wrote:

> No, I have no intention of pulling that into this release, since the
> corresponding Android code caused performance issues due to numerous file
> reads.
>
> On Tue, Sep 13, 2016 at 11:21 AM, Darryl Pogue  wrote:
>
>> Just wanted to check whether this cordova-lib change was intended to get
>> pulled in as part of the Cordova Android 6 release:
>> https://github.com/apache/cordova-lib/pull/469
>>
>> If it is, I have an additional commit to add that fixes the JS spec tests:
>> https://github.com/infil00p/cordova-lib/pull/1
>>
>>
>> On 13 September 2016 at 10:30, Joe Bowser  wrote:
>>
>> > OK, so it looks like all our ducks are lined up and we should be ready
>> for
>> > a 6.0 release pretty soon.  How do people feel about doing testing this
>> > week, and getting the vote thread going on Monday? I know the vote
>> thread
>> > is only 72 hours, so I want a bit more testing on the major before we
>> do it
>> > because the PRs haven't been getting the attention that I wanted them
>> to.
>> >
>> > What do people think?
>> >
>> > On Thu, Sep 8, 2016 at 2:54 PM, Shazron  wrote:
>> >
>> > > Ask Crosswalk to:
>> > > "To detach the fork and turn it into a standalone repository on
>> GitHub,
>> > > contact GitHub Support."
>> > >
>> > > From:
>> > > https://help.github.com/articles/why-are-my-
>> > contributions-not-showing-up-
>> > > on-my-profile/
>> > >
>> > >
>> > >
>> > > On Thu, Sep 8, 2016 at 2:46 PM, Joe Bowser  wrote:
>> > >
>> > > > Hey
>> > > >
>> > > > So, this is exciting.  Things are broken on Master if you're trying
>> to
>> > > use
>> > > > Cordova with Jellybean.  Apparently we forgot to add a failsafe for
>> the
>> > > > bridge to go back to APIs lower than 19, so the bridge doesn't work
>> if
>> > > > you're targeting people still on Jellybean.  Unfortunately, we still
>> > have
>> > > > to support Jellybean despite the fact that their jsToNativeBridge is
>> > > > prompt.
>> > > >
>> > > > Also, I just realized that I can't send a PR to Crosswalk, since I
>> own
>> > > the
>> > > > initial crosswalk repo on GitHub. (Oops!)  This means that I need
>> > someone
>> > > > from the Crosswalk project to adopt these changes here to get this
>> to
>> > > work
>> > > > on Cordova-Android 6.0.0
>> > > >
>> > > > https://github.com/infil00p/cordova-crosswalk-engine/tree/
>> > > Crosswalk_Compat
>> > > >
>> > > > I'm tempted to nuke the thing in the near future, since the
>> Crosswalk
>> > > > Project should be managing the repository and their repository
>> should
>> > be
>> > > > the canonical source for everything Crosswalk/Cordova related and
>> not
>> > my
>> > > > prototype repo. :P
>> > > >
>> > > > So, is anyone using the stock webview for Jellybean, and should we
>> > spend
>> > > > time fixing this issue? We changed the webview because we found that
>> > > using
>> > > > multiple webviews in an application was falling apart, and we needed
>> > this
>> > > > change for stability so we knew which callbacks go to which
>> instance of
>> > > > webview.  However, if people reviewed the patch requests, they would
>> > have
>> > > > noticed that this doesn't work on API 16. :(
>> > > >
>> > > > I'm going to go by the assumption that we want this fixed until I
>> hear
>> > > > otherwise for now.  That said, if people think it's reasonable to
>> > > recommend
>> > > > that people targeting Jellybean use Crosswalk, I'm cool with that as
>> > > well.
>> > > >
>> > > > Thoughts?
>> > > >
>> > > >
>> > > >
>> > > > On Tue, Sep 6, 2016 at 11:25 AM, julio cesar sanchez <
>> > > > jcesarmob...@gmail.com
>> > > > > wrote:
>> > > >
>> > > > > Those 2 lines have minSdkVersion 14
>> > > > >
>> > > > > https://github.com/apache/cordova-android/blob/master/
>> > > > > framework/AndroidManifest.xml#L22
>> > > > > https://github.com/apache/cordova-android/blob/master/
>> > > > > test/AndroidManifest.xml#L48
>> > > > >
>> > > > > Maybe I looked into the wrong place and that is not being used
>> > > > >
>> > > > >
>> > > > >
>> > > > > El martes, 6 de septiembre de 2016, Joe Bowser > > > > > > escribió:
>> > > > >
>> > > > > > On Tue, Sep 6, 2016 at 11:14 AM, julio cesar sanchez <
>> > > > > > jcesarmob...@gmail.com
>> > > > > > > wrote:
>> > > > > >
>> > > > > > > Now we shouldn't forget to increase the minSdkVersion. I
>> couldn't
>> > > > find
>> > > > > an
>> > > > > > > issue open for this. Which API level did we say that we will
>> > > support?
>> > > > > 16?
>> > > > > > >
>> > > > > > >
>> > > > > > Yes, we said 16.  I already did it when bumping up to API 24,
>> but
>> 

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

2016-09-29 Thread fredgalvao
Github user fredgalvao commented on the issue:

https://github.com/apache/cordova-ios/pull/228
  
Is there any reason why this PR doesn't also export `CFBundleName` as the 
result of the short name on config.xml? Follow me for a while:

According to [this page on the developer 
portal](https://developer.apple.com/library/content/qa/qa1892/_index.html) it 
seems like these two properties go along and, unless they are too big, should 
most probably have the same value.

Now, with the recent findings and issues related to renaming projects 
(which causes malformed pbxproj files and unsolvable string search 
operations), it seems to me like we could simply leave the project structure 
and project name (not to be confused with app name) a generic static value, and 
deal with the `` and `` outputing them to 
`CFBundleDisplayName` and `CFBundleName` respectively.

That's what I did when I evolved my cordova project into a whitelabel, so 
that I could generate different apps with the same code base. However, in my 
case I needed to use a string replacement on `build.gradle` to set the 
`applicationId` on android (the app name works fine, it's updated in the 
string.xml correctly and my main activity class doesn't need to be renamed). 
There's an [issue](https://issues.apache.org/jira/browse/CB-11374) for the 
`applicationId` thing too, btw. On iOS, I also had to use 
[cordova-plugin-app-name](https://github.com/blakgeek/cordova-plugin-app-name/blob/master/plugin.xml)
 to deal with the "renaming breaks the project" issue (leaving the `` 
untouched, otherwise I'd be screwed).

## Summary of my _opinion_

To evolve into a more whitelabel-friendly structure with respect to naming 
apps:

- Evolve `` and `` handling to affect **ONLY** 
{`strings.xml`@`app_name`} on android, and {`CFBundleName` + 
`CFBundleDisplayName`} on iOS, leaving the following items with a generic 
static name [activity class name on android, xcode project files (plist, 
pbxproj)].

Please @shazron and @dpogue tell me what you think of all of this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file issue #195: CB-11848 windows: Remove duplicate slash aft...

2016-09-29 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/195
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/195/commits/62fa66bff4daadd8297f15bfdaa931add7decb62)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file issue #195: CB-11848 windows: Remove duplicate slash aft...

2016-09-29 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/195
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/195/commits/b90d25c78f14bf0ca55b02f49f40278250663d5e)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread ekrapfl
Github user ekrapfl commented on the issue:

https://github.com/apache/cordova-ios/pull/257
  
Out of curiosity, is there any reason to do the archive step at all when 
building in order to run?  Perhaps there could be an option to skip archiving, 
which would be called when doing a run.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView

2016-09-29 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/337
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/337?src=pr) is 
35.15% (diff: 100%)
> Merging 
[#337](https://codecov.io/gh/apache/cordova-android/pull/337?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #337   diff @@
==
  Files12 12  
  Lines  1007   1007  
  Methods 198198  
  Messages  0  0  
  Branches168168  
==
  Hits354354  
  Misses  653653  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[30325e4...9357737](https://codecov.io/gh/apache/cordova-android/compare/30325e4f32564cc8806bb1e100dbe4be8a0db449...9357737f3c6f7396af947c5c4529cba7022882b0?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request #645: Wrong header-file attribute. "target" should...

2016-09-29 Thread psavard
GitHub user psavard opened a pull request:

https://github.com/apache/cordova-docs/pull/645

Wrong header-file attribute. "target" should be "target-dir" instead.

Attribute "target" of header-file does nothing to the file, It's still 
copied to the root of the plugin folder. Using "target-dir" will create the 
necessary folder and copy the file at the right place.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/psavard/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/645.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #645


commit e1fa06d9e958ac045abc6122aab91b70049cdac4
Author: psavard 
Date:   2016-09-29T12:58:38Z

Change Header-file's "target" attribute to "target-dir"

Attribute "target" of header-file does nothing to the file, It's still 
copied to the root of the plugin folder. "target-dir" will create the necessary 
folder and copy the file at the right place.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #337: CB-11935 Call onPause & onResume on WebVi...

2016-09-29 Thread spirann
GitHub user spirann opened a pull request:

https://github.com/apache/cordova-android/pull/337

CB-11935 Call onPause & onResume on WebView

Does a best-effort attempt to pause any processing that can be paused 
safely, such as animations and geolocation.
Fix the potential rejection from Play Store

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/spirann/cordova-android master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #337


commit 9357737f3c6f7396af947c5c4529cba7022882b0
Author: Simon Pireyn 
Date:   2016-09-29T12:47:19Z

CB-11935 Does a best-effort attempt to pause any processing that can be 
paused safely, such as animations and geolocation.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file issue #195: CB-11848 windows: Remove duplicate slash aft...

2016-09-29 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/195
  
@vladimir-kotikov, updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request #197: CB-11522 [windows] Make cordova-js clone ...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/197


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-js pull request #137: CB-11522 [windows] Make cordova-js clone handl...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/137


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #333: CB-11869 Fix cordova-js android exec test...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/333


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-js issue #137: CB-11522 [windows] Make cordova-js clone handle 'unkn...

2016-09-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-js/pull/137
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #333: CB-11869 Fix cordova-js android exec tests

2016-09-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-android/pull/333
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #494: Documentation for using cordova-lib with gulp

2016-09-29 Thread mspace
GitHub user mspace opened a pull request:

https://github.com/apache/cordova-lib/pull/494

Documentation for using cordova-lib with gulp

Is there any documentation available or will be for using cordova-lib with 
gulp tasks. For example

```javascript
gulp.task("build-apk", [], function(cb) {

  console.log("Task: build-apk");
  cordova.build({
"platforms": ["android"],
"options": { argv: ["--debug", "--gradleArg=--no-daemon", 
"--buildConfig=build.json"] } // cordova > 5.4.0
//"options": ["--release", "--gradleArg=--no-daemon", 
"--buildConfig=build.json"] // cordova < 5.4.0
  }, function (cb1) { // cordova -> The callback is passed the error object 
upon failure, or undefined upon success.
console.log("Build release completed." + cb1);
cb(cb1); // cb(err); // if err is not null and not undefined, the run 
will stop, and note that it failed
return;
  });
});
```

where could documentation for cordova-build be found. I ended up looking at 
source code 
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/util.js#L294.
 Additionally where what functions are available cordova.clean, cordova.build, 
...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cordova-lib 6.3.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/494.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #494


commit 91571407f985644c65dedb5f7e56f2f16eeffaf7
Author: Vladimir Kotikov 
Date:   2016-07-12T15:57:49Z

CB-11569 Bump pinned platforms' versions

commit 0d65e91451f63c60879e5189daf164583e949fc1
Author: Vladimir Kotikov 
Date:   2016-07-12T15:47:54Z

CB-11569 Updated version and RELEASENOTES.md for cordova-fetch release 1.0.1

commit 3df3a38da2e43584c92343b9056a88901083ceb1
Author: Vladimir Kotikov 
Date:   2016-07-12T15:48:25Z

CB-11569 Updated version and RELEASENOTES.md for cordova-common release 
1.4.0

commit 09ab5bbc73da253f6badb0979a27c3118596
Author: Vladimir Kotikov 
Date:   2016-07-12T15:48:46Z

CB-11569 Updated version and RELEASENOTES.md for cordova-lib release 6.3.0

commit 634202255d1c0e86ed8845a673818e5add7d7b1b
Author: Darryl Pogue 
Date:   2016-07-15T18:23:27Z

CB-11589: Fix missing plugin files after restore

 This closes #464

commit b5dc35bac1ac0391237c04bcb76a34fe82607d64
Author: Nikita Matrosov 
Date:   2016-07-29T11:47:44Z

CB-11205 Respect saved variables when installing plugin

This closes #471

commit e4f30ceefd39e646d0513c50a1d17900995a4f50
Author: gruppjo 
Date:   2016-06-27T14:50:02Z

CB-11493: Add cordova emulate option to skip prepare

 This closes #459

commit 647852e5e48f779cc99c91b470d35b177644c342
Author: Jesse MacFadyen 
Date:   2016-07-01T23:35:53Z

CB-11194 Defer creating of libDir folder until something actually requests 
it

This closes #462

commit 9b023d1bdd4c26bb94da751d3bc270dab3ae1ceb
Author: Vladimir Kotikov 
Date:   2016-08-02T12:08:24Z

CB-11652 Update run and emulate to skip build

We need to add this conditional logic to cordova's `run` and
`emulate` methods to skip build when `--nobuild` option is
specified. CLI previously has delegated this logic to platform's
`run` method but since introducing `before_deploy` hook we call
platform's `build` and `run` separately and so we need to handle
this option in CLI

commit a2736f594c47c0ecb173ea7f17d9ffa18758752a
Author: Vladimir Kotikov 
Date:   2016-08-08T07:55:36Z

CB-11685 Updated version and RELEASENOTES.md for 6.3.1 release




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Nightly build #162 for cordova has failed

2016-09-29 Thread Apache Jenkins Server
Nightly build #162 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/162/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/162/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2016-09-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-lib/pull/453
  
I think we should as shortName is part of the W3C Widget spec


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts issue #136: CB-11028 android: Allow to set custom la...

2016-09-29 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/136
  
@vladimir-kotikov, updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org