[GitHub] cordova-js pull request #139: CB-12017: updated dependencies in package.json

2016-10-13 Thread stevengill 
GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-js/pull/139

CB-12017: updated dependencies in package.json



### Platforms affected
cordova-js

### What does this PR do?
updates outdated dependencies, fixes security issues with old versions of 
dependencies. 

### What testing has been done on this change?
npm test

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-js CB-12017

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-js/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit 4f28160d2c4e9f5d5f4148bb5ff6cd2c58904ce3
Author: Steve Gill 
Date:   2016-10-14T03:00:59Z

CB-12017: updated dependencies in package.json




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js issue #133: Update Cordova.js

2016-10-13 Thread stevengill 
Github user stevengill commented on the issue:

https://github.com/apache/cordova-js/pull/133
  
Hey @chander12shekhar! Can you explain this a bit more? Do you have a 
corresponding issue? issues.cordova.io


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #177 for cordova has succeeded!

2016-10-13 Thread Apache Jenkins Server 
Nightly build #177 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/177/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #246: CB-11100 Update dependencies to avoid installation w...

2016-10-13 Thread stevengill 
Github user stevengill commented on the issue:

https://github.com/apache/cordova-cli/pull/246
  
Just sent an updated PR removing grunt and updating istanbul. 
https://github.com/apache/cordova-cli/pull/264

Feel free to close this PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #264: CB-11100 removed grunt and grunt-retire dev-d...

2016-10-13 Thread stevengill 
GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-cli/pull/264

CB-11100 removed grunt and grunt-retire dev-deps, updated istanbul de…



### Platforms affected
none

### What does this PR do?
removes unused dev dependencies, updates the version of istanbul dev 
dependency to get rid of deprecation notices

### What testing has been done on this change?
npm test && npm run cover

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [] Added automated test coverage as appropriate for this change.

…v-dep

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-cli CB-11100

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #264


commit b72536597de2341f87868521d3e3d947ccbf24ee
Author: Steve Gill 
Date:   2016-10-14T02:40:55Z

CB-11100 removed grunt and grunt-retire dev-deps, updated istanbul dev-dep




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #255: CLI Refactor

2016-10-13 Thread stevengill 
Github user stevengill commented on the issue:

https://github.com/apache/cordova-cli/pull/255
  
Hey @omefire, should i review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

2016-10-13 Thread stevengill 
Github user stevengill commented on the issue:

https://github.com/apache/cordova-cli/pull/263
  
hows it going on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...

2016-10-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #485: CB-11771 Deep symlink directories to target p...

2016-10-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/485


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #485: CB-11771 Deep symlink directories to target project ...

2016-10-13 Thread stevengill 
Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/485
  
I confirmed the leaking! Your patch solves the problem. Thanks!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #326: CB-11771 Deep symlink directories to targ...

2016-10-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/326


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #326: CB-11771 Deep symlink directories to target proj...

2016-10-13 Thread stevengill 
Github user stevengill commented on the issue:

https://github.com/apache/cordova-android/pull/326
  
I confirmed the leaking and your patch solves the problem. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #501: CB-11951 CB-11967: Respect preference default...

2016-10-13 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/501#discussion_r83341216
  
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -203,6 +204,23 @@ describe('plugin end-to-end', function() {
 .fin(done);
 });
 
+it('should respect preference default values', function (done) {
+   addPlugin(path.join(pluginsDir, org_test_defaultvariables), 
org_test_defaultvariables, {cli_variables: { REQUIRED:'NO', 
REQUIRED_ANDROID:'NO'}}, done)
+   .then(function() {
+var platformJsonPath = path.join(project, 'plugins', 
helpers.testPlatform + '.json');
+var installed_plugins = 
JSON.parse(fs.readFileSync(platformJsonPath)).installed_plugins;
--- End diff --

Instead of `JSON.parse` & `fs.readFileSync`, why not use 
```var installed_plugins = require('platformJsonPath').installed_plugins;```

That would remove the need to `require('fs')`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #503: CB-11994 - appveyor tests on cordova-lib are ...

2016-10-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/503


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Brief introduction Octavio Bokel

2016-10-13 Thread Joe Bowser 
Hey

Can you send me a link to the PR so I can check the fix and make sure it's
not directly related to something that we already have committed/fixed?  We
currently have open PRs waiting to be merged into Camera once we finally
release Cordova-Android 6.0.0, which adds Nougat Support.

Thanks

Joe

On Wed, Oct 12, 2016 at 6:05 PM, Dobra9 (Octavio)  wrote:

> Hello.
>
> Just want to introduce myself.
>
> I am Octavio Bokel, and reticently fixed a bug in cordova-plugin-camera
> plugin for Android. I am CEO at Woopter (www.woopter.com) and this bug as
> direct affection our app.
>
> Since I tested and believe that it might help the community, I want to be
> able to do a pull request. After that, I want to continue contributing. I
> always liked the open source community philosophy.
>
> I could not subscribe to MarkMail yet since it is offline, I will do it
> soon.
>
> Thanks for your attention.
>
> Octavio Bokel
>

RE: Brief introduction Octavio Bokel

2016-10-13 Thread Ryan J. Salva 
Hi, Octavio and thanks for the bug fix!



Ryan J. Salva  |  Principal PM Manager
Visual Studio Mobile Developer Tools
rsa...@microsoft.com
425 706 5270 office
206 612 5079 mobile

-Original Message-
From: Dobra9 (Octavio) [mailto:dob...@gmail.com] 
Sent: Wednesday, October 12, 2016 8:05 PM
To: dev@cordova.apache.org
Subject: Brief introduction Octavio Bokel

Hello.

Just want to introduce myself.

I am Octavio Bokel, and reticently fixed a bug in cordova-plugin-camera plugin 
for Android. I am CEO at Woopter 
(https://na01.safelinks.protection.outlook.com/?url=www.woopter.com=01%7C01%7Crsalva%40microsoft.com%7C4a045b3a3ee849e9243408d3f396bfba%7C72f988bf86f141af91ab2d7cd011db47%7C1=XlZ2m53YZonilIsDp5duToqZrRzcNpsyEpCefTN4K%2Fs%3D=0)
 and this bug as direct affection our app.

Since I tested and believe that it might help the community, I want to be able 
to do a pull request. After that, I want to continue contributing. I always 
liked the open source community philosophy.

I could not subscribe to MarkMail yet since it is offline, I will do it soon.

Thanks for your attention.

Octavio Bokel

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Brief introduction Octavio Bokel

2016-10-13 Thread Dobra9 (Octavio) 
Hello.

Just want to introduce myself.

I am Octavio Bokel, and reticently fixed a bug in cordova-plugin-camera
plugin for Android. I am CEO at Woopter (www.woopter.com) and this bug as
direct affection our app.

Since I tested and believe that it might help the community, I want to be
able to do a pull request. After that, I want to continue contributing. I
always liked the open source community philosophy.

I could not subscribe to MarkMail yet since it is offline, I will do it
soon.

Thanks for your attention.

Octavio Bokel

[GitHub] cordova-plugin-splashscreen issue #116: CB-12011: (android) added the possib...

2016-10-13 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/116
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-splashscreen/pull/116/commits/a13a07960ce863c990956b4194f3ed0d9923ae40)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/29//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #191: CB-12010 (android) Catch FileUriExpo...

2016-10-13 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/191
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/191/commits/efae0573dd6e56205a3ce3615c9ef8edf0ce7623)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #161: Allowing chunkedMode to be false on...

2016-10-13 Thread cordova-qa 
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/161
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request #161: Allowing chunkedMode to be f...

2016-10-13 Thread Webpal 
GitHub user Webpal opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/161

Allowing chunkedMode to be false on Android / https



### Platforms affected
Android

### What does this PR do?
File uploads over https were automatically turned to Transfer-encoding: 
chunked due to old Android issues. Since adding this header to transfers often 
breaks functionality (for example you can't add an additional header to an 
Amazon S3 request that was signed without it) - isn't it better to follow the 
users instruction to use chunked mode or not instead of overwriting it? 

### What testing has been done on this change?
Only deployed on one Android device, can not verify that it doesn't cause 
OOM issues - but this option is available as a setting for the user to controll 
in js.

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Webpal/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #161


commit e836377a0ff6e2fda810f65a8220413b2095a3ec
Author: Webpal 
Date:   2016-10-13T11:44:11Z

Update FileTransfer.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #191: CB-12010 (android) Catch File...

2016-10-13 Thread alsorokin 
GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/191

CB-12010 (android) Catch FileUriExposedException

### Platforms affected
Android

### What does this PR do?
Fixes a crash on Android 7.0 devices when trying to open a file URI in the 
system browser.

### What testing has been done on this change?
Manual testing on Android 7.0 emulator

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change - *can 
only be tested manually*.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-inappbrowser CB-12010

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #191


commit efae0573dd6e56205a3ce3615c9ef8edf0ce7623
Author: Alexander Sorokin 
Date:   2016-10-13T10:29:23Z

CB-12010 (android) Catch FileUriExposedException




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org