[GitHub] cordova-plugin-battery-status pull request #44: CB-8929 Fix failing tests on...

2016-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-battery-status issue #44: CB-8929 Fix failing tests on iOS

2016-11-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/44 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-battery-status pull request #44: CB-8929 Fix failing tests on...

2016-11-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/44 CB-8929 Fix failing tests on iOS ### Platforms affected ### What does this PR do? ### What testing has been done on this change?

[GitHub] cordova-plugin-splashscreen issue #117: CB-12062: (ios) Fix crash when liste...

2016-11-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/117 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-splashscreen issue #117: CB-12062: (ios) Fix crash when liste...

2016-11-09 Thread PaulTaykalo
Github user PaulTaykalo commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/117 @shazron done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Nightly build #222 for cordova has succeeded!

2016-11-09 Thread Apache Jenkins Server
Nightly build #222 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/222/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-ios issue #275: CB-12127 - Add buildFlag support in build.json

2016-11-09 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/275 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/275?src=pr) is 60.00% (diff: 0.00%) > Merging [#275](https://codecov.io/gh/apache/cordova-ios/pull/275?src=pr) into

[GitHub] cordova-plugin-statusbar issue #67: CB-12024: Browser platform support

2016-11-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/67 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-docs issue #662: CB-12127 - (ios) Add buildFlag support in build.jso...

2016-11-09 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/662 Pull this in for cordova-ios 4.3.1 release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request #662: CB-12127 - Add buildFlag support in build.js...

2016-11-09 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/662 CB-12127 - Add buildFlag support in build.json ### Platforms affected iOS ### What does this PR do? Document the "buildFlag" option in build.json ### What

[GitHub] cordova-ios pull request #275: CB-12127 - Add buildFlag support in build.jso...

2016-11-09 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/275 CB-12127 - Add buildFlag support in build.json ### Platforms affected iOS ### What does this PR do? Add build.json support for the "buildFlag" key. The value for the

[GitHub] cordova-docs pull request #629: Update index.md according to CB-11705

2016-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-splashscreen issue #117: CB-12062: (ios) Fix crash when liste...

2016-11-09 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/117 Thanks! Can you add the Apache License headers to the .h and .m files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

2016-11-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 I think it makes more sense for photo gallery images, as you might have downloaded them with a low resolution, or maybe when using the front camera in some devices with less than

Help for Cordova

2016-11-09 Thread Sagar Gajera
Dear Sir, I have been using cordova since last 2 years. I have developed one cordova application which is built on backboneJS and is running on Android,iOS,Windows and Blackberry platforms. Here I am writing to get help from you for below points. - I have integrated Apple watch in

[GitHub] cordova-plugin-camera issue #178: Create Pictures directory if it doesn't ex...

2016-11-09 Thread TheBosZ
Github user TheBosZ commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/178 It probably failed because this branch is out of date. I can't for the life of me remember the exact device this happened to. It's a very straightforward fix, but I've

[GitHub] cordova-plugin-camera issue #124: [android] fix crop from gallery doesn't wo...

2016-11-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/124 Works for me, closing this really old issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-camera issue #112: CB-9446 Fix real path returning null point...

2016-11-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/112 OK, do we still need this, or does the N fix also fix this? More testing is needed. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-camera pull request #124: [android] fix crop from gallery doe...

2016-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera issue #192: [Android] Prevent edited image to replace ...

2016-11-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/192 Can you fix the conflicts, and create a JIRA for this issue? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-camera issue #169: separate FILE_URI and NATIVE_URI / take in...

2016-11-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/169 The web doesn't know what content URIs are, so we should never return them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...

2016-11-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/170 There's tons of problems with getRealPath, we should be using the FilesProvider to access files instead, since it actually maps to real locations on the disk instead of messing with

[GitHub] cordova-plugin-camera issue #178: Create Pictures directory if it doesn't ex...

2016-11-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/178 Which device doesn't have this folder? Also, for some reason this failed Travis. Can you clean up the conficts, create a JIRA issue and provide more details for the repro? Thanks!

[GitHub] cordova-plugin-camera issue #220: Fix Android bug in permission requests

2016-11-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/220 https://issues.apache.org/jira/browse/CB-12126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-camera issue #220: Fix Android bug in permission requests

2016-11-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/220 What device does this behaviour show up in? I think the Google Pixel and Nexus 5X have something causing the bug to not appear that other devices don't have, since I can't actually

[GitHub] cordova-plugin-camera issue #221: android fix: image from gallery not compre...

2016-11-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/221 There is only FILE_URI and NATIVE_URI. Can you fix the conflicts that arose from the Nougat fix? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

2016-11-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 Yeah, I'm cool with this being in here, but I need to run more tests to see when this is the case. (The original height/width is usually HUGE) --- If your project is set up for it,

Re: camera plugin - target bigger than original picture

2016-11-09 Thread Joe Bowser
+1 to this PR On Mon, Oct 10, 2016 at 10:38 AM, Shazron wrote: > +1 but with caveats as I outlined in the PR. > > On Mon, Oct 10, 2016 at 10:16 AM, julio cesar sanchez < > jcesarmob...@gmail.com> wrote: > > > I was the one who asked for the email as I think we should discuss

[GitHub] cordova-docs issue #661: Corrected spelling

2016-11-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/661 Merged. @thomastthai, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request #661: Corrected spelling

2016-11-09 Thread thomastthai
GitHub user thomastthai opened a pull request: https://github.com/apache/cordova-docs/pull/661 Corrected spelling ### Platforms affected None ### What does this PR do? Corrected website spelling. ### What testing has been done on this change?