date:20161212

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-12 Thread alsorokin

Github user alsorokin commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/18#discussion_r92111761
  
--- Diff: package.json ---
@@ -51,7 +51,7 @@
 "wd": "^0.4.0"
   },
   "devDependencies": {
-"jasmine-node": "~1",
-"jshint": "^2.6.0"
+"jshint": "^2.6.0",
+"appium": "1.5.3"
--- End diff --

Adding Appium to dependencies would drastically increase paramedic install 
time for every build on CI, while only a small subset of them actually needs it.
I think we can still install this particular version via executing `npm i 
appium@1.5.3` in `installAppiumServer()` function, aren't we?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-12 Thread alsorokin

Github user alsorokin commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/18#discussion_r92113708
  
--- Diff: lib/appium/AppiumRunner.js ---
@@ -419,8 +411,9 @@ AppiumRunner.prototype.prepareApp = function () {
 var deviceString = self.options.device ? ' --device' : '';
 var buildCommand = 'cordova build ' + self.options.platform + 
deviceString;
 
+// TODO: is removing medic.json still needed?
--- End diff --

Yes, this is still needed because we use this file to pass local medic 
server URI to paramedic plugin so it could report test results back to 
paramedic. We remove it before the Appium run so the test framework plugin 
won't start plugin tests right away.
So, basically this is needed to run Appium tests without running other 
plugin tests simultaneously.
This probably should've been mentioned by me in this comment ð¼ 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

2016-12-12 Thread alsorokin

Github user alsorokin commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/18#discussion_r92112118
  
--- Diff: lib/paramedic.js ---
@@ -271,9 +271,13 @@ ParamedicRunner.prototype.runLocalTests = function () {
 })
 .then(function(command) {
 self.setPermissions();
-logger.normal('cordova-paramedic: running command ' + command);
 
-return execPromise(command);
+if (!self.config.runMainTests()) {
--- End diff --

This change would break local Android Appium run, I believe. See the 
comment on line 283.
We need to boot up an Android emulator for Appium to run tests on and 
skipping this command would skip starting the emulator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] EOL cordova-medic

2016-12-12 Thread Vladimir Kotikov (Akvelon)

Hey all!

I’m +1 for killing Medic, since it hasn’t been used for months and I guess 
hardly ever will be used in the future.

Though I have a bit different proposal about moving configs – IMO they are a 
part of CI and should live somewhere inside a CI. I don’t think there is a need 
to either exhibit them to public or make them easily editable by anybody – the 
current practice demonstrates that the only one who really needs to see or edit 
these configs is the CI maintainer. From the implementation side, I think we 
can just reuse one of the millions of Jenkins plugins (maybe this: 
https://wiki.jenkins-ci.org/display/JENKINS/Config+File+Provider+Plugin)

> Substantial code was added to paramedic to support some other use cases 
> (Appium, Sauce, ...), but I would still REALLY like to prevent us turning 
> paramedic into a behemoth travelling hospital ... it may already be too late 
> though.

Jesse, I share your concerns! Just want to say that despite it became really 
complex, and the code is far from ideal, paramedic really does its job!
I wish we could have a bit of spare time and some free hands to redesign it and 
make it lightweight and modular (I think all that added functionality, like 
Appium and Sauce support, easily could be moved out of paramedic into “plugins”)

-
Best regards, Vladimir

On 12/13/16, 01:03, "Filip Maj"  wrote:

On Mon, Dec 12, 2016 at 1:46 PM, Jesse  wrote:
> What would be the added responsibilities for cordova-paramedic?

Good question. As far as I can tell, I believe paramedic would need to
additionally house the helper JSON files containing configuration that
one passes into paramedic - basically replacing the various flags one
can run paramedic with with a single one pointing to a file instead.

In particular, the Jenkins configs that the cloudapp CI uses that it
feeds into paramedic [1] - including the "local" ones used for local
testing [2], which seem particularly relevant to paramedic's mission.
This would save our Jenkins instance from pulling the medic repo down,
speeding up test execution (it seems silly to clone a whole repo just
to pull a few JSON files out!).

So right now, when I want to run paramedic locally, I invoke something like:

$ node cordova-paramedic/main.js --platform android --plugin
./cordova-plugin-contacts --verbose --cleanUpAfterRun

I can reduce on the flags passed in by pointing paramedic to the
afore-mentioned local configs, but, these currently exist in the medic
repo. So I've actually been running paramedic recently like so:

$ node cordova-paramedic/main.js --plugin
./cordova-plugin-contacts --config
./cordova-medic/jenkins-conf/pr/local/android-5.1.config.json

The above incantation is also how our cloudapp CI invokes paramedic:
by pointing it to a config file (it points it to a "non-local" config
file, e.g. [3]).

In effect, it is just shuffling around code from one repo to the
other, but the benefits we get are:
 - save compute within our CI
 - all testing-relevant configurations will exist in one repo, not two
 - we can remove the medic repo along with its code duplication of paramedic

The cons, as far as I can tell, are:
 - there will be a new 'config' top-level directory

Let me know how that sounds and what else I've missed.

[1] 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-medic%2Ftree%2Fmaster%2Fjenkins-conf=02%7C01%7Cv-vlkoti%40microsoft.com%7C2e9fcdbcd93d4516275708d422dab62e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636171770130218288=YjWqa5CiRntxkhmikqNE12bwGaEf0W4q2YF%2BT8E1Asg%3D=0
[2] 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-medic%2Ftree%2Fmaster%2Fjenkins-conf%2Fpr%2Flocal=02%7C01%7Cv-vlkoti%40microsoft.com%7C2e9fcdbcd93d4516275708d422dab62e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636171770130218288=FbkW3oVkKBw%2FrlPTc3wUCD5d3dRdTYDvYPTj1h%2FUYRM%3D=0
[3] 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-medic%2Fblob%2Fmaster%2Fjenkins-conf%2Fpr%2Fandroid-5.1.config.json=02%7C01%7Cv-vlkoti%40microsoft.com%7C2e9fcdbcd93d4516275708d422dab62e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636171770130218288=BqBTYje0DLo2ND6SPxkLTcgyI1c0HA0qSoXS7%2FhdVw8%3D=0

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #314: Document lib-file for Android

2016-12-12 Thread mbektchiev

Github user mbektchiev commented on the issue:

https://github.com/apache/cordova-docs/pull/314
  
Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

2016-12-12 Thread alsorokin

Github user alsorokin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92108886
  
--- Diff: appium-tests/common/common.spec.js ---
@@ -228,11 +228,18 @@ describe('Contacts Android', function () {
 function checkSession(done) {
 if (failedToStart) {
 fail('Failed to start a session');
-done();
 }
+done();
--- End diff --

I think you're still missing the purpose of this check ð 
The way you put it, it wouldn't work as intended because it wouldn't skip 
the spec if called from beforeEach, it basically would check the variable and 
then call `beforeEach`'s `done()`. Then the spec would try to execute anyways.
The intent of this check is to skip the spec if the session is failed to 
start. We could also intentionally call `fail()` here to mark the spec as 
failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins Release

2016-12-12 Thread Shazron

Starting on https://issues.apache.org/jira/browse/CB-12237 now.

Acknowledgements: I would like to thank Rick Astley for getting me through
the previous release.

On Mon, Dec 12, 2016 at 3:39 PM, Shazron  wrote:

> https://issues.apache.org/jira/browse/CB-12224 is complete (published to
> dist, npm and blog post is live).
>
> On Mon, Dec 12, 2016 at 10:48 AM, Shazron  wrote:
>
>> Thanks Carlos and Steve for the access.
>> Unfortunately, one last hiccup -- when trying to publish
>> `cordova-plugin-screen-orientation` to npm the version already exists
>> (the package already existed before Apache, but now we have access). This
>> is due to the migration of this plugin repo from a community user -- when
>> that happened the version should have been bumped -- our packaging
>> automation treats the current version in plugin.xml/package.json as the
>> version to be published next.
>>
>> I'll have to remove it from dist, and move its release to
>> https://issues.apache.org/jira/browse/CB-12237
>>
>>
>> On Mon, Dec 12, 2016 at 5:14 AM, Carlos Santana 
>> wrote:
>>
>>> Ok Shaz, you have access to all cordova plugins on npm now
>>>
>>> Keep the good work adn train moving forward shoo shoo !!!
>>>
>>>
>>> On Mon, Dec 12, 2016 at 8:06 AM Carlos Santana 
>>> wrote:
>>>
>>> > Shaz giving you access at the moment, should be done in 5 minutes
>>> >
>>> > On Sun, Dec 11, 2016 at 5:37 PM Shazron  wrote:
>>> >
>>> >> Hi Steve Gill and/or Carlos Santana -- please give me write access to
>>> >> these
>>> >> npm modules below. Publishing is stalled until I get permissions.
>>> >>
>>> >> cordova-plugin-battery-status
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-camera
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-console
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-contacts
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-device
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-device-motion
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-device-orientation
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-dialogs
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-file
>>> >> kotikov.vladimir
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-file-transfer
>>> >> nikhilkh
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-geolocation
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-globalization
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-legacy-whitelist
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-media
>>> >> kotikov.vladimir
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-media-capture
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-network-information
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-screen-orientation
>>> >> gbenvenuti
>>> >> stevegill
>>> >> tony--
>>> >> cordova-plugin-splashscreen
>>> >> kotikov.vladimir
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-statusbar
>>> >> kotikov.vladimir
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-test-framework
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-vibration
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-whitelist
>>> >> csantanapr
>>> >> stevegill
>>> >>
>>> >> --
>>> >>
>>> >> I already have access to these:
>>> >>
>>> >> cordova-plugin-wkwebview-engine
>>> >> bowserj
>>> >> kotikov.vladimir
>>> >> purplecabbage
>>> >> shazron
>>> >> csantanapr
>>> >> stevegill
>>> >> cordova-plugin-inappbrowser
>>> >> csantanapr
>>> >> stevegill
>>> >> kotikov.vladimir
>>> >> sgrebnov
>>> >> shazron
>>> >>
>>> >>
>>> >> On Sun, Dec 11, 2016 at 2:11 PM, Shazron  wrote:
>>> >>
>>> >> > I've already started https://issues.apache.org/jira/browse/CB-12237
>>> >> >
>>> >> > On Sun, Dec 11, 2016 at 2:01 PM, Shazron  wrote:
>>> >> >
>>> >> >> One more issue -- cordova-plugin-inappbrowser, my intent is not to
>>> call
>>> >> >> anyone out here (hey I'm the major source of mistakes for this
>>> >> release) but
>>> >> >> my intent is to fix the problem. The plugin minor version was
>>> >> incremented
>>> >> >> in plugin.xml to 1.6.0 but not incremented in package.json. Thus
>>> when
>>> >> the
>>> >> >> packaging automation ran, the version had a mismatch, and that
>>> this is
>>> >> >> reflected in cordova-plugin-inappbrowser.
>>> >> >>
>>> >> >> https://github.com/apache/cordova-plugin-inappbrowser/commit
>>> >> >> /cfbd3845a893df647ff39ec3c750804d775a0e57
>>> >> >>
>>> >> >> We should have a version mismatch automation check during release
>>> as
>>> >> well
>>> >> >> in coho, and/or the tests.
>>> >> >>
>>> >> >>

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

2016-12-12 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/143
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/143/commits/288c1085ea4a30603e2438551e5d5f592d04849d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/62//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

2016-12-12 Thread filmaj

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/143
  
I re-added the `checkSession` functionality, and factored it out into a 
`beforeEach` to clean up the test code, at least. Take a look @alsrokin when 
you have a chance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins Release

2016-12-12 Thread Shazron

https://issues.apache.org/jira/browse/CB-12224 is complete (published to
dist, npm and blog post is live).

On Mon, Dec 12, 2016 at 10:48 AM, Shazron  wrote:

> Thanks Carlos and Steve for the access.
> Unfortunately, one last hiccup -- when trying to publish
> `cordova-plugin-screen-orientation` to npm the version already exists
> (the package already existed before Apache, but now we have access). This
> is due to the migration of this plugin repo from a community user -- when
> that happened the version should have been bumped -- our packaging
> automation treats the current version in plugin.xml/package.json as the
> version to be published next.
>
> I'll have to remove it from dist, and move its release to
> https://issues.apache.org/jira/browse/CB-12237
>
>
> On Mon, Dec 12, 2016 at 5:14 AM, Carlos Santana 
> wrote:
>
>> Ok Shaz, you have access to all cordova plugins on npm now
>>
>> Keep the good work adn train moving forward shoo shoo !!!
>>
>>
>> On Mon, Dec 12, 2016 at 8:06 AM Carlos Santana 
>> wrote:
>>
>> > Shaz giving you access at the moment, should be done in 5 minutes
>> >
>> > On Sun, Dec 11, 2016 at 5:37 PM Shazron  wrote:
>> >
>> >> Hi Steve Gill and/or Carlos Santana -- please give me write access to
>> >> these
>> >> npm modules below. Publishing is stalled until I get permissions.
>> >>
>> >> cordova-plugin-battery-status
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-camera
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-console
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-contacts
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-device
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-device-motion
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-device-orientation
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-dialogs
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-file
>> >> kotikov.vladimir
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-file-transfer
>> >> nikhilkh
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-geolocation
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-globalization
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-legacy-whitelist
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-media
>> >> kotikov.vladimir
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-media-capture
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-network-information
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-screen-orientation
>> >> gbenvenuti
>> >> stevegill
>> >> tony--
>> >> cordova-plugin-splashscreen
>> >> kotikov.vladimir
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-statusbar
>> >> kotikov.vladimir
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-test-framework
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-vibration
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-whitelist
>> >> csantanapr
>> >> stevegill
>> >>
>> >> --
>> >>
>> >> I already have access to these:
>> >>
>> >> cordova-plugin-wkwebview-engine
>> >> bowserj
>> >> kotikov.vladimir
>> >> purplecabbage
>> >> shazron
>> >> csantanapr
>> >> stevegill
>> >> cordova-plugin-inappbrowser
>> >> csantanapr
>> >> stevegill
>> >> kotikov.vladimir
>> >> sgrebnov
>> >> shazron
>> >>
>> >>
>> >> On Sun, Dec 11, 2016 at 2:11 PM, Shazron  wrote:
>> >>
>> >> > I've already started https://issues.apache.org/jira/browse/CB-12237
>> >> >
>> >> > On Sun, Dec 11, 2016 at 2:01 PM, Shazron  wrote:
>> >> >
>> >> >> One more issue -- cordova-plugin-inappbrowser, my intent is not to
>> call
>> >> >> anyone out here (hey I'm the major source of mistakes for this
>> >> release) but
>> >> >> my intent is to fix the problem. The plugin minor version was
>> >> incremented
>> >> >> in plugin.xml to 1.6.0 but not incremented in package.json. Thus
>> when
>> >> the
>> >> >> packaging automation ran, the version had a mismatch, and that this
>> is
>> >> >> reflected in cordova-plugin-inappbrowser.
>> >> >>
>> >> >> https://github.com/apache/cordova-plugin-inappbrowser/commit
>> >> >> /cfbd3845a893df647ff39ec3c750804d775a0e57
>> >> >>
>> >> >> We should have a version mismatch automation check during release as
>> >> well
>> >> >> in coho, and/or the tests.
>> >> >>
>> >> >> So now the problem is, I can't publish cordova-plugin-inappbrowser
>> this
>> >> >> release because package.json shows the version is 1.5.1 while
>> >> plugin.xml is
>> >> >> 1.6.0 (1.6.0 is correct).
>> >> >>
>> >> >> I will have to omit cordova-plugin-inappbrowser in this release, and
>> >> put
>> >> >> out another cordova plugins release which includes:
>> >> >>
>> >> >> 1) Updates in

[GitHub] cordova-docs issue #664: Update images.md

2016-12-12 Thread jcesarmobile

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-docs/pull/664
  
Yes @shazron, the icon problem is fixed in cordova-android 6.1.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] EOL cordova-medic

2016-12-12 Thread Filip Maj

On Mon, Dec 12, 2016 at 1:46 PM, Jesse  wrote:
> What would be the added responsibilities for cordova-paramedic?

Good question. As far as I can tell, I believe paramedic would need to
additionally house the helper JSON files containing configuration that
one passes into paramedic - basically replacing the various flags one
can run paramedic with with a single one pointing to a file instead.

In particular, the Jenkins configs that the cloudapp CI uses that it
feeds into paramedic [1] - including the "local" ones used for local
testing [2], which seem particularly relevant to paramedic's mission.
This would save our Jenkins instance from pulling the medic repo down,
speeding up test execution (it seems silly to clone a whole repo just
to pull a few JSON files out!).

So right now, when I want to run paramedic locally, I invoke something like:

$ node cordova-paramedic/main.js --platform android --plugin
./cordova-plugin-contacts --verbose --cleanUpAfterRun

I can reduce on the flags passed in by pointing paramedic to the
afore-mentioned local configs, but, these currently exist in the medic
repo. So I've actually been running paramedic recently like so:

$ node cordova-paramedic/main.js --plugin
./cordova-plugin-contacts --config
./cordova-medic/jenkins-conf/pr/local/android-5.1.config.json

The above incantation is also how our cloudapp CI invokes paramedic:
by pointing it to a config file (it points it to a "non-local" config
file, e.g. [3]).

In effect, it is just shuffling around code from one repo to the
other, but the benefits we get are:
 - save compute within our CI
 - all testing-relevant configurations will exist in one repo, not two
 - we can remove the medic repo along with its code duplication of paramedic

The cons, as far as I can tell, are:
 - there will be a new 'config' top-level directory

Let me know how that sounds and what else I've missed.

[1] https://github.com/apache/cordova-medic/tree/master/jenkins-conf
[2] https://github.com/apache/cordova-medic/tree/master/jenkins-conf/pr/local
[3] 
https://github.com/apache/cordova-medic/blob/master/jenkins-conf/pr/android-5.1.config.json

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #664: Update images.md

2016-12-12 Thread ttimmy

Github user ttimmy commented on the issue:

https://github.com/apache/cordova-docs/pull/664
  
It was. My change was rejected, see CB-12221


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] EOL cordova-medic

2016-12-12 Thread Jesse

What would be the added responsibilities for cordova-paramedic?
I am all about deleting code, but if we are simply reshuffling
responsibilities then we are really not gaining/losing anything.

Originally, and metaphorically ...
'medic' was the hospital and 'paramedic' was the ambulance.
To elaborate, for those who don't get metaphors
medic was meant to test all the things
paramedic was meant to quickly test any simple combo of a plugin+platform

Substantial code was added to paramedic to support some other use cases
(Appium,Sauce,...), but I would still REALLY like to prevent us turning
paramedic into a behemoth travelling hospital ... it may already be too
late though.





@purplecabbage
risingj.com

On Mon, Dec 12, 2016 at 1:31 PM, Steven Gill  wrote:

> +1
>
> On Mon, Dec 12, 2016 at 10:57 AM, Filip Maj  wrote:
>
> > Dearest cordova devs,
> >
> > I'd like to discuss the possibility of killing off the cordova-medic
> > repo. Kinda funny, as I landed the first commit in that repo over 4
> > years ago.
> >
> > I recently sent some updates in a pull request to medic [1], updating
> > some appium stuff, and after some discussion with Alex, he pointed out
> > that medic is pretty much not used these days. With paramedic taking
> > over as both the local testing tool as well as the keystone piece for
> > Cordova's CI on cloudapp, I don't think it is worth maintaining two
> > similar repositories with lots of code duplication between them.
> >
> > It looks to me like Apache's buildbot configs for Cordova exist in the
> > medic repo. How valuable are these? Worth keeping around? Is execution
> > on Apache buildbot going to be a thing once more in the future?
> > Cloudapp seems to be doing an excellent job for us on its own...
> >
> > Other than the buildbot configs, I believe the only thing that needs
> > to be migrated out are the Jenkins configs. This would be a beneficial
> > move for our CI system anyways, as right now every single Jenkins job
> > pulls down the medic repo _solely to get the Jenkins configs_. Moving
> > the Jenkins configs into the paramedic repo would save every cloudapp
> > job a repo pull, saving some time, and in CI, every second counts :)
> >
> > Anything else I'm missing? What do y'all think? Good idea? Bad idea?
> >
> > Thanks for your feedback!
> >
> > -Fil
> >
> > [1] https://github.com/apache/cordova-medic/pull/106
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Re: [DISCUSS] EOL cordova-medic

2016-12-12 Thread Steven Gill

+1

On Mon, Dec 12, 2016 at 10:57 AM, Filip Maj  wrote:

> Dearest cordova devs,
>
> I'd like to discuss the possibility of killing off the cordova-medic
> repo. Kinda funny, as I landed the first commit in that repo over 4
> years ago.
>
> I recently sent some updates in a pull request to medic [1], updating
> some appium stuff, and after some discussion with Alex, he pointed out
> that medic is pretty much not used these days. With paramedic taking
> over as both the local testing tool as well as the keystone piece for
> Cordova's CI on cloudapp, I don't think it is worth maintaining two
> similar repositories with lots of code duplication between them.
>
> It looks to me like Apache's buildbot configs for Cordova exist in the
> medic repo. How valuable are these? Worth keeping around? Is execution
> on Apache buildbot going to be a thing once more in the future?
> Cloudapp seems to be doing an excellent job for us on its own...
>
> Other than the buildbot configs, I believe the only thing that needs
> to be migrated out are the Jenkins configs. This would be a beneficial
> move for our CI system anyways, as right now every single Jenkins job
> pulls down the medic repo _solely to get the Jenkins configs_. Moving
> the Jenkins configs into the paramedic repo would save every cloudapp
> job a repo pull, saving some time, and in CI, every second counts :)
>
> Anything else I'm missing? What do y'all think? Good idea? Bad idea?
>
> Thanks for your feedback!
>
> -Fil
>
> [1] https://github.com/apache/cordova-medic/pull/106
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[DISCUSS] EOL cordova-medic

2016-12-12 Thread Filip Maj

Dearest cordova devs,

I'd like to discuss the possibility of killing off the cordova-medic
repo. Kinda funny, as I landed the first commit in that repo over 4
years ago.

I recently sent some updates in a pull request to medic [1], updating
some appium stuff, and after some discussion with Alex, he pointed out
that medic is pretty much not used these days. With paramedic taking
over as both the local testing tool as well as the keystone piece for
Cordova's CI on cloudapp, I don't think it is worth maintaining two
similar repositories with lots of code duplication between them.

It looks to me like Apache's buildbot configs for Cordova exist in the
medic repo. How valuable are these? Worth keeping around? Is execution
on Apache buildbot going to be a thing once more in the future?
Cloudapp seems to be doing an excellent job for us on its own...

Other than the buildbot configs, I believe the only thing that needs
to be migrated out are the Jenkins configs. This would be a beneficial
move for our CI system anyways, as right now every single Jenkins job
pulls down the medic repo _solely to get the Jenkins configs_. Moving
the Jenkins configs into the paramedic repo would save every cloudapp
job a repo pull, saving some time, and in CI, every second counts :)

Anything else I'm missing? What do y'all think? Good idea? Bad idea?

Thanks for your feedback!

-Fil

[1] https://github.com/apache/cordova-medic/pull/106

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #314: Document lib-file for Android

2016-12-12 Thread shazron

Github user shazron commented on the issue:

https://github.com/apache/cordova-docs/pull/314
  
Hi, this PR needs a rebase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #611: Lowercase Windows consistently through the docs

2016-12-12 Thread shazron

Github user shazron commented on the issue:

https://github.com/apache/cordova-docs/pull/611
  
@purplecabbage can you give this a quick review? thx


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #649: If you want to record sound on ios10 permission mus...

2016-12-12 Thread shazron

Github user shazron commented on the issue:

https://github.com/apache/cordova-docs/pull/649
  
Please close this PR, the upcoming plugins release should have this 
permission added already, not only that, this note is in the wrong section.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #664: Update images.md

2016-12-12 Thread shazron

Github user shazron commented on the issue:

https://github.com/apache/cordova-docs/pull/664
  
Has this been fixed in Cordova-Android 6.1.0?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #665: Requesting the addition of Mobiscroll to the...

2016-12-12 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/665


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #667: CB-12224 - Added plugins release blog post

2016-12-12 Thread filmaj

Github user filmaj commented on the issue:

https://github.com/apache/cordova-docs/pull/667
  
LGTM! ð 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic issue #106: Appium updates

2016-12-12 Thread filmaj

Github user filmaj commented on the issue:

https://github.com/apache/cordova-medic/pull/106
  
@alsorokin ok no problem. I think we just need to move the jenkins configs 
over to paramedic, then we could probably delete the medic repo completely. I 
will start a discuss thread on the dev list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #667: CB-12224 - Added plugins release blog post

2016-12-12 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/667


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request #106: Appium updates

2016-12-12 Thread filmaj

Github user filmaj closed the pull request at:

https://github.com/apache/cordova-medic/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [BLOG POST] Dec 07 2016 Plugins Release

2016-12-12 Thread Filip Maj

+1

On Mon, Dec 12, 2016 at 11:19 AM, Kerri Shotts  wrote:
> +1
>
> ~ Kerri
>
>> On Dec 11, 2016, at 17:17, Shazron  wrote:
>>
>> https://github.com/apache/cordova-docs/pull/667
>>
>> +1 it, etc
>>
>> Pending npm package publish.
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #667: CB-12224 - Added plugins release blog post

2016-12-12 Thread filmaj

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/667#discussion_r92020220
  
--- Diff: www/_posts/2016-12-07-plugins-release.md ---
@@ -0,0 +1,231 @@
+---
+layout: post
+author:
+name: Shazron Abdullah
+url: https://twitter.com/shazron
+title:  "Plugins Release"
+categories: news
+tags: release plugins
+---
+
+The following plugins were updated today:
+
+* cordova-plugin-battery-status: 1.2.1
+* cordova-plugin-camera: 2.3.1
+* cordova-plugin-console: 1.0.5
+* cordova-plugin-contacts: 2.2.1
+* cordova-plugin-device: 1.1.4
+* cordova-plugin-device-motion: 1.2.3
+* cordova-plugin-device-orientation: 1.0.5
+* cordova-plugin-dialogs: 1.3.1
+* cordova-plugin-file: 4.3.1
+* cordova-plugin-file-transfer: 1.6.1
+* cordova-plugin-geolocation: 2.4.1
+* cordova-plugin-globalization: 1.0.5
+* cordova-plugin-legacy-whitelist: 1.1.2
+* cordova-plugin-media: 2.4.1
+* cordova-plugin-media-capture: 1.4.1
+* cordova-plugin-network-information: 1.3.1
+* cordova-plugin-screen-orientation: 1.4.2
--- End diff --

I thought this one had to be removed for this release?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [BLOG POST] Dec 07 2016 Plugins Release

2016-12-12 Thread Kerri Shotts

+1

~ Kerri

> On Dec 11, 2016, at 17:17, Shazron  wrote:
> 
> https://github.com/apache/cordova-docs/pull/667
> 
> +1 it, etc
> 
> Pending npm package publish.

[GitHub] cordova-plugin-screen-orientation issue #2: Update YoikScreenOrientation.m

2016-12-12 Thread purplecabbage

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/2
  
This changes is covered by the more exhaustive pr #4 
Closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #5: change console.log to show Scree...

2016-12-12 Thread purplecabbage

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/5
  
Technically, this does not change anything. But it does point out that 
there is an issue in how toString is handled by the orientation object.  
Closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #3: Typo on YoikScreenOrientation.m

2016-12-12 Thread purplecabbage

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/3
  
Thanks for the pr, this will be closed by another pull request #4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [BLOG POST] Dec 07 2016 Plugins Release

2016-12-12 Thread Jesse

+1


@purplecabbage
risingj.com

On Mon, Dec 12, 2016 at 10:50 AM, Shazron  wrote:

> Edited to remove cordova-plugin-screen-orientation, it is moved to
> https://issues.apache.org/jira/browse/CB-12237
>
> On Sun, Dec 11, 2016 at 3:17 PM, Shazron  wrote:
>
> > https://github.com/apache/cordova-docs/pull/667
> >
> > +1 it, etc
> >
> > Pending npm package publish.
> >
>

Re: [BLOG POST] Dec 07 2016 Plugins Release

2016-12-12 Thread Shazron

Edited to remove cordova-plugin-screen-orientation, it is moved to
https://issues.apache.org/jira/browse/CB-12237

On Sun, Dec 11, 2016 at 3:17 PM, Shazron  wrote:

> https://github.com/apache/cordova-docs/pull/667
>
> +1 it, etc
>
> Pending npm package publish.
>

Re: [DISCUSS] Plugins Release

2016-12-12 Thread Shazron

Thanks Carlos and Steve for the access.
Unfortunately, one last hiccup -- when trying to publish
`cordova-plugin-screen-orientation` to npm the version already exists (the
package already existed before Apache, but now we have access). This is due
to the migration of this plugin repo from a community user -- when that
happened the version should have been bumped -- our packaging automation
treats the current version in plugin.xml/package.json as the version to be
published next.

I'll have to remove it from dist, and move its release to
https://issues.apache.org/jira/browse/CB-12237


On Mon, Dec 12, 2016 at 5:14 AM, Carlos Santana 
wrote:

> Ok Shaz, you have access to all cordova plugins on npm now
>
> Keep the good work adn train moving forward shoo shoo !!!
>
>
> On Mon, Dec 12, 2016 at 8:06 AM Carlos Santana 
> wrote:
>
> > Shaz giving you access at the moment, should be done in 5 minutes
> >
> > On Sun, Dec 11, 2016 at 5:37 PM Shazron  wrote:
> >
> >> Hi Steve Gill and/or Carlos Santana -- please give me write access to
> >> these
> >> npm modules below. Publishing is stalled until I get permissions.
> >>
> >> cordova-plugin-battery-status
> >> csantanapr
> >> stevegill
> >> cordova-plugin-camera
> >> csantanapr
> >> stevegill
> >> cordova-plugin-console
> >> csantanapr
> >> stevegill
> >> cordova-plugin-contacts
> >> csantanapr
> >> stevegill
> >> cordova-plugin-device
> >> csantanapr
> >> stevegill
> >> cordova-plugin-device-motion
> >> csantanapr
> >> stevegill
> >> cordova-plugin-device-orientation
> >> csantanapr
> >> stevegill
> >> cordova-plugin-dialogs
> >> csantanapr
> >> stevegill
> >> cordova-plugin-file
> >> kotikov.vladimir
> >> csantanapr
> >> stevegill
> >> cordova-plugin-file-transfer
> >> nikhilkh
> >> csantanapr
> >> stevegill
> >> cordova-plugin-geolocation
> >> csantanapr
> >> stevegill
> >> cordova-plugin-globalization
> >> csantanapr
> >> stevegill
> >> cordova-plugin-legacy-whitelist
> >> csantanapr
> >> stevegill
> >> cordova-plugin-media
> >> kotikov.vladimir
> >> csantanapr
> >> stevegill
> >> cordova-plugin-media-capture
> >> csantanapr
> >> stevegill
> >> cordova-plugin-network-information
> >> csantanapr
> >> stevegill
> >> cordova-plugin-screen-orientation
> >> gbenvenuti
> >> stevegill
> >> tony--
> >> cordova-plugin-splashscreen
> >> kotikov.vladimir
> >> csantanapr
> >> stevegill
> >> cordova-plugin-statusbar
> >> kotikov.vladimir
> >> csantanapr
> >> stevegill
> >> cordova-plugin-test-framework
> >> csantanapr
> >> stevegill
> >> cordova-plugin-vibration
> >> csantanapr
> >> stevegill
> >> cordova-plugin-whitelist
> >> csantanapr
> >> stevegill
> >>
> >> --
> >>
> >> I already have access to these:
> >>
> >> cordova-plugin-wkwebview-engine
> >> bowserj
> >> kotikov.vladimir
> >> purplecabbage
> >> shazron
> >> csantanapr
> >> stevegill
> >> cordova-plugin-inappbrowser
> >> csantanapr
> >> stevegill
> >> kotikov.vladimir
> >> sgrebnov
> >> shazron
> >>
> >>
> >> On Sun, Dec 11, 2016 at 2:11 PM, Shazron  wrote:
> >>
> >> > I've already started https://issues.apache.org/jira/browse/CB-12237
> >> >
> >> > On Sun, Dec 11, 2016 at 2:01 PM, Shazron  wrote:
> >> >
> >> >> One more issue -- cordova-plugin-inappbrowser, my intent is not to
> call
> >> >> anyone out here (hey I'm the major source of mistakes for this
> >> release) but
> >> >> my intent is to fix the problem. The plugin minor version was
> >> incremented
> >> >> in plugin.xml to 1.6.0 but not incremented in package.json. Thus when
> >> the
> >> >> packaging automation ran, the version had a mismatch, and that this
> is
> >> >> reflected in cordova-plugin-inappbrowser.
> >> >>
> >> >> https://github.com/apache/cordova-plugin-inappbrowser/commit
> >> >> /cfbd3845a893df647ff39ec3c750804d775a0e57
> >> >>
> >> >> We should have a version mismatch automation check during release as
> >> well
> >> >> in coho, and/or the tests.
> >> >>
> >> >> So now the problem is, I can't publish cordova-plugin-inappbrowser
> this
> >> >> release because package.json shows the version is 1.5.1 while
> >> plugin.xml is
> >> >> 1.6.0 (1.6.0 is correct).
> >> >>
> >> >> I will have to omit cordova-plugin-inappbrowser in this release, and
> >> put
> >> >> out another cordova plugins release which includes:
> >> >>
> >> >> 1) Updates in cordova-plugin-battery-status that we discussed
> >> >> 2) The package.json update in cordova-plugin-inappbrowser (same
> >> version,
> >> >> 1.6.0)
> >> >>
> >> >>
> >> >>
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> On Sun, Dec 11, 2016 at 11:32 AM, Shazron  wrote:
> >> >>
> >> >>> I screwed up the release notes for each plugin

[GitHub] cordova-windows issue #216: CB-11177 SplashScreen gets shifted on Windows de...

2016-12-12 Thread codecov-io

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/216
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-windows/pull/216?src=pr) is 
76.13% (diff: 100%)
> Merging 
[#216](https://codecov.io/gh/apache/cordova-windows/pull/216?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #216   diff @@
==
  Files16 16  
  Lines  2204   2204  
  Methods 413413  
  Messages  0  0  
  Branches430430  
==
  Hits   1678   1678  
  Misses  526526  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[707bf96...94b0c27](https://codecov.io/gh/apache/cordova-windows/compare/707bf962823b9585a22dfaa3ffa6f0185562df5a...94b0c271fef8217c413c35ee401594f5f986b351?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

2016-12-12 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/265#discussion_r92010506
  
--- Diff: package.json ---
@@ -31,6 +31,7 @@
 "cordova-common": "1.5.x",
 "cordova-lib": "6.4.0",
 "insight": "~0.8.2",
+"jasmine": "^2.5.2",
--- End diff --

Shouldn't this be a dev dependency?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

2016-12-12 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/265#discussion_r92009821
  
--- Diff: package.json ---
@@ -11,7 +11,7 @@
 "cordova": "./bin/cordova"
   },
   "scripts": {
-"test": "node node_modules/jasmine-node/bin/jasmine-node 
--captureExceptions --color spec",
+"test": "node node_modules/jasmine/bin/jasmine --captureExceptions 
--color spec",
 "cover": "node node_modules/istanbul/lib/cli.js cover --root src 
--print detail node_modules/jasmine-node/bin/jasmine-node -- spec"
--- End diff --

@audreyso, looks like you'll also need to update `cover` command to use 
jasmine inatead of jasmine-node


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

2016-12-12 Thread daserge

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/216

CB-11177 SplashScreen gets shifted on Windows devices with soft navbar



### Platforms affected
Windows

### What does this PR do?
Fixes splash jump bug (affected mostly Windows 10 Mobile devices, 
especially with soft navigation bar)

### What testing has been done on this change?
Manual testing

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-windows CB-11177

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #216


commit 94b0c271fef8217c413c35ee401594f5f986b351
Author: daserge 
Date:   2016-12-12T18:32:37Z

CB-11177 SplashScreen gets shifted on Windows devices with soft navbar




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

2016-12-12 Thread audreyso

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-cli/pull/265

CB-12018 : updated tests to function with jasmine instead of jasmine-node



### Platforms affected


### What does this PR do?
Updated tests to function with jasmine instead of jasmine-node

### What testing has been done on this change?


### Checklist
- [X ] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X ] Added automated test coverage as appropriate for this change.

â¦node

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-cli CB-12018

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #265


commit a0e80aa05cce90399160f6a6555389f83c746d87
Author: audreyso 
Date:   2016-12-10T01:11:28Z

CB-12018 : updated tests to function with jasmine instead of jasmine-node




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSSION] Windows tag, what should it be doing?

2016-12-12 Thread Karen Tran

Does anyone have any other objections?
Otherwise I'll proceed to work on this tomorrow.

On Thu, Dec 8, 2016 at 8:03 PM, Shazron  wrote:

> +1 sounds good
>
> On Thu, Dec 8, 2016 at 4:36 PM, Karen Tran  wrote:
>
> > I dug up the old pull request for this behavior change (
> > https://github.com/apache/cordova-windows/pull/139) and it seems like
> the
> > main goal for the change was to be able to have .dll files specific to
> > different architectures without having different target locations for
> each
> > of them and make the .dll files visible in Visual Studio so that Visual
> > Studio can reference them.
> > ^Correct me if I'm wrong here...
> >
> > I tested the following two sets and now have a better understanding of
> why
> > this behavior was added, but I'm not entirely sure why it had to replace
> > the copy in the first place as opposed to adding a flag to do referencing
> > instead of copy. Having both behavior in resource-file is probably okay
> > since they are kind of similar.
> >
> > Set 1.
> > 
> > 
> > - With copy, this behaves the exact same as the referencing behavior.
> > - The only difference between each behavior is the path where Visual
> Studio
> > will point to the file, copy will point to the target and reference will
> > point to src
> >
> > Set 2.
> > 
> > 
> > - With copy, only the x64 foo.dll will be used since the second
> >  would overwrite the first one. In Visual Studio, the
> > foo.dll when targeting x86 or x64 will point to the same x64 foo.dll. So
> > this is the issue with copy for this specific case.
> > - With referencing, Visual Studio will properly reference the correct
> > foo.dll because it's pointing to the src path and there is no overwriting
> > here.
> >
> > I will propose that resource-file should default to copy and the
> reference
> > behavior should be set by a flag. This is what it should have been when
> the
> > behavior was changed, so I think it's worth making the switch back to
> copy
> > even though it will be breaking a few users (because right now it might
> > unknowingly be breaking more users who have long since been expecting
> > resource-file to copy; it was never documented that resource-file had
> > changed at all). Resource-file wasn't intended for .dll, but for actual
> > resources like json, images, xml, and my case properties files. So this
> is
> > a big issue if some of these resources aren't available to the app at run
> > time.
> > 
> >
> > TL;DR
> > I propose setting copy as default and the reference behavior with a flag
> > because this is what it should have been in the first place.
> >
> > On Wed, Dec 7, 2016 at 5:58 PM, Karen Tran  wrote:
> >
> > > Sorry I missed this, it was in my spam folder.
> > >
> > > I think the general consensus is that  should definitely
> > > have the copy function added back. Not sure if it was clear if we came
> > to a
> > > conclusion on whether it should be default behavior though.
> > >
> > > As for what to do for the reference behavior, I think the easy route is
> > to
> > > do what you suggested Tim and keep the current behavior as the default
> > and
> > > have the copy be an attribute users can set. Intuitively though, I
> think
> > > resource-file should default to copy as expected just like other
> > platforms,
> > > and any other behavior can be handled with attribute flags or moved to
> > > another more appropriate tag.
> > >
> > > I would lean towards the second option because it makes more sense to
> me
> > > as a plugin developer because all  tags do a copy. I know it
> > > would break existing plugins that depend on the current behavior, but I
> > can
> > > say the same for resource-file being changed in the first place and
> never
> > > documented nor mentioned in any blog release (my plugin is currently
> > > broken). I don't know if many developers are even aware that it was
> > changed
> > > besides the contributor. It's been in cordova-windows since v4.4.0.
> > >
> > > So this falls back on my initial two questions I asked:
> > > 1. What should be the default behavior of  tag? Should
> it
> > > simply be copy resources as it was originally intended to, or should it
> > be
> > > doing what it is now, which is making a reference to the resource
> files.
> > > 2. Should  tag handle both functionalities, or should
> one
> > > be separated out into another tag?
> > >
> > >
> > > On Fri, Dec 2, 2016 at 9:31 PM, Tim Barham 
> > > wrote:
> > >
> > >> It seems to me it would be bad form to simply change the default
> > behavior
> > >> back to copy, if that will break existing plugins that rely on the
> > current
> > >> behavior. While it would be inconsistent with other platforms, perhaps
> > we
> > >> should leave the current default behavior as-is and add an attribute
> to
> > >> specify copy behavior? And then document the discrepancy.
> > >>
> > >>

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

2016-12-12 Thread alsorokin

Github user alsorokin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r91970543
  
--- Diff: appium-tests/common/common.spec.js ---
@@ -242,7 +248,6 @@ describe('Contacts Android', function () {
 
 describe('Picking contacts', function () {
 afterEach(function (done) {
-checkSession(done);
--- End diff --

As far as I remember, this check is to quickly fail without extra requests 
to the driver. Because when the session is failed to start it could just get 
unresponsive and we would just sit there and wait for every test to time out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic issue #106: Appium updates

2016-12-12 Thread alsorokin

Github user alsorokin commented on the issue:

https://github.com/apache/cordova-medic/pull/106
  
Yeah, sorry about this confusion. I think we could get rid of medic 
altogether, not just the appium code. Medic was used back when we had buildbot 
CI up and running. Now it's just sits here covered in dust.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic issue #106: Appium updates

2016-12-12 Thread filmaj

Github user filmaj commented on the issue:

https://github.com/apache/cordova-medic/pull/106
  
I see now that they are not! My mistake. I will go look around in 
paramedic, then :)

We should probably remove this functionality from medic if it is all based 
in paramedic! Code duplication and confusing to new contributors, clearly :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

2016-12-12 Thread filmaj

Github user filmaj commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r91953513
  
--- Diff: appium-tests/common/common.spec.js ---
@@ -242,7 +248,6 @@ describe('Contacts Android', function () {
 
 describe('Picking contacts', function () {
 afterEach(function (done) {
-checkSession(done);
--- End diff --

I don't think this function provides much benefit: it only checks if the 
first, "self-check"-like test finished properly. If the appium session fails to 
initiate, the other tests will most certainly fail anyways. In my opinion, it 
is added complexity.

Let me pose the reverse question to you: why have this check?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic issue #106: Appium updates

2016-12-12 Thread filmaj

Github user filmaj commented on the issue:

https://github.com/apache/cordova-medic/pull/106
  
Good question @alsorokin ! I thought that the appium-based CI tests were 
triggered via medic, not paramedic? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request #106: Appium updates

2016-12-12 Thread filmaj

Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/106#discussion_r91951340
  
--- Diff: medic/medic-appium.js ---
@@ -355,9 +358,8 @@ function isFailFastError(error) {
 function killProcess(procObj, killSignal, callback) {
 if (procObj.alive) {
 procObj.alive = false;
-setTimeout(function () {
-kill(procObj.process.pid, killSignal, callback);
-}, 1000);
--- End diff --

I see. I will take a look at this in my windows VM, then. Do you recall 
what version of windows you saw this problem on?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins Release

2016-12-12 Thread Carlos Santana

Ok Shaz, you have access to all cordova plugins on npm now

Keep the good work adn train moving forward shoo shoo !!!


On Mon, Dec 12, 2016 at 8:06 AM Carlos Santana  wrote:

> Shaz giving you access at the moment, should be done in 5 minutes
>
> On Sun, Dec 11, 2016 at 5:37 PM Shazron  wrote:
>
>> Hi Steve Gill and/or Carlos Santana -- please give me write access to
>> these
>> npm modules below. Publishing is stalled until I get permissions.
>>
>> cordova-plugin-battery-status
>> csantanapr
>> stevegill
>> cordova-plugin-camera
>> csantanapr
>> stevegill
>> cordova-plugin-console
>> csantanapr
>> stevegill
>> cordova-plugin-contacts
>> csantanapr
>> stevegill
>> cordova-plugin-device
>> csantanapr
>> stevegill
>> cordova-plugin-device-motion
>> csantanapr
>> stevegill
>> cordova-plugin-device-orientation
>> csantanapr
>> stevegill
>> cordova-plugin-dialogs
>> csantanapr
>> stevegill
>> cordova-plugin-file
>> kotikov.vladimir
>> csantanapr
>> stevegill
>> cordova-plugin-file-transfer
>> nikhilkh
>> csantanapr
>> stevegill
>> cordova-plugin-geolocation
>> csantanapr
>> stevegill
>> cordova-plugin-globalization
>> csantanapr
>> stevegill
>> cordova-plugin-legacy-whitelist
>> csantanapr
>> stevegill
>> cordova-plugin-media
>> kotikov.vladimir
>> csantanapr
>> stevegill
>> cordova-plugin-media-capture
>> csantanapr
>> stevegill
>> cordova-plugin-network-information
>> csantanapr
>> stevegill
>> cordova-plugin-screen-orientation
>> gbenvenuti
>> stevegill
>> tony--
>> cordova-plugin-splashscreen
>> kotikov.vladimir
>> csantanapr
>> stevegill
>> cordova-plugin-statusbar
>> kotikov.vladimir
>> csantanapr
>> stevegill
>> cordova-plugin-test-framework
>> csantanapr
>> stevegill
>> cordova-plugin-vibration
>> csantanapr
>> stevegill
>> cordova-plugin-whitelist
>> csantanapr
>> stevegill
>>
>> --
>>
>> I already have access to these:
>>
>> cordova-plugin-wkwebview-engine
>> bowserj
>> kotikov.vladimir
>> purplecabbage
>> shazron
>> csantanapr
>> stevegill
>> cordova-plugin-inappbrowser
>> csantanapr
>> stevegill
>> kotikov.vladimir
>> sgrebnov
>> shazron
>>
>>
>> On Sun, Dec 11, 2016 at 2:11 PM, Shazron  wrote:
>>
>> > I've already started https://issues.apache.org/jira/browse/CB-12237
>> >
>> > On Sun, Dec 11, 2016 at 2:01 PM, Shazron  wrote:
>> >
>> >> One more issue -- cordova-plugin-inappbrowser, my intent is not to call
>> >> anyone out here (hey I'm the major source of mistakes for this
>> release) but
>> >> my intent is to fix the problem. The plugin minor version was
>> incremented
>> >> in plugin.xml to 1.6.0 but not incremented in package.json. Thus when
>> the
>> >> packaging automation ran, the version had a mismatch, and that this is
>> >> reflected in cordova-plugin-inappbrowser.
>> >>
>> >> https://github.com/apache/cordova-plugin-inappbrowser/commit
>> >> /cfbd3845a893df647ff39ec3c750804d775a0e57
>> >>
>> >> We should have a version mismatch automation check during release as
>> well
>> >> in coho, and/or the tests.
>> >>
>> >> So now the problem is, I can't publish cordova-plugin-inappbrowser this
>> >> release because package.json shows the version is 1.5.1 while
>> plugin.xml is
>> >> 1.6.0 (1.6.0 is correct).
>> >>
>> >> I will have to omit cordova-plugin-inappbrowser in this release, and
>> put
>> >> out another cordova plugins release which includes:
>> >>
>> >> 1) Updates in cordova-plugin-battery-status that we discussed
>> >> 2) The package.json update in cordova-plugin-inappbrowser (same
>> version,
>> >> 1.6.0)
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >> On Sun, Dec 11, 2016 at 11:32 AM, Shazron  wrote:
>> >>
>> >>> I screwed up the release notes for each plugin (RELEASENOTES.md) in
>> each
>> >>> plugin repo. I'll fix it after release, but will fix it for the blog
>> post:
>> >>> https://issues.apache.org/jira/browse/CB-12236
>> >>>
>> >>> On Thu, Dec 8, 2016 at 9:03 PM,  wrote:
>> >>>
>>  Just replying to it from my apache address to bump it up from your
>> spam
>>  folders, guys. I'll cast my +1 today.
>> 
>>  -Original Message-
>>  From: Michael Braude [mailto:mbra...@microsoft.com]
>>  Sent: Thursday, December 8, 2016 10:09 PM
>>  To: dev@cordova.apache.org
>>  Subject: RE: [DISCUSS] Plugins Release
>> 
>>  Not out of the box, no. We don't use that flag ourselves in our
>> default
>>  build.
>> 
>>  I'm OK with this plan. We can release it with the bug and do a patch
>>  release later with a fix.
>> 
>>  Thanks,
>>  Mike
>> 
>>  -Original Message-
>>  From: Shazron [mailto:shaz...@gmail.com]
>>  Sent: Thursday,

Re: [DISCUSS] Plugins Release

2016-12-12 Thread Carlos Santana

Shaz giving you access at the moment, should be done in 5 minutes

On Sun, Dec 11, 2016 at 5:37 PM Shazron  wrote:

> Hi Steve Gill and/or Carlos Santana -- please give me write access to these
> npm modules below. Publishing is stalled until I get permissions.
>
> cordova-plugin-battery-status
> csantanapr
> stevegill
> cordova-plugin-camera
> csantanapr
> stevegill
> cordova-plugin-console
> csantanapr
> stevegill
> cordova-plugin-contacts
> csantanapr
> stevegill
> cordova-plugin-device
> csantanapr
> stevegill
> cordova-plugin-device-motion
> csantanapr
> stevegill
> cordova-plugin-device-orientation
> csantanapr
> stevegill
> cordova-plugin-dialogs
> csantanapr
> stevegill
> cordova-plugin-file
> kotikov.vladimir
> csantanapr
> stevegill
> cordova-plugin-file-transfer
> nikhilkh
> csantanapr
> stevegill
> cordova-plugin-geolocation
> csantanapr
> stevegill
> cordova-plugin-globalization
> csantanapr
> stevegill
> cordova-plugin-legacy-whitelist
> csantanapr
> stevegill
> cordova-plugin-media
> kotikov.vladimir
> csantanapr
> stevegill
> cordova-plugin-media-capture
> csantanapr
> stevegill
> cordova-plugin-network-information
> csantanapr
> stevegill
> cordova-plugin-screen-orientation
> gbenvenuti
> stevegill
> tony--
> cordova-plugin-splashscreen
> kotikov.vladimir
> csantanapr
> stevegill
> cordova-plugin-statusbar
> kotikov.vladimir
> csantanapr
> stevegill
> cordova-plugin-test-framework
> csantanapr
> stevegill
> cordova-plugin-vibration
> csantanapr
> stevegill
> cordova-plugin-whitelist
> csantanapr
> stevegill
>
> --
>
> I already have access to these:
>
> cordova-plugin-wkwebview-engine
> bowserj
> kotikov.vladimir
> purplecabbage
> shazron
> csantanapr
> stevegill
> cordova-plugin-inappbrowser
> csantanapr
> stevegill
> kotikov.vladimir
> sgrebnov
> shazron
>
>
> On Sun, Dec 11, 2016 at 2:11 PM, Shazron  wrote:
>
> > I've already started https://issues.apache.org/jira/browse/CB-12237
> >
> > On Sun, Dec 11, 2016 at 2:01 PM, Shazron  wrote:
> >
> >> One more issue -- cordova-plugin-inappbrowser, my intent is not to call
> >> anyone out here (hey I'm the major source of mistakes for this release)
> but
> >> my intent is to fix the problem. The plugin minor version was
> incremented
> >> in plugin.xml to 1.6.0 but not incremented in package.json. Thus when
> the
> >> packaging automation ran, the version had a mismatch, and that this is
> >> reflected in cordova-plugin-inappbrowser.
> >>
> >> https://github.com/apache/cordova-plugin-inappbrowser/commit
> >> /cfbd3845a893df647ff39ec3c750804d775a0e57
> >>
> >> We should have a version mismatch automation check during release as
> well
> >> in coho, and/or the tests.
> >>
> >> So now the problem is, I can't publish cordova-plugin-inappbrowser this
> >> release because package.json shows the version is 1.5.1 while
> plugin.xml is
> >> 1.6.0 (1.6.0 is correct).
> >>
> >> I will have to omit cordova-plugin-inappbrowser in this release, and put
> >> out another cordova plugins release which includes:
> >>
> >> 1) Updates in cordova-plugin-battery-status that we discussed
> >> 2) The package.json update in cordova-plugin-inappbrowser (same version,
> >> 1.6.0)
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >> On Sun, Dec 11, 2016 at 11:32 AM, Shazron  wrote:
> >>
> >>> I screwed up the release notes for each plugin (RELEASENOTES.md) in
> each
> >>> plugin repo. I'll fix it after release, but will fix it for the blog
> post:
> >>> https://issues.apache.org/jira/browse/CB-12236
> >>>
> >>> On Thu, Dec 8, 2016 at 9:03 PM,  wrote:
> >>>
>  Just replying to it from my apache address to bump it up from your
> spam
>  folders, guys. I'll cast my +1 today.
> 
>  -Original Message-
>  From: Michael Braude [mailto:mbra...@microsoft.com]
>  Sent: Thursday, December 8, 2016 10:09 PM
>  To: dev@cordova.apache.org
>  Subject: RE: [DISCUSS] Plugins Release
> 
>  Not out of the box, no. We don't use that flag ourselves in our
> default
>  build.
> 
>  I'm OK with this plan. We can release it with the bug and do a patch
>  release later with a fix.
> 
>  Thanks,
>  Mike
> 
>  -Original Message-
>  From: Shazron [mailto:shaz...@gmail.com]
>  Sent: Thursday, December 8, 2016 10:48 AM
>  To: dev@cordova.apache.org
>  Subject: Re: [DISCUSS] Plugins Release
> 
>  > I just found that cordova-plugin-battery-status cannot be built for
>  windows with --browserify tag.
> 
>  Does this affect any downstream distributions, ie Visual Studio?
>  IMO:
>  If it does, I cancel the vote, put out a new vote

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

2016-12-12 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/201
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/201/commits/358b6804b2bd96d900daa0f6cc964169205ae400)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/106//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

2016-12-12 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/201
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/201/commits/45214911cbeb3268f98e0a64081ec80732829659)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/105//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #215: CB-12193 cordova.js crashes windows app i...

2016-12-12 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/215


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

2016-12-12 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/201
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/201/commits/4063179c35bbd6c4bd1f3deaef005fd2c95fe36b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/104//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status issue #46: CB-12227 (windows) Fixed Browserify...

2016-12-12 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/46
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/46/commits/1d8218621645e45c25898d04f5e87d41e90b3e6a)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/35//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status issue #46: CB-12227 (windows) Fixed Browserify...

2016-12-12 Thread alsorokin

Github user alsorokin commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/46
  
Just to clarify: the failures are caused by missing commit (I've updated my 
branch before tests could start). Expecting 1 more failure and then a success.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #201: (Android) Implement Download ...

2016-12-12 Thread Gorebar

GitHub user Gorebar opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/201

(Android) Implement Download Files from URL on Android WebView.



### Platforms affected

Android

### What does this PR do?

Allow Download Files from URL on Android WebView

### What testing has been done on this change?

Download Files from URL.

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

I needed download files from URL on Android WebView but doesn't works, 
then... I added `inAppWebView.setDownloadListener` method to implement that 
feature. Testes on Android 4.4 and above and works fine. =)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Gorebar/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/201.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #201


commit 4063179c35bbd6c4bd1f3deaef005fd2c95fe36b
Author: Gorebar 
Date:   2016-12-12T11:49:19Z

(Android) Implement Download Files from URL on Android WebView.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status issue #46: CB-12227 (windows) Fixed Browserify...

2016-12-12 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/46
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/46/commits/bb5d4f92ef5b2a5576d0116d6dabe6f5bbd3951d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/34//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request #46: CB-12227 (windows) Fixed Bro...

2016-12-12 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-battery-status/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status issue #46: CB-12227 (windows) Fixed Browserify...

2016-12-12 Thread vladimir-kotikov

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/46
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request #46: CB-12227 (windows) Fixed Bro...

2016-12-12 Thread alsorokin

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/46

CB-12227 (windows) Fixed Browserify error

### Platforms affected
Windows

### What does this PR do?
Fixes the `cordova run --browserify` error described here:
https://issues.apache.org/jira/browse/CB-12227

### What testing has been done on this change?
Successfully ran the browserified and unbrowserified apps on WIndows 10 
Store.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-battery-status 
CB-12227

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #46


commit bb5d4f92ef5b2a5576d0116d6dabe6f5bbd3951d
Author: Alexander Sorokin 
Date:   2016-12-12T11:29:54Z

CB-12227 (windows) Fixed Browserify error




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins Release

2016-12-12 Thread Vladimir Kotikov (Akvelon)

Hi Shazron
Gave you permissions to packages which I have access to.

-
Best regards, Vladimir
 

On 12/12/16, 01:37, "Shazron"  wrote:

Hi Steve Gill and/or Carlos Santana -- please give me write access to these
npm modules below. Publishing is stalled until I get permissions.

cordova-plugin-battery-status
csantanapr
stevegill
cordova-plugin-camera
csantanapr
stevegill
cordova-plugin-console
csantanapr
stevegill
cordova-plugin-contacts
csantanapr
stevegill
cordova-plugin-device
csantanapr
stevegill
cordova-plugin-device-motion
csantanapr
stevegill
cordova-plugin-device-orientation
csantanapr
stevegill
cordova-plugin-dialogs
csantanapr
stevegill
cordova-plugin-file
kotikov.vladimir
csantanapr
stevegill
cordova-plugin-file-transfer
nikhilkh
csantanapr
stevegill
cordova-plugin-geolocation
csantanapr
stevegill
cordova-plugin-globalization
csantanapr
stevegill
cordova-plugin-legacy-whitelist
csantanapr
stevegill
cordova-plugin-media
kotikov.vladimir
csantanapr
stevegill
cordova-plugin-media-capture
csantanapr
stevegill
cordova-plugin-network-information
csantanapr
stevegill
cordova-plugin-screen-orientation
gbenvenuti
stevegill
tony--
cordova-plugin-splashscreen
kotikov.vladimir
csantanapr
stevegill
cordova-plugin-statusbar
kotikov.vladimir
csantanapr
stevegill
cordova-plugin-test-framework
csantanapr
stevegill
cordova-plugin-vibration
csantanapr
stevegill
cordova-plugin-whitelist
csantanapr
stevegill

--

I already have access to these:

cordova-plugin-wkwebview-engine
bowserj
kotikov.vladimir
purplecabbage
shazron
csantanapr
stevegill
cordova-plugin-inappbrowser
csantanapr
stevegill
kotikov.vladimir
sgrebnov
shazron


On Sun, Dec 11, 2016 at 2:11 PM, Shazron  wrote:

> I've already started 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-12237=02%7C01%7Cv-vlkoti%40microsoft.com%7C0e0639e78dac47d771a708d4221658d2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636170926753647122=w%2F0INJNEerZ%2FYkorTQO%2BAd1x%2FTOk5bqtOI6gHW3ZU8w%3D=0
>
> On Sun, Dec 11, 2016 at 2:01 PM, Shazron  wrote:
>
>> One more issue -- cordova-plugin-inappbrowser, my intent is not to call
>> anyone out here (hey I'm the major source of mistakes for this release) 
but
>> my intent is to fix the problem. The plugin minor version was incremented
>> in plugin.xml to 1.6.0 but not incremented in package.json. Thus when the
>> packaging automation ran, the version had a mismatch, and that this is
>> reflected in cordova-plugin-inappbrowser.
>>
>> 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-plugin-inappbrowser%2Fcommit=02%7C01%7Cv-vlkoti%40microsoft.com%7C0e0639e78dac47d771a708d4221658d2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636170926753647122=8B2GLsiiMxL7357w%2BsmrgTDexI2oVBImPKiOVvx9NQ8%3D=0
>> /cfbd3845a893df647ff39ec3c750804d775a0e57
>>
>> We should have a version mismatch automation check during release as well
>> in coho, and/or the tests.
>>
>> So now the problem is, I can't publish cordova-plugin-inappbrowser this
>> release because package.json shows the version is 1.5.1 while plugin.xml 
is
>> 1.6.0 (1.6.0 is correct).
>>
>> I will have to omit cordova-plugin-inappbrowser in this release, and put
>> out another cordova plugins release which includes:
>>
>> 1) Updates in cordova-plugin-battery-status that we discussed
>> 2) The package.json update in cordova-plugin-inappbrowser (same version,
>> 1.6.0)
>>
>>
>>
>>
>>
>>
>>
>> On Sun, Dec 11, 2016 at 11:32 AM, Shazron  wrote:
>>
>>> I screwed up the release notes for each plugin (RELEASENOTES.md) in each
>>> plugin repo. I'll fix it after release, but will fix it for the blog 
post:
>>> 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-12236=02%7C01%7Cv-vlkoti%40microsoft.com%7C0e0639e78dac47d771a708d4221658d2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636170926753647122=2Q%2Bi07ZZetyqGbDkfxXu2CynpfWdzVruLXcy7vNfJMI%3D=0
>>>
>>> On Thu, Dec 8, 2016 at 9:03 PM,  wrote:
>>>
 Just replying to it from my apache address to

[GitHub] cordova-plugin-media-capture issue #73: decrease file size

2016-12-12 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media-capture/pull/73
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media-capture/pull/73/commits/75ba34c631d2516d445f47d1b24f87fd8281582f)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/30//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request #73: decrease file size

2016-12-12 Thread saaksshi

GitHub user saaksshi opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/73

decrease file size

File size for 2 min audio was 21 MB. 
Now with lower bit rate it's been decreased to almost half 

### Platforms affected
iOS

### What does this PR do?
File size for 2 min audio was 21 MB. 
Now with lower bit rate it's been decreased to almost half 

### What testing has been done on this change?
Create/Play/pause audio

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/saaksshi/cordova-plugin-media-capture master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #73


commit 75ba34c631d2516d445f47d1b24f87fd8281582f
Author: Saaksshi Tyagi 
Date:   2016-12-12T09:02:53Z

decrease file size




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request #106: Appium updates

2016-12-12 Thread alsorokin

Github user alsorokin commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/106#discussion_r91896443
  
--- Diff: medic/medic-appium.js ---
@@ -355,9 +358,8 @@ function isFailFastError(error) {
 function killProcess(procObj, killSignal, callback) {
 if (procObj.alive) {
 procObj.alive = false;
-setTimeout(function () {
-kill(procObj.process.pid, killSignal, callback);
-}, 1000);
--- End diff --

As far as I remember, these process-killing timeouts were needed to give 
the treekill module some time to actually kill the process. On mac it may be 
fine, but on Windows the Appium process is left hanging in the memory and 
occupying the port.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

63 matches

Mail list logo