[GitHub] cordova-ios issue #286: CB-12287: Remove hardcoded simulator build destinati...

2017-01-09 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/286
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-ios/pull/286?src=pr) is 63.26% 
(diff: 13.04%)
> Merging [#286](https://codecov.io/gh/apache/cordova-ios/pull/286?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) 
will decrease coverage by **0.85%**

```diff
@@ master   #286   diff @@
==
  Files12 12  
  Lines  1360   1380+20   
  Methods 208213 +5   
  Messages  0  0  
  Branches229233 +4   
==
+ Hits872873 +1   
- Misses  488507+19   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[7ec3bdb...3c0ba16](https://codecov.io/gh/apache/cordova-ios/compare/7ec3bdb463a5fd806d9d370b294a96f35e361179...3c0ba16324c0892beec1fd4c741714836cd2?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #286: CB-12287: Remove hardcoded simulator build de...

2017-01-09 Thread kerrishotts 
GitHub user kerrishotts opened a pull request:

https://github.com/apache/cordova-ios/pull/286

CB-12287: Remove hardcoded simulator build destination



### Platforms affected

iOS 4.3.1 and below

### What does this PR do?

In `cordova-ios@4.3.1` and below, the Xcode build destination when building 
for a simulator is hardcoded as "iPhone 5s". This works as long as the user has 
an iPhone 5s simulator installed, but if they remove it, the build process 
breaks.

This PR follows the same logic as `cordova emulate ios` in choosing a 
default destination, but also respects `--target` if specified. For example:

```
$ cordova emulate ios   # will currently select iPhone SE simulator 
to build against and emulate
$ cordova emulate ios --target="iPhone-7-Plus"  # will build against 
and emulate on the iPhone 7+
```

If there are no simulators available, the behavior is undefined, but Xcode 
wouldn't be able to build either.

### What testing has been done on this change?

Manual tests and `npm test`

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.
- Note: a couple of tests were modified so that they could pass, but 
they don't actually test this issue. Tests covering the inner logic will come 
in a separate PR


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kerrishotts/cordova-ios CB-12287

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #286


commit 3c0ba16324c0892beec1fd4c741714836cd2
Author: Kerri Shotts 
Date:   2017-01-10T05:29:00Z

CB-12287: Remove hardcoded simulator build destination




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Include TypeScript definitions in plugins

2017-01-09 Thread Steven Gill 
DO ITTT

On Mon, Jan 9, 2017 at 5:04 PM, Frederico Galvão <
frederico.gal...@pontoget.com.br> wrote:

> Please do!
>
> 2017-01-09 20:40 GMT-02:00 Mike Hartington :
>
> > Types can be in sub-folder.
> > As long as the type entried just points to the path
> >
> > https://www.typescriptlang.org/docs/handbook/declaration-
> > files/publishing.html  > org/docs/handbook/declaration-files/publishing.html>
> >
> >
> > Mike Hartington
> >
> >
> >
> > > On Jan 9, 2017, at 5:38 PM, Victor Sosa 
> wrote:
> > >
> > > +1... I love this idea! Will help a lot to static analysis tools and
> > IDEs.
> > >
> > > On Mon, Jan 9, 2017 at 3:56 PM Shazron  wrote:
> > >
> > >> Thanks for bringing this up Vladimir,
> > >> +1 -- but does the .ts definition need to be in the root? I'd rather
> it
> > be
> > >> in a subfolder (either an existing one like 'www' or a new one)
> > >>
> > >> On Mon, Jan 9, 2017 at 5:23 AM, Vladimir Kotikov (Akvelon) <
> > >> v-vlk...@microsoft.com> wrote:
> > >>
> > >>> Hey, everybody!
> > >>>
> > >>> I’d like to propose/discuss the idea of redistributing Typescript
> > >>> definitions along with core plugins, so that users who write their
> apps
> > >> in
> > >>> Typescript would get the typings in their projects without additional
> > >> mess
> > >>> with 'tsd'/'typings' (these all are the package managers for
> typescript
> > >>> declarations) or manual installation from '@types' NPM org.
> > >>>
> > >>> As mentioned above, our main goal - to reduce the number of
> additional
> > >>> actions needed to either add the plugin to Typescript project or get
> > the
> > >>> types information and intellisense for JavaScript projects. Also,
> this
> > >>> would reduce the number of network calls to other services (typings
> > >>> registry, NPM registry) which are known as common points of denial
> (per
> > >>> telemetry data).
> > >>>
> > >>> The changes are pretty minimal and include adding a d.ts file with
> type
> > >>> definitions (taken from DefinitelyTyped[1]) and 'types' entry to
> > >>> package.json according to Typescript convention [2]. The sample
> > >>> implementation for camera plugin is here: https://github.com/apache/
> > >>> cordova-plugin-camera/compare/master...vladimir-kotikov:add-typings
> > >>>
> > >>> Does anyone have any considerations/objections about this proposal?
> > >>>
> > >>> -
> > >>> [1] https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/
> > >>> cordova-plugin-camera/index.d.ts
> > >>> [2] http://www.typescriptlang.org/docs/handbook/declaration-
> > >>> files/publishing.html
> > >>>
> > >>> -
> > >>> Best regards, Vladimir
> > >>>
> > >>>
> > >>>
> > >>> -
> > >>> Best regards, Vladimir
> > >>>
> > >>>
> > >>>
> > >>
> >
> >
>
>
> --
>
> *Frederico Galvão*
>
> Diretor de Tecnologia
>
> PontoGet Inovação Web
>
>
> ( +55(62) 8131-5720
>
> * www.pontoget.com.br 
>

[GitHub] cordova-plugin-wkwebview-engine issue #22: CB-11937 - Travis CI build failin...

2017-01-09 Thread shazron 
Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/22
  
Test 7 - I think I may have found the culprit. Because it's a workspace, 
sometimes CordovaLib doesn't get processed first, and CDVWKWebViewEngineLib 
wasn't depending on CordovaLib, so it was missing the header. I added the 
dependency


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Include TypeScript definitions in plugins

2017-01-09 Thread Frederico Galvão 
Please do!

2017-01-09 20:40 GMT-02:00 Mike Hartington :

> Types can be in sub-folder.
> As long as the type entried just points to the path
>
> https://www.typescriptlang.org/docs/handbook/declaration-
> files/publishing.html  org/docs/handbook/declaration-files/publishing.html>
>
>
> Mike Hartington
>
>
>
> > On Jan 9, 2017, at 5:38 PM, Victor Sosa  wrote:
> >
> > +1... I love this idea! Will help a lot to static analysis tools and
> IDEs.
> >
> > On Mon, Jan 9, 2017 at 3:56 PM Shazron  wrote:
> >
> >> Thanks for bringing this up Vladimir,
> >> +1 -- but does the .ts definition need to be in the root? I'd rather it
> be
> >> in a subfolder (either an existing one like 'www' or a new one)
> >>
> >> On Mon, Jan 9, 2017 at 5:23 AM, Vladimir Kotikov (Akvelon) <
> >> v-vlk...@microsoft.com> wrote:
> >>
> >>> Hey, everybody!
> >>>
> >>> I’d like to propose/discuss the idea of redistributing Typescript
> >>> definitions along with core plugins, so that users who write their apps
> >> in
> >>> Typescript would get the typings in their projects without additional
> >> mess
> >>> with 'tsd'/'typings' (these all are the package managers for typescript
> >>> declarations) or manual installation from '@types' NPM org.
> >>>
> >>> As mentioned above, our main goal - to reduce the number of additional
> >>> actions needed to either add the plugin to Typescript project or get
> the
> >>> types information and intellisense for JavaScript projects. Also, this
> >>> would reduce the number of network calls to other services (typings
> >>> registry, NPM registry) which are known as common points of denial (per
> >>> telemetry data).
> >>>
> >>> The changes are pretty minimal and include adding a d.ts file with type
> >>> definitions (taken from DefinitelyTyped[1]) and 'types' entry to
> >>> package.json according to Typescript convention [2]. The sample
> >>> implementation for camera plugin is here: https://github.com/apache/
> >>> cordova-plugin-camera/compare/master...vladimir-kotikov:add-typings
> >>>
> >>> Does anyone have any considerations/objections about this proposal?
> >>>
> >>> -
> >>> [1] https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/
> >>> cordova-plugin-camera/index.d.ts
> >>> [2] http://www.typescriptlang.org/docs/handbook/declaration-
> >>> files/publishing.html
> >>>
> >>> -
> >>> Best regards, Vladimir
> >>>
> >>>
> >>>
> >>> -
> >>> Best regards, Vladimir
> >>>
> >>>
> >>>
> >>
>
>


-- 

*Frederico Galvão*

Diretor de Tecnologia

PontoGet Inovação Web


( +55(62) 8131-5720

* www.pontoget.com.br

[GitHub] cordova-plugin-wkwebview-engine issue #27: CB-12297 Support WKProcessPool fo...

2017-01-09 Thread shazron 
Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/27
  
The next release perhaps in the next two weeks since I will be away next 
week. I'm trying to fix the CI failures for this repo first (they pass when 
manually run).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #205: CB-9148 - (android) Add support for ...

2017-01-09 Thread darron1217 
Github user darron1217 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/205
  
@infil00p  Thank you for your guidance :)
I was glad that my work can be help for improving project :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Include TypeScript definitions in plugins

2017-01-09 Thread Mike Hartington 
Types can be in sub-folder.
As long as the type entried just points to the path

https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html 



Mike Hartington



> On Jan 9, 2017, at 5:38 PM, Victor Sosa  wrote:
> 
> +1... I love this idea! Will help a lot to static analysis tools and IDEs.
> 
> On Mon, Jan 9, 2017 at 3:56 PM Shazron  wrote:
> 
>> Thanks for bringing this up Vladimir,
>> +1 -- but does the .ts definition need to be in the root? I'd rather it be
>> in a subfolder (either an existing one like 'www' or a new one)
>> 
>> On Mon, Jan 9, 2017 at 5:23 AM, Vladimir Kotikov (Akvelon) <
>> v-vlk...@microsoft.com> wrote:
>> 
>>> Hey, everybody!
>>> 
>>> I’d like to propose/discuss the idea of redistributing Typescript
>>> definitions along with core plugins, so that users who write their apps
>> in
>>> Typescript would get the typings in their projects without additional
>> mess
>>> with 'tsd'/'typings' (these all are the package managers for typescript
>>> declarations) or manual installation from '@types' NPM org.
>>> 
>>> As mentioned above, our main goal - to reduce the number of additional
>>> actions needed to either add the plugin to Typescript project or get the
>>> types information and intellisense for JavaScript projects. Also, this
>>> would reduce the number of network calls to other services (typings
>>> registry, NPM registry) which are known as common points of denial (per
>>> telemetry data).
>>> 
>>> The changes are pretty minimal and include adding a d.ts file with type
>>> definitions (taken from DefinitelyTyped[1]) and 'types' entry to
>>> package.json according to Typescript convention [2]. The sample
>>> implementation for camera plugin is here: https://github.com/apache/
>>> cordova-plugin-camera/compare/master...vladimir-kotikov:add-typings
>>> 
>>> Does anyone have any considerations/objections about this proposal?
>>> 
>>> -
>>> [1] https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/
>>> cordova-plugin-camera/index.d.ts
>>> [2] http://www.typescriptlang.org/docs/handbook/declaration-
>>> files/publishing.html
>>> 
>>> -
>>> Best regards, Vladimir
>>> 
>>> 
>>> 
>>> -
>>> Best regards, Vladimir
>>> 
>>> 
>>> 
>>

Re: [DISCUSS] Include TypeScript definitions in plugins

2017-01-09 Thread Victor Sosa 
+1... I love this idea! Will help a lot to static analysis tools and IDEs.

On Mon, Jan 9, 2017 at 3:56 PM Shazron  wrote:

> Thanks for bringing this up Vladimir,
> +1 -- but does the .ts definition need to be in the root? I'd rather it be
> in a subfolder (either an existing one like 'www' or a new one)
>
> On Mon, Jan 9, 2017 at 5:23 AM, Vladimir Kotikov (Akvelon) <
> v-vlk...@microsoft.com> wrote:
>
> > Hey, everybody!
> >
> > I’d like to propose/discuss the idea of redistributing Typescript
> > definitions along with core plugins, so that users who write their apps
> in
> > Typescript would get the typings in their projects without additional
> mess
> > with 'tsd'/'typings' (these all are the package managers for typescript
> > declarations) or manual installation from '@types' NPM org.
> >
> > As mentioned above, our main goal - to reduce the number of additional
> > actions needed to either add the plugin to Typescript project or get the
> > types information and intellisense for JavaScript projects. Also, this
> > would reduce the number of network calls to other services (typings
> > registry, NPM registry) which are known as common points of denial (per
> > telemetry data).
> >
> > The changes are pretty minimal and include adding a d.ts file with type
> > definitions (taken from DefinitelyTyped[1]) and 'types' entry to
> > package.json according to Typescript convention [2]. The sample
> > implementation for camera plugin is here: https://github.com/apache/
> > cordova-plugin-camera/compare/master...vladimir-kotikov:add-typings
> >
> > Does anyone have any considerations/objections about this proposal?
> >
> > -
> > [1] https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/
> > cordova-plugin-camera/index.d.ts
> > [2] http://www.typescriptlang.org/docs/handbook/declaration-
> > files/publishing.html
> >
> > -
> > Best regards, Vladimir
> >
> >
> >
> > -
> > Best regards, Vladimir
> >
> >
> >
>

Re: [DISCUSS] Include TypeScript definitions in plugins

2017-01-09 Thread Shazron 
Thanks for bringing this up Vladimir,
+1 -- but does the .ts definition need to be in the root? I'd rather it be
in a subfolder (either an existing one like 'www' or a new one)

On Mon, Jan 9, 2017 at 5:23 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> Hey, everybody!
>
> I’d like to propose/discuss the idea of redistributing Typescript
> definitions along with core plugins, so that users who write their apps in
> Typescript would get the typings in their projects without additional mess
> with 'tsd'/'typings' (these all are the package managers for typescript
> declarations) or manual installation from '@types' NPM org.
>
> As mentioned above, our main goal - to reduce the number of additional
> actions needed to either add the plugin to Typescript project or get the
> types information and intellisense for JavaScript projects. Also, this
> would reduce the number of network calls to other services (typings
> registry, NPM registry) which are known as common points of denial (per
> telemetry data).
>
> The changes are pretty minimal and include adding a d.ts file with type
> definitions (taken from DefinitelyTyped[1]) and 'types' entry to
> package.json according to Typescript convention [2]. The sample
> implementation for camera plugin is here: https://github.com/apache/
> cordova-plugin-camera/compare/master...vladimir-kotikov:add-typings
>
> Does anyone have any considerations/objections about this proposal?
>
> -
> [1] https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/
> cordova-plugin-camera/index.d.ts
> [2] http://www.typescriptlang.org/docs/handbook/declaration-
> files/publishing.html
>
> -
> Best regards, Vladimir
>
>
>
> -
> Best regards, Vladimir
>
>
>

[GitHub] cordova-lib pull request #514: CB-12337 Resolve symbolic links in project ro...

2017-01-09 Thread sryze 
GitHub user sryze opened a pull request:

https://github.com/apache/cordova-lib/pull/514

CB-12337 Resolve symbolic links in project root

### Platforms affected
All?

### What does this PR do?

If project path had symlinks its absolute value was different from that 
returned by `__dirname` inside project-local modules. So when it was joined 
with various dirs like `www` the two absolute paths were merged resulting in an 
invalid path.

This should make commands like `cordova emulate android` work on Windows 
for projects with symlinks in path.

There may be other places where similar measures need to be taken.

### What testing has been done on this change?
Tested locally on my project.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sryze/cordova-lib cb-12337

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #514


commit dff7e78ddf87d90c09a9fd265b76e083cbf45869
Author: Sergey Zolotarev 
Date:   2017-01-09T19:51:57Z

CB-12337 Resolve symbolic links in project root

If project path had symlinks its absolute value was different from that
returned by __dirname inside project-local modules. So when it was joined
with various dirs like 'www' the two absolute paths were merged resulting
in an invalid path.

This should make 'cordova emulate android' work on Windows for projects
with symlinks in path.

There may be other places where similar measures need to be taken.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: browsing mailing lists?

2017-01-09 Thread Carlos Santana 
Thanks Shaz for the link !

This is why ponymail.apache.org was not working for me :-)


On Mon, Jan 9, 2017 at 1:50 PM Shazron  wrote:

> Yes we should change it.
>
> https://lists.apache.org/list.html?cordova.apache.org
>
> On Mon, Jan 9, 2017 at 9:50 AM, Carlos Santana 
> wrote:
>
> > I was looking on where to search an browse the mailing list, the website
> > points to markmail [1], but I thought there was a new system to browse
> > implemented recently
> >
> > anyone knows where that new system is? and if we should change the
> website
> > contact page?
> >
> > [1] http://cordova.apache.org/contact/
> >
>

Re: browsing mailing lists?

2017-01-09 Thread Shazron 
Yes we should change it.

https://lists.apache.org/list.html?cordova.apache.org

On Mon, Jan 9, 2017 at 9:50 AM, Carlos Santana  wrote:

> I was looking on where to search an browse the mailing list, the website
> points to markmail [1], but I thought there was a new system to browse
> implemented recently
>
> anyone knows where that new system is? and if we should change the website
> contact page?
>
> [1] http://cordova.apache.org/contact/
>

[GitHub] cordova-android pull request #344: CB-5968 (Android) - Missing the drawable-...

2017-01-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/344


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

browsing mailing lists?

2017-01-09 Thread Carlos Santana 
I was looking on where to search an browse the mailing list, the website
points to markmail [1], but I thought there was a new system to browse
implemented recently

anyone knows where that new system is? and if we should change the website
contact page?

[1] http://cordova.apache.org/contact/

[GitHub] cordova-plugin-inappbrowser issue #205: CB-9148 - (android) Add support for ...

2017-01-09 Thread infil00p 
Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/205
  
Congrats on your first major contribution to Cordova!  Well done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #205: CB-9148 - (android) Add suppo...

2017-01-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/205


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Include TypeScript definitions in plugins

2017-01-09 Thread Vladimir Kotikov (Akvelon) 
Hey, everybody!

I’d like to propose/discuss the idea of redistributing Typescript definitions 
along with core plugins, so that users who write their apps in Typescript would 
get the typings in their projects without additional mess with 'tsd'/'typings' 
(these all are the package managers for typescript declarations) or manual 
installation from '@types' NPM org.

As mentioned above, our main goal - to reduce the number of additional actions 
needed to either add the plugin to Typescript project or get the types 
information and intellisense for JavaScript projects. Also, this would reduce 
the number of network calls to other services (typings registry, NPM registry) 
which are known as common points of denial (per telemetry data).

The changes are pretty minimal and include adding a d.ts file with type 
definitions (taken from DefinitelyTyped[1]) and 'types' entry to package.json 
according to Typescript convention [2]. The sample implementation for camera 
plugin is here: 
https://github.com/apache/cordova-plugin-camera/compare/master...vladimir-kotikov:add-typings

Does anyone have any considerations/objections about this proposal?

-
[1] 
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/cordova-plugin-camera/index.d.ts
[2] 
http://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

-
Best regards, Vladimir



-
Best regards, Vladimir

[GitHub] cordova-plugin-media issue #124: CB-12319: (Android) Fix bug that record...

2017-01-09 Thread jcesarmobile 
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/124
  
AAC_ADTS is API level 16, which is fine as is the min used in 
cordova-android 6.1.0, but then you should make the plugin require that 
cordova-android version on the engine tag, and requiring that version might 
also require a major or minor bump on the plugin version.
Also, the README.md should be changed as right now it says that Android 
records in Adaptive Multi-Rate format, which won't be true after merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #25: CB-12317: Allow to configure navi...

2017-01-09 Thread jcesarmobile 
Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25
  
You should also document it on the README.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Platform Version support/coverage

2017-01-09 Thread Alexander Sorokin (Akvelon) 
I say let's do this!

Going to add the iOS 10 builds this week. Will keep you informed.

-Original Message-
From: Filip Maj [mailto:maj@gmail.com] 
Sent: Friday, January 6, 2017 2:19 AM
To: dev@cordova.apache.org
Subject: Re: Platform Version support/coverage

Thanks Shaz. If we want to make that happen, then I think that Alex will need 
to tweak our cloudapp jenkins instance to run the ios tests against both iOS 
9.3 and 10. Shouldn't be too difficult, as Alex already has the dual-OS-version 
setup in place for Android (which is how we test both 4.4 and 5.1 currently).

What say you, Alex?

On Thu, Jan 5, 2017 at 2:58 PM, Shazron  wrote:
> For iOS, we usually test on the current iOS version and the one 
> previous, so that would be iOS 10 and iOS 9. It follows what 
> cordova-ios currently supports, which with cordova-ios@4.4.0 we would 
> increase the minimum deployment target to iOS 9 (previously discussed in a 
> thread in this list).
>
> On Thu, Jan 5, 2017 at 1:01 PM, Filip Maj  wrote:
>
>> Hi!
>>
>> TL;DR: what OS versions should we be running our tests on? What 
>> versions should we be testing against in our CI?
>>
>> Recently, I received an email from Sauce Labs, letting me know that 
>> support for test runs on Android 4.3 and below has officially ended.
>> This reminded me that our current Android CI in cloudapp (which uses 
>> Sauce Labs) tests against Android 4.4 and 5.1, so we are starting to 
>> cut it pretty close with which versions of Android we are testing 
>> against.
>>
>> In general, I wanted to start a discussion around what OS versions of 
>> our platforms we intend to support, and which ones we would want CI 
>> coverage on?
>>
>> I think we probably want to have some test coverage on newer versions 
>> of Android than 5.1. Unfortunately, at this time Sauce Labs does not 
>> have support for Android 6 (let alone 7!), so our hands are tied 
>> there until Sauce catches up a bit.
>>
>> On iOS, cloudapp currently tests against iOS 9.3. Sauce Labs _does_ 
>> have support for iOS 10, though, so we could update our CI to get 
>> that coverage if we wanted.
>>
>> Our CI also includes coverage for "Windows 10 Store", which, based on 
>> some CI output [1], runs on the following environment:
>>
>> Windows OS: installed Windows 10
>> MSBuild Tools: installed 12.0
>> Visual Studio: installed 14.0
>> Windows SDK: installed 8.1
>> Windows Phone SDK: installed 8.1
>>
>> What do y'all think?
>>
>> [1] 
>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcordo
>> va-ci.cloudapp.net%3A8080%2Fview%2FPull%2520requests%2F=02%7C01%
>> 7Cv-alsoro%40microsoft.com%7C846b538123ff473a856208d435c14103%7C72f98
>> 8bf86f141af91ab2d7cd011db47%7C1%7C0%7C636192551514435865=RFQsHn
>> %2BnbajwIq6oSEfMa9Bf7mjodpl3C07HOjC%2B5R8%3D=0
>> job/cordova-plugin-camera-pr/115/PLATFORM=windows-10-store/console
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org