[GitHub] cordova-lib pull request #499: Cb 11960

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/499


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #358: CB-12424: (android) Fix encoding of multi...

[kalliste]

GitHub user kalliste opened a pull request:

https://github.com/apache/cordova-android/pull/358

CB-12424: (android) Fix encoding of multipart messages.


Currently when I try to assemble a multipart message cordova-android 
assembles the data in NativeToJsMessageQueue.java as [""] but if I call 
pMessageLoopResponse(callbackContext, 3, 5) it should generate [3, 5]

private void pMessageLoopResponse(final CallbackContext ctx, int iMsg, 
int iTag) {
List results = new ArrayList();
results.add(0, new PluginResult(PluginResult.Status.OK, iMsg));
results.add(1, new PluginResult(PluginResult.Status.OK, iTag));
PluginResult result = new PluginResult(PluginResult.Status.OK, 
results);
result.setKeepCallback(true);
ctx.sendPluginResult(result);
}

We split off encodeMessageAsJsMessage as its own method to support 
multipart messages including ones containing array buffer, binary string, or 
other multipart messages.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kalliste/cordova-android master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #358


commit 2dd9acf2fa0c179269002e369cb0d7df598741eb
Author: Josh Jackson 
Date:   2017-02-03T21:20:37Z

Fix encoding of multipart messages.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #267: CB: 11982 -Created new cordova config command

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/267#discussion_r99413111
  
--- Diff: doc/config.txt ---
@@ -0,0 +1,20 @@
+Synopsis
+
+cordova-cli config  [options]
+
+
+The config command can be used to set, get, delete, and edit the 
+contents of the user files.
+
+Options
+--set   .. Sets the config key to 
the 
value.If 
value is omitted,   
   
then it sets it to "true".
+--get  .. Echo the config value 
to  
 stdout.
+--delete  ... Deletes the key from 
all 
  
configuration files.
+--edit ... Opens the config file 
in an   
 editor.
+
+Example
+
+cordova-cli config set   --> cordova config set autosave true
+cordova-cli config get --> cordova config get autosave
+cordova-cli config delete  --> cordova config delete 
autosave
+cordova-cli config edit --> cordova config edit
--- End diff --

will need to add in "ls" command


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #267: CB: 11982 -Created new cordova config command

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/267#discussion_r99413060
  
--- Diff: package.json ---
@@ -33,6 +33,7 @@
 "configstore": "^2.1.0",
 "cordova-common": "2.0.0",
 "cordova-lib": "6.5.0",
+"editor": "^1.0.0",
--- End diff --

will remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #267: CB: 11982 -Created new cordova config command

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-cli/pull/267

CB: 11982  -Created new cordova config command

* Not ready to review yet. Thanks!



### Platforms affected


### What does this PR do?
Created new cordova config command (edit, ls, delete, get, set)
### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-cli CB-11982

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #267


commit 6f54ddf4e47230b05caab28c7df3c6b99d84d6fc
Author: Audrey So 
Date:   2017-01-31T23:27:34Z

CB-11982 : added config command that sets, gets, and deletes

commit 1356e1289e851b2ca8ee2226bee4c11386d5ff75
Author: Audrey So 
Date:   2017-02-02T00:00:56Z

CB-11982 : added jasmine tests to test config get, set and delete

commit 9c9e65ff30020a382c9e6ab3e8719a56eeb8e086
Author: Audrey So 
Date:   2017-02-02T01:36:39Z

CB-11982 : updated config command if save, fetch, or browserify is undefined

commit e585a9cc4290021e1d37911a54f5cfc3989f5b60
Author: Audrey So 
Date:   2017-02-03T00:39:39Z

CB-11982 : added edit and ls to delete command




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #226: CB-12416 (Windows) Built bundles are misp...

[daserge]

GitHub user daserge reopened a pull request:

https://github.com/apache/cordova-windows/pull/226

CB-12416 (Windows) Built bundles are misplaced when building for mult…

…iple archs



### Platforms affected
Windows

### What does this PR do?
Override default MSBuild behavior which is to use `AppxBundle=Always` for 
Windows 10 builds

### What testing has been done on this change?
Run npm test, manually checked AppPackages folder output for --bundle and 
default (non-bundled) cases.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-windows CB-12416

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #226


commit 8f086e2f0b2ffe75bae70f7eb22911310bf71e0f
Author: daserge 
Date:   2017-02-02T10:58:32Z

CB-12416 (Windows) Built bundles are misplaced when building for multiple 
archs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #198: CB-10857 android : Camera.getPicture retur...

[ppiacez]

Github user ppiacez commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/198
  
Any news?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #357: CB-12421: (android)The CoreAndroid's load...

[wlmzfx]

GitHub user wlmzfx opened a pull request:

https://github.com/apache/cordova-android/pull/357

CB-12421: (android)The CoreAndroid's loadUrl method should load web p…



### Platforms affected
Android

### What does this PR do?
Upate CoreAndroid's loadUrl method to load web pages in the UI thread

### What testing has been done on this change?
Built and run the generated application, calling 
{color:red}navigator.app.loadUrl('http://domain.com', { "clearHistory": 
true}){color} , verify that there is not more errors and navigation can be made 
successfully.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-12421: The CoreAndroid's 
loadUrl method should load web pages in the UI thread"
- [x] Added automated test coverage as appropriate for this change. (don't 
know how?)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wlmzfx/cordova-android CB-12421

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #357


commit 4dfbbadae8199c78d89e566a6fc6fdefa58c39b2
Author: Pu Wang 
Date:   2017-02-03T10:15:34Z

CB-12421: (android)The CoreAndroid's loadUrl method should load web pages 
in the UI thread




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #356: The CoreAndroid's loadUrl method should l...

[wlmzfx]

Github user wlmzfx closed the pull request at:

https://github.com/apache/cordova-android/pull/356


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #356: The CoreAndroid's loadUrl method should l...

[wlmzfx]

GitHub user wlmzfx opened a pull request:

https://github.com/apache/cordova-android/pull/356

The CoreAndroid's loadUrl method should load web pages in the UI thread



### Platforms affected
Android

### What does this PR do?
Upate CoreAndroid's loadUrl method to load web pages in the UI thread

### What testing has been done on this change?
Built and run the generated application, calling 
{color:red}navigator.app.loadUrl('http://domain.com', { "clearHistory": 
true}){color} , verify that there is not more errors and navigation can be made 
successfully.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-12421: The CoreAndroid's 
loadUrl method should load web pages in the UI thread"
- [x] Added automated test coverage as appropriate for this change. (don't 
know how?)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wlmzfx/cordova-android app-load-url

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #356


commit eaeaf94f2f7b986bc2210fa65b95c2b3f55f157a
Author: Pu Wang 
Date:   2017-02-03T09:47:32Z

The CoreAndroid's loadUrl method will load web pages in the UI thread




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #:

[rubenstolk]

Github user rubenstolk commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/commit/fa57e92c5582d0edc7fc4b1f4be7f5e3380d93cf#commitcomment-20727337
  
@kelvindart @jcesarmobile I'm also facing the same issue, when any other 
fullscreen plugin gets into view and then after switching back to the main 
view, the statusbar is overlaying, even when it was set to `overlay=false`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org