Nightly build #269 for cordova has failed

2017-03-01 Thread Apache Jenkins Server 
Nightly build #269 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/269/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/269/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #523: CB-11346 Remove known platforms checks

2017-03-01 Thread purplecabbage 
Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-lib/pull/523
  
Let there be tests!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #293: CB-12523 - Remove iOS 8 support

2017-03-01 Thread shazron 
GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/293

CB-12523 - Remove iOS 8 support

### Platforms affected

iOS

### What does this PR do?

Bump up minimum deployment target to iOS 9.

### What testing has been done on this change?

`npm test` and also created a new project with the cordova-ios platform 
that includes this change, and built for both device and simulator.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-12523

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #293


commit afa32be6f04542a2b6f8927c9e43615434458fa5
Author: Shazron Abdullah 
Date:   2017-03-02T00:12:35Z

CB-12523 - Remove iOS 8 support




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #292: CB-12522 - Remove node 0.x support in CI

2017-03-01 Thread shazron 
GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/292

CB-12522 - Remove node 0.x support in CI

### Platforms affected

Self

### What does this PR do?

Remove node 0.x support from CI

### What testing has been done on this change?

This PR is the test (for CI)

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-12522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #292


commit f0b58c19940a1b2f6a18f2fee37d4f4605b4fe05
Author: Shazron Abdullah 
Date:   2017-03-01T23:45:33Z

CB-12522 - Remove node 0.x support in CI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] cordova-ios@4.4.0 release

2017-03-01 Thread Shazron 
Board:
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=162

In-Progress issues are ones that definitely will get in.
The others in the backlog ('ToDo') will/may get pushed to cordova-ios@4.4.1
or later.

LMK if there are others I missed that should get in.

I went through all ~160 issues for Component:iOS this past Monday and also
"Component:No Component" (~20 issues)

[GitHub] cordova-lib pull request #:

2017-03-01 Thread purplecabbage 
Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-lib/commit/b3ca300172fdb94860a523505ab12d90512d984c#commitcomment-21110531
  
In 
cordova-lib/spec-cordova/fixtures/platforms/cordova-browser/bin/lib/create.js:
In 
cordova-lib/spec-cordova/fixtures/platforms/cordova-browser/bin/lib/create.js 
on line 49:
This makes for ugly test output ..Creating Browser project. 
Path: platforms/browser..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #310: [CB-10916] Support display name for Android

2017-03-01 Thread dpogue 
Github user dpogue commented on the issue:

https://github.com/apache/cordova-android/pull/310
  
Will do :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request #175: CB-10696 iOS: Encode target ...

2017-03-01 Thread blankg 
Github user blankg commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/175#discussion_r103760457
  
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -440,13 +440,23 @@ - (void)download:(CDVInvokedUrlCommand*)command
 targetURL = [[self.commandDelegate getCommandInstance:@"File"] 
fileSystemURLforLocalPath:target].url;
 } else {
 targetURL = [NSURL URLWithString:target];
+
+if (targetURL == nil) {
+NSString* targetUrlTextEscaped = [target 
stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
--- End diff --

stringByAddingPercentEscapesUsingEncoding is deprecated, would be better to 
use [target stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet 
URLFragmentAllowedCharacterSet]]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #357: CB-12421: (android)The CoreAndroid's loadUrl met...

2017-03-01 Thread infil00p 
Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/357
  
I'm pretty sure this is already being done on the UI thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #310: [CB-10916] Support display name for Android

2017-03-01 Thread infil00p 
Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/310
  
Looks fine, but we should wait for it all to go in together if possible.  
@dpogue You have commit rights, so can you make sure that this gets pulled in 
when the parent issue gets resolved? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #304: fix crash when calling methods on a destroyed we...

2017-03-01 Thread infil00p 
Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/304
  
Do you have a stack trace for this? This is old, but it doesn't conflict, 
so I might pull it in, but it would help to see an error report or something 
before throwing this over the fence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #283: CB-10897 Refactor URI Parsing for Whitelist

2017-03-01 Thread infil00p 
Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/283
  
What's the status for this? I refactored the unit tests so we can actually 
have tests that back this code now, as opposed to before where it wasn't quite 
as straight forward.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #522: CB-12016 : removes pluginId mapping

2017-03-01 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/522
  
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/522?src=pr=h1) 
Report
> Merging 
[#522](https://codecov.io/gh/apache/cordova-lib/pull/522?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/b0402b9e51bf2d97488fedd39d13348b29f81c3c?src=pr=desc)
 will **increase** coverage by `0.22%`.
> The diff coverage is `87.5%`.


```diff
@@Coverage Diff @@
##   master #522  +/-   ##
==
+ Coverage81.9%   82.13%   +0.22% 
==
  Files  68   68  
  Lines5504 5446  -58 
  Branches 1090 1062  -28 
==
- Hits 4508 4473  -35 
+ Misses996  973  -23
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/522?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[cordova-lib/src/cordova/plugin.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...a29720e6d6b2378d9e342a5b1bb46bef1db17fa8?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGx1Z2luLmpz)
 | `89.48% <ø> (+0.69%)` | :white_check_mark: |
| 
[cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...a29720e6d6b2378d9e342a5b1bb46bef1db17fa8?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==)
 | `87.71% <ø> (+0.55%)` | :white_check_mark: |
| 
[cordova-lib/src/plugman/uninstall.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...a29720e6d6b2378d9e342a5b1bb46bef1db17fa8?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vdW5pbnN0YWxsLmpz)
 | `89.93% <100%> (+3.15%)` | :white_check_mark: |
| 
[cordova-lib/src/plugman/fetch.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...a29720e6d6b2378d9e342a5b1bb46bef1db17fa8?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vZmV0Y2guanM=)
 | `84.41% <85.71%> (+2.95%)` | :white_check_mark: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/522?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/522?src=pr=footer). 
Last update 
[b0402b9...a29720e](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...a29720e6d6b2378d9e342a5b1bb46bef1db17fa8?el=footer=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #131: CB-10033 – iOS: new resizable cropping r...

2017-03-01 Thread mashpie 
Github user mashpie commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/131
  
will this get merged? Or is there another way to get 
src/ios/CDVCamera.bundle/de.lproj/Localizable.strings into a current version?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request #61: CB-12105 (browser) Properly detect E...

2017-03-01 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/61


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org