Nightly build #292 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #292 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/292/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/137
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/137/commits/36e4fdf22820f750d96774e0e254327aca062dec)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/115//PLATFORM=android-5.1/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #121: CB-12146: (android) Adds support for...

[romedius]

Github user romedius closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/121


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

[romedius]

Github user romedius commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/137
  
Old PR: #121 

One question:
I couldn't test the 
`onMessage(String id, Object data) {`
method and its affects. when is this triggered?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...

[romedius]

Github user romedius commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/121
  
New PR:
https://github.com/apache/cordova-plugin-media/pull/137


 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request #137: CB-12146 (android) Adding playAudioW...

[romedius]

GitHub user romedius opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/137

CB-12146 (android) Adding playAudioWhenScreenIsLocked for Android

When loosing focus of the app in android (onPause()) the audio playback is 
paused when playAudioWhenScreenIsLocked is set to false.



### Platforms affected
Android

### What does this PR do?
Adds the playAudioWhenScreenIsLocked flag to the Android version. This 
makes it possible to selectively keep audios playing, when onPause is called.

### What testing has been done on this change?
Manual testing on Android N

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/romedius/cordova-plugin-media 
CB-12146cordova-plugin-media

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #137


commit 36e4fdf22820f750d96774e0e254327aca062dec
Author: Romedius Weiss 
Date:   2017-03-24T17:54:26Z

CB-12146 (android) Adding playAudioWhenScreenIsLocked for Android

When loosing focus of the app in android (onPause()) the audio playback is 
paused if playAudioWhenScreenIsLocked is set to false.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...

[robertoandrade]

Github user robertoandrade commented on the issue:

https://github.com/apache/cordova-lib/pull/399
  
Will check it out let you guys know.
On Fri, Mar 24, 2017 at 9:03 PM Shazron Abdullah 
wrote:

> @robertoandrade  I want to get this
> in, any word? If not I can just fork your branch and do the edits needed
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-lib/pull/399
  
@robertoandrade I want to get this in, any word? If not I can just fork 
your branch and do the edits needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #508: CB-11908 Add tests for edit-config in config.xml and...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/508
  
Hey @ktop!

Any chance you can rebase this? If not, let us know and I can take a look 
at reimplementing. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/522


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #514: CB-12337 Resolve symbolic links in project ro...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/521#discussion_r108009704
  
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {
 // Combining arrays and checking duplicates.
 comboArray = pkgJsonPlatforms.slice();
 }
+
 engines = cfg.getEngines(projectHome);
+
+if(fs.existsSync(pkgJsonPath)) {
+pkgJson = require(pkgJsonPath);
+
+// If package.json doesn't exist, auto-create one.
+} else if (engines.length > 0 && !fs.existsSync(pkgJsonPath)) {
--- End diff --

It would be better to change this from `if (engines.length > 0 && 
!fs.existsSync(pkgJsonPath))` to `if (engines.length > 0 && pkgJson))` Since 
you already check for `pkgJsonPath` and `require pkgjson` on lines 53-54, you 
don't have to do another `existsSync` operation (which is expensive).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/521#discussion_r108009309
  
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {
 // Combining arrays and checking duplicates.
 comboArray = pkgJsonPlatforms.slice();
 }
+
 engines = cfg.getEngines(projectHome);
+
+if(fs.existsSync(pkgJsonPath)) {
--- End diff --

I don't think you need lines 70-72 because you check if pkgJson exists at 
line 54. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/521#discussion_r107994895
  
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {
 // Combining arrays and checking duplicates.
 comboArray = pkgJsonPlatforms.slice();
 }
+
 engines = cfg.getEngines(projectHome);
+
+if(fs.existsSync(pkgJsonPath)) {
+pkgJson = require(pkgJsonPath);
+// TODO: Eventually refactor out to pacakge manager module.
--- End diff --

oo you can keep it. Would be good practice to include the issue number in 
the todo. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #489: CB-11811 - Updated travis settings for CocoaP...

[shazron]

Github user shazron closed the pull request at:

https://github.com/apache/cordova-lib/pull/489


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugin search is broken

[Kerri Shotts]

Cool. Thanks! :-)

~ Kerri

> On Mar 24, 2017, at 12:52, Shazron  wrote:
> 
> Here:
> https://github.com/apache/cordova-docs/blob/a3589ce66336821f2fd714a1115125cfcfa9fd1b/www/static/plugins/app.js
> 
> On Fri, Mar 24, 2017 at 5:36 AM, Kerri Shotts  wrote:
> 
>> +1 to moving off npmsearch.
>> 
>> While I’m thinking of it — where does the code for the plugin search live?
>> I found variations on it, but not sure I ever came across the canonical
>> version.
>> 
>> ~ Kerri
>> 
>>> On Mar 23, 2017, at 16:04, Shazron  wrote:
>>> 
>>> I'm going to assume by lazy consensus that moving off npmsearch is a
>> 'go'.
>>> 
>>> Filed: https://issues.apache.org/jira/browse/CB-12602
>>> 
>>> Currently our plugin search works after I filed those two issues in their
>>> repo and they were was fixed, thus fixing our search.
>>> 
>>> On Sun, Mar 19, 2017 at 4:36 PM, Shazron  wrote:
>>> 
 Consequently, found another bug and filed: https://issues.apache.
 org/jira/browse/CB-12585
 
 On Sun, Mar 19, 2017 at 4:04 PM, Shazron  wrote:
 
> I filed https://github.com/nodesource/npmsearch/issues/54 earlier and
> the dev fixed it right away, yay! So currently our search is working
>> again,
> but the original proposal stands regarding migration.
> 
> On Sun, Mar 19, 2017 at 1:50 PM, Shazron  wrote:
> 
>> Ignore the last message ;)
>> 
>> This results in zero results.
>> http://npmsearch.com/query/?fields=name,keywords,license,des
>> cription,author,modified,homepage,version,rating=keywords:
>> %22ecosystem:cordova%22=rating:desc
>> 
>> The same URL without the sort query param has results:
>> 
>> http://npmsearch.com/query/?fields=name,keywords,license,des
>> cription,author,modified,homepage,version,rating=keywords:
>> %22ecosystem:cordova%22
>> 
>> 
>> On Sun, Mar 19, 2017 at 1:44 PM, Shazron  wrote:
>> 
>>> I believe the original problem lies in npmsearch.com erroring on a
>>> query param "sort":
>>> http://npmsearch.com/query/?sort=rating:desc=name,key
>>> words,license,description,author,modified,homepage,version,r
>>> ating==keywords:%22ecosystem:cordova%22
>>> 
>>> The URL above is a query that we send to it. (a simple "sort="
>> results
>>> in the same error)
>>> 
>>> If "sort" is removed, it is fine:
>>> http://npmsearch.com/query/?fields=name,keywords,license,des
>>> cription,author,modified,homepage,version,rating==key
>>> words:%22ecosystem:cordova%22
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> On Sun, Mar 19, 2017 at 1:25 PM, Shazron  wrote:
>>> 
 The impetus for this is, users are reporting [1][2][3][4] that they
 can't find plugins, and I don't think they know of a search
>> alternative.
 
 In the near term, I think we should tweet how to search for plugins
 using npmjs.com
 
 [1] https://twitter.com/edeortuzar/status/843310576101146625
 [2] https://twitter.com/kumakumadev/status/843149557127155712
 [3] https://twitter.com/quangv/status/842925319254360064
 [4] https://twitter.com/skumarSDsoft/status/842677001433497600
 
 
 
 
 On Sun, Mar 19, 2017 at 1:19 PM, Shazron 
>> wrote:
 
> ### PROBLEM
> 
> Plugin search is broken.
> 
> ### DESCRIPTION
> 
> Page:
> http://cordova.apache.org/plugins/
> 
> JIRA:
> https://issues.apache.org/jira/browse/CB-12579
> 
> 
> Q: How does the plugin search work?
> 
> A:
> Page Source: http://cordova.apache.org/plugins
> and the source (this specific line): http://svn.apache.org/v
> iewvc/cordova/site/public/plugins/index.html?view=markup#l117
> 
> which is added from here:
> https://github.com/apache/cordova-docs/blob/master/www/plugi
> ns/index.html
> 
> which is generated from this React code:
> https://github.com/apache/cordova-docs/blob/a3589ce66336821f
> 2fd714a1115125cfcfa9fd1b/www/static/plugins/app.js
> 
> Nothing shows up as errors in the Web Inspector, so it is hard to
> track down.
> 
> ### MY PROPOSAL
> 
> The era of needing npmsearch.com to populate this page is over. We
> could just redirect users to npmjs.com and add the
> "ecosystem:cordova" token (i.e https://www.npmjs.com/sea
> rch?q=ecosystem%3Acordova)
> 
> The alternative is to use npm's Registry API:
> https://github.com/npm/registry/commits/master/docs/
>> REGISTRY-API.md
> 
> The API was only documented 

Re: [DISCUSS] Plugin search is broken

[Shazron]

Here:
https://github.com/apache/cordova-docs/blob/a3589ce66336821f2fd714a1115125cfcfa9fd1b/www/static/plugins/app.js

On Fri, Mar 24, 2017 at 5:36 AM, Kerri Shotts  wrote:

> +1 to moving off npmsearch.
>
> While I’m thinking of it — where does the code for the plugin search live?
> I found variations on it, but not sure I ever came across the canonical
> version.
>
> ~ Kerri
>
> > On Mar 23, 2017, at 16:04, Shazron  wrote:
> >
> > I'm going to assume by lazy consensus that moving off npmsearch is a
> 'go'.
> >
> > Filed: https://issues.apache.org/jira/browse/CB-12602
> >
> > Currently our plugin search works after I filed those two issues in their
> > repo and they were was fixed, thus fixing our search.
> >
> > On Sun, Mar 19, 2017 at 4:36 PM, Shazron  wrote:
> >
> >> Consequently, found another bug and filed: https://issues.apache.
> >> org/jira/browse/CB-12585
> >>
> >> On Sun, Mar 19, 2017 at 4:04 PM, Shazron  wrote:
> >>
> >>> I filed https://github.com/nodesource/npmsearch/issues/54 earlier and
> >>> the dev fixed it right away, yay! So currently our search is working
> again,
> >>> but the original proposal stands regarding migration.
> >>>
> >>> On Sun, Mar 19, 2017 at 1:50 PM, Shazron  wrote:
> >>>
>  Ignore the last message ;)
> 
>  This results in zero results.
>  http://npmsearch.com/query/?fields=name,keywords,license,des
>  cription,author,modified,homepage,version,rating=keywords:
>  %22ecosystem:cordova%22=rating:desc
> 
>  The same URL without the sort query param has results:
> 
>  http://npmsearch.com/query/?fields=name,keywords,license,des
>  cription,author,modified,homepage,version,rating=keywords:
>  %22ecosystem:cordova%22
> 
> 
>  On Sun, Mar 19, 2017 at 1:44 PM, Shazron  wrote:
> 
> > I believe the original problem lies in npmsearch.com erroring on a
> > query param "sort":
> > http://npmsearch.com/query/?sort=rating:desc=name,key
> > words,license,description,author,modified,homepage,version,r
> > ating==keywords:%22ecosystem:cordova%22
> >
> > The URL above is a query that we send to it. (a simple "sort="
> results
> > in the same error)
> >
> > If "sort" is removed, it is fine:
> > http://npmsearch.com/query/?fields=name,keywords,license,des
> > cription,author,modified,homepage,version,rating==key
> > words:%22ecosystem:cordova%22
> >
> >
> >
> >
> >
> >
> > On Sun, Mar 19, 2017 at 1:25 PM, Shazron  wrote:
> >
> >> The impetus for this is, users are reporting [1][2][3][4] that they
> >> can't find plugins, and I don't think they know of a search
> alternative.
> >>
> >> In the near term, I think we should tweet how to search for plugins
> >> using npmjs.com
> >>
> >> [1] https://twitter.com/edeortuzar/status/843310576101146625
> >> [2] https://twitter.com/kumakumadev/status/843149557127155712
> >> [3] https://twitter.com/quangv/status/842925319254360064
> >> [4] https://twitter.com/skumarSDsoft/status/842677001433497600
> >>
> >>
> >>
> >>
> >> On Sun, Mar 19, 2017 at 1:19 PM, Shazron 
> wrote:
> >>
> >>> ### PROBLEM
> >>>
> >>> Plugin search is broken.
> >>>
> >>> ### DESCRIPTION
> >>>
> >>> Page:
> >>> http://cordova.apache.org/plugins/
> >>>
> >>> JIRA:
> >>> https://issues.apache.org/jira/browse/CB-12579
> >>>
> >>>
> >>> Q: How does the plugin search work?
> >>>
> >>> A:
> >>> Page Source: http://cordova.apache.org/plugins
> >>> and the source (this specific line): http://svn.apache.org/v
> >>> iewvc/cordova/site/public/plugins/index.html?view=markup#l117
> >>>
> >>> which is added from here:
> >>> https://github.com/apache/cordova-docs/blob/master/www/plugi
> >>> ns/index.html
> >>>
> >>> which is generated from this React code:
> >>> https://github.com/apache/cordova-docs/blob/a3589ce66336821f
> >>> 2fd714a1115125cfcfa9fd1b/www/static/plugins/app.js
> >>>
> >>> Nothing shows up as errors in the Web Inspector, so it is hard to
> >>> track down.
> >>>
> >>> ### MY PROPOSAL
> >>>
> >>> The era of needing npmsearch.com to populate this page is over. We
> >>> could just redirect users to npmjs.com and add the
> >>> "ecosystem:cordova" token (i.e https://www.npmjs.com/sea
> >>> rch?q=ecosystem%3Acordova)
> >>>
> >>> The alternative is to use npm's Registry API:
> >>> https://github.com/npm/registry/commits/master/docs/
> REGISTRY-API.md
> >>>
> >>> The API was only documented earlier this year, if not we would have
> >>> used it.
> >>>
> >>>
> >>
> >
> 
> >>>
> >>
>
>

[GitHub] cordova-android issue #304: fix crash when calling methods on a destroyed we...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/304
  
1. We need a JIRA for this
2. This has become more interesting since we need to add an Android O 
version of this code to handle it better, because the renderer goes away, not 
the whole webview now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #370: CB-12595: Fix Android Studio Detection (m...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/370


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/521#discussion_r107954943
  
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -114,13 +135,19 @@ function installPlatformsFromConfigXML(platforms, 
opts) {
 events.emit('verbose', 'Package.json and config.xml platforms 
are different. Updating config.xml with most current list of platforms.');
 comboArray.forEach(function(item) {
 var prefixItem = ('cordova-'+item);
+
 // Modify package.json if any of these cases are true:
-if((pkgJson.dependencies === undefined && 
Object.keys(mergedPlatformSpecs).length)||
-(pkgJson.dependencies[item] === undefined && 
mergedPlatformSpecs[item]) ||
-(pkgJson.dependencies[prefixItem] === undefined && 
mergedPlatformSpecs[prefixItem])) {
+if((pkgJson.dependencies === undefined && 
Object.keys(mergedPlatformSpecs).length) ||
+(pkgJson.dependencies && mergedPlatformSpecs && 
pkgJson.dependencies[item] === undefined && mergedPlatformSpecs[item]) || 
+(pkgJson.dependencies && mergedPlatformSpecs && 
pkgJson.dependencies[prefixItem] === undefined && 
mergedPlatformSpecs[prefixItem])) {
 modifiedPkgJson = true;
 }
 
+// if ((pkgJson.dependencies && mergedPlatformSpecs && 
pkgJson.dependencies[item] === undefined && mergedPlatformSpecs[item]) || 
--- End diff --

Good catch! thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/521#discussion_r107954295
  
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {
 // Combining arrays and checking duplicates.
 comboArray = pkgJsonPlatforms.slice();
 }
+
 engines = cfg.getEngines(projectHome);
+
+if(fs.existsSync(pkgJsonPath)) {
+pkgJson = require(pkgJsonPath);
+// TODO: Eventually refactor out to pacakge manager module.
--- End diff --

Reminder to  ---> https://issues.apache.org/jira/browse/CB-12592. Want me 
to take it out?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/522#discussion_r107952809
  
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) {
 if (!expectedIdAndVersion) return;
 
 var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
-
-if (parsedSpec.id != pinfo.id) {
-var alias = parsedSpec.scope ? null : 
pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
--- End diff --

Made some updates! Let me know if there is anything else! Thank you! :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugin search is broken

[Kerri Shotts]

+1 to moving off npmsearch.

While I’m thinking of it — where does the code for the plugin search live? I 
found variations on it, but not sure I ever came across the canonical version.

~ Kerri

> On Mar 23, 2017, at 16:04, Shazron  wrote:
> 
> I'm going to assume by lazy consensus that moving off npmsearch is a 'go'.
> 
> Filed: https://issues.apache.org/jira/browse/CB-12602
> 
> Currently our plugin search works after I filed those two issues in their
> repo and they were was fixed, thus fixing our search.
> 
> On Sun, Mar 19, 2017 at 4:36 PM, Shazron  wrote:
> 
>> Consequently, found another bug and filed: https://issues.apache.
>> org/jira/browse/CB-12585
>> 
>> On Sun, Mar 19, 2017 at 4:04 PM, Shazron  wrote:
>> 
>>> I filed https://github.com/nodesource/npmsearch/issues/54 earlier and
>>> the dev fixed it right away, yay! So currently our search is working again,
>>> but the original proposal stands regarding migration.
>>> 
>>> On Sun, Mar 19, 2017 at 1:50 PM, Shazron  wrote:
>>> 
 Ignore the last message ;)
 
 This results in zero results.
 http://npmsearch.com/query/?fields=name,keywords,license,des
 cription,author,modified,homepage,version,rating=keywords:
 %22ecosystem:cordova%22=rating:desc
 
 The same URL without the sort query param has results:
 
 http://npmsearch.com/query/?fields=name,keywords,license,des
 cription,author,modified,homepage,version,rating=keywords:
 %22ecosystem:cordova%22
 
 
 On Sun, Mar 19, 2017 at 1:44 PM, Shazron  wrote:
 
> I believe the original problem lies in npmsearch.com erroring on a
> query param "sort":
> http://npmsearch.com/query/?sort=rating:desc=name,key
> words,license,description,author,modified,homepage,version,r
> ating==keywords:%22ecosystem:cordova%22
> 
> The URL above is a query that we send to it. (a simple "sort=" results
> in the same error)
> 
> If "sort" is removed, it is fine:
> http://npmsearch.com/query/?fields=name,keywords,license,des
> cription,author,modified,homepage,version,rating==key
> words:%22ecosystem:cordova%22
> 
> 
> 
> 
> 
> 
> On Sun, Mar 19, 2017 at 1:25 PM, Shazron  wrote:
> 
>> The impetus for this is, users are reporting [1][2][3][4] that they
>> can't find plugins, and I don't think they know of a search alternative.
>> 
>> In the near term, I think we should tweet how to search for plugins
>> using npmjs.com
>> 
>> [1] https://twitter.com/edeortuzar/status/843310576101146625
>> [2] https://twitter.com/kumakumadev/status/843149557127155712
>> [3] https://twitter.com/quangv/status/842925319254360064
>> [4] https://twitter.com/skumarSDsoft/status/842677001433497600
>> 
>> 
>> 
>> 
>> On Sun, Mar 19, 2017 at 1:19 PM, Shazron  wrote:
>> 
>>> ### PROBLEM
>>> 
>>> Plugin search is broken.
>>> 
>>> ### DESCRIPTION
>>> 
>>> Page:
>>> http://cordova.apache.org/plugins/
>>> 
>>> JIRA:
>>> https://issues.apache.org/jira/browse/CB-12579
>>> 
>>> 
>>> Q: How does the plugin search work?
>>> 
>>> A:
>>> Page Source: http://cordova.apache.org/plugins
>>> and the source (this specific line): http://svn.apache.org/v
>>> iewvc/cordova/site/public/plugins/index.html?view=markup#l117
>>> 
>>> which is added from here:
>>> https://github.com/apache/cordova-docs/blob/master/www/plugi
>>> ns/index.html
>>> 
>>> which is generated from this React code:
>>> https://github.com/apache/cordova-docs/blob/a3589ce66336821f
>>> 2fd714a1115125cfcfa9fd1b/www/static/plugins/app.js
>>> 
>>> Nothing shows up as errors in the Web Inspector, so it is hard to
>>> track down.
>>> 
>>> ### MY PROPOSAL
>>> 
>>> The era of needing npmsearch.com to populate this page is over. We
>>> could just redirect users to npmjs.com and add the
>>> "ecosystem:cordova" token (i.e https://www.npmjs.com/sea
>>> rch?q=ecosystem%3Acordova)
>>> 
>>> The alternative is to use npm's Registry API:
>>> https://github.com/npm/registry/commits/master/docs/REGISTRY-API.md
>>> 
>>> The API was only documented earlier this year, if not we would have
>>> used it.
>>> 
>>> 
>> 
> 
 
>>> 
>> 

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/11/commits/d2931b173c22a33c14de4bdbdca3818f447e0eb4)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/22//PLATFORM=android-5.1/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

[Sh1d0w]

Github user Sh1d0w commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
@cnspaha Can you advise on the issue above, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

[cnspaha]

Github user cnspaha commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
@purplecabbage 
applied your proposed changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

[Sh1d0w]

Github user Sh1d0w commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
The proposed fix works ok (reverted `screenObject.nativeLock !== null` back 
to `screenObject.nativeLock != null`), expect that it does not force rotate the 
screen if you are already holding the phone in that orientation. What I mean:

Lock the screen to landscape while holding the phone vertically. It will 
work ok.
Rotate the phone horizontal, then rotate it again vertically.

Now lock the phone to portrait, the web view will remain in landscape mode 
until you shake it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Update iOS Embedded WebView docs for Carthage

[Corinne]

Sent from my iPhone

> On 24 Mar 2017, at 01:11, Shazron  wrote:
> 
> Yes for plugins we have to use plugman.
> 
> Why Carthage and not CocoaPods?
> 
> Firstly I like that Carthage is not opinionated like CocoaPods -- you have
> to have a Podfile, podspec, etc, and it creates a workspace that you *have*
> to use. I was working on the goal for users to "easily add Cordova to an
> existing project" -- thus Carthage wins hands down (it builds the
> framework, you add it in, you're done). Granted, Carthage is for iOS 8+
> only but that is our deployment target anyway.
> 
> CocoaPods is pretty heavy and I didn't like the hundreds of megabytes (half
> gig?) you need to download before you can use it -- and I feel that
> Carthage is the way of the future anyway (although CocoaPods is great for
> discovery I suppose). Not to mention potential CocoaPods
> Ruby/Gems/dependency hell.

Mmm... difficult to predict the future but I'll bet on Swift package manager 
(once it's got a proper iOS support)

> 
> I realize that if users need plugins they will have to install CocoaPods
> anyway if the plugins require CocoaPods (but that is outside the scope of
> embedding Cordova). I don't want users to go through that hell
> pre-emptively just to embed Cordova.

The doc starts with "This guide shows how to embed a Cordova-enabled WebView 
component within a larger iOS application."
If the app is large chances are that it already use CocoaPods.

What about a foc with 2 methods and let the use puck either Carthage or 
CocoaPods? 
> 
> Note that we *can* use Cordova as a CocoaPod already (not directly from
> Apache): http://docs.phonegap.com/tutorials/develop/1-embed-webview/ios/
> 
> 
> 
> 
> On Thu, Mar 23, 2017 at 4:29 PM, julio cesar sanchez > wrote:
> 
>> No objection, but why Carthage and not CocoaPods?
>> 
>> For the plugins we have to use plugman, right?
>> 
>> 2017-03-23 22:07 GMT+01:00 Shazron :
>> 
>>> I'm going to leave this open for the rest of this week, and if no
>> concerns
>>> I will take that as lazy consensus and file an issue for changing this.
>>> 
 On Tue, Mar 21, 2017 at 2:41 PM, Shazron  wrote:
 
 ## DESCRIPTION
 
 Carthage is supported for embedding Cordova into existing iOS projects
>>> now
 (in cordova-ios@4.4.0, the next release):
 https://issues.apache.org/jira/browse/CB-12050
 
 The Docs to update are here:
 http://cordova.apache.org/docs/en/6.x/guide/platforms/ios/webview.html
 
 Doc issue:
 https://issues.apache.org/jira/browse/CB-12514
 
 ## CARTHAGE
 
 Carthage is:
 https://github.com/Carthage/Carthage
 
 In your existing project, you create a Cartfile. In it, you point it to
 the Git repo for cordova-ios (among other dependencies). It will then
 download the repo and build Cordova.framework in your project in a
 subfolder. You would then add Cordova.framework into your project. Then
>>> in
 your code you can do this:
 
 @import Cordova;
 
 CDVViewController* cdv = [CDVViewController new];
 
 ### PROPOSAL
 
 Update the docs to use Carthage, replacing the existing multitude of
 steps. Note that Carthage, like the docs before it, does not solve the
>>> "How
 do I add plugins?" problem, it is a replacement for the existing
>> method.
 
>>> 
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #489: CB-11811 - Updated travis settings for CocoaPods tes...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/489
  
can we close this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #424: CB-11062 Add --recursive option to git clone command

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/424
  
I think I'm going to close this. In cordova-7, we don't use gitclone.js and 
instead use cordova-fetch which runs npm install under the hood. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/521#discussion_r107840862
  
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -114,13 +135,19 @@ function installPlatformsFromConfigXML(platforms, 
opts) {
 events.emit('verbose', 'Package.json and config.xml platforms 
are different. Updating config.xml with most current list of platforms.');
 comboArray.forEach(function(item) {
 var prefixItem = ('cordova-'+item);
+
 // Modify package.json if any of these cases are true:
-if((pkgJson.dependencies === undefined && 
Object.keys(mergedPlatformSpecs).length)||
-(pkgJson.dependencies[item] === undefined && 
mergedPlatformSpecs[item]) ||
-(pkgJson.dependencies[prefixItem] === undefined && 
mergedPlatformSpecs[prefixItem])) {
+if((pkgJson.dependencies === undefined && 
Object.keys(mergedPlatformSpecs).length) ||
+(pkgJson.dependencies && mergedPlatformSpecs && 
pkgJson.dependencies[item] === undefined && mergedPlatformSpecs[item]) || 
+(pkgJson.dependencies && mergedPlatformSpecs && 
pkgJson.dependencies[prefixItem] === undefined && 
mergedPlatformSpecs[prefixItem])) {
 modifiedPkgJson = true;
 }
 
+// if ((pkgJson.dependencies && mergedPlatformSpecs && 
pkgJson.dependencies[item] === undefined && mergedPlatformSpecs[item]) || 
--- End diff --

We can delete line 146-150


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/521#discussion_r107840945
  
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {
 // Combining arrays and checking duplicates.
 comboArray = pkgJsonPlatforms.slice();
 }
+
 engines = cfg.getEngines(projectHome);
+
+if(fs.existsSync(pkgJsonPath)) {
+pkgJson = require(pkgJsonPath);
+// TODO: Eventually refactor out to pacakge manager module.
--- End diff --

what is this TODO comment about


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #455: CB-10438 Install correct dependency version, ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/455


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #530: CB-10438 : Install correct dependency version

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/530
  
merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #530: CB-10438 : Install correct dependency version

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/530


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org