Nightly build #298 for cordova has succeeded!
Nightly build #298 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/298/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #532: CB-12612 : removing amazon-fireos code
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/532 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/532?src=pr=h1) Report > Merging [#532](https://codecov.io/gh/apache/cordova-lib/pull/532?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/4c99c0d4e08c5a48ab5d2d48e627b58c45c4b8d2?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/532/graphs/tree.svg?height=150=pr=KwBjKMXLqA=650)](https://codecov.io/gh/apache/cordova-lib/pull/532?src=pr=tree) ```diff @@Coverage Diff @@ ## master #532 +/- ## == - Coverage 82.42% 82.41% -0.01% == Files 68 68 Lines5461 5459 -2 Branches 1070 1069 -1 == - Hits 4501 4499 -2 Misses960 960 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/532?src=pr=tree) | Coverage Π| | |---|---|---| | [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/pull/532?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `78.23% <ø> (-0.1%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/532?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/532?src=pr=footer). Last update [4c99c0d...7411005](https://codecov.io/gh/apache/cordova-lib/pull/532?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/534 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr=h1) Report > Merging [#534](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/4c99c0d4e08c5a48ab5d2d48e627b58c45c4b8d2?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/534/graphs/tree.svg?height=150=pr=KwBjKMXLqA=650)](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #534 +/- ## === Coverage 82.42% 82.42% === Files 68 68 Lines5461 5461 Branches 1070 1070 === Hits 4501 4501 Misses960 960 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr=tree) | Coverage Π| | |---|---|---| | [cordova-lib/src/plugman/platforms/ios.js](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2lvcy5qcw==) | `82.16% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr=footer). Last update [4c99c0d...509b027](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #532: CB-12612 : removing amazon-fireos code
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/532 @purplecabbage just checking to see if it will pass the ci tests. i can squash it after? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 Just did a quick test of `` in a plugin with the platform changes in this PR, the embed attribute is not picked up. Thus, we definitely need the `cordova-common` changes in the CLI (coming in cordova-cli@7.0.0 and in this PR: https://github.com/apache/cordova-lib/pull/534) Once that PR has been integrated, I will generate a test CLI with those changes and re-test this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
GitHub user shazron reopened a pull request: https://github.com/apache/cordova-lib/pull/534 CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project ### Platforms affected iOS ### What does this PR do? Support the "embed" attribute for the `` tag of plugin.xml to facilitate installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for the iOS platform ### What testing has been done on this change? Added unit tests to `cordova-lib\spec-plugman\platforms\ios.spec.js` ### Other notes Complementary PR: https://github.com/apache/cordova-ios/pull/299 ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-" - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-11233 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/534.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #534 commit c3f4dcfca6bdc8b23cf4f46d49aca7abec449cb6 Author: Shazron AbdullahDate: 2017-03-30T08:39:43Z CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #259: CB-12618: (android) Appium tests: Handle n...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/259 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/259/commits/180f7b5510a7055e11ae7c13c7ea54c4d95f7ebb) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=windows-10-store/artifact/) | | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=ios-9.3/artifact/) | | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=ios-10.0/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/151//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 CI is all green! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #259: CB-12618: (android) Appium tests: Handle n...
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/259 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #371: CB-12574 - Bumping Version
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/371 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/371?src=pr=h1) Report > Merging [#371](https://codecov.io/gh/apache/cordova-android/pull/371?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/8a2e96d995666448802a2e6669bd4dbacb6b5d0c?src=pr=desc) will **decrease** coverage by `1.91%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/371/graphs/tree.svg?token=q14nMf6C5a=pr=650=150)](https://codecov.io/gh/apache/cordova-android/pull/371?src=pr=tree) ```diff @@Coverage Diff @@ ## master #371 +/- ## == - Coverage 42.95% 41.03% -1.92% == Files 14 14 Lines1362 1462 +100 Branches 252 279 +27 == + Hits 585 600 +15 - Misses777 862 +85 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/371?src=pr=tree) | Coverage Π| | |---|---|---| | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/371?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `32.16% <0%> (-6.36%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/371?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/371?src=pr=footer). Last update [8a2e96d...362e2b7](https://codecov.io/gh/apache/cordova-android/pull/371?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #371: CB-12574 - Bumping Version
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/371 Actually, it did. GitHub is being weird. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #371: CB-12574 - Bumping Version
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/371 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #371: CB-12574 - Bumping Version
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/371 Blargh. This didn't actually land into master. Sorry guys, this will be in the next patch release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #371: CB-12574 - Bumping Version
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/371 CB-12574 - Bumping Version ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/371.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #371 commit 362e2b724b97d0445a9ed9dd890e8303b173db7a Author: Joe BowserDate: 2017-03-15T20:19:58Z CB-12574 - Bumping Version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #690: Cordova Screen Orientation Plugin Blog
GitHub user maverickmishra opened a pull request: https://github.com/apache/cordova-docs/pull/690 Cordova Screen Orientation Plugin Blog ### What does this PR do? This PR adds a blog about the version(2.0.0) of the cordova-screen-orientation-plugin. You can merge this pull request into a Git repository by running: $ git pull https://github.com/maverickmishra/cordova-docs master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/690.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #690 commit a2c053227728d383cca0e1a5419f231861281368 Author: maverickmishraDate: 2017-03-30T18:18:36Z cordova screen orientation plugin blog commit 9da6f44f3d2077ba0e88f8b96322de1435072764 Author: maverickmishra Date: 2017-03-30T18:22:41Z rectified minor mistakes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 I might be able to get away with it if I revert this change I think: https://github.com/apache/cordova-ios/pull/299/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #259: CB-12618: (android) Appium tests: Handle n...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/259 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/259/commits/180f7b5510a7055e11ae7c13c7ea54c4d95f7ebb) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=windows-10-store/artifact/) | | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=ios-9.3/artifact/) | | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=ios-10.0/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/150//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Should we force the use of the Gradle daemon?
Hey devs, TL;DR: Gradle daemon can cause problems on some environments. Why do we force it on? --- Recently, I tried to disable the Gradle daemon for Android builds on our CI (because it is unstable when running concurrent builds), but found that it is nearly impossible to do. To each Gradle invocation, Cordova adds an argument which forces the usage of the daemon[1]. I've also found that some other users had issues with the daemon[2]. At the moment, you cannot disable it for good. Even if you do "cordova build android -- --gradleArg=-Dorg.gradle.daemon=false", it would only fix things for the build command. The Gradle daemon is still invoked when adding a plugin. I ended up creating a monkey patch commenting this line out on our CI, but I don't think it is the best solution here. So, what I wanted to ask is: Do we really need to force it on like this? Can't we just rely on user's Gradle properties? [1] https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/ lib/builders/GradleBuilder.js#L57 [2] https://forum.ionicframework.com/t/kill-the-gradle-daemon/31690 Thanks, Alexander Sorokin - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/534 @shazron I believe that is expected because something was changed with a test platform from npm. We should ignore it temporarily. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #259: CB-12618: (android) Appium tests: H...
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/259 CB-12618: (android) Appium tests: Handle native cling ### Platforms affected Android ### What does this PR do? Enables Appium tests to handle native cling on Android which prevents them from removing temporary image from the image gallery. https://issues.apache.org/jira/browse/CB-12618 ### What testing has been done on this change? Android 4.4: local and Sauce Labs run ### Checklist - [x] [Reported an issue](https://issues.apache.org/jira/browse/CB-12618) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alsorokin/cordova-plugin-camera CB-12618 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/259.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #259 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 Looks like my PluginInfo.js change did not stick and overridden by the CI running 'npm install'. Builds fine locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/534 Getting unrelated test error: ``` 1) non-core platform add and rm end-to-end --fetch Test 009 : should add and remove 3rd party platforms Message: Expected Error: /tmp/e2e-test/non-core-platform-test/hello/node_modules/cordova-platform-test/bin/create: Command failed with exit code ENOENT to be undefined. Stack: Error: Expected Error: /tmp/e2e-test/non-core-platform-test/hello/node_modules/cordova-platform-test/bin/create: Command failed with exit code ENOENT to be undefined. at /home/travis/build/apache/cordova-lib/cordova-lib/spec-cordova/platform.spec.js:414:25 at _rejected (/home/travis/build/apache/cordova-lib/cordova-lib/node_modules/q/q.js:797:24) at /home/travis/build/apache/cordova-lib/cordova-lib/node_modules/q/q.js:823:30 at Promise.when (/home/travis/build/apache/cordova-lib/cordova-lib/node_modules/q/q.js:1035:31) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #299: CB-11233 - Support installing frameworks into...
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/299 CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project ### Platforms affected iOS ### What does this PR do? Support the "embed" attribute for the `` tag of plugin.xml to facilitate installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for the iOS platform ### What testing has been done on this change? Added unit tests. ### Other notes Complementary PR: https://github.com/apache/cordova-lib/pull/534 I manually updated PluginInfo.js in the cordova-common bundledDependency for tests to pass. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-" - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-11233 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/299.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #299 commit 6edb7e6964f6fd90dba167deec7f77b7958510e2 Author: Shazron AbdullahDate: 2017-03-30T10:12:25Z CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #230: CB-12617 Removed node 0.x
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-windows/pull/230 CB-12617 Removed node 0.x ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-windows CB-12617 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/230.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #230 commit 47f2ddb2c13f65dae75f5dc860b6c7ab18034876 Author: Jesse MacFadyenDate: 2017-03-30T09:23:19Z CB-12617 Removed node 0.x from CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/534 CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project ### Platforms affected iOS ### What does this PR do? Support the "embed" attribute for the `` tag of plugin.xml to facilitate installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for the iOS platform ### What testing has been done on this change? Added unit tests to `cordova-lib\spec-plugman\platforms\ios,spec.js` ### Other notes The same code and tests will be added to the Platform API of cordova-ios as appropriate. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-" - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-11233 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/534.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #229: Allow build when using --bundle and multi...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-windows/pull/229 Allow build when using --bundle and multiple architectures. This clos⦠â¦es #175 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-windows MultiArch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #229 commit b992fb82818b6d204ad0ab6d46f1dd98af284b8d Author: Jesse MacFadyenDate: 2017-03-30T08:06:35Z Allow build when using --bundle and multiple architectures. This closes #175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #193: Add support for uap3.
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #221: CB-12018 : updated tests to work with jas...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org