Nightly build #368 for cordova has failed

Nightly build #368 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/368/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/368/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @karlachavez > we have to remove the splashscreen of our app In the meantime: cordova plugins remove cordova-plugin-splashscreen cordova

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-media issue #142: documentation: setRate method

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/142 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media issue #130: CB-8098 & CB-7810:(android) Added media rat...

Github user dellagustin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/130 @ghenry22, I'm interested on using this feature as well in android, but I think some adaptations on the code are needed, can you take a look a my comments? --- If your project is

[GitHub] cordova-plugin-media issue #130: CB-8098 & CB-7810:(android) Added media rat...

Github user dellagustin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/130 @filmaj @AshishMehra I created pull request https://github.com/apache/cordova-plugin-media/pull/142 to document the existing setRate method for iOS platform. --- If your project

[GitHub] cordova-plugin-media pull request #142: documentation: setRate method

GitHub user dellagustin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/142 documentation: setRate method ### Platforms affected iOS ### What does this PR do? Adds documentation for the setRate method ### What testing

[GitHub] cordova-plugin-media issue #141: Fixed link to issue tracker

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/141 Thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-media pull request #141: Fixed link to issue tracker

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120737624 --- Diff: src/android/AudioPlayer.java --- @@ -271,7 +272,6 @@ public void stopRecording(boolean stop) {

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120745011 --- Diff: src/android/AudioPlayer.java --- @@ -532,6 +532,27 @@ public void setVolume(float volume) { } }

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/130#discussion_r119812195 --- Diff: www/Media.js --- @@ -173,7 +173,9 @@ Media.prototype.setRate = function(rate) { if (cordova.platformId === 'ios'){

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

Github user karlachavez commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 We can reproduce this issue on a Samsung S6 with the following tech specs: http://www.samsung.com/ca/business/business-products/smartphones/smartphones/SM-G920WZWABMC

[GitHub] cordova-plugin-media issue #141: Fixed link to issue tracker

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/141 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media issue #141: Fixed link to issue tracker

Github user dellagustin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/141 This pull request replaces https://github.com/apache/cordova-plugin-media/pull/140/commits/5e6cfb628f7a2e9d1a867ea223dfd7fd6212734f I had some mess with the commits of that

[GitHub] cordova-plugin-media pull request #141: Fixed link to issue tracker

GitHub user dellagustin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/141 Fixed link to issue tracker ### Platforms affected none ### What does this PR do? Fix the link to the issue tracker. The component Plugin Media was

[GitHub] cordova-plugin-media pull request #140: Fixed the link to report issues

Github user dellagustin closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-windows pull request #175: Fix build result when using --bundle and ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request #231: Fix broken headings in Markdown files

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request #229: Allow build when using --bundle and multi...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request #230: CB-12617 Removed node 0.x

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request #383: CB-12762 : pointed package.json repo item...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-whitelist pull request #25: CB-12847: added `bugs` entry to p...

Github user filmaj closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-windows pull request #233: CB-12847: fixed `bugs` entry in package.j...

Github user filmaj closed the pull request at: https://github.com/apache/cordova-windows/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser pull request #212: Add 'hide' method in typing d...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-device-orientation pull request #34: CB-12667 android: Added ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 @filmaj, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 @filmaj, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-test-framework pull request #25: CB-12847: added `bugs` entry...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 Same thing - can you rebase with latest master here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 @matrosov-nikita can you rebase with latest master first, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 Just realized you don't have committer rights - I will merge this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 Huh, strange. Perhaps we should nominate you :) I will merge this in, then. --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [NOTICE] Intent on moving to Github

That's really helpful Carlos, thanks! On Wed, Jun 7, 2017 at 12:47 AM, Steven Gill wrote: > Thanks Carlos! Very useful information! > > On Tue, Jun 6, 2017 at 5:28 PM, Carlos Santana wrote: > >> ASF will allow it, other projects already showed

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 @filmaj, I don't have committer rights. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 @matrosov-nikita as long as you tested this on one of the real devices affected by the issue, and confirmed the fix, I am good to have this merged. --- If your project is

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 @matrosov-nikita go for it, then. You have committer rights, yes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Thanks. I will need to test this manually as the file-transfer CI is super broken. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Thanks for the PR and the quick responses! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-camera pull request #262: fix(error): changes error message f...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 @filmaj, @infil00p, do I need to do something else on this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-statusbar issue #79: Browser: Check callback exists before ca...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/79 Thank you for the PR and the quick responses! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-statusbar pull request #79: Browser: Check callback exists be...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 @filmaj, no, the same pr was merged into DefinitelyTyped repo (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14138) --- If your project is set up for it, you

[GitHub] cordova-plugin-media-capture issue #79: CB-12882: (ios): adds support for pe...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/79 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...

Github user stalniy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120596224 --- Diff: src/ios/CDVCapture.m --- @@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath

[GitHub] cordova-plugin-media pull request #140: Fixed the link to report issues

Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/140#discussion_r120577449 --- Diff: README.md --- @@ -46,7 +46,7 @@ function onDeviceReady() { } ``` -Report issues with this plugin on the

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 @shazron All good now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS

Github user dpogue closed the pull request at: https://github.com/apache/cordova-ios/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS

GitHub user dpogue reopened a pull request: https://github.com/apache/cordova-ios/pull/228 [CB-10916] Support display name for iOS This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453. You can merge this pull request into a Git repository by

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Cordova CI Build has one or more failures. **Commit** -

Re: move common, fetch and serve to their own repo

I will have to prep a new coho release as well. Can we add coho as a nightly as well or is that too much work? On Tue, Jun 6, 2017 at 11:16 PM, Steven Gill wrote: > I have lifted the code freeze. Feel free to commit again in cordova-lib. > The modules have officially

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Cordova CI Build has one or more failures. **Commit** -

Re: move common, fetch and serve to their own repo

I have lifted the code freeze. Feel free to commit again in cordova-lib. The modules have officially been broken out. cordova-lib has been moved to top level in its existing git repo. coho repo-clone -r common -r fetch -r serve will clone the modules from their new repo Still have a bit of CI

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/228 @dpogue bah, same timeout error. Please do the close and re-open PR dance again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

Github user homen commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 @filmaj All my editors showing correct alignment. Anyhow I fixed this with five commits :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Cordova CI Build has one or more failures. **Commit** -