Nightly build #375 for cordova has failed

2017-06-14 Thread Apache Jenkins Server
Nightly build #375 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/375/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/375/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

2017-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine pull request #38: Dynamic Swipe Preference

2017-06-14 Thread ccorcos
GitHub user ccorcos opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 Dynamic Swipe Preference This PR lets you dynamically change whether or not you can swipe navigation using `window.WkWebView.allowsBackForwardNavigationGestures(boolean)`

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...

2017-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/562#discussion_r122097628 --- Diff: spec-cordova/platform.spec.ios.js --- @@ -1,137 +0,0 @@ -/** --- End diff -- These tests got moved out to cordova-ios?

[GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...

2017-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/562#discussion_r122101116 --- Diff: src/cordova/platform.js --- @@ -1,769 +0,0 @@ -/** --- End diff -- to confirm, you ripped out this file into multpile

[GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...

2017-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/562#discussion_r122097578 --- Diff: spec-cordova/platform/addHelper.spec.js --- @@ -0,0 +1,515 @@ +/** --- End diff -- This file is just a placeholder for now

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-14 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 Since this plugin just swizzles the WKWebView class, you can make it separate plugin instead of a fork. It might make maintenance easier. Look in

[GitHub] cordova-lib issue #563: CB-11713 and CB-11961

2017-06-14 Thread goya
Github user goya commented on the issue: https://github.com/apache/cordova-lib/pull/563 should be fixed now. got bit by false git documentation on git < 2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib issue #563: CB-11713 and CB-11961

2017-06-14 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/563 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=h1) Report > Merging [#563](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr=desc) into

[GitHub] cordova-android pull request #386: CB-12895 : added eslint and removed jshin...

2017-06-14 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-android/pull/386 CB-12895 : added eslint and removed jshint / reformatted with eslint ### Platforms affected ### What does this PR do? Added eslint and removed jshint /

[GitHub] cordova-browser pull request #32: Cb 12804

2017-06-14 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-browser/pull/32 Cb 12804 ### Platforms affected cordova-browser ### What does this PR do? adds manifest.json support ### What testing has been done on this change? added

[GitHub] cordova-ios pull request #319: Updating unit tests + unit test runner and ad...

2017-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-mobile-spec issue #144: Use path.sep instead of Unix separator.

2017-06-14 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-mobile-spec/pull/144 Thank you very much for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...

2017-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...

2017-06-14 Thread halton
Github user halton commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/144#discussion_r122075324 --- Diff: createmobilespec/createmobilespec.js --- @@ -365,7 +365,7 @@ shelljs.config.fatal = true; if (argv.clearnpmcache) { //

[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...

2017-06-14 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/144#discussion_r122072468 --- Diff: createmobilespec/createmobilespec.js --- @@ -365,7 +365,7 @@ shelljs.config.fatal = true; if (argv.clearnpmcache) { //

[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...

2017-06-14 Thread halton
GitHub user halton opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/144 Use path.sep instead of Unix separator. ### Platforms affected ### What does this PR do? Fix the unix format patch on Windows host ### What testing

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-14 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-ios/pull/319 Yay, green! And looks like the codecov reporting is fixed too ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-14 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/319 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@8c77a0b`). [Click here to learn what

[GitHub] cordova-plugin-file issue #199: CB-12355: (iOS) fix FileEntry.file.type

2017-06-14 Thread rodreiser
Github user rodreiser commented on the issue: https://github.com/apache/cordova-plugin-file/pull/199 someone can merge this? i really need it ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-14 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-ios/pull/319 Made some more changes, rebased, confirmed the unit tests now run on my Windows 10 VM. Sucks to be running tests conditionally but I'm not sure what other option we have. --- If your

[GitHub] cordova-android issue #384: CB-11244: Studio project cleanup

2017-06-14 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/384 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=h1) Report > Merging [#384](https://codecov.io/gh/apache/cordova-android/pull/384?src=pr=desc) into

[GitHub] cordova-docs pull request #712: CB-11373 - document config.xml widget attrib...

2017-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/712 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs issue #712: CB-11373 - document config.xml widget attributes an...

2017-06-14 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-docs/pull/712 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-camera issue #270: CB-12912 - Incorrect 'Report Bugs' link in...

2017-06-14 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/270 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-console pull request #22: CB-12168(ios):"Fix to upgrade to io...

2017-06-14 Thread sruthakeerthikotla
Github user sruthakeerthikotla closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-camera pull request #270: CB-12912 - Incorrect 'Report Bugs' ...

2017-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request #270: CB-12912 - Incorrect 'Report Bugs' ...

2017-06-14 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/270 CB-12912 - Incorrect 'Report Bugs' link in README ### What does this PR do? Fix broken link. ### What testing has been done on this change? Tested new link

[GitHub] cordova-docs pull request #712: CB-11373 - document config.xml widget attrib...

2017-06-14 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/712 CB-11373 - document config.xml widget attributes android-packageName, android-activityName, ios-CFBundleIdentifier ### What testing has been done on this change? Generated the docs.