[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

[stalniy]

Github user stalniy commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150
  
@filmaj any news on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

[alanhg]

Github user alanhg commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/109
  
if AutoHideSplashScreen works for android.
how to use if i want to hide splashscreen manually


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #429 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #429 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/429/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #327: CB-12895: replaced jshint with eslint

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/327


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request #38: CB-12895 : replaced jshint with eslint

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-osx/pull/38


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #236: CB -12895 : updated files to use eslint i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugman pull request #90: CB-12895 : setup eslint and removed jshint

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugman/pull/90


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request #38: CB-12895 : replaced jshint with eslint

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-osx/pull/38

CB-12895 : replaced jshint with eslint



### Platforms affected


### What does this PR do?

Replaced jshint with eslint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-osx CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-osx/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #38


commit 031e2c2c99af24dd3d5de3c69a369814da6a6716
Author: Audrey So 
Date:   2017-06-01T18:41:28Z

CB-12762 : point package.json repo items to github mirrors instead of 
apache repos site

 This closes #37

commit e6ff572ccc752817f989a5e29840da134c320cba
Author: Audrey So 
Date:   2017-07-14T18:14:04Z

CB-12985 : updated to use eslint format




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #281: CB-12895 : replaced jshint with esl...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/281

CB-12895 : replaced jshint with eslint



### Platforms affected


### What does this PR do?
Replaced jshint with eslint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-plugin-camera CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #281


commit e2a27e6679585b0e4931b68dcf0b389014d877f2
Author: Audrey So 
Date:   2017-06-09T21:51:30Z

CB-12985 : setup eslint and removed jshint

commit f6a2fec1844b00ab6f1caf3e066c13817c9b4e70
Author: Audrey So 
Date:   2017-07-14T21:19:05Z

CB-12895 : updated src files to use eslint format




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

[ccorcos]

Github user ccorcos commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
  
@shazron does this PR have any chance of making it in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugman pull request #90: CB-12895 : setup eslint and removed jshint

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-plugman/pull/90

CB-12895 : setup eslint and removed jshint



### Platforms affected


### What does this PR do?

Setup eslint and removed jshint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-plugman CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugman/pull/90.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #90


commit 20c2f03ba55663dd3aebecb8558b8f2c36e1651f
Author: Audrey So 
Date:   2017-06-09T21:01:44Z

CB-12895 : setup eslint and remove jshint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request #185: CB-7995: document that `File...

[filmaj]

Github user filmaj closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/185


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #310: [CB-10916] Support display name for Andro...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/310


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #310: [CB-10916] Support display name for Android

[dpogue]

Github user dpogue commented on the issue:

https://github.com/apache/cordova-android/pull/310
  
Sorry, been on vacation the past few weeks, but it looks like we've already 
bundled in the required version of cordova-common, so this is good to go!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #310: [CB-10916] Support display name for Android

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/310
  
This appears to have fell by the wayside.  Why hasn't this been pulled into 
cordova-android?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #393: Fix for Jira issue CB-12981

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/393
  
I think if the PR author rebases w/ latest master, they will find that test 
no longer exists / no longer applicable.

I bet it was Travis VM being too slow / our timeout for the create/compile 
loop being too low.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #393: Fix for Jira issue CB-12981

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/393
  
This somehow broke the project creation test.  Can you figure out what 
happened with your PR that caused this to break?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #395: CB-12423: make explicit JDK 1.8 or greate...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/395


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request #185: CB-7995: document that `File...

[filmaj]

GitHub user filmaj opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/185

CB-7995: document that `FileTransferError.exception` on iOS is never used

https://issues.apache.org/jira/browse/CB-7995



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/filmaj/cordova-plugin-file-transfer CB-7995

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #185






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/395
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #280: (browser) automatically click on fi...

[MaxXx1313]

GitHub user MaxXx1313 opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/280

(browser) automatically click on file input field



### Platforms affected
Browser

### What does this PR do?
Skip the step to load an image from file system when camera.getPicture() 
ought to load file from the file system (not take it from camera) 

### What testing has been done on this change?
I've run `npm test`. 
Actually, there is no test for browser platform. However these changes are 
used in a real project.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MaxXx1313/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #280


commit 85b2d9e047b02abe109678eb91ecf66c750ac348
Author: Maksim Chartkou 
Date:   2017-07-14T18:38:19Z

automatically click on file input field




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #715: CB-12735: AllowInlineMediaPlayback preferenc...

[filmaj]

Github user filmaj closed the pull request at:

https://github.com/apache/cordova-docs/pull/715


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #715: CB-12735: AllowInlineMediaPlayback preferenc...

[filmaj]

GitHub user filmaj opened a pull request:

https://github.com/apache/cordova-docs/pull/715

CB-12735: AllowInlineMediaPlayback preference requires different 
Date:   2017-07-14T17:03:43Z

CB-12735: AllowInlineMediaPlayback preference requires different  
element attributes dependent on iOS version.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/395
  
You cool with this change @infil00p ? Just making sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/395
  
# 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=h1) 
Report
> Merging 
[#395](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/5917d4ef0bd773fb54bc5b232e5ed95d3a073f8b?src=pr=desc)
 will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/395/graphs/tree.svg?width=650=q14nMf6C5a=150=pr)](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=tree)

```diff
@@   Coverage Diff   @@
##   master #395   +/-   ##
===
  Coverage   42.55%   42.55%   
===
  Files  17   17   
  Lines1678 1678   
  Branches  304  304   
===
  Hits  714  714   
  Misses964  964
```



--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=footer).
 Last update 
[5917d4e...76dd861](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #37: CB-12895 : replaced jshint with eslint

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-browser/pull/37

CB-12895 : replaced jshint with eslint



### Platforms affected


### What does this PR do?
Replaced jshint with eslint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-browser CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit a4bf54bf76ec53a04885d221484339b4d241a041
Author: Audrey So 
Date:   2017-06-09T18:32:38Z

CB-12895 : set up eslint and remove jshint

commit 36100a95b6228fd134a44052e6f650c739d1857e
Author: Audrey So 
Date:   2017-07-13T19:19:25Z

CB-12895 : updated based on eslint indenting rules




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #395: CB-12423: make explicit JDK 1.8 or greate...

[filmaj]

GitHub user filmaj opened a pull request:

https://github.com/apache/cordova-android/pull/395

CB-12423: make explicit JDK 1.8 or greater is needed in the README.

Lining it up with 
https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#installing-the-requirements

As per https://issues.apache.org/jira/browse/CB-12423

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/filmaj/cordova-android CB-12423

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #395


commit 76dd8613ca0f0914da9129e171653117572933f6
Author: filmaj 
Date:   2017-07-14T16:13:52Z

CB-12423: make explicit JDK 1.8 or greater is needed in the README.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

[karlachavez]

Github user karlachavez commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/125
  
Your suggest works fine. The splashscreen is not displayed on the device we 
had the problem, but on the rest of devices. We are going to take this 
workaround until an official fix is released.
Thank so much!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

[matrosov-nikita]

Github user matrosov-nikita commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/237#discussion_r127480714
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -171,6 +182,54 @@ function getAvailableUAPVersions() {
 });
 
 return result;
+};
+
+/**
+ * Lists all VS 2017+ instances dirs in ProgramData
+ * 
+ * @return {String[]} List of paths to all VS2017+ instances
+ */
+function getWillowProgDataPaths() {
+if (!process.env.systemdrive) {
+// running on linux/osx?
+return [];
+}
+var instancesRoot = path.join(process.env.systemdrive, 
'ProgramData/Microsoft/VisualStudio/Packages/_Instances');
+if (!shell.test('-d', instancesRoot)) {
+// can't seem to find VS instances dir, return empty result
+return [];
+}
+
+return fs.readdirSync(instancesRoot).map(function(file) {
--- End diff --

Can we use `filter` instead of `map` in this case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

[matrosov-nikita]

Github user matrosov-nikita commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/237#discussion_r127481484
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -171,6 +182,54 @@ function getAvailableUAPVersions() {
 });
 
 return result;
+};
+
+/**
+ * Lists all VS 2017+ instances dirs in ProgramData
+ * 
+ * @return {String[]} List of paths to all VS2017+ instances
+ */
+function getWillowProgDataPaths() {
+if (!process.env.systemdrive) {
+// running on linux/osx?
+return [];
+}
+var instancesRoot = path.join(process.env.systemdrive, 
'ProgramData/Microsoft/VisualStudio/Packages/_Instances');
+if (!shell.test('-d', instancesRoot)) {
+// can't seem to find VS instances dir, return empty result
+return [];
+}
+
+return fs.readdirSync(instancesRoot).map(function(file) {
+var instanceDir = path.join(instancesRoot, file);
+if (shell.test('-d', instanceDir)) {
+return instanceDir;
+}
+});
 }
 
-module.exports.getAvailableUAPVersions = getAvailableUAPVersions;
+/**
+ * Lists all installed VS 2017+ versions
+ * 
+ * @return {Object[]} List of all VS 2017+ versions
+ */
+module.exports.getWillowInstallations = function () {
+var progDataPaths = getWillowProgDataPaths();
+var installations = [];
+progDataPaths.filter(function (progDataPath) {
+// make sure state.json exists
+return shell.test('-e', path.join(progDataPath, 'state.json'));
--- End diff --

`fs.existsSync`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

[matrosov-nikita]

Github user matrosov-nikita commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/237#discussion_r127480919
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -171,6 +182,54 @@ function getAvailableUAPVersions() {
 });
 
 return result;
+};
+
+/**
+ * Lists all VS 2017+ instances dirs in ProgramData
+ * 
+ * @return {String[]} List of paths to all VS2017+ instances
+ */
+function getWillowProgDataPaths() {
+if (!process.env.systemdrive) {
+// running on linux/osx?
+return [];
+}
+var instancesRoot = path.join(process.env.systemdrive, 
'ProgramData/Microsoft/VisualStudio/Packages/_Instances');
+if (!shell.test('-d', instancesRoot)) {
+// can't seem to find VS instances dir, return empty result
+return [];
+}
+
+return fs.readdirSync(instancesRoot).map(function(file) {
+var instanceDir = path.join(instancesRoot, file);
+if (shell.test('-d', instanceDir)) {
--- End diff --

Can we use `fs.statSync` here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

[matrosov-nikita]

Github user matrosov-nikita commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/237#discussion_r127480213
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -171,6 +182,54 @@ function getAvailableUAPVersions() {
 });
 
 return result;
+};
+
+/**
+ * Lists all VS 2017+ instances dirs in ProgramData
+ * 
+ * @return {String[]} List of paths to all VS2017+ instances
+ */
+function getWillowProgDataPaths() {
+if (!process.env.systemdrive) {
+// running on linux/osx?
+return [];
+}
+var instancesRoot = path.join(process.env.systemdrive, 
'ProgramData/Microsoft/VisualStudio/Packages/_Instances');
+if (!shell.test('-d', instancesRoot)) {
--- End diff --

Can we use `fs.statSync` here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

[matrosov-nikita]

Github user matrosov-nikita commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/237#discussion_r127481238
  
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -171,6 +182,54 @@ function getAvailableUAPVersions() {
 });
 
 return result;
+};
+
+/**
+ * Lists all VS 2017+ instances dirs in ProgramData
+ * 
+ * @return {String[]} List of paths to all VS2017+ instances
+ */
+function getWillowProgDataPaths() {
+if (!process.env.systemdrive) {
+// running on linux/osx?
+return [];
+}
+var instancesRoot = path.join(process.env.systemdrive, 
'ProgramData/Microsoft/VisualStudio/Packages/_Instances');
+if (!shell.test('-d', instancesRoot)) {
+// can't seem to find VS instances dir, return empty result
+return [];
+}
+
+return fs.readdirSync(instancesRoot).map(function(file) {
+var instanceDir = path.join(instancesRoot, file);
+if (shell.test('-d', instanceDir)) {
+return instanceDir;
+}
+});
 }
 
-module.exports.getAvailableUAPVersions = getAvailableUAPVersions;
+/**
+ * Lists all installed VS 2017+ versions
+ * 
+ * @return {Object[]} List of all VS 2017+ versions
+ */
+module.exports.getWillowInstallations = function () {
+var progDataPaths = getWillowProgDataPaths();
+var installations = [];
+progDataPaths.filter(function (progDataPath) {
--- End diff --

Can we make this filter in `getWillowProgDataPaths`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #238: CB-13022 Correct a VS installation warnin...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-windows/pull/238

CB-13022 Correct a VS installation warning during check_reqs

### Platforms affected
this one!

### What does this PR do?
Corrects a warning message that asks a user to install VS.

### What testing has been done on this change?
none

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-windows CB-13022

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #238


commit 6f7c29f5d97aea93dc32a263a0427ddaa69e20e4
Author: Alexander Sorokin 
Date:   2017-07-14T13:18:22Z

CB-13022 Correct a VS installation warning during check_reqs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-windows/pull/237

Cb 12636 Fix check_reqs to properly find VS 2017

### Platforms affected
this one!

### What does this PR do?
Teaches `cordova-windows` to properly recognize VS 2017 installation in the 
system.

### What testing has been done on this change?
`cordova requirements` on Windows 10 / Windows 8.1 with only VS 2017, as 
well as with other VS versions.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-windows CB-12636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #237


commit c768bfee3d00d2ac2cdef0592426c7ebc2688d1c
Author: Alexander Sorokin 
Date:   2017-07-13T08:47:07Z

CB-12636 Fix check_reqs to properly find VS 2017




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org