[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-16 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127631518 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { }); return

[GitHub] cordova-plugin-media-capture issue #77: Suport iPhone 6

2017-07-16 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/77 The code looks good, but the problem is those images don't exist. Could you add them to the PR? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

2017-07-16 Thread G-Rath
Github user G-Rath commented on the issue: https://github.com/apache/cordova-lib/pull/558 @stevengill I really agree with @uloco - Not only for the reason of consistent, but because the constant removal of the last line is picked up by VCSs, which can be really annoying.

[GitHub] cordova-plugin-splashscreen issue #74: CB-8396 Add AutoHideSplashScreen logi...

2017-07-16 Thread alanhg
Github user alanhg commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/74 @daserge I copy your commited file into plugin . ``` ``` in index.js ``` inAppBrowserRef =